pidl: Fix array range checks in python output
authorVolker Lendecke <vl@samba.org>
Tue, 20 Jun 2017 13:31:18 +0000 (15:31 +0200)
committerJeremy Allison <jra@samba.org>
Tue, 20 Jun 2017 16:50:06 +0000 (18:50 +0200)
commit67040cf61232dd1cdcc820237919ac1e073c31c2
tree919c43468a514e74f866df43140321e4d1780083
parente60aeb6f56a26019788442247361ed516bf965af
pidl: Fix array range checks in python output

Without this, we generated code like

if (ndr_table_dnsserver.num_calls < 0) {
        PyErr_SetString(PyExc_TypeError, "Internal Error, ndr_interface_call missing for py_DnssrvOperation_ndr_pack");
        return NULL;
}
call = &ndr_table_dnsserver.calls[0];

This does not really make sense, and Coverity found comparing the unsigned
num_calls against <0 a bit pointless.

Should fix 138 Coverity findings and make the code a bit more correct.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
pidl/lib/Parse/Pidl/Samba4/Python.pm