Always scan for revision (again) as it's needed for the blame mails.

[amitay/build-farm.git] / import-and-analyse.py

diff --git a/import-and-analyse.py b/import-and-analyse.py
index 89dae0ac5dfc50576948b6234469dacf97581e93..758707a442d2d8b9a9cb6e116bcf6ff76211a633 100755 (executable)
--- a/import-and-analyse.py
+++ b/import-and-analyse.py
@@ -10,10 +10,12 @@ some mail chastising the possible culprits when the build fails, based
 on recent commits.
 """
 
-from buildfarm import (
-    BuildFarm,
-    data,
+from buildfarm.build import (
+    MissingRevisionInfo,
+    NoSuchBuildError,
     )
+from buildfarm.sqldb import StormCachingBuildFarm
+from buildfarm.web import build_uri
 from email.mime.text import MIMEText
 import logging
 import optparse
@@ -25,30 +27,29 @@ parser.add_option("--verbose", help="Be verbose", action="count")
 
 (opts, args) = parser.parse_args()
 
-# we open readonly here as only apache(www-run) has write access
-buildfarm = BuildFarm()
+buildfarm = StormCachingBuildFarm(timeout=40.0)
 
 smtp = smtplib.SMTP()
 smtp.connect()
 
-def check_and_send_mails(tree, host, compiler, cur, old):
-    t = buildfarm.trees[tree]
+def check_and_send_mails(cur, old):
+    t = buildfarm.trees[cur.tree]
 
-    (cur_rev, cur_rev_timestamp) = cur.revision_details()
+    cur_rev = cur.revision_details()
     cur_status = cur.status()
 
-    (old_rev, old_rev_timestamp) = old.revision_details()
+    old_rev = old.revision_details()
     old_status = old.status()
 
     if not cur_status.regressed_since(old_status):
-        if opts.verbose:
-            print "the build didn't get worse since %r" % old_status
+        if opts.verbose >= 3:
+            print "... hasn't regressed since %s: %s" % (old_rev, old_status)
         return
 
     recipients = set()
     change_log = ""
 
-    for rev in t.get_branch().log(from_rev=cur.rev, exclude_revs=set([old.rev])):
+    for rev in t.get_branch().log(from_rev=cur.revision, exclude_revs=set([old.revision])):
         recipients.add(rev.author)
         recipients.add(rev.committer)
         change_log += """
@@ -67,41 +68,77 @@ Tree %(tree)s is %(scm)s branch %(branch)s.
 Build status for new revision %(cur_rev)s is %(cur_status)s
 Build status for old revision %(old_rev)s was %(old_status)s
 
-See http://build.samba.org/?function=View+Build;host=%(host)s;tree=%(tree)s;compiler=%(compiler)s
+See %(build_link)s
 
 The build may have been broken by one of the following commits:
 
 %(change_log)s
-    """ % {"tree": tree, "host": host, "compiler": compiler, "change_log": change_log, "scm": t.scm, "branch": t.branch,
-            "cur_rev": cur_rev, "old_rev": old_rev, "cur_status": cur_status, "old_status": old_status }
+    """ % {
+        "tree": cur.tree, "host": cur.host, "compiler": cur.compiler,
+        "change_log": change_log,
+        "scm": t.scm,
+        "branch": t.branch,
+        "cur_rev": cur_rev,
+        "old_rev": old_rev,
+        "cur_status": cur_status,
+        "old_status": old_status,
+        "build_link": build_uri("http://build.samba.org/build.cgi", cur)
+        }
 
     msg = MIMEText(body)
-    msg["Subject"] = "BUILD of %s:%s BROKEN on %s with %s AT REVISION %s" % (tree, t.branch, host, compiler, cur_rev)
+    msg["Subject"] = "BUILD of %s:%s BROKEN on %s with %s AT REVISION %s" % (cur.tree, t.branch, cur.host, cur.compiler, cur_rev)
     msg["From"] = "\"Build Farm\" <build@samba.org>"
-    msg["To"] = ",".join(recipients.keys())
+    msg["To"] = ",".join(recipients)
     if not opts.dry_run:
-        smtp.send(msg["From"], [msg["To"]], msg.as_string())
+        smtp.sendmail(msg["From"], [msg["To"]], msg.as_string())
+    else:
+        print msg.as_string()
 
 
 for build in buildfarm.get_new_builds():
-    if opts.verbose >= 1:
-        print "Processing %s..." % build
+    if build in buildfarm.builds:
+        continue
 
     if not opts.dry_run:
-        buildfarm.builds.upload_build(build)
+        old_build = build
+        try:
+            build = buildfarm.builds.upload_build(old_build)
+        except MissingRevisionInfo:
+            print "No revision info in %r, skipping" % build
+            continue
+
+    try:
+        rev = build.revision_details()
+    except MissingRevisionInfo:
+        print "No revision info in %r, skipping" % build
+        continue
 
-    (rev, commit_rev, rev_timestamp) = build.revision_details()
+    if opts.verbose >= 2:
+        print "%s... " % build,
+        print str(build.status())
 
     try:
-        prev_rev = buildfarm.builds.get_previous_revision(build.tree, build.host, build.compiler, rev)
-    except data.NoSuchBuild:
+        if opts.dry_run:
+            # Perhaps this is a dry run and rev is not in the database yet?
+            prev_rev = buildfarm.builds.get_latest_revision(build.tree, build.host, build.compiler)
+        else:
+            prev_rev = buildfarm.builds.get_previous_revision(build.tree, build.host, build.compiler, rev)
+    except NoSuchBuildError:
+        if opts.verbose >= 1:
+            print "Unable to find previous build for %s,%s,%s" % (build.tree, build.host, build.compiler)
         # Can't send a nastygram until there are 2 builds..
-        continue
     else:
-        prev_build = buildfarm.get_build(build.tree, build.host, build.compiler, prev_rev)
-        check_and_send_mails(build.tree, build.host, build.compiler, build, prev_build)
+        try:
+            assert prev_rev is not None
+            prev_build = buildfarm.builds.get_build(build.tree, build.host, build.compiler, prev_rev)
+        except NoSuchBuildError:
+            if opts.verbose >= 1:
+                print "Previous build %s has disappeared" % prev_build
+        else:
+            check_and_send_mails(build, prev_build)
 
     if not opts.dry_run:
-        build.remove()
+        old_build.remove()
+        buildfarm.commit()
 
 smtp.quit()