Add a FIXME

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@13064 a5019735-40e9-0310-863c-91ae7b9d1cf9

diff --git a/coregrind/m_options.c b/coregrind/m_options.c
index a1de2491803f5a761b164a57d1e643b6c70afc58..2a3ea3ded277a56f42f6efacd9216ea5bd11c6ed 100644 (file)
--- a/coregrind/m_options.c
+++ b/coregrind/m_options.c
@@ -211,6 +211,8 @@ Char* VG_(expand_file_name)(Char* option_name, Char* format)
                   } else if ('}' == format[i]) {
                      // Temporarily replace the '}' with NUL to extract var
                      // name.
+                     // FIXME: this is not safe as FORMAT is sometimes a
+                     // string literal which may reside in read-only memory
                      format[i] = 0;
                      qual = VG_(getenv)(qualname);
                      if (NULL == qual) {