From 936a799d32c28dc8857b97a5fe90f0150a280fa4 Mon Sep 17 00:00:00 2001 From: Robin McCorkell Date: Thu, 9 Jul 2015 15:28:05 +0100 Subject: [PATCH] Replace random() and related calls with generate_random_buffer() Result: better seeded random numbers that are cryptographically secure (not that it matters in this case) Please let it be right this time... Signed-off-by: Robin McCorkell Reviewed-by: Volker Lendecke Reviewed-by: Jeremy Allison --- dfs_server/dfs_server_ad.c | 4 +--- source3/smbd/msdfs.c | 7 +++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/dfs_server/dfs_server_ad.c b/dfs_server/dfs_server_ad.c index 3d93e19c989..61466329eaf 100644 --- a/dfs_server/dfs_server_ad.c +++ b/dfs_server/dfs_server_ad.c @@ -42,13 +42,11 @@ static void shuffle_dc_set(struct dc_set *list) { uint32_t i; - srandom(time(NULL)); - for (i = list->count; i > 1; i--) { uint32_t r; const char *tmp; - r = random() % i; + r = generate_random() % i; tmp = list->names[i - 1]; list->names[i - 1] = list->names[r]; diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c index a39efce0689..e895c1f7acc 100644 --- a/source3/smbd/msdfs.c +++ b/source3/smbd/msdfs.c @@ -431,13 +431,12 @@ NTSTATUS create_conn_struct_cwd(TALLOC_CTX *ctx, static void shuffle_strlist(char **list, int count) { - int i, r; + int i; + uint32_t r; char *tmp; - srandom(time(NULL)); - for (i = count; i > 1; i--) { - r = random() % i; + r = generate_random() % i; tmp = list[i-1]; list[i-1] = list[r]; -- 2.34.1