Michael Adam [Wed, 13 Jun 2012 15:18:59 +0000 (17:18 +0200)]
s3:smbd: change FNUM_FIELD_INVALID from -1 to 0
This is in preparation for changing the type of files_struct.fnum
to unit64_t.
This can safely be done, since all checks have been converted to
using FNUM_FIELD_INVALID and fsp->fnum is only ever set to either
FNUM_FIELD_INVALID or some i + FILE_HANDLE_OFFSET with i >= 0 and
FILE_HANDLE_OFFSET > 0.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Tue, 12 Jun 2012 15:56:43 +0000 (17:56 +0200)]
s3:smbd: use FNUM_FIELD_INVALID instead of literal -1
This is in preparation of changing fnum to uint64_t
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Tue, 12 Jun 2012 12:35:39 +0000 (14:35 +0200)]
s3:include: define FNUM_FIELD_INVALID - the invalid value for the fnum
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Thu, 7 Jun 2012 14:31:14 +0000 (16:31 +0200)]
s3:files: factor fsp_free() out of file_free()
To be reused in the durable reconnect code.
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Michael Adam [Thu, 7 Jun 2012 14:27:24 +0000 (16:27 +0200)]
s3:files: reorder file_free() a bit
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Thu, 7 Jun 2012 14:13:36 +0000 (16:13 +0200)]
s3:smbd: refactor fsp_new() out of file_new()
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Jelmer Vernooij [Thu, 14 Jun 2012 21:02:28 +0000 (23:02 +0200)]
waf: Update to newer upstream snapshot.
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Fri Jun 15 03:12:35 CEST 2012 on sn-devel-104
Jelmer Vernooij [Thu, 14 Jun 2012 21:02:06 +0000 (23:02 +0200)]
update-waf.sh: make mktemp happy by including anything Xes.
Jelmer Vernooij [Sun, 13 May 2012 01:29:48 +0000 (03:29 +0200)]
lib/util: Fix typo in comment.
Björn Jacke [Thu, 14 Jun 2012 17:58:00 +0000 (19:58 +0200)]
make librpc/build_idl.sh more portable
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Thu Jun 14 23:57:40 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 13 Jun 2012 10:13:01 +0000 (12:13 +0200)]
s3:smbd: use fsp_persistent_id() as persistent_file_id part for SMB2 (bug #8995)
It seems to be important to have unique persistent file ids,
because windows clients seem to index files by server_guid + persistent_file_id.
Which may break, if we just have a 16-bit range per connection
and the client connects multiple times.
Based on code from Ira Cooper. Use fsp->fh->gen_id as the persistent
fileid in SMB2.
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jun 14 22:04:13 CEST 2012 on sn-devel-104
Stefan Metzmacher [Thu, 14 Jun 2012 08:32:43 +0000 (10:32 +0200)]
s3:smbd: add a fsp_persistent_id() function
This calculates a 64-bit value that most likely uniquely identifies
the files_struct globally to the server.
* 32-bit random gen_id
* 16-bit truncated open_time
* 16-bit fnum (valatile_id)
Based on code from Ira Cooper. Use fsp->fh->gen_id as the persistent
fileid in SMB2.
Pair-Programmed-With: Michael Adam <obnox@samba.org>
metze
Stefan Metzmacher [Wed, 13 Jun 2012 13:40:23 +0000 (15:40 +0200)]
s3:smbd: only set fsp->fh->gen_id for a client connection
For faked connections, like dfs and printing, we leave it as 0.
metze
Stefan Metzmacher [Wed, 13 Jun 2012 10:11:51 +0000 (12:11 +0200)]
s3:smbd: try to make fsp->fh->gen_id as globally unique as possible
This makes sure the value is never 0, it's between 1 and UINT32_MAX.
While fsp->fh->gen_id is 'unsigned long' currently (which might by 8 bytes),
there's some oplock code which truncates it to uint32_t (using IVAL()).
Which means we could reuse fsp->fh->gen_id as persistent file id
until we have a final fix, which uses database.
See bug #8995 for more details.
Based on code from Ira Cooper. Ensure fsp->fh->gen_id starts from
a random point. We will use this as the SMB2 persistent_id.
metze
Volker Lendecke [Wed, 13 Jun 2012 07:48:25 +0000 (09:48 +0200)]
s3: Simplify tdb_data_is_cstr a bit
The original code contained rawmemchr for performance reasons. I
would expect the very common strlen routine to be not much worse
performance-wise than rawmemchr. On top, for me this patch simplifies
the expression a bit.
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Jun 14 16:55:58 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 13 Jun 2012 14:31:58 +0000 (16:31 +0200)]
tdb2: remove unused debug_fprintf() macro that breaks the build
The IRIX compiler doesn't support '...' in a macro.
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jun 14 11:26:15 CEST 2012 on sn-devel-104
Stefan Metzmacher [Wed, 13 Jun 2012 14:31:58 +0000 (16:31 +0200)]
tdb: remove unused debug_fprintf() macro that breaks the build
The IRIX compiler doesn't support '...' in a macro.
metze
Stefan Metzmacher [Mon, 11 Jun 2012 07:11:17 +0000 (09:11 +0200)]
lib/replace: define HAVE_WORKING_STRPTIME instead of REPLACE_STRPTIME
That makes the logic in 'wscript' simpler.
metze
Stefan Metzmacher [Wed, 13 Jun 2012 11:17:46 +0000 (13:17 +0200)]
lib/replace: execute strptime.c tests
They need runtime verification.
metze
Stefan Metzmacher [Wed, 13 Jun 2012 10:41:57 +0000 (12:41 +0200)]
Revert "replace: use replace for non 'samba' compliant strptime"
This reverts commit
4ea7d4694a8353fc55ecd12cb09b9c91ffde7b3f.
A better fix will follow.
metze
Stefan Metzmacher [Mon, 11 Jun 2012 07:07:06 +0000 (09:07 +0200)]
lib/replace: add more condition to add snprintf.c
metze
Stefan Metzmacher [Mon, 11 Jun 2012 06:56:09 +0000 (08:56 +0200)]
Revert "lib/replace: Fix snprintf() override for systems with a broken snprintf()"
This reverts commit
bbc1b0c9853322da10483f72c020fe0dd83b28fa.
A more generic fix will follow.
metze
Stefan Metzmacher [Wed, 13 Jun 2012 11:17:13 +0000 (13:17 +0200)]
lib/replace: s/execute=1/execute=True
metze
Volker Lendecke [Wed, 13 Jun 2012 09:11:39 +0000 (11:11 +0200)]
s3: Fix a comment
The fd count is implicit
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jun 14 01:53:17 CEST 2012 on sn-devel-104
Björn Jacke [Wed, 13 Jun 2012 20:02:53 +0000 (22:02 +0200)]
replace: fix unused variable warning
e2747fc62c2acbab143c4971469e0a4fc36d8789 fixed ...
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Jun 13 23:57:58 CEST 2012 on sn-devel-104
Björn Jacke [Wed, 13 Jun 2012 19:55:42 +0000 (21:55 +0200)]
Revert "replace: fix unused variable warning"
This reverts commit
e2747fc62c2acbab143c4971469e0a4fc36d8789.
one line slipped into a wrong ifndef ...
Björn Jacke [Wed, 13 Jun 2012 17:28:06 +0000 (19:28 +0200)]
s3: fix build without ads support
when we have no ads support we don't have the ads_get_sid_token symbol used in
this unused code :-)
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Jun 13 21:20:15 CEST 2012 on sn-devel-104
Björn Jacke [Wed, 13 Jun 2012 16:55:56 +0000 (18:55 +0200)]
replace: fix unused variable warning
found by the IRIX compiler
Björn Jacke [Tue, 12 Jun 2012 09:35:29 +0000 (11:35 +0200)]
doc: fix typo uniq → unique
Stefan Metzmacher [Wed, 13 Jun 2012 07:11:42 +0000 (09:11 +0200)]
s4:ntvfs: add '_fn' suffix to all ntvfs_ops function pointers
This hopefully fixes the build on systems where _LARGE_FILES
triggers defines of syscalls e.g. '#define lseek lseek64'
on AIX.
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jun 13 11:03:15 CEST 2012 on sn-devel-104
Volker Lendecke [Tue, 12 Jun 2012 09:17:58 +0000 (11:17 +0200)]
s3: Use talloc_tos() in more places in dbwrap_util
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Jun 12 15:37:16 CEST 2012 on sn-devel-104
Volker Lendecke [Mon, 11 Jun 2012 12:10:23 +0000 (14:10 +0200)]
s3: Make --pw-nt-hash useable in smbclient
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jun 12 12:41:10 CEST 2012 on sn-devel-104
Volker Lendecke [Mon, 11 Jun 2012 12:03:16 +0000 (14:03 +0200)]
s3: Add --pw-nt-hash to popt_common_credentials
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 11 Jun 2012 12:02:03 +0000 (14:02 +0200)]
s3: Add cli_state->pw_nt_hash
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 11 Jun 2012 12:01:08 +0000 (14:01 +0200)]
s3: Add user_auth_info->use_pw_nt_hash
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 11 Jun 2012 21:47:48 +0000 (23:47 +0200)]
s3-libsmbclient: change vnum to 0.2.0
metze
Volker Lendecke [Mon, 11 Jun 2012 11:29:10 +0000 (13:29 +0200)]
s3-libsmbclient: Add OptionUseNTHash
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 11 Jun 2012 11:32:07 +0000 (13:32 +0200)]
s3: Add CLI_FULL_CONNECTION_USE_NT_HASH
... as an indicator that the password supplied is the NT hash
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 11 Jun 2012 11:12:30 +0000 (13:12 +0200)]
S3: Add ntlmssp_set_password_hash
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Mon, 11 Jun 2012 08:15:08 +0000 (10:15 +0200)]
s3-libsmbclient: Make SMBC_call_auth_fn static
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Mon, 11 Jun 2012 22:32:19 +0000 (00:32 +0200)]
s4:smbd: fix typos
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Jun 12 09:21:15 CEST 2012 on sn-devel-104
Michael Adam [Mon, 11 Jun 2012 22:30:42 +0000 (00:30 +0200)]
s4:kerberos: fix typos in kerberos-notes.txt
Michael Adam [Mon, 11 Jun 2012 22:29:11 +0000 (00:29 +0200)]
s4:gensec: fix a comment typo
Michael Adam [Mon, 11 Jun 2012 15:58:02 +0000 (17:58 +0200)]
s4:torture: fix use of non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:52:57 +0000 (17:52 +0200)]
s4:tests: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:51:51 +0000 (17:51 +0200)]
s4:provision: fix use of non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:51:05 +0000 (17:51 +0200)]
s4:registry:testsuite: fix use of non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:50:22 +0000 (17:50 +0200)]
s4:heimdal: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:49:15 +0000 (17:49 +0200)]
s3:torture: fix use of non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:48:32 +0000 (17:48 +0200)]
s3:printing: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:47:58 +0000 (17:47 +0200)]
s3:vfs:scannedonly: fix use of non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:47:04 +0000 (17:47 +0200)]
libsmbclient: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:38:28 +0000 (17:38 +0200)]
selftest: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:37:44 +0000 (17:37 +0200)]
lib/testtools: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:37:13 +0000 (17:37 +0200)]
tdb:tests: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:36:38 +0000 (17:36 +0200)]
ldb:tests: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:35:11 +0000 (17:35 +0200)]
pidl/tests: fix use of a non-existent word (existant)
Michael Adam [Mon, 11 Jun 2012 15:24:20 +0000 (17:24 +0200)]
lib/util: fix use of a non-existent word (existant) in a comment
Michael Adam [Mon, 11 Jun 2012 15:24:20 +0000 (17:24 +0200)]
nsstest: fix use of a non-existent word (existant)
Volker Lendecke [Fri, 8 Jun 2012 09:59:18 +0000 (11:59 +0200)]
s3: Make vfswrap_audit_file static
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jun 12 02:26:31 CEST 2012 on sn-devel-104
Volker Lendecke [Mon, 11 Jun 2012 09:16:12 +0000 (11:16 +0200)]
s3: Fix Coverity ID 703870 Uninitialized scalar variable
According to man 2 recvmsg this might be unnecessary, but it does
not hurt either
Signed-off-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Mon, 11 Jun 2012 09:00:27 +0000 (11:00 +0200)]
s3: Save errno around a TALLOC_FREE
Signed-off-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Mon, 11 Jun 2012 08:59:23 +0000 (10:59 +0200)]
s3: Fix Coverity ID 703871 Unused pointer value
Signed-off-by: Jeremy Allison <jra@samba.org>
Björn Jacke [Mon, 11 Jun 2012 18:58:11 +0000 (20:58 +0200)]
s3/doc: some spelling fixes
Thanks to Frans Luteijn <f.a.g.luteijn at knoware.nl> for providing the fixes!
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Mon Jun 11 23:16:26 CEST 2012 on sn-devel-104
Matthieu Patou [Mon, 11 Jun 2012 17:23:51 +0000 (10:23 -0700)]
s3-winbindd: add comments about dump_core_setup
This patch is related to change
0ea7152ff479e32e25817e4ddb1c2a1569bad81d
Comments are added to explain why we call dump_core_setup 3 times.
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Mon Jun 11 21:21:11 CEST 2012 on sn-devel-104
Michael Adam [Thu, 7 Jun 2012 12:49:28 +0000 (14:49 +0200)]
s3:smbd: explain parameters to filename_convert call in smbd_smb2_create_send()
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Jun 11 19:21:51 CEST 2012 on sn-devel-104
Volker Lendecke [Mon, 11 Jun 2012 09:33:45 +0000 (11:33 +0200)]
s3: Fix Coverity ID 703869 Logically dead code
We "TALLOC_FREE(curr)" and assign prev=curr in the for-loop header.
This will lead to "prev"==NULL always. In this loop, we do not need
to correctly re-shuffle the linked list, we delete all from the
beginning anyway.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun 11 17:26:53 CEST 2012 on sn-devel-104
Volker Lendecke [Mon, 11 Jun 2012 08:35:38 +0000 (10:35 +0200)]
s3: Fix Coverity ID 709049 Dereference before null check
We have dereferenced fsp before. Because smb2 is only handle based,
this is a bogus check.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun 11 15:30:54 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 11 Jun 2012 03:22:42 +0000 (13:22 +1000)]
debug: Do not constantly rename logs when max log size = 0
In Samba4, the max log size parameter is not yet connected, so maxlog is 0
This means that we would, on receipt of a -HUP, have all child
processes attempt a rename.
Now we have the -HUP mean we reopen the logs unconditionally, and then
we see if the log is too large (samba3 mode) or simply proceed assuming
that someone else has renamed the logs for us.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Jun 11 13:34:43 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 11 Jun 2012 00:48:32 +0000 (10:48 +1000)]
file_server: Use samba4 auth module for guest logins as well
This is important for consistancy on NTLM logins, as the samba4 stack is used
for all NTLMSSP logins anyway.
Andrew Bartlett
Andrew Bartlett [Mon, 11 Jun 2012 01:12:52 +0000 (11:12 +1000)]
lib/param: simplfy lp_find_security()
All the roles other than ROLE_DOMAIN_MEMBER map to SEC_USER.
Andrew Bartlett
Andrew Bartlett [Sun, 10 Jun 2012 10:30:27 +0000 (20:30 +1000)]
pyldb: Ensure that the ldb argument is really an ldb before we dereference
Andrew Bartlett [Sun, 10 Jun 2012 06:08:12 +0000 (16:08 +1000)]
s3-smbd: Remove unused branches in negprot since security=share was removed
Andrew Bartlett [Fri, 8 Jun 2012 03:37:49 +0000 (13:37 +1000)]
s4-selftest: Test samba-tool drs replicate --local --full-sync
Stefan Metzmacher [Mon, 11 Jun 2012 06:42:29 +0000 (08:42 +0200)]
libcli/nbt: remove unused system/network.h from libnbt.h
This is not needed and breaks the build on AIX:
[ 988/3309] Compiling source4/smb_server/smb/reply.c
"../source4/smb_server/smb/reply.c", line 1093.42: 1506-022 (S) "lseek64" is not a member of "union smb_seek".
"../source4/smb_server/smb/reply.c", line 1093.42: 1506-022 (S) "lseek64" is not a member of "union smb_seek".
"../source4/smb_server/smb/reply.c", line 1093.42: 1506-022 (S) "lseek64" is not a member of "union smb_seek".
"../source4/smb_server/smb/reply.c", line 1093.42: 1506-022 (S) "lseek64" is not a member of "union smb_seek".
"../source4/smb_server/smb/reply.c", line 1109.13: 1506-022 (S) "lseek64" is not a member of "union smb_seek".
"../source4/smb_server/smb/reply.c", line 1110.13: 1506-022 (S) "lseek64" is not a member of "union smb_seek".
"../source4/smb_server/smb/reply.c", line 1111.13: 1506-022 (S) "lseek64" is not a member of "union smb_seek".
"../source4/smb_server/smb/reply.c", line 1113.38: 1506-022 (S) "lseek64" is not a member of "union smb_seek".
Waf: Leaving directory `/opt/home/build/build_farm/samba_4_0_test/bin'
Build failed: -> task failed (err #1):
{task: cc reply.c -> reply_1.o}
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun 11 10:32:51 CEST 2012 on sn-devel-104
Stefan Metzmacher [Sun, 10 Jun 2012 20:59:00 +0000 (22:59 +0200)]
lib/ldb/tools: add missing "replace.h"
This has to be the first header!
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun 11 01:21:01 CEST 2012 on sn-devel-104
Björn Jacke [Sun, 10 Jun 2012 19:32:55 +0000 (21:32 +0200)]
s3/test: make dd call more portable
using multiplicative suffixes like K, M etc. in dd isn't portable
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Sun Jun 10 23:29:42 CEST 2012 on sn-devel-104
Björn Jacke [Sun, 10 Jun 2012 18:17:44 +0000 (20:17 +0200)]
s4/pvfs: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on O_NOFOLLOW symlink open calls
see also
f75f1d62339f0accb4e574645b1d265c75a01b5b
Björn Jacke [Sun, 10 Jun 2012 18:00:03 +0000 (20:00 +0200)]
s3: fix build on systems without O_NOFOLLOW
Stefan Metzmacher [Sun, 10 Jun 2012 15:48:15 +0000 (17:48 +0200)]
wafsamba: try to fix the build on AIX with xlc_r
bld.env['CPP'] can be 'None' or '[]', bld.CONFIG_SET("CPP") should return False
File "./buildtools/wafsamba/samba_pidl.py", line 131, in SAMBA_PIDL_LIST
bld.SAMBA_PIDL(name, p, options=options, output_dir=output_dir, symlink=symlink, generate_tables=generate_tables)
File "./buildtools/wafsamba/samba_pidl.py", line 65, in SAMBA_PIDL
cpp = 'CPP="%s"' % bld.CONFIG_GET("CPP")[0]
IndexError: list index out of range
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sun Jun 10 20:18:49 CEST 2012 on sn-devel-104
Stefan Metzmacher [Sun, 10 Jun 2012 14:21:12 +0000 (16:21 +0200)]
heimdal:lib/asn1: try to fix the build on IRIX
cc-1028 cc: ERROR File = ../source4/heimdal/lib/asn1/gen_template.c, Line = 548
The expression used must have a constant value.
struct templatehead template = { 0L, &(template). tqh_first };
^
If this really fixes the IRIX build, we'll propose this for heimdal upstream.
metze
Stefan Metzmacher [Sat, 9 Jun 2012 09:11:26 +0000 (11:11 +0200)]
Revert "s3:smbd: set req->smb2req->compat_chain_fsp in file_fsp()"
This reverts commit
c2716a7d5ccf78f9716b703c22e6cf4d4f179656.
This is not needed anymore, as we have file_fsp_smb2() now.
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sun Jun 10 18:04:21 CEST 2012 on sn-devel-104
Björn Jacke [Sun, 7 Jun 2009 11:55:26 +0000 (13:55 +0200)]
s3: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on O_NOFOLLOW symlink open calls
or should we leave the NetBSD and FreeBSD platforms just broken? Actually these
two *want* to have broken platforms as they use different errno's than POSIX
demands *interntionally*. The POSIX errno ELOOP for O_NOFOLLOW open calls on
symlinks is clear and unambiguous. See http://gnats.netbsd.org/43154 for the
interesting NetBSD discussion on that.
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Sun Jun 10 16:10:02 CEST 2012 on sn-devel-104
Stefan Metzmacher [Fri, 8 Jun 2012 10:12:59 +0000 (12:12 +0200)]
s3:smb2_ioctl: make use of file_fsp_smb2()
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sun Jun 10 01:10:15 CEST 2012 on sn-devel-104
Stefan Metzmacher [Fri, 8 Jun 2012 09:57:21 +0000 (11:57 +0200)]
s3:smb2_lock: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 09:47:05 +0000 (11:47 +0200)]
s3:smb2_write: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 09:24:02 +0000 (11:24 +0200)]
s3:smb2_read: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 09:05:58 +0000 (11:05 +0200)]
s3:smb2_notify: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 08:54:46 +0000 (10:54 +0200)]
s3:smb2_setinfo: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 08:46:13 +0000 (10:46 +0200)]
s3:smb2_getinfo: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 08:42:43 +0000 (10:42 +0200)]
s3:smb2_find: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 08:36:24 +0000 (10:36 +0200)]
s3:smb2_break: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 08:31:58 +0000 (10:31 +0200)]
s3:smb2_close: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 08:14:45 +0000 (10:14 +0200)]
s3:smb2_flush: make use of file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 08:11:57 +0000 (10:11 +0200)]
s3:smbd: add file_fsp_smb2()
metze
Stefan Metzmacher [Fri, 8 Jun 2012 09:19:00 +0000 (11:19 +0200)]
s3:smb2_write: pass fsp->fnum to init_strict_lock_struct()
fsp->fnum is the same as in_file_id_volatile.
When we start to support durable handles we should pass
in_file_id_persistent.
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Jun 9 18:50:32 CEST 2012 on sn-devel-104
Stefan Metzmacher [Fri, 8 Jun 2012 09:19:00 +0000 (11:19 +0200)]
s3:smb2_read: pass fsp->fnum to init_strict_lock_struct()
fsp->fnum is the same as in_file_id_volatile.
When we start to support durable handles we should pass
in_file_id_persistent.
metze
Stefan Metzmacher [Fri, 8 Jun 2012 09:19:00 +0000 (11:19 +0200)]
s3:smb2_lock: use fsp->fnum as locking context
fsp->fnum is the same as in_file_id_volatile.
When we start to support durable handles we should pass
in_file_id_persistent.
metze
Stefan Metzmacher [Fri, 8 Jun 2012 10:05:56 +0000 (12:05 +0200)]
s3:smb2_lock: use smb2req->compat_chain_fsp instead of looking it up again
metze
Stefan Metzmacher [Sat, 9 Jun 2012 09:09:25 +0000 (11:09 +0200)]
s3:smbd: set req->smb2req->compat_chain_fsp in file_fsp()
metze