ambi/samba-autobuild/.git
8 years agolibwbclient: added support for WBC_ID_TYPE_BOTH
Andrew Tridgell [Tue, 26 Jul 2011 01:05:38 +0000 (11:05 +1000)]
libwbclient: added support for WBC_ID_TYPE_BOTH

the Samba4 winbindd allows for a single SID to map to both a user and
group id. This is used to support files with the owner_sid set to a
group

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
8 years agolib/util: move some timespec helpers from source3 to the toplevel
Stefan Metzmacher [Thu, 22 Sep 2011 18:33:22 +0000 (20:33 +0200)]
lib/util: move some timespec helpers from source3 to the toplevel

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Sep 23 00:15:31 CEST 2011 on sn-devel-104

8 years agos3:smb2_server: fix a logic error, we should sign non guest sessions
Stefan Metzmacher [Thu, 22 Sep 2011 19:04:51 +0000 (21:04 +0200)]
s3:smb2_server: fix a logic error, we should sign non guest sessions

metze

8 years agos4:selftest: skip flakey samba4.nbt.winsreplication for now
Stefan Metzmacher [Thu, 22 Sep 2011 20:28:59 +0000 (22:28 +0200)]
s4:selftest: skip flakey samba4.nbt.winsreplication for now

 [825/1154 in 43m52s] samba4.nbt.winsreplication(dc)
 Test if we always get back the same assoc_ctx
 Setup wrepl connections
 Test one pull replication cycle
 Setup wrepl connections
 Setup wrepl conflict pull connection
 UNEXPECTED(error): samba4.nbt.winsreplication.replica
 REASON: _StringException: _StringException: Unknown error/failure

I don't have time to look into the problem currently.

metze

8 years agoFix bug #8476 - Samba asserts when SMB2 client breaks the crediting rules.
Jeremy Allison [Thu, 22 Sep 2011 16:06:48 +0000 (09:06 -0700)]
Fix bug #8476 - Samba asserts when SMB2 client breaks the crediting rules.

Just drop the connection, not SMB_ASSERT.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 22 19:41:31 CEST 2011 on sn-devel-104

8 years agos4-dbcheck: fixed transaction nesting in dbcheck
Andrew Tridgell [Wed, 21 Sep 2011 23:58:39 +0000 (09:58 +1000)]
s4-dbcheck: fixed transaction nesting in dbcheck

ensure we don't cancel a transaction we didn't start

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Sep 22 03:39:59 CEST 2011 on sn-devel-104

8 years agosamba-tool: use show_recycled in dbchecker
Andrew Tridgell [Wed, 21 Sep 2011 23:58:09 +0000 (09:58 +1000)]
samba-tool: use show_recycled in dbchecker

we need to use show_recycled instead of show_deleted in dbchecker to
allow us to see recycled objects

8 years agos4-kdc: set NO_GLOBAL_CATALOG control in kdc
Andrew Tridgell [Wed, 21 Sep 2011 23:57:26 +0000 (09:57 +1000)]
s4-kdc: set NO_GLOBAL_CATALOG control in kdc

the kdc doesn't want to find users who are in partialReplica
partitions, as they won't have the needed secret info for the kdc to
operate. We need to generate referrals instead

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-rpc: show binding string in failed rpc binds
Andrew Tridgell [Wed, 21 Sep 2011 23:56:27 +0000 (09:56 +1000)]
s4-rpc: show binding string in failed rpc binds

this makes debugging some RPC auth issues easier

8 years agos4-ldap-server: set the NO_GLOBAL_CATALOG control on non-GC operations
Andrew Tridgell [Wed, 21 Sep 2011 23:55:55 +0000 (09:55 +1000)]
s4-ldap-server: set the NO_GLOBAL_CATALOG control on non-GC operations

this makes us honor GC semantics on the two ldap ports

8 years agos4-repl: remove unused principal_name element
Andrew Tridgell [Wed, 21 Sep 2011 23:54:56 +0000 (09:54 +1000)]
s4-repl: remove unused principal_name element

8 years agos4-dsdb: load the partialReplica attribute in the @PARTITION object
Andrew Tridgell [Wed, 21 Sep 2011 23:52:29 +0000 (09:52 +1000)]
s4-dsdb: load the partialReplica attribute in the @PARTITION object

this modifies the partition module to honor a partialReplica attribute
on the @PARTITION module, marking partiations as partial replicas so
the NO_GLOBAL_CATALOG control can be honoured

8 years agos4-repl: fill in GUID and SID from partition information
Andrew Tridgell [Wed, 21 Sep 2011 23:50:57 +0000 (09:50 +1000)]
s4-repl: fill in GUID and SID from partition information

when we find a NC via a DN string, fill in the GUID and SID so the
caller can properly report them

8 years agos4-kcc: return partial replica NCs in drs showrepl
Andrew Tridgell [Wed, 21 Sep 2011 23:49:54 +0000 (09:49 +1000)]
s4-kcc: return partial replica NCs in drs showrepl

the showrepl operation should return all our replicated NCs, including
partial replicas

8 years agos4-dsdb: added NO_GLOBAL_CATALOG control
Andrew Tridgell [Wed, 21 Sep 2011 23:48:17 +0000 (09:48 +1000)]
s4-dsdb: added NO_GLOBAL_CATALOG control

this control is used to ask samdb to not return searches with a basedn
in partial repica partitions, which is needed to support the
difference between a search on the 3268 GC ldap port and the non-GC
389 port

8 years agos4-dns: started adding support for auto-creation of NS glue record
Andrew Tridgell [Tue, 20 Sep 2011 22:59:30 +0000 (08:59 +1000)]
s4-dns: started adding support for auto-creation of NS glue record

when we create a new subdomain we need to create a NS glue record in
the parent domain pointing at our subdomain

8 years agos4-dsdb: get GUID and SID for DSA from extended DN
Andrew Tridgell [Tue, 20 Sep 2011 22:58:13 +0000 (08:58 +1000)]
s4-dsdb: get GUID and SID for DSA from extended DN

this allows us to use the DN from a hasPartialReplicaNCs attribute to
create a reps1 object

8 years agos4-dsdb: enable initial replication of partitions via DsReplicaSync
Andrew Tridgell [Tue, 20 Sep 2011 22:56:32 +0000 (08:56 +1000)]
s4-dsdb: enable initial replication of partitions via DsReplicaSync

we need to create a temporary dsa object to allow the replication task
to replicate a NC that is not listed in a repsFrom attribute

8 years agos4-repl: get NCs to replicate from our NTDS object
Andrew Tridgell [Tue, 20 Sep 2011 22:53:15 +0000 (08:53 +1000)]
s4-repl: get NCs to replicate from our NTDS object

we need to use the hasMasterNCs and hasPartialReplicaNCs attributes on
our NTDS object to get the list of NCs to replicate, instead of using
the rootDSE. This is needed to support replicating of GC partial
replicas, which are not listed in the rootDSE

8 years agos4-dsdb: added support for replicating with GC partial attribute set
Andrew Tridgell [Tue, 20 Sep 2011 22:52:14 +0000 (08:52 +1000)]
s4-dsdb: added support for replicating with GC partial attribute set

if we are replicating a partial replica, then we need to supply the
partial attribute set we want to replicate to the server

8 years agos4-dsdb: failing to find the object is not an error in dsdb_loadreps()
Andrew Tridgell [Tue, 20 Sep 2011 22:51:20 +0000 (08:51 +1000)]
s4-dsdb: failing to find the object is not an error in dsdb_loadreps()

we may not have replicated the partition yet, so this should be
considered the same as having no repsFrom/repsTo

8 years agos3: Fix Coverity ID 2619: UNINIT
Volker Lendecke [Wed, 21 Sep 2011 19:31:30 +0000 (21:31 +0200)]
s3: Fix Coverity ID 2619: UNINIT

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Sep 22 01:55:04 CEST 2011 on sn-devel-104

8 years agos3: Fix Coverity ID 2618: UNINIT
Volker Lendecke [Wed, 21 Sep 2011 19:31:15 +0000 (21:31 +0200)]
s3: Fix Coverity ID 2618: UNINIT

8 years agoRemove extraneous debug code.
Jeremy Allison [Wed, 21 Sep 2011 20:47:22 +0000 (13:47 -0700)]
Remove extraneous debug code.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 22 00:22:12 CEST 2011 on sn-devel-104

8 years agoFix bug #8458] - IE9 on Windows 7 cannot download files to samba 3.5.11 share
Jeremy Allison [Wed, 21 Sep 2011 20:33:38 +0000 (13:33 -0700)]
Fix bug #8458] - IE9 on Windows 7 cannot download files to samba 3.5.11 share

Handle the SECINFO_LABEL flag in the same was as Win2k3.

8 years agoFix bug #8474 - SMB2 create doesn't cope with an Apple client using NULL blob in...
Jeremy Allison [Wed, 21 Sep 2011 18:40:01 +0000 (11:40 -0700)]
Fix bug #8474 - SMB2 create doesn't cope with an Apple client using NULL blob in create

Cope with zero length data_offset and data_length values.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Sep 21 22:12:40 CEST 2011 on sn-devel-104

8 years agoFix bug #8473 - smb2_find uses a hard coded max reply size of 0x10000 instead of...
Jeremy Allison [Wed, 21 Sep 2011 18:30:06 +0000 (11:30 -0700)]
Fix bug #8473 - smb2_find uses a hard coded max reply size of 0x10000 instead of smb2_max_trans.

Use lp_smb2_max_trans() instead of 0x10000.

8 years agos3-libnet: allow to use default krb5 ccache in libnet_Join/libnet_Unjoin.
Günther Deschner [Wed, 21 Sep 2011 15:28:58 +0000 (17:28 +0200)]
s3-libnet: allow to use default krb5 ccache in libnet_Join/libnet_Unjoin.

We force using a MEMORY ccache though in the wkssvc server.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Sep 21 19:13:33 CEST 2011 on sn-devel-104

8 years agos3-netapi: allow to use default krb5 credential cache for libnetapi users.
Günther Deschner [Wed, 21 Sep 2011 15:28:02 +0000 (17:28 +0200)]
s3-netapi: allow to use default krb5 credential cache for libnetapi users.

Guenther

8 years agos3:smb2-server: session setup replies should always be signed (except for guest sessions)
Michael Adam [Wed, 21 Sep 2011 01:56:30 +0000 (03:56 +0200)]
s3:smb2-server: session setup replies should always be signed (except for guest sessions)

not only if the session should be signed

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 21 11:00:09 CEST 2011 on sn-devel-104

8 years agotdb2: change --enable-tdb2-breaks-compat to --enable-tdb2
Rusty Russell [Wed, 21 Sep 2011 05:48:05 +0000 (15:18 +0930)]
tdb2: change --enable-tdb2-breaks-compat to --enable-tdb2

Since we no longer break compatibility, don't scare people.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Wed Sep 21 09:25:11 CEST 2011 on sn-devel-104

8 years agotdb_compat: add "TDB_COMPAT_USE_TDB2" environment variable
Rusty Russell [Wed, 21 Sep 2011 03:28:59 +0000 (12:58 +0930)]
tdb_compat: add "TDB_COMPAT_USE_TDB2" environment variable

When BUILD_TDB2 is defined, add TDB_VERSION1 flag to all tdb_open()
calls, unless this flag is set.  This means we use the tdb1 on-disk
format unless the user specifically asks for tdb2.

We'd love to do this using loadparm, but we need to work with both
Samba 3 and Samba 4's loadparm, and they're not unified yet.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotdb_compat: honour hashsize arg when using tdb2 with TDB_VERSION1 flag.
Rusty Russell [Wed, 21 Sep 2011 03:27:59 +0000 (12:57 +0930)]
tdb_compat: honour hashsize arg when using tdb2 with TDB_VERSION1 flag.

We use the TDB_ATTRIBUTE_TDB1_HASHSIZE to set the hash size.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotdb_compat: handle TDB_VOLATILE flag.
Rusty Russell [Wed, 21 Sep 2011 03:26:59 +0000 (12:56 +0930)]
tdb_compat: handle TDB_VOLATILE flag.

This is only meaningful when using the TDB_VERSION1 flag: we set the
attribute to control the maximum number of dead records (to 5, which is
what TDB_VOLATILE did for tdb1).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotdb_compat: handle TDB_INCOMPATIBLE_HASH flag.
Rusty Russell [Wed, 21 Sep 2011 03:25:59 +0000 (12:55 +0930)]
tdb_compat: handle TDB_INCOMPATIBLE_HASH flag.

This is only meaningful when using the TDB_VERSION1 flag: it is done
by using a magic hash value (which will fall back to the default hash
if that works instead).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoTry and fix bug #8472 - Crash in asn.1 parsing code.
Jeremy Allison [Wed, 21 Sep 2011 01:50:00 +0000 (18:50 -0700)]
Try and fix bug #8472 - Crash in asn.1 parsing code.

Found by Codenomicon at the SNIA plugfest. Don't keep going
in the loop when reading the OIDs fail.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Sep 21 05:24:59 CEST 2011 on sn-devel-104

8 years agos3: Further fix for bug 8338
Volker Lendecke [Tue, 20 Sep 2011 20:45:52 +0000 (22:45 +0200)]
s3: Further fix for bug 8338

OS/X can not deal with a 10-vwv read on normal files.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Sep 21 00:51:08 CEST 2011 on sn-devel-104

8 years agoFix some typos
Volker Lendecke [Sun, 18 Sep 2011 23:41:27 +0000 (01:41 +0200)]
Fix some typos

8 years agos3: Fix typos
Volker Lendecke [Sun, 18 Sep 2011 22:02:55 +0000 (00:02 +0200)]
s3: Fix typos

8 years agos4:ntvfs common - remove two outdated function prototypes
Matthias Dieter Wallnöfer [Tue, 20 Sep 2011 16:38:54 +0000 (18:38 +0200)]
s4:ntvfs common - remove two outdated function prototypes

The two functions don't exist anymore.

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Sep 20 20:16:29 CEST 2011 on sn-devel-104

8 years agos4:ntvfs common - add "UTIL_TDB" and "tdb-wrap" as internal build dependency
Matthias Dieter Wallnöfer [Tue, 20 Sep 2011 13:04:54 +0000 (15:04 +0200)]
s4:ntvfs common - add "UTIL_TDB" and "tdb-wrap" as internal build dependency

These modules are required for both header and source code files (see
bug #8468).

Reviewed-by: Jelmer
8 years agos4:param/pyparam.c - suppress "P_SEP" compilation warning
Matthias Dieter Wallnöfer [Tue, 20 Sep 2011 12:32:52 +0000 (14:32 +0200)]
s4:param/pyparam.c - suppress "P_SEP" compilation warning

Reviewed-by: Jelmer
8 years agos3-docs: document -k switch in net manpage.
Günther Deschner [Tue, 20 Sep 2011 12:13:36 +0000 (14:13 +0200)]
s3-docs: document -k switch in net manpage.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Sep 20 15:47:00 CEST 2011 on sn-devel-104

8 years agos4-drs: allow replication of the GC partial attribute set
Andrew Tridgell [Tue, 20 Sep 2011 05:15:36 +0000 (15:15 +1000)]
s4-drs: allow replication of the GC partial attribute set

when a DC has the GUID_DRS_GET_FILTERED_ATTRIBUTES right on a NC, we
need to allow it to replicate if all the attributes it is asking for
are in the GC partial attribute set

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Sep 20 13:47:38 CEST 2011 on sn-devel-104

8 years agotdb2: allow readonly changes even while holding locks.
Rusty Russell [Tue, 20 Sep 2011 02:32:43 +0000 (12:02 +0930)]
tdb2: allow readonly changes even while holding locks.

This happens in SAMBA with the TDB_VERSION1, presumably due to a
read-only traverse nested inside a normal traverse (since it doesn't
occur without TDB_VERSION1).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
(Imported from CCAN commit 24e5ddb143fb5e79112649472258f5da67cc7362)

Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue Sep 20 09:35:10 CEST 2011 on sn-devel-104

8 years agos3:dbwrap_ctdb: skip the internal __db_sequence_number__ key from (persistent) traver...
Michael Adam [Tue, 20 Sep 2011 02:33:31 +0000 (04:33 +0200)]
s3:dbwrap_ctdb: skip the internal __db_sequence_number__ key from (persistent) traverse and traverse_read

This is is used internally in the persistent transactions and should not surface.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Sep 20 07:59:20 CEST 2011 on sn-devel-104

8 years agos3:dbwrap_tool: add popt support and standard samba options
Michael Adam [Tue, 20 Sep 2011 02:32:25 +0000 (04:32 +0200)]
s3:dbwrap_tool: add popt support and standard samba options

8 years agos3:g_lock: add a missing \n to a debug message in g_lock_init
Michael Adam [Mon, 19 Sep 2011 20:30:57 +0000 (22:30 +0200)]
s3:g_lock: add a missing \n to a debug message in g_lock_init

8 years agolib/util/charset: remove charset module loading
Andrew Bartlett [Tue, 20 Sep 2011 02:13:21 +0000 (19:13 -0700)]
lib/util/charset: remove charset module loading

Now that the 'table' modules are gone, there is no reason for there to
be charset modules at all.  This builds the macosxfs and weird modules
into the binary at the appropriate times, and changes the tests to
test instead the difference between the remaining internal handlers
and iconv().

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Sep 20 06:27:06 CEST 2011 on sn-devel-104

8 years agolib/util/charcnv: Remove broken internal CP850 and CP464 modules
Andrew Bartlett [Fri, 16 Sep 2011 21:52:28 +0000 (14:52 -0700)]
lib/util/charcnv: Remove broken internal CP850 and CP464 modules

These modules are now known to be faulty, and Samba 3.6.0 didn't
include support for them, so we now require a system iconv if you wish
to support these character sets for the non-ASCII range.

Andrew Bartlett

8 years agos4-client: added close command in smbclient
Andrew Tridgell [Mon, 19 Sep 2011 20:06:26 +0000 (06:06 +1000)]
s4-client: added close command in smbclient

this matches the existing open command, and also gives you error codes
on both open and close

useful for testing share mode locking

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Sep 19 23:59:28 CEST 2011 on sn-devel-104

8 years agos4:ntvfs/common/brlock.c - remove unnecessary include "tdb_compat.h"
Matthias Dieter Wallnöfer [Mon, 19 Sep 2011 11:12:48 +0000 (13:12 +0200)]
s4:ntvfs/common/brlock.c - remove unnecessary include "tdb_compat.h"

Attempt to fix bug #8468
(https://bugzilla.samba.org/show_bug.cgi?id=8468).

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Sep 19 18:03:24 CEST 2011 on sn-devel-104

8 years agos4:libnet/py_net.c - fix up includes (in order to find all "struct"s)
Matthias Dieter Wallnöfer [Mon, 19 Sep 2011 08:48:31 +0000 (10:48 +0200)]
s4:libnet/py_net.c - fix up includes (in order to find all "struct"s)

Reviewed-by: Jelmer
8 years agos4:auth - remove unused variables
Matthias Dieter Wallnöfer [Mon, 19 Sep 2011 08:29:57 +0000 (10:29 +0200)]
s4:auth - remove unused variables

Reviewed-by: Jelmer
8 years agos4:selftest: run the nbt tests before the smb tests
Stefan Metzmacher [Mon, 19 Sep 2011 03:11:50 +0000 (05:11 +0200)]
s4:selftest: run the nbt tests before the smb tests

This hopefully avoids to run into problems with the
flakey error in the samba4.nbt.winsreplication test

 [1071/1154 in 58m58s] samba4.nbt.winsreplication(dc)
 Test if we always get back the same assoc_ctx
 Setup wrepl connections
 Test one pull replication cycle
 Setup wrepl connections
 Setup wrepl conflict pull connection
 UNEXPECTED(error): samba4.nbt.winsreplication.replica
 REASON: _StringException: _StringException: Unknown error/failure

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Sep 19 16:29:22 CEST 2011 on sn-devel-104

8 years agos3:registry: fix a debug message in the v2_to_v3 upgrade code
Michael Adam [Tue, 13 Sep 2011 15:11:04 +0000 (17:11 +0200)]
s3:registry: fix a debug message in the v2_to_v3 upgrade code

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Sep 19 10:31:45 CEST 2011 on sn-devel-104

8 years agos3:smb2cli: remove unused struct ntlmssp_state from smb2cli_session_setup_state
Stefan Metzmacher [Sun, 18 Sep 2011 18:24:38 +0000 (20:24 +0200)]
s3:smb2cli: remove unused struct ntlmssp_state from smb2cli_session_setup_state

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Sep 19 06:06:46 CEST 2011 on sn-devel-104

8 years agos3:smb2cli: s/smb2cli_sesssetup_blob/smb2cli_session_setup/
Stefan Metzmacher [Sun, 18 Sep 2011 18:23:22 +0000 (20:23 +0200)]
s3:smb2cli: s/smb2cli_sesssetup_blob/smb2cli_session_setup/

metze

8 years agos4-dsdb: cope with out of sync replication attributes in partition module
Andrew Tridgell [Mon, 19 Sep 2011 00:55:17 +0000 (10:55 +1000)]
s4-dsdb: cope with out of sync replication attributes in partition module

if the @ATTRIBUTES or other objects which are replicated between
partions become out of sync, then the ldb would fail to open. This
changes ensures that we can always fix those records, by running the
operation in the top level partition, and replicating the result to
the other partitions

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Sep 19 04:31:48 CEST 2011 on sn-devel-104

8 years agoldb:"ldb_extended" -make the call more similar to "ldb_search"
Matthias Dieter Wallnöfer [Tue, 21 Jun 2011 20:25:22 +0000 (22:25 +0200)]
ldb:"ldb_extended" -make the call more similar to "ldb_search"

For example NULL out the LDB result pointer on failures.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agopyldb: fixed places where we try to concatenate a Dn with a string
Andrew Tridgell [Fri, 16 Sep 2011 05:15:35 +0000 (15:15 +1000)]
pyldb: fixed places where we try to concatenate a Dn with a string

you need to either use str(dn) or use %s in a format string

8 years agos4-provision: use get_config_basedn() in DNS setup
Andrew Tridgell [Fri, 16 Sep 2011 01:18:26 +0000 (11:18 +1000)]
s4-provision: use get_config_basedn() in DNS setup

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agosamba-tool: use get_config_basedn() to get configuration NC DN
Andrew Tridgell [Fri, 16 Sep 2011 01:18:05 +0000 (11:18 +1000)]
samba-tool: use get_config_basedn() to get configuration NC DN

this allows these commands to work for subdomains

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-kdc: default kvno for inter-domain trusts to zero
Andrew Tridgell [Fri, 16 Sep 2011 01:15:27 +0000 (11:15 +1000)]
s4-kdc: default kvno for inter-domain trusts to zero

the exact value doesn't matter, as both Samba and windows check
against the latest password, but the old default of -1 caused ASN.1
parsing errors on windows, which prevented it answering TGS requests

thanks to Hongwei Sun for finding this from a ttt trace

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-dsdb: use get_config_basedn() in python tests
Andrew Tridgell [Fri, 16 Sep 2011 01:14:12 +0000 (11:14 +1000)]
s4-dsdb: use get_config_basedn() in python tests

we can't just append CN=Configuration to the basedn, as that won't
give the right configuration DN for a subdomain of a forest

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-drs: cope with REPL_OBJ getncchanges call for new object
Andrew Tridgell [Fri, 16 Sep 2011 01:13:05 +0000 (11:13 +1000)]
s4-drs: cope with REPL_OBJ getncchanges call for new object

when we do a subdomain join we create a new object using a REPL_OBJ
getncchanges call for the partitions DN. This has a side effect of
creating that object. We need to skip the UDV update in that case

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-provision Add initial support for joining as a new subdomain
Andrew Bartlett [Wed, 24 Aug 2011 05:39:51 +0000 (15:39 +1000)]
s4-provision Add initial support for joining as a new subdomain

To do this we need to reorganise a lot of the provision code, so that
we can create the framework for the inbound replicaton of the config
and schema partitions and then add in the new subdomain locally.

Andrew Bartlett

8 years agoFix a typo. This is not an electromagnet pulse daemon I guess :-)
Volker Lendecke [Sun, 18 Sep 2011 21:19:41 +0000 (23:19 +0200)]
Fix a typo. This is not an electromagnet pulse daemon I guess :-)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Sep 19 01:25:23 CEST 2011 on sn-devel-104

8 years agos3: Add some const to create_local_private_krb5_conf_for_domain
Volker Lendecke [Sun, 18 Sep 2011 19:59:31 +0000 (21:59 +0200)]
s3: Add some const to create_local_private_krb5_conf_for_domain

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Sep 18 23:31:28 CEST 2011 on sn-devel-104

8 years agos3: Add some const to print_kdc_line
Volker Lendecke [Sun, 18 Sep 2011 19:59:20 +0000 (21:59 +0200)]
s3: Add some const to print_kdc_line

8 years agos3:smb2cli: s/smb2cli_sesssetup/smb2cli_sesssetup_ntlmssp/
Stefan Metzmacher [Sun, 18 Sep 2011 18:09:48 +0000 (20:09 +0200)]
s3:smb2cli: s/smb2cli_sesssetup/smb2cli_sesssetup_ntlmssp/

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Sep 18 21:43:26 CEST 2011 on sn-devel-104

8 years agos3: Fix a c++ warning
Volker Lendecke [Sat, 17 Sep 2011 23:52:14 +0000 (01:52 +0200)]
s3: Fix a c++ warning

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Sep 18 18:55:48 CEST 2011 on sn-devel-104

8 years agos3: Fix "ISO C90 forbids mixed declarations and code"
Volker Lendecke [Sat, 17 Sep 2011 23:50:37 +0000 (01:50 +0200)]
s3: Fix "ISO C90 forbids mixed declarations and code"

8 years agoswrap: Fix a c++ warning
Volker Lendecke [Sat, 17 Sep 2011 23:31:44 +0000 (01:31 +0200)]
swrap: Fix a c++ warning

8 years agos3: Fix two c++ warnings
Volker Lendecke [Sat, 17 Sep 2011 23:27:53 +0000 (01:27 +0200)]
s3: Fix two c++ warnings

8 years agopyldb: Drop unnecessary dependency on pytalloc-util.
Jelmer Vernooij [Sun, 18 Sep 2011 13:23:56 +0000 (15:23 +0200)]
pyldb: Drop unnecessary dependency on pytalloc-util.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Sep 18 17:23:40 CEST 2011 on sn-devel-104

8 years agos3:smb2cli: pass timeout to smb2cli_req_create/send()
Stefan Metzmacher [Sat, 17 Sep 2011 17:56:50 +0000 (19:56 +0200)]
s3:smb2cli: pass timeout to smb2cli_req_create/send()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Sep 18 07:04:05 CEST 2011 on sn-devel-104

8 years agos3:smb2cli: pass an array of expected status/body_size pairs to smb2cli_req_recv()
Stefan Metzmacher [Tue, 30 Aug 2011 22:40:06 +0000 (00:40 +0200)]
s3:smb2cli: pass an array of expected status/body_size pairs to smb2cli_req_recv()

This gives the caller more control and correctly reports unexpected
errors to the caller, instead of return NT_STATUS_INVALID_NETWOR_RESPONSE

metze

8 years agos3:smb2cli: only use tevent_req_defer_callback() if we have more than one smb2 response
Stefan Metzmacher [Wed, 7 Sep 2011 16:55:02 +0000 (18:55 +0200)]
s3:smb2cli: only use tevent_req_defer_callback() if we have more than one smb2 response

metze

8 years agos3:smb2cli: ignore async interim responses and store the async_id
Stefan Metzmacher [Sat, 17 Sep 2011 19:17:18 +0000 (21:17 +0200)]
s3:smb2cli: ignore async interim responses and store the async_id

metze

8 years agos3:smb2cli: check the response has the SMB2_HDR_FLAG_REDIRECT flag
Stefan Metzmacher [Sat, 17 Sep 2011 19:15:45 +0000 (21:15 +0200)]
s3:smb2cli: check the response has the SMB2_HDR_FLAG_REDIRECT flag

metze

8 years agos3:smb2cli: validate the opcode from the server is as expected
Stefan Metzmacher [Sat, 17 Sep 2011 19:13:58 +0000 (21:13 +0200)]
s3:smb2cli: validate the opcode from the server is as expected

metze

8 years agos3:smb2cli: initialize status if we got an unexpected response
Stefan Metzmacher [Sat, 17 Sep 2011 19:11:23 +0000 (21:11 +0200)]
s3:smb2cli: initialize status if we got an unexpected response

metze

8 years agos3:libsmb: return INTERNAL_ERROR if the request is in bad state when the caller ships it
Stefan Metzmacher [Sat, 17 Sep 2011 19:09:30 +0000 (21:09 +0200)]
s3:libsmb: return INTERNAL_ERROR if the request is in bad state when the caller ships it

metze

8 years agos3:libsmb: return if tevent_req_set_endtime() fails
Stefan Metzmacher [Sat, 17 Sep 2011 17:49:01 +0000 (19:49 +0200)]
s3:libsmb: return if tevent_req_set_endtime() fails

tevent_req_set_endtime() already calls tevent_req_nomem().

metze

8 years agos3:SMB2-BASIC: test smb2cli_flush()
Stefan Metzmacher [Sat, 17 Sep 2011 17:29:51 +0000 (19:29 +0200)]
s3:SMB2-BASIC: test smb2cli_flush()

metze

8 years agos3:smb2cli: SMB2_FLUSH responses have a body size of 4
Stefan Metzmacher [Sat, 17 Sep 2011 17:30:36 +0000 (19:30 +0200)]
s3:smb2cli: SMB2_FLUSH responses have a body size of 4

metze

8 years agos3: Trim a debug to 80 chars
Volker Lendecke [Sat, 17 Sep 2011 21:43:19 +0000 (23:43 +0200)]
s3: Trim a debug to 80 chars

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Sep 18 01:15:02 CEST 2011 on sn-devel-104

8 years agos3: Fix a cut&paste error
Volker Lendecke [Sat, 17 Sep 2011 21:42:23 +0000 (23:42 +0200)]
s3: Fix a cut&paste error

8 years agos4:selftest: skip flakey samba4.drs.repl_schema.python for now
Stefan Metzmacher [Sat, 17 Sep 2011 05:06:26 +0000 (07:06 +0200)]
s4:selftest: skip flakey samba4.drs.repl_schema.python for now

UNEXPECTED(error): samba4.drs.repl_schema.python(vampire_dc).repl_schema.DrsReplSchemaTestCase.test_classWithCustomAttribute
REASON: _StringException: _StringException: Content-Type: text/x-traceback;charset=utf8,language=python
traceback
49F
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/memdisk/autobuild/flakey/b12973/samba4/source4/torture/drs/python/repl_schema.py", line 179, in test_classWithCustomAttribute
    self._net_drs_replicate(DC=self.dnsname_dc2, fromDC=self.dnsname_dc1, nc_dn=self.schema_dn)
  File "/memdisk/autobuild/flakey/b12973/samba4/source4/torture/drs/python/drs_base.py", line 110, in _net_drs_replicate
    return self.check_output(cmd_line)
  File "bin/python/samba/tests/__init__.py", line 157, in check_output
    raise BlackboxProcessError(retcode, line, p.stdout.read(), p.stderr.read())
BlackboxProcessError: Command '/memdisk/autobuild/flakey/b12973/samba4/bin/samba-tool drs replicate -USAMBADOMAIN/Administrator%locDCpass1 --sync-forced LOCALVAMPIREDC.samba.example.com localdc.samba.example.com CN=Schema,CN=Configuration,DC=samba,DC=example,DC=com'; exit status 255; stdout: ''; stderr: 'ERROR(runtime): DsReplicaSync failed - (-1073741807, 'NT_STATUS_END_OF_FILE')
'
0

As this is an error, we have to skip it instead of adding it to the knowfail file

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Sep 17 08:43:31 CEST 2011 on sn-devel-104

8 years agos3: Fix bug 8455 -- Samba PDC is looking up only primary user group
Volker Lendecke [Fri, 16 Sep 2011 13:45:47 +0000 (15:45 +0200)]
s3: Fix bug 8455 -- Samba PDC is looking up only primary user group

group_sids_to_info3 does a sid_peek_check_rid on the domain sid before adding
the rids to the array. If the domain sid is 0x0, then the check will always
fail.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Sep 17 00:51:27 CEST 2011 on sn-devel-104

8 years agolibcli/smb: add SMB2_DIALECT_REVISION_222
Stefan Metzmacher [Fri, 16 Sep 2011 14:12:24 +0000 (16:12 +0200)]
libcli/smb: add SMB2_DIALECT_REVISION_222

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Sep 16 19:51:47 CEST 2011 on sn-devel-104

8 years agolibcli/smb: add PROTOCOL_SMB2_22
Stefan Metzmacher [Fri, 16 Sep 2011 14:11:47 +0000 (16:11 +0200)]
libcli/smb: add PROTOCOL_SMB2_22

metze

8 years agos3:libsmb: forward declaration for struct smb_trans_enc_state
Stefan Metzmacher [Thu, 15 Sep 2011 15:56:04 +0000 (17:56 +0200)]
s3:libsmb: forward declaration for struct smb_trans_enc_state

metze

8 years agos3-waf: finally make SO_PEERCRED configure check work with stricter CFLAGS.
Günther Deschner [Fri, 16 Sep 2011 10:35:58 +0000 (12:35 +0200)]
s3-waf: finally make SO_PEERCRED configure check work with stricter CFLAGS.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Sep 16 14:14:48 CEST 2011 on sn-devel-104

8 years agos3: Trim lines in nfs4_acls.c
Volker Lendecke [Thu, 15 Sep 2011 21:35:05 +0000 (23:35 +0200)]
s3: Trim lines in nfs4_acls.c

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Sep 16 01:39:36 CEST 2011 on sn-devel-104

8 years agos3: Fix some nonempty blank lines
Volker Lendecke [Thu, 15 Sep 2011 21:24:51 +0000 (23:24 +0200)]
s3: Fix some nonempty blank lines

8 years agos3: Make sharesec optionally use sddl
Volker Lendecke [Thu, 15 Sep 2011 17:27:07 +0000 (19:27 +0200)]
s3: Make sharesec optionally use sddl

8 years agos4:upgrade_from_s3 - old s3 versions < 3.4.x don't have a "state directory" param
Matthias Dieter Wallnöfer [Wed, 14 Sep 2011 08:12:30 +0000 (10:12 +0200)]
s4:upgrade_from_s3 - old s3 versions < 3.4.x don't have a "state directory" param

Hence the "lock directory" path has to be used instead.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Sep 16 00:07:30 CEST 2011 on sn-devel-104

8 years agotalloc: change version to 2.0.7 talloc-2.0.7
Stefan Metzmacher [Thu, 15 Sep 2011 15:05:11 +0000 (17:05 +0200)]
talloc: change version to 2.0.7

The version change is needed because the ABI file
of the pytalloc code was fixed.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 15 22:32:59 CEST 2011 on sn-devel-104