ambi/samba-autobuild/.git
7 years agoWHATSNEW: more information on running dbcheck
Andrew Tridgell [Tue, 13 Sep 2011 02:05:00 +0000 (12:05 +1000)]
WHATSNEW: more information on running dbcheck

7 years agos4-python: Fix some formatting issues.
Jelmer Vernooij [Mon, 12 Sep 2011 23:27:50 +0000 (01:27 +0200)]
s4-python: Fix some formatting issues.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Sep 13 03:51:13 CEST 2011 on sn-devel-104

7 years agos4-python: Consistently use spaces rather than tabs, fix headers in several places.
Jelmer Vernooij [Mon, 12 Sep 2011 23:10:37 +0000 (01:10 +0200)]
s4-python: Consistently use spaces rather than tabs, fix headers in several places.

7 years agoAdd samba.tests.source, which checks Python files for copyright lines, license header...
Jelmer Vernooij [Mon, 12 Sep 2011 23:09:16 +0000 (01:09 +0200)]
Add samba.tests.source, which checks Python files for copyright lines, license headers and invalid characters (dos newlines, tabs).

7 years agotestparm.py: Use standard formatting of header.
Jelmer Vernooij [Mon, 12 Sep 2011 22:20:57 +0000 (00:20 +0200)]
testparm.py: Use standard formatting of header.

7 years agogroup.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:20:17 +0000 (00:20 +0200)]
group.py: Remove tab characters.

7 years agodrs.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:20:03 +0000 (00:20 +0200)]
drs.py: Remove tab characters.

7 years agodomain.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:19:51 +0000 (00:19 +0200)]
domain.py: Remove tab characters.

7 years agodelegation.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:19:45 +0000 (00:19 +0200)]
delegation.py: Remove tab characters.

7 years agodrs_utils.py: Remove tab characters.
Jelmer Vernooij [Mon, 12 Sep 2011 22:19:24 +0000 (00:19 +0200)]
drs_utils.py: Remove tab characters.

7 years agos4:lib/socket/interface.c - "ifaces" strictly needs to be initialised
Matthias Dieter Wallnöfer [Mon, 12 Sep 2011 13:45:11 +0000 (15:45 +0200)]
s4:lib/socket/interface.c - "ifaces" strictly needs to be initialised

Please consider a failing "get_interfaces" call and the "talloc_free()"
operation on a possible uninitialised "ifaces" on line 326.

https://bugzilla.samba.org/show_bug.cgi?id=8397

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Sep 12 23:49:12 CEST 2011 on sn-devel-104

7 years agoMove the talloc_move call until *after* the check on status. Don't want to move somet...
Jeremy Allison [Mon, 12 Sep 2011 18:23:17 +0000 (11:23 -0700)]
Move the talloc_move call until *after* the check on status. Don't want to move something that might be invalid.

Makes the code match what is currently in 3.6.x.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Sep 12 22:21:24 CEST 2011 on sn-devel-104

7 years agos3:libsmb: check the wct of the incoming SMBnegprot responses
Stefan Metzmacher [Mon, 12 Sep 2011 05:13:56 +0000 (07:13 +0200)]
s3:libsmb: check the wct of the incoming SMBnegprot responses

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Sep 12 20:50:27 CEST 2011 on sn-devel-104

7 years agos3:libsmb: let cli_pull_raw_error() return NT_STATUS_OK as DOS-Error success
Stefan Metzmacher [Mon, 12 Sep 2011 07:45:13 +0000 (09:45 +0200)]
s3:libsmb: let cli_pull_raw_error() return NT_STATUS_OK as DOS-Error success

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Sep 12 19:12:21 CEST 2011 on sn-devel-104

7 years agos3-auth: fix uninitialized server_info
Sumit Bose [Mon, 12 Sep 2011 13:50:31 +0000 (15:50 +0200)]
s3-auth: fix uninitialized server_info

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Sep 12 17:44:46 CEST 2011 on sn-devel-104

7 years agos3-lsa: Add conversion for auth info structs
Sumit Bose [Thu, 1 Sep 2011 16:18:31 +0000 (18:18 +0200)]
s3-lsa: Add conversion for auth info structs

struct lsa_TrustDomainInfoAuthInfo and struct
trustAuthInOutBlob can store the same information for different usage. The added
routines can convert one struct into the other.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Sep 12 15:52:17 CEST 2011 on sn-devel-104

7 years agodoc: suggest samba-tool dbcheck in upgrading-samba4.txt
Andrew Bartlett [Mon, 12 Sep 2011 10:41:29 +0000 (20:41 +1000)]
doc: suggest samba-tool dbcheck in upgrading-samba4.txt

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Sep 12 14:24:20 CEST 2011 on sn-devel-104

7 years agos4-s3-upgrade Remove upgrade_from_s3 script, use samba-tool domain samba3upgrade
Andrew Bartlett [Mon, 12 Sep 2011 10:21:53 +0000 (20:21 +1000)]
s4-s3-upgrade Remove upgrade_from_s3 script, use samba-tool domain samba3upgrade

7 years agostart Samba 4.0alpha17 release notes
Andrew Bartlett [Mon, 12 Sep 2011 04:16:12 +0000 (14:16 +1000)]
start Samba 4.0alpha17 release notes

7 years agos3-selftest: Set path to bin/net and bin/wbinfo in command line to test scripts
Andrew Bartlett [Sat, 10 Sep 2011 22:16:50 +0000 (08:16 +1000)]
s3-selftest: Set path to bin/net and bin/wbinfo in command line to test scripts

This makes it easier to reproduce these tests outside the test
environment, as we rely less on environment variables.

Andrew Bartlett

7 years agosamba-tool: Add "domain samba3upgrade" subcommand
Amitay Isaacs [Mon, 12 Sep 2011 06:03:34 +0000 (16:03 +1000)]
samba-tool: Add "domain samba3upgrade" subcommand

Added new command to upgrade from samba3 to samba4.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-s3-upgrade: Check for duplicate sids before provisioning
Amitay Isaacs [Mon, 12 Sep 2011 05:09:49 +0000 (15:09 +1000)]
s4-s3-upgrade: Check for duplicate sids before provisioning

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-provision: Fix the informational message from dns provisioning
Amitay Isaacs [Mon, 12 Sep 2011 03:17:50 +0000 (13:17 +1000)]
s4-provision: Fix the informational message from dns provisioning

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-provision: Create private dir for dns in a separate function
Amitay Isaacs [Mon, 12 Sep 2011 03:14:42 +0000 (13:14 +1000)]
s4-provision: Create private dir for dns in a separate function

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-s3-upgrade: Check for common user/group names before provisioning
Amitay Isaacs [Mon, 12 Sep 2011 02:14:00 +0000 (12:14 +1000)]
s4-s3-upgrade: Check for common user/group names before provisioning

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-provision: Generate appropriate named.conf file depending on dns_backend
Amitay Isaacs [Thu, 8 Sep 2011 05:33:41 +0000 (15:33 +1000)]
s4-provision: Generate appropriate named.conf file depending on dns_backend

For --dns_backend=BIND9, generate the dns zone file, and named.conf with
zone information.

For --dns-backend=BIND9_DLZ, generate the named.conf with dlz directive.

If no option is specified, default dns_backend is BIND9.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-provision: Remove dupliate creation of dns/spn_update_list files
Amitay Isaacs [Thu, 8 Sep 2011 05:29:59 +0000 (15:29 +1000)]
s4-provision: Remove dupliate creation of dns/spn_update_list files

dns_update_list and spn_update_list are set up using
create_dns_update_list() function.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-provision: Add named.conf template for BIND9 with DLZ support
Amitay Isaacs [Thu, 8 Sep 2011 05:24:11 +0000 (15:24 +1000)]
s4-provision: Add named.conf template for BIND9 with DLZ support

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-provision: Add Seperate instructions for BIND 9.7.x and 9.8.x.
Amitay Isaacs [Thu, 8 Sep 2011 04:44:44 +0000 (14:44 +1000)]
s4-provision: Add Seperate instructions for BIND 9.7.x and 9.8.x.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-provision: Enable SPNs for DNS
Amitay Isaacs [Mon, 5 Sep 2011 06:20:00 +0000 (16:20 +1000)]
s4-provision: Enable SPNs for DNS

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4:samba-tool/domain.py - rename arguments "domain" -> "domain-level", "forest" ...
Matthias Dieter Wallnöfer [Sun, 11 Sep 2011 15:31:38 +0000 (17:31 +0200)]
s4:samba-tool/domain.py - rename arguments "domain" -> "domain-level", "forest" -> "forest-level"

This should clarify the scope of them.

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Sep 11 20:12:52 CEST 2011 on sn-devel-104

7 years agos4:samba-tool/domain.py - restore domain raise functionality
Matthias Dieter Wallnöfer [Fri, 9 Sep 2011 13:27:25 +0000 (15:27 +0200)]
s4:samba-tool/domain.py - restore domain raise functionality

The samba-tool command has accidentally been damaged by commit
2d4988c3d79e501003875cd26b7f9aaa72402b31.

Reviewed-by: Jelmer
7 years agoldb:ldb_controls.c - remove duplicate definition of "LDB_CONTROL_CMP"
Matthias Dieter Wallnöfer [Wed, 22 Jun 2011 12:48:33 +0000 (14:48 +0200)]
ldb:ldb_controls.c - remove duplicate definition of "LDB_CONTROL_CMP"

And fix the comment

Reviewed-by: Jelmer
7 years agoldb:pyldb.c - point out that "PyLdbResult_AsResult" does not convert everything
Matthias Dieter Wallnöfer [Tue, 21 Jun 2011 09:11:04 +0000 (11:11 +0200)]
ldb:pyldb.c - point out that "PyLdbResult_AsResult" does not convert everything

Reviewed-by: Jelmer
7 years agolib/util/charset: the comparsion must be against our charset modules
Andrew Bartlett [Sat, 10 Sep 2011 05:51:45 +0000 (15:51 +1000)]
lib/util/charset: the comparsion must be against our charset modules

There is little point testing this against the system iconv.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Sep 10 15:45:42 CEST 2011 on sn-devel-104

7 years agolib/util/charset Use name of ISO-8859-1 that matches our internal implementation
Andrew Bartlett [Sat, 10 Sep 2011 05:41:14 +0000 (15:41 +1000)]
lib/util/charset Use name of ISO-8859-1 that matches our internal implementation

7 years agolib/util/charset: Improve toture assertions in iconv test
Andrew Bartlett [Sat, 10 Sep 2011 03:23:22 +0000 (13:23 +1000)]
lib/util/charset: Improve toture assertions in iconv test

7 years agolib/util/charset Run charset sets with and without the system iconv
Andrew Bartlett [Fri, 9 Sep 2011 23:53:29 +0000 (09:53 +1000)]
lib/util/charset Run charset sets with and without the system iconv

We need to know that we can load the samba-provided modules, and that
they are correct.  However, we must mark a number of tests as
knownfail due to errors in our internal iconv modules.

Andrew Bartlett

7 years agolib/util/charset: add back loading of charset modules
Andrew Bartlett [Fri, 9 Sep 2011 13:51:06 +0000 (23:51 +1000)]
lib/util/charset: add back loading of charset modules

For autoconf builds these remain as modules, for waf builds they are
built into the charset library.

This is required to provide the CP850 charset when iconv is not available.

The charset modules static for the waf builds because with proper
shared libs, there isn't the same need for these to be in seperate .so
files.  The modules are also not produced if a system iconv is found,
except for developers, to allow testing of both code paths.

Andrew Bartlett

7 years agolibcli/smb: s/FLAGS2_UNKNOWN_BIT4/FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED
Stefan Metzmacher [Fri, 9 Sep 2011 20:43:28 +0000 (22:43 +0200)]
libcli/smb: s/FLAGS2_UNKNOWN_BIT4/FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Sep 10 00:34:50 CEST 2011 on sn-devel-104

7 years agos4-s3-upgrade Do not use python 2.6 style exceptions
Andrew Bartlett [Fri, 9 Sep 2011 02:44:56 +0000 (12:44 +1000)]
s4-s3-upgrade Do not use python 2.6 style exceptions

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Sep  9 08:54:16 CEST 2011 on sn-devel-104

7 years agobuild: a more robust zlib test
Andrew Bartlett [Fri, 9 Sep 2011 02:08:54 +0000 (12:08 +1000)]
build: a more robust zlib test

Just in-case, and done this way due to the #define maze that applies
to this function.  No actual host has been found that needs this yet.

Andrew Bartlett

7 years agosamba-tool: epilog option to OptionParser available in python >= 2.6
Amitay Isaacs [Fri, 9 Sep 2011 03:27:13 +0000 (13:27 +1000)]
samba-tool: epilog option to OptionParser available in python >= 2.6

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Provide feedback if synopsis is not defined for a command
Amitay Isaacs [Fri, 9 Sep 2011 03:26:04 +0000 (13:26 +1000)]
samba-tool: Provide feedback if synopsis is not defined for a command

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: max() with key option is available in python >= 2.6
Amitay Isaacs [Fri, 9 Sep 2011 03:24:10 +0000 (13:24 +1000)]
samba-tool: max() with key option is available in python >= 2.6

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Correctly handle sys.exit() called from subcommand
Amitay Isaacs [Fri, 9 Sep 2011 03:22:27 +0000 (13:22 +1000)]
samba-tool: Correctly handle sys.exit() called from subcommand

Catch SystemExit exception if any subcommand calls sys.exit()
and return with failure (-1).

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "ldapcmp" command synopsis
Giampaolo Lauria [Fri, 2 Sep 2011 15:23:26 +0000 (11:23 -0400)]
samba-tool: Fixed "ldapcmp" command synopsis

Fixed "ldapcmp" command syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "dbcheck" subcommand syntax
Giampaolo Lauria [Tue, 30 Aug 2011 22:08:44 +0000 (18:08 -0400)]
samba-tool: Fixed "dbcheck" subcommand syntax

Fixed syntax for "dbcheck" subcommand

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Moved _get_user_realm_domain fcn to common
Giampaolo Lauria [Wed, 7 Sep 2011 15:11:38 +0000 (11:11 -0400)]
samba-tool: Moved _get_user_realm_domain fcn to common

_get_user_realm_domain is used by both delegation and spn commands

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "testparm" syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:41:41 +0000 (13:41 -0400)]
samba-tool: Fixed "testparm" syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "user" command syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:35:00 +0000 (13:35 -0400)]
samba-tool: Fixed "user" command syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "rodc" syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:25:30 +0000 (13:25 -0400)]
samba-tool: Fixed "rodc" syntax

Remove options from syntax to be consistent w/ the rest of commands

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "ntacl" subcommands syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:15:25 +0000 (13:15 -0400)]
samba-tool: Fixed "ntacl" subcommands syntax

Removed options from syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "group" subcommands syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:12:36 +0000 (13:12 -0400)]
samba-tool: Fixed "group" subcommands syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "dsacl" command syntax
Giampaolo Lauria [Tue, 6 Sep 2011 17:05:19 +0000 (13:05 -0400)]
samba-tool: Fixed "dsacl" command syntax

Removed option from syntax to be consistent w/ the rest of commands

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "drs" subcommands syntax
Giampaolo Lauria [Fri, 2 Sep 2011 17:56:51 +0000 (13:56 -0400)]
samba-tool: Fixed "drs" subcommands syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "domain" subcommands syntax
Giampaolo Lauria [Fri, 2 Sep 2011 17:21:49 +0000 (13:21 -0400)]
samba-tool: Fixed "domain" subcommands syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "spn" command syntax
Giampaolo Lauria [Fri, 2 Sep 2011 16:52:54 +0000 (12:52 -0400)]
samba-tool: Fixed "spn" command syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "delegation" command syntax
Giampaolo Lauria [Fri, 2 Sep 2011 17:10:05 +0000 (13:10 -0400)]
samba-tool: Fixed "delegation" command syntax

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Fixed "time" command synopsis
Giampaolo Lauria [Tue, 30 Aug 2011 21:52:59 +0000 (17:52 -0400)]
samba-tool: Fixed "time" command synopsis

"server_name" is an optional parameter
added "options" parameter

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Removed "acl" command
Giampaolo Lauria [Tue, 30 Aug 2011 21:22:06 +0000 (17:22 -0400)]
samba-tool: Removed "acl" command

Removed "acl" command as it has been changed to:
"dsacl" and "ntacl"

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Added "ntacl" command
Giampaolo Lauria [Tue, 30 Aug 2011 21:19:59 +0000 (17:19 -0400)]
samba-tool: Added "ntacl" command

Added "ntacl" command to substitute "acl nt" command

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Added "dsacl" command
Giampaolo Lauria [Tue, 30 Aug 2011 21:09:53 +0000 (17:09 -0400)]
samba-tool: Added "dsacl" command

Added "dsacl" command to substitute "acl ds"

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Changed fsmo implementation
Giampaolo Lauria [Tue, 2 Aug 2011 22:05:54 +0000 (18:05 -0400)]
samba-tool: Changed fsmo implementation

Changed fsmo code to fit the object <action> model

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Expanded acronym descriptions
Giampaolo Lauria [Tue, 2 Aug 2011 17:50:15 +0000 (13:50 -0400)]
samba-tool: Expanded acronym descriptions

Expanded command acronym descriptions
Added footnote for "server connection needed"

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Formatted subcommand list output
Giampaolo Lauria [Mon, 1 Aug 2011 21:47:31 +0000 (17:47 -0400)]
samba-tool: Formatted subcommand list output

Formatted output of subcommand list to be a function of the
max number of chars in the longest string

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Moved command definition to sambatool command
Giampaolo Lauria [Mon, 1 Aug 2011 18:45:18 +0000 (14:45 -0400)]
samba-tool: Moved command definition to sambatool command

Moved subcommand definition from __init__.py to cmd_sambatool class

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Add long_description and epilog to Command class
Giampaolo Lauria [Fri, 29 Jul 2011 21:04:45 +0000 (17:04 -0400)]
samba-tool: Add long_description and epilog to Command class

long_description and epilog should now be defined for each command.
Their string value will be printed whenever the user invokes the
command w/ the -h or --help
long_desciption will be printed after the usage statement.
epilog will be printed after the options are defined

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Redefined samba-tool as a SuperCommand
Giampaolo Lauria [Fri, 29 Jul 2011 01:44:06 +0000 (21:44 -0400)]
samba-tool: Redefined samba-tool as a SuperCommand

Removed MainCommand class as samba-tool is a SuperCommand
Redefined samba-tool as a SuperCommand
Fixed error handling in SuperCommand _run

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Removed SuperCommand usage method
Giampaolo Lauria [Fri, 29 Jul 2011 01:42:03 +0000 (21:42 -0400)]
samba-tool: Removed SuperCommand usage method

Removed usage method as it is not being used anywhere

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agosamba-tool: Removed attribute name from Command class
Giampaolo Lauria [Thu, 28 Jul 2011 18:21:40 +0000 (14:21 -0400)]
samba-tool: Removed attribute name from Command class

Removed name as it is not used anywhere
Moved all the attributes on top of the class declaration

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4-test: name attribute remove from Command class, so test not required
Amitay Isaacs [Fri, 9 Sep 2011 05:21:59 +0000 (15:21 +1000)]
s4-test: name attribute remove from Command class, so test not required

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3-spoolss: Fix bug #8351 forms migration.
Andreas Schneider [Tue, 6 Sep 2011 12:09:47 +0000 (14:09 +0200)]
s3-spoolss: Fix bug #8351 forms migration.

Don't fail if the form already exists (or is builtin now).

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep  9 03:21:42 CEST 2011 on sn-devel-104

7 years agos4-s3-upgrade do not convert min password length as a time
Andrew Bartlett [Thu, 8 Sep 2011 21:31:42 +0000 (07:31 +1000)]
s4-s3-upgrade do not convert min password length as a time

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Sep  9 01:53:55 CEST 2011 on sn-devel-104

7 years agoSecond part of fix for bug #8443 - Default user entry is set to minimal permissions...
Jeremy Allison [Thu, 8 Sep 2011 20:48:27 +0000 (13:48 -0700)]
Second part of fix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.

Be smarter about setting default permissions when a ACL_USER_OBJ isn't given. Use the principle of least surprises for the user.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep  9 00:26:08 CEST 2011 on sn-devel-104

7 years agoFirst part of fix for bug #8443 - Default user entry is set to minimal permissions...
Jeremy Allison [Thu, 8 Sep 2011 19:51:18 +0000 (12:51 -0700)]
First part of fix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.

create_default_mode() is not needed - it's taken care of by code
inside ensure_canon_entry_valid().

7 years agoFix bug #8203 - winbindd needs to reset the DC connection if an RPC times out.
Jeremy Allison [Fri, 3 Jun 2011 21:28:33 +0000 (14:28 -0700)]
Fix bug #8203 - winbindd needs to reset the DC connection if an RPC times out.

Based on Volker's original code.
(cherry picked from commit 5b5ef7f20d34f4c6c1d3d02530ac7b13e051c960)

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep  8 21:29:53 CEST 2011 on sn-devel-104

7 years agos3:torture: make use of CLI_FULL_CONNECTION_DONT_SPNEGO
Stefan Metzmacher [Thu, 8 Sep 2011 07:56:16 +0000 (09:56 +0200)]
s3:torture: make use of CLI_FULL_CONNECTION_DONT_SPNEGO

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep  8 19:23:32 CEST 2011 on sn-devel-104

7 years agos3:torture: make use of CLI_FULL_CONNECTION_FORCE_DOS_ERRORS
Stefan Metzmacher [Thu, 8 Sep 2011 07:24:11 +0000 (09:24 +0200)]
s3:torture: make use of CLI_FULL_CONNECTION_FORCE_DOS_ERRORS

metze

7 years agos3:libsmb: add CLI_FULL_CONNECTION_FORCE_ASCII
Stefan Metzmacher [Thu, 8 Sep 2011 07:49:26 +0000 (09:49 +0200)]
s3:libsmb: add CLI_FULL_CONNECTION_FORCE_ASCII

metze

7 years agos3:libsmb: add CLI_FULL_CONNECTION_FORCE_DOS_ERRORS
Stefan Metzmacher [Thu, 8 Sep 2011 07:18:45 +0000 (09:18 +0200)]
s3:libsmb: add CLI_FULL_CONNECTION_FORCE_DOS_ERRORS

metze

7 years agos3:libsmb: don't handle CLI_FULL_CONNECTION_* flags in cli_full_connection()
Stefan Metzmacher [Thu, 8 Sep 2011 15:26:30 +0000 (17:26 +0200)]
s3:libsmb: don't handle CLI_FULL_CONNECTION_* flags in cli_full_connection()

This is already done by cli_state_create().

metze

7 years agos3:libsmb: don't handle CLI_FULL_CONNECTION_* flags in cli_start_connection()
Stefan Metzmacher [Thu, 8 Sep 2011 15:26:30 +0000 (17:26 +0200)]
s3:libsmb: don't handle CLI_FULL_CONNECTION_* flags in cli_start_connection()

This is already done by cli_state_create().

metze

7 years agos4-param void function cannot return value
Andrew Bartlett [Thu, 8 Sep 2011 11:41:12 +0000 (21:41 +1000)]
s4-param void function cannot return value

This is even if the returned function is void, on Solaris.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Sep  8 16:38:30 CEST 2011 on sn-devel-104

7 years agos3-loadparm: fixed re-application of cmdline parametric options
Andrew Tridgell [Tue, 26 Jul 2011 02:21:00 +0000 (12:21 +1000)]
s3-loadparm: fixed re-application of cmdline parametric options

this ensures that cmdline parametric options are re-applied when we
reload smb.conf

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agos3-loadparm: fixed a memory leak in parametric options
Andrew Tridgell [Tue, 26 Jul 2011 02:19:58 +0000 (12:19 +1000)]
s3-loadparm: fixed a memory leak in parametric options

before we memset the Globals structure we need to free any global
parametrics

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agonsswitch: make the wbcSidsToUnixIds() parser more robust
Andrew Tridgell [Tue, 26 Jul 2011 01:01:36 +0000 (11:01 +1000)]
nsswitch: make the wbcSidsToUnixIds() parser more robust

this allows it to handle new types of responses

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agos4-winbindd: implement WINBINDD_SIDS_TO_XIDS
Andrew Tridgell [Tue, 26 Jul 2011 00:52:59 +0000 (10:52 +1000)]
s4-winbindd: implement WINBINDD_SIDS_TO_XIDS

this fixes wbinfo --sids-to-unix-ids

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agos4-winbindd: fixed handling of extra_data in s3 requests
Andrew Tridgell [Tue, 26 Jul 2011 00:51:31 +0000 (10:51 +1000)]
s4-winbindd: fixed handling of extra_data in s3 requests

extra_data in s3 winbind requests is appended to the end of the
request, but does not change the length header of the packet. Instead
you need to get it from the extra_len element of the request
structure.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agos4-winbind: added count argument to wb_sids2xids_recv()
Andrew Tridgell [Tue, 26 Jul 2011 00:50:22 +0000 (10:50 +1000)]
s4-winbind: added count argument to wb_sids2xids_recv()

this allows callers to know how many SIDs were mapped

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agos3: Fix a debug message
Volker Lendecke [Thu, 8 Sep 2011 11:15:21 +0000 (13:15 +0200)]
s3: Fix a debug message

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Sep  8 15:08:43 CEST 2011 on sn-devel-104

7 years agos3: Fix a typo
Volker Lendecke [Thu, 8 Sep 2011 10:01:42 +0000 (12:01 +0200)]
s3: Fix a typo

7 years agobuild: Add duplicate symbol checking as part of make test
Andrew Bartlett [Thu, 8 Sep 2011 09:07:47 +0000 (19:07 +1000)]
build: Add duplicate symbol checking as part of make test

This ensures we do not get duplicate symbols again, when run as
./configure.developer on non-build farm machines.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Sep  8 13:37:40 CEST 2011 on sn-devel-104

7 years agobuild: netapi does not depend on TOKEN_UTIL
Andrew Bartlett [Thu, 8 Sep 2011 07:14:44 +0000 (17:14 +1000)]
build: netapi does not depend on TOKEN_UTIL

This means we avoid dupliate symbols between libgpo and netapi.

Andrew Bartlett

7 years agobuild: make LIBWBCLIENT_OLD and auth_unix_token libraries
Andrew Bartlett [Thu, 8 Sep 2011 07:10:27 +0000 (17:10 +1000)]
build: make LIBWBCLIENT_OLD and auth_unix_token libraries

This assists with avoiding duplicate symbols.

Andrew Bartlett

7 years agolibrpc: put NDR_NTPRINTING into ndr-samba grouping library
Andrew Bartlett [Thu, 8 Sep 2011 07:09:47 +0000 (17:09 +1000)]
librpc: put NDR_NTPRINTING into ndr-samba grouping library

This assists with avoiding duplicate symobls now that ntprinting_migrate is a library.

Andrew Bartlett

7 years agolibgpo: call security_token_has_sid() directly
Andrew Bartlett [Thu, 8 Sep 2011 07:08:52 +0000 (17:08 +1000)]
libgpo: call security_token_has_sid() directly

7 years agos3:libsmb: pass CLI_FULL_CONNECTION_* flags via cli_connect_nb()
Stefan Metzmacher [Wed, 7 Sep 2011 18:35:51 +0000 (20:35 +0200)]
s3:libsmb: pass CLI_FULL_CONNECTION_* flags via cli_connect_nb()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep  8 10:21:50 CEST 2011 on sn-devel-104

7 years agos3:libsmb: pass CLI_FULL_CONNECTION_* flags to cli_state_create()
Stefan Metzmacher [Wed, 7 Sep 2011 19:10:24 +0000 (21:10 +0200)]
s3:libsmb: pass CLI_FULL_CONNECTION_* flags to cli_state_create()

metze

7 years agolib/replace: include <sys/uio.h> in "system/filesys.h" in order to have struct iovec
Stefan Metzmacher [Thu, 8 Sep 2011 06:01:30 +0000 (08:01 +0200)]
lib/replace: include <sys/uio.h> in "system/filesys.h" in order to have struct iovec

This is needed on some platforms, e.g. NetBSD5.

metze