abartlet/samba.git/.git
10 years agoRemove unused extended_dn_out_{dereference,ldb}.c files master
Andrew Bartlett [Tue, 16 Dec 2008 05:28:18 +0000 (16:28 +1100)]
Remove unused extended_dn_out_{dereference,ldb}.c files

10 years agoMerge branch 'master' of ssh://git.samba.org/data/git/abartlet/samba into extended...
Andrew Bartlett [Tue, 16 Dec 2008 00:19:13 +0000 (11:19 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/abartlet/samba into extended-dn-devel

10 years agoMerge more-commented version of rpc_server crash fix
Andrew Bartlett [Fri, 12 Dec 2008 10:40:51 +0000 (21:40 +1100)]
Merge more-commented version of rpc_server crash fix

Merge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn

Conflicts:

source4/rpc_server/dcerpc_server.c

10 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Fri, 12 Dec 2008 09:31:02 +0000 (10:31 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

10 years agoRemove EJS backend for PIDL, as we don't have EJS anymore.
Jelmer Vernooij [Fri, 12 Dec 2008 09:30:13 +0000 (10:30 +0100)]
Remove EJS backend for PIDL, as we don't have EJS anymore.

10 years agos4:fix segfault in rpc-server, when client binds to unsupported service.
Stefan Metzmacher [Fri, 12 Dec 2008 08:51:44 +0000 (09:51 +0100)]
s4:fix segfault in rpc-server, when client binds to unsupported service.

Signed-off-by: Michael Adam <obnox@samba.org>
10 years agoEnsure to normalise distinguishedName too
Andrew Bartlett [Fri, 12 Dec 2008 06:43:54 +0000 (17:43 +1100)]
Ensure to normalise distinguishedName too

10 years agoInitialise private->normalise in the extended_dn_out module
Andrew Bartlett [Fri, 12 Dec 2008 06:04:00 +0000 (17:04 +1100)]
Initialise private->normalise in the extended_dn_out module

Andrew Bartlett

10 years agoDon't segfault during RPC-COUNTCALLS
Andrew Bartlett [Fri, 12 Dec 2008 05:35:39 +0000 (16:35 +1100)]
Don't segfault during RPC-COUNTCALLS

The iface->bind() may well fail, and we can't dereference
call->context in this case, so fall back to the previous behaviour.

Andrew Bartlett

10 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn
Andrew Bartlett [Fri, 12 Dec 2008 04:24:20 +0000 (15:24 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn

10 years agoCorrectly parse the LDAP dereference control
Andrew Bartlett [Fri, 12 Dec 2008 04:00:48 +0000 (15:00 +1100)]
Correctly parse the LDAP dereference control

This is the final part needed for supporting extended DNs against OpenLDAP

Andrew Bartlett

10 years agoOpenLDAP backend: The 'deref' overlay works better as a global
Andrew Bartlett [Fri, 12 Dec 2008 03:47:24 +0000 (14:47 +1100)]
OpenLDAP backend: The 'deref' overlay works better as a global

10 years agoMerge the 'normalise' ldb module with extended_dn_out
Andrew Bartlett [Fri, 12 Dec 2008 03:45:03 +0000 (14:45 +1100)]
Merge the 'normalise' ldb module with extended_dn_out

This allows extended_dn_out to use the cheaper binary comparisons when
looping over the dereference control avoids a second module doing a
loop over all attributes and the matching schema lookup.

Andrew Bartlett

10 years agoAdd comment to extended_dn_store.c
Andrew Bartlett [Fri, 12 Dec 2008 03:42:36 +0000 (14:42 +1100)]
Add comment to extended_dn_store.c

10 years agoReturn per-entry controls in ldb_module_send_entry()
Andrew Bartlett [Fri, 12 Dec 2008 01:34:02 +0000 (12:34 +1100)]
Return per-entry controls in ldb_module_send_entry()

Returning a control on each result is how the OpenLDAP dereference
control operates.

Andrew Bartlett

10 years agos3: Use strtoul since id types are unsigned
Dan Sledz [Mon, 8 Dec 2008 22:52:14 +0000 (14:52 -0800)]
s3: Use strtoul since id types are unsigned

10 years agoInstall symlink for convenience for the samba4 setup directory.
Jelmer Vernooij [Thu, 11 Dec 2008 18:07:50 +0000 (19:07 +0100)]
Install symlink for convenience for the samba4 setup directory.

10 years agoAdd interactive flag to setup/provision (also the default when no arguments are given).
Jelmer Vernooij [Thu, 11 Dec 2008 17:51:28 +0000 (18:51 +0100)]
Add interactive flag to setup/provision (also the default when no arguments are given).

10 years agoBuild python modules by default in merged build (required for provision).
Jelmer Vernooij [Thu, 11 Dec 2008 17:20:18 +0000 (18:20 +0100)]
Build python modules by default in merged build (required for provision).

10 years agoSamba3-HOWTO: Fix usage of 'net idmap restore'.
Karolin Seeger [Thu, 11 Dec 2008 17:08:29 +0000 (18:08 +0100)]
Samba3-HOWTO: Fix usage of 'net idmap restore'.

This fixes bug #5883.

Karolin

10 years agos4:selftest: samba4 fails the changed delete test
Stefan Metzmacher [Thu, 11 Dec 2008 16:54:38 +0000 (17:54 +0100)]
s4:selftest: samba4 fails the changed delete test

metze

10 years agos4:libcli/resolve: add resolve_name_all*() which return all addresses not only the...
Stefan Metzmacher [Thu, 11 Dec 2008 14:43:47 +0000 (15:43 +0100)]
s4:libcli/resolve: add resolve_name_all*() which return all addresses not only the first one

metze

10 years agopackaging(RHEL-CTDB): don't show failure messages in check for ccache
Michael Adam [Mon, 1 Dec 2008 22:19:02 +0000 (23:19 +0100)]
packaging(RHEL-CTDB): don't show failure messages in check for ccache

by fixing the order of "> /dev/null 2>&1"

Michael
(cherry picked from commit 0e9d5638a7c375b3b18f19f83f97924ab45ad382)
(cherry picked from commit 6e51f250c5d38e973948aa1d53222bcccdcca365)

10 years agopackaging(RHEL-CTDB): fix the build when ccache is not found.
Michael Adam [Mon, 1 Dec 2008 22:03:38 +0000 (23:03 +0100)]
packaging(RHEL-CTDB): fix the build when ccache is not found.

Michael
(cherry picked from commit c98fb34ef933944a96a286d2d276cf2adc99e25e)
(cherry picked from commit 7d929d9fa363a1f1c67926678524f338e84b3535)

10 years agopackaging(RHEL-CTDB): use ccache if available
Michael Adam [Mon, 1 Dec 2008 02:07:19 +0000 (03:07 +0100)]
packaging(RHEL-CTDB): use ccache if available

Michael
(cherry picked from commit 36ca917a63f23126536e786bed845dee48fbf61c)
(cherry picked from commit 05b51bc176f87e7dc1b65adf3d866e797159d953)

10 years agopackaging(RHEL-CTDB): move the cifs.upcall manpage to the client package
Michael Adam [Tue, 11 Nov 2008 12:47:37 +0000 (13:47 +0100)]
packaging(RHEL-CTDB): move the cifs.upcall manpage to the client package

Michael
(cherry picked from commit 16f23eb27467ace9751ef2d1fbb6c4d3a5ae9550)
(cherry picked from commit 9538e3130f33ffde1d68eaea303b2b2dd9ddd71d)

10 years agopackaging(RHEL-CTDB): add the cifs.upcall binary to the client package.
Michael Adam [Tue, 11 Nov 2008 12:45:40 +0000 (13:45 +0100)]
packaging(RHEL-CTDB): add the cifs.upcall binary to the client package.

Michael
(cherry picked from commit 1875b373a319ac9494fdc907793e59804c577a4d)
(cherry picked from commit e1dca5f1870975b7d9a57869357c971d559afdfe)

10 years agopackaging(RHEL-CTDB): fix typo in makerpms.sh
Michael Adam [Mon, 15 Sep 2008 14:15:42 +0000 (16:15 +0200)]
packaging(RHEL-CTDB): fix typo in makerpms.sh

Michael
(cherry picked from commit 5fc5e82d4c2c386894fde95f94992171620c7853)
(cherry picked from commit 0e35ff0b46be2f9deab6e539c34970c85c3b58ce)

10 years agopackaging(RHEL-CTDB): refactor creation of spec file from template out
Michael Adam [Fri, 12 Sep 2008 13:50:33 +0000 (15:50 +0200)]
packaging(RHEL-CTDB): refactor creation of spec file from template out

into new script makespec.sh

Michael
(cherry picked from commit d49a9d1c67e4d98017ce5f7d1351bca1366e1a8d)
(cherry picked from commit 086873f00de96ca48717b05dddb71e776c74ca7d)

10 years agopackaging(RHEL-CTDB): fix installation of pam modules
Michael Adam [Wed, 10 Sep 2008 21:06:28 +0000 (23:06 +0200)]
packaging(RHEL-CTDB): fix installation of pam modules

use configure parameter to specify the pam modules dir.

Michael
(cherry picked from commit 24282daa5e293ef9362a69f7f70a684587d6763a)

10 years agos3-libnet: fix DEBUG statement in libnet_keytab.
Günther Deschner [Thu, 11 Dec 2008 10:25:45 +0000 (11:25 +0100)]
s3-libnet: fix DEBUG statement in libnet_keytab.

Guenther

10 years agoRemove unused variables
Andrew Bartlett [Thu, 11 Dec 2008 04:04:21 +0000 (15:04 +1100)]
Remove unused variables

10 years agoRename ldb_dn_extended_linearized to ldb_dn_get_extended_linearized
Andrew Bartlett [Thu, 11 Dec 2008 04:03:16 +0000 (15:03 +1100)]
Rename ldb_dn_extended_linearized to ldb_dn_get_extended_linearized

10 years agoDon't send the dereference OID unless client asked for extended DNs
Andrew Bartlett [Thu, 11 Dec 2008 01:46:39 +0000 (12:46 +1100)]
Don't send the dereference OID unless client asked for extended DNs

10 years agoUse the correct 'dereference' OID (temp OpenLDAP oid for now)
Andrew Bartlett [Thu, 11 Dec 2008 01:46:18 +0000 (12:46 +1100)]
Use the correct 'dereference' OID (temp OpenLDAP oid for now)

10 years agoStart using the new 'deref' overlay to get extended DNs from OpenLDAP
Andrew Bartlett [Thu, 11 Dec 2008 01:45:50 +0000 (12:45 +1100)]
Start using the new 'deref' overlay to get extended DNs from OpenLDAP

10 years agoMake the LookupRid access check match LookupName until
Jeremy Allison [Thu, 11 Dec 2008 01:03:53 +0000 (17:03 -0800)]
Make the LookupRid access check match LookupName until
we know the correct bits to use here.
Jeremy.

10 years agoFix usrmgr opening a user object as non-root.
Jeremy Allison [Wed, 10 Dec 2008 23:29:14 +0000 (15:29 -0800)]
Fix usrmgr opening a user object as non-root.
Jeremy.

10 years agoFix the build
Volker Lendecke [Wed, 10 Dec 2008 15:58:40 +0000 (16:58 +0100)]
Fix the build

Crap, too many trees and no instant, infinitely fast rebuild

Signed-off-by: Michael Adam <obnox@samba.org>
10 years agoAlso search for -lgpfs which is available as GPL in GPFS PTF8
Volker Lendecke [Wed, 10 Dec 2008 17:17:59 +0000 (18:17 +0100)]
Also search for -lgpfs which is available as GPL in GPFS PTF8
(cherry picked from commit 3c93c96fd0fe362c35fe8127058f94868abc9342)

Signed-off-by: Michael Adam <obnox@samba.org>
10 years agoMake use of smbd_gpfs_get_realfilename_path in unix_convert
Volker Lendecke [Wed, 10 Dec 2008 11:32:24 +0000 (12:32 +0100)]
Make use of smbd_gpfs_get_realfilename_path in unix_convert
(cherry picked from commit b37684ffcec4ba0beada55d37bcaf4f5e79bcd58)

Signed-off-by: Michael Adam <obnox@samba.org>
10 years agoFix nonempty blank lines in vfs_gpfs.c
Volker Lendecke [Wed, 10 Dec 2008 02:22:04 +0000 (03:22 +0100)]
Fix nonempty blank lines in vfs_gpfs.c

Signed-off-by: Michael Adam <obnox@samba.org>
10 years agos3:modules/gpfs: Fix nonempty blank lines
Volker Lendecke [Wed, 1 Oct 2008 10:26:55 +0000 (12:26 +0200)]
s3:modules/gpfs: Fix nonempty blank lines

10 years agopackaging(RHEL-CTDB): explicitly build the gpfs module
Michael Adam [Mon, 1 Dec 2008 02:05:40 +0000 (03:05 +0100)]
packaging(RHEL-CTDB): explicitly build the gpfs module

to prevent potetential problems on PTF8 systems where there
is no valid autodetecting configure check yet.

Michael
(cherry picked from commit 37039d345e9a25654bef038f2b8bb4b891cfa6f0)

Signed-off-by: Michael Adam <obnox@samba.org>
10 years agopackaging(RHEL-CTDB): adapt configure.rpm to changes to the spec file
Michael Adam [Thu, 18 Sep 2008 03:02:14 +0000 (05:02 +0200)]
packaging(RHEL-CTDB): adapt configure.rpm to changes to the spec file

Michael
(cherry picked from commit d249a9ca2a1761f20655cbcfe39fbc942547974d)

Signed-off-by: Michael Adam <obnox@samba.org>
10 years agoMove the doxygen comments of wbclient to the header file.
Andreas Schneider [Tue, 9 Dec 2008 12:18:06 +0000 (13:18 +0100)]
Move the doxygen comments of wbclient to the header file.

So that a developer who wants to use the wbclient api can read
the documentation in the header file.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Michael Adam <obnox@samba.org>
10 years agoRevert "Fix some merge omissions for GPFS"
Volker Lendecke [Wed, 10 Dec 2008 22:14:46 +0000 (23:14 +0100)]
Revert "Fix some merge omissions for GPFS"

This reverts commit a0efc4cffbd84898c454d27eaf946d073dfdad0f.

This one should have been done with careful cherry-picks, sorry.

Volker

10 years agoRevert "Fix nonempty blank lines in vfs_gpfs.c"
Volker Lendecke [Wed, 10 Dec 2008 22:14:16 +0000 (23:14 +0100)]
Revert "Fix nonempty blank lines in vfs_gpfs.c"

This reverts commit a4b52118d44906882677ed1234428d8025134036.

10 years agoRevert "Make use of smbd_gpfs_get_realfilename_path in unix_convert"
Volker Lendecke [Wed, 10 Dec 2008 22:14:01 +0000 (23:14 +0100)]
Revert "Make use of smbd_gpfs_get_realfilename_path in unix_convert"

This reverts commit b37684ffcec4ba0beada55d37bcaf4f5e79bcd58.

10 years agoRevert "Also search for -lgpfs which is available as GPL in GPFS PTF8"
Volker Lendecke [Wed, 10 Dec 2008 22:13:48 +0000 (23:13 +0100)]
Revert "Also search for -lgpfs which is available as GPL in GPFS PTF8"

This reverts commit 3c93c96fd0fe362c35fe8127058f94868abc9342.

10 years agoRevert "Fix the build"
Volker Lendecke [Wed, 10 Dec 2008 22:13:34 +0000 (23:13 +0100)]
Revert "Fix the build"

This reverts commit c044b09572631cbdd686e5dbbdfbcc731145533a.

10 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn
Andrew Bartlett [Wed, 10 Dec 2008 21:07:24 +0000 (08:07 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn

10 years agoFix the build
Volker Lendecke [Wed, 10 Dec 2008 15:58:40 +0000 (16:58 +0100)]
Fix the build

Crap, too many trees and no instant, infinitely fast rebuild

10 years agoAlso search for -lgpfs which is available as GPL in GPFS PTF8
Volker Lendecke [Wed, 10 Dec 2008 17:17:59 +0000 (18:17 +0100)]
Also search for -lgpfs which is available as GPL in GPFS PTF8

10 years agoMake use of smbd_gpfs_get_realfilename_path in unix_convert
Volker Lendecke [Wed, 10 Dec 2008 11:32:24 +0000 (12:32 +0100)]
Make use of smbd_gpfs_get_realfilename_path in unix_convert

10 years agoFix nonempty blank lines in vfs_gpfs.c
Volker Lendecke [Wed, 10 Dec 2008 02:22:04 +0000 (03:22 +0100)]
Fix nonempty blank lines in vfs_gpfs.c

10 years agoFix some merge omissions for GPFS
Volker Lendecke [Wed, 10 Dec 2008 17:10:03 +0000 (18:10 +0100)]
Fix some merge omissions for GPFS

10 years agoPass the get_real_filename operation through the VFS
Volker Lendecke [Wed, 10 Dec 2008 02:17:19 +0000 (03:17 +0100)]
Pass the get_real_filename operation through the VFS

This is done to help file systems that can tell us about the real upper/lower
case combination given a case-insensitive file name. The sample I will soon
push is the gpfs module (recent gpfs has a get_real_filename function), others
might have a similar function to help alleviate the 1million files in a single
directory problem.

Jeremy, please comment!

Thanks,

Volker

10 years agoChange get_real_filename() to unix syscall conventions, make it non-static
Volker Lendecke [Wed, 10 Dec 2008 02:03:51 +0000 (03:03 +0100)]
Change get_real_filename() to unix syscall conventions, make it non-static

It sets errno, so it might as well return 0/-1.

10 years agoApply some const
Volker Lendecke [Tue, 9 Dec 2008 12:50:22 +0000 (13:50 +0100)]
Apply some const

10 years agoRename "scan_directory" to "get_real_filename"
Volker Lendecke [Tue, 9 Dec 2008 12:40:41 +0000 (13:40 +0100)]
Rename "scan_directory" to "get_real_filename"

10 years agos4-smbtorture: skip ServerGetTrustInfo for samba4.
Günther Deschner [Wed, 10 Dec 2008 11:47:05 +0000 (12:47 +0100)]
s4-smbtorture: skip ServerGetTrustInfo for samba4.

Guenther

10 years agoMore tests in ldap.py
Andrew Bartlett [Wed, 10 Dec 2008 11:12:52 +0000 (22:12 +1100)]
More tests in ldap.py

Cleanup better before we run the tests again, and check for extended
DN behaviour in DN-syntax attributes (such as member)

Andrew Bartlett

10 years agos3-netlogon: fix netlogon server build.
Günther Deschner [Wed, 10 Dec 2008 01:54:06 +0000 (02:54 +0100)]
s3-netlogon: fix netlogon server build.

Guenther

10 years agos3-build: re-run make samba3-idl.
Günther Deschner [Wed, 10 Dec 2008 01:53:36 +0000 (02:53 +0100)]
s3-build: re-run make samba3-idl.

Guenther

10 years agos4-smbtorture: add simple netr_ServerGetTrustInfo test.
Günther Deschner [Wed, 10 Dec 2008 01:51:49 +0000 (02:51 +0100)]
s4-smbtorture: add simple netr_ServerGetTrustInfo test.

Guenther

10 years agos4-netlogon: fix the build of netlogon server.
Günther Deschner [Wed, 10 Dec 2008 01:51:16 +0000 (02:51 +0100)]
s4-netlogon: fix the build of netlogon server.

Guenther

10 years agonetlogon: fill in netr_ServerGetTrustInfo IDL.
Günther Deschner [Wed, 10 Dec 2008 01:50:46 +0000 (02:50 +0100)]
netlogon: fill in netr_ServerGetTrustInfo IDL.

Guenther

10 years agoAdd AD schema from Microsoft's WSPP documentation.
Andrew Bartlett [Wed, 10 Dec 2008 06:54:06 +0000 (17:54 +1100)]
Add AD schema from Microsoft's WSPP documentation.

This schema is *NOT* licenced under a standard Free Software licence,
but does provide us the freedoms we need to use the schema, and the
requirement to distribute as 'part of an implemenation' is similar to
common Free font licences that are accepted by major linux distributions.

Andrew Bartlett

10 years agonormalise returned attribute names against the LDAP backend
Andrew Bartlett [Wed, 10 Dec 2008 06:25:28 +0000 (17:25 +1100)]
normalise returned attribute names against the LDAP backend

AD returns normalised case always, while OpenLDAP returns (far more
sensibly) what is asked for.

This should not matter to a good client, but ldap.py found it, and
poor clients will no doubt be similarly untested.

Andrew Bartlett

10 years agoFix sequence number generation against OpenLDAP
Andrew Bartlett [Wed, 10 Dec 2008 06:23:44 +0000 (17:23 +1100)]
Fix sequence number generation against OpenLDAP

It seems that in 2deeb99fff1a90c79ba1927e1a069362e250a63c adding the
partition control to this request was missed out.

Andrew Bartlett

10 years agoextended_dn_out: use ldb_attr_cmp not strcasecmp() and handle '*' as an attr
Andrew Bartlett [Wed, 10 Dec 2008 04:30:44 +0000 (15:30 +1100)]
extended_dn_out: use ldb_attr_cmp not strcasecmp() and handle '*' as an attr

Also fix some indentation

10 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn
Andrew Bartlett [Wed, 10 Dec 2008 04:29:42 +0000 (15:29 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn

10 years agoTurn off over-verbose logging in OpenLDAP test backend
Andrew Bartlett [Wed, 10 Dec 2008 03:41:42 +0000 (14:41 +1100)]
Turn off over-verbose logging in OpenLDAP test backend

10 years agoencode_openldap_dereference: write out the linearised control
Andrew Bartlett [Wed, 10 Dec 2008 03:22:40 +0000 (14:22 +1100)]
encode_openldap_dereference:  write out the linearised control

10 years agoFix normalise module: Skip non-DN attributes
Andrew Bartlett [Wed, 10 Dec 2008 03:22:23 +0000 (14:22 +1100)]
Fix normalise module:  Skip non-DN attributes

Due to a bug/typo, we were instead skipping all DN attributes, and
blanking the rest.

Andrew Bartlett

Conflicts:

10 years agoBe more careful in extended_dn_out
Andrew Bartlett [Wed, 10 Dec 2008 03:20:20 +0000 (14:20 +1100)]
Be more careful in extended_dn_out

This fixes the module to operate correctly when the init function has
not yet been called (say for a search during the initilisation of
another module), and to fix memory allocation issues in
dereference_control->dereference.

Andrew Bartlett

10 years agos3: [3/3]: Fix a delete on close divergence from windows and the associated torture...
Tim Prouty [Sun, 7 Dec 2008 00:08:35 +0000 (16:08 -0800)]
s3: [3/3]: Fix a delete on close divergence from windows and the associated torture test

This third patch cleans up by removing all of the code that is made
obsolete by the first patch.  It should cause no functional changes.

10 years agos4: [2/3] Fix a delete on close divergence from windows and the associated torture...
Tim Prouty [Sun, 7 Dec 2008 18:34:37 +0000 (10:34 -0800)]
s4: [2/3] Fix a delete on close divergence from windows and the associated torture test

This second patch fixes the deltest17 BASE-DELETE torture test to pass
against win2k3/win2k8/winXPsp2

10 years agos3: [1/3] Fix a delete on close divergence from windows and the associated torture...
Tim Prouty [Sun, 7 Dec 2008 18:30:01 +0000 (10:30 -0800)]
s3: [1/3] Fix a delete on close divergence from windows and the associated torture test

smbtorture4's BASE-DELETE:deltest17 was failing against win2k8,
win2k3, and winXPsp2 but passing against samba.

deltest17 does the following:

1. open file -> file is created
2. closes file
3. open file with DOC -> fnum1
4. check that DOC is not reported as being set from fnum1
5. opens file again Read Only -> fnum2
6. check that DOC is not reported as being set from either file handle
7. close fnum1 (the file handle that requested DOC to be set)
8. check if DOC is reported as being set from fnum2
 * This is where windows and samba begin to diverge.  Windows
   reports that the DOC bit is set, while samba reports that it is not set.
9. close fnum2 (the last remaining open handle for the file)
10.See if the file has been deleted.
 * On samba the file still exists.  On windows the file was deleted.

The way open_file_ntcreate is written now, if an open has the DOC bit
set on the wire, DOC (fsp->initial_delete_on_close) is not set unless:
a. the open creates the file, or b. there is an open file handle with
a share_entry in the struct lck that has the
SHARE_MODE_ALLOW_INITIAL_DELETE_ON_CLOSE bit set (let's call it
SM_AIDOC).

My understanding of SM_AIDOC is that it was added to differentiate
between DOC being set on an open that creates a file vs an open that
opens an existing.  As described in step 8/10 above, it appears that
windows does not make this differentiation.

To resolve this issue there are three patches.  This first patch is a
simple proof of concept change that is sufficient to fix the bug.  It
removes the differentiation in open_file_ntcreate, and updates
deltest17 to allow it to pass against win2k3/xp.  This makes
open_file_ntcreate more closely match the semantics in open_directory
and rename_internals_fsp.  This change also does not break any other
tests in BASE-DELETE or "make test".  Specifically test deltest20b
which verifies the CIFSFS rename DOC semantics still passes :).

10 years agos4-samr: Fix Bug #5946. userparameters handling in torture test.
Matthias Dieter Wallnöfer [Tue, 9 Dec 2008 22:32:04 +0000 (23:32 +0100)]
s4-samr: Fix Bug #5946. userparameters handling in torture test.

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos4-samr: Fix Bug #5946. userparameters handling in samr server.
Matthias Dieter Wallnöfer [Tue, 9 Dec 2008 22:31:15 +0000 (23:31 +0100)]
s4-samr: Fix Bug #5946. userparameters handling in samr server.

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos3: Add the OneFS SMB_VFS_CREATE_FILE implementation
Tim Prouty [Tue, 9 Dec 2008 00:57:58 +0000 (16:57 -0800)]
s3: Add the OneFS SMB_VFS_CREATE_FILE implementation

This is the first pass at extending the onefs vfs module to support
the CIFS-specific enhancements available on OneFS.  Most of this patch
is massaging the sama open path to work with ifs_createfile.

ifs_createfile is a CIFS-specific syscall for opening/files and
directories.  It adds support for:
- Full in-kernel access checks using a windows access_mask
- Cluster-coherent share mode locks
- Cluster-coherent oplocks
- Streams
- Setting security descriptors at create time
- Setting dos_attributes at create time

This patch does not implement the samba side of the streams support or
oplocks support.  Tests that expect oplocks to be granted or streams
to be supported will fail.  This will be remedied in upcoming patches.

10 years agos3: Add onefs_open.c with code copied verbatim from smbd/open.c
Tim Prouty [Tue, 9 Dec 2008 00:42:45 +0000 (16:42 -0800)]
s3: Add onefs_open.c with code copied verbatim from smbd/open.c

This is an intermediate step that makes it much easier to see how the
OneFS SMB_VFS_CREATE_FILE implementation diverges from stock samba.
The goal is that more common code can be refactored into utility
functions.

10 years agos3: Call fd_close from close_directory
Tim Prouty [Thu, 27 Nov 2008 00:47:14 +0000 (16:47 -0800)]
s3: Call fd_close from close_directory

Some implementations of SMB_VFS_CREATE_FILE implementations actually
keep an fd open for directories just as files.  In this case it is
necessary to call fd_close when closing directories.  This is safe
because fd_close is a no-op when fd == -1, which is true for directory
opens originating from open.c (the default SMB_VFS_CREATE_FILE
implementation).

10 years agos3: Refactor calculating path from relative_fid into a separate function
Tim Prouty [Thu, 20 Nov 2008 05:26:42 +0000 (21:26 -0800)]
s3: Refactor calculating path from relative_fid into a separate function

10 years agos3: Refactor getting sec_info from a security_descriptor into separate function
Tim Prouty [Wed, 5 Nov 2008 02:08:03 +0000 (18:08 -0800)]
s3: Refactor getting sec_info from a security_descriptor into separate function

10 years agos3: Make a few open utility functions non-static
Tim Prouty [Thu, 30 Oct 2008 00:28:19 +0000 (17:28 -0700)]
s3: Make a few open utility functions non-static

This allows vfs modules that implement SMB_VFS_CREATE_FILE to access
some of the useful utility functions.

10 years agoClear up error strings in samldb.c
Andrew Bartlett [Tue, 9 Dec 2008 22:30:01 +0000 (09:30 +1100)]
Clear up error strings in samldb.c

Also use dom_sid_split_rid rather than a manual dup and num_auths--

10 years agoFix bug #5688 LPQ process is orphaned if socket address parameter is invalid
SATOH Fumiyasu [Tue, 9 Dec 2008 22:26:22 +0000 (14:26 -0800)]
Fix bug #5688 LPQ process is orphaned if socket address parameter is invalid

10 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn
Andrew Bartlett [Tue, 9 Dec 2008 20:36:19 +0000 (07:36 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into extended-dn

10 years agos3-ldapsam: Fix Bug 5957: do not abort rename process on valid rename script.
Günther Deschner [Tue, 9 Dec 2008 16:28:15 +0000 (17:28 +0100)]
s3-ldapsam: Fix Bug 5957: do not abort rename process on valid rename script.

Guenther
(cherry picked from commit 26139344fd0fac4fdd2a6752628b252fbd9b7450)
(cherry picked from commit 866efa63a26f75bbf17cd4bebf639594e2feafba)

10 years agos4:rpc_server: don't keep half finished dcesrv_connection_contexts
Stefan Metzmacher [Tue, 9 Dec 2008 15:16:31 +0000 (16:16 +0100)]
s4:rpc_server: don't keep half finished dcesrv_connection_contexts

metze

10 years agos3-libnet: fix build warning (missing prototype).
Günther Deschner [Tue, 9 Dec 2008 13:48:10 +0000 (14:48 +0100)]
s3-libnet: fix build warning (missing prototype).

Guenther

10 years agos4:rpc_server: initialize rpc server module also for the named pipe case
Stefan Metzmacher [Tue, 9 Dec 2008 08:22:31 +0000 (09:22 +0100)]
s4:rpc_server: initialize rpc server module also for the named pipe case

This fixes bug #5878.

metze

10 years agos3-samr: a level 18 password set needs to set the pwdlastset as well.
Günther Deschner [Tue, 9 Dec 2008 11:39:47 +0000 (12:39 +0100)]
s3-samr: a level 18 password set needs to set the pwdlastset as well.

Guenther

10 years agos3-srvsvc: fix build warning.
Günther Deschner [Tue, 9 Dec 2008 11:39:14 +0000 (12:39 +0100)]
s3-srvsvc: fix build warning.

Guenther

10 years agos3: Add support for access based share enumeration
Todd Stecher [Thu, 4 Dec 2008 19:33:32 +0000 (11:33 -0800)]
s3: Add support for access based share enumeration

10 years agoFix bug #5953 - smbclient crashes: cli_list_new segmentation fault.
Jeremy Allison [Mon, 8 Dec 2008 22:24:38 +0000 (14:24 -0800)]
Fix bug #5953 - smbclient crashes: cli_list_new segmentation fault.
Jeremy.

10 years agoAdd wb_trans_send/revc
Volker Lendecke [Mon, 1 Dec 2008 07:25:25 +0000 (08:25 +0100)]
Add wb_trans_send/revc