Michael Adam [Mon, 8 Mar 2010 22:37:21 +0000 (23:37 +0100)]
s3:release-scripts: fix create-tarball to treat vendor patch level correctly
Jeff Layton [Mon, 8 Mar 2010 20:05:05 +0000 (15:05 -0500)]
samba: remove Linux cifs-utils files from samba master branch
This patch removes all of the files from the samba tree that should now
be provided by the cifs-utils package. It also drops a
"README.cifs-utils" into the topdir with a URL to the main cifs-utils
webpage. This is for people who don't want the lists and might be taken
by surprise by the change. That's optional, but I think it's a good idea
for a least a release or two.
Signed-off-by: Jeff Layton <jlayton@samba.org>
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 19:36:16 +0000 (20:36 +0100)]
s4:"dns_update_list" file: install it properly into the private directory
This is what the "samba_dnsupdate" script requests (line 220).
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 19:30:06 +0000 (20:30 +0100)]
Revert "s4:script/installmisc.sh - install "dns_update_list" to target setup folder"
This reverts commit
b49276e291274652d46eed39249c07531e32b591.
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:asq module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:sort module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:rdn name module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:paged searches module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:paged results module - change counters to "unsigned" where appropriate
Björn Jacke [Mon, 8 Mar 2010 16:53:18 +0000 (17:53 +0100)]
s3: add missing Makefile.in changes for vfs_crossrename
Björn Jacke [Mon, 8 Mar 2010 11:38:38 +0000 (12:38 +0100)]
s3: add man page for vfs_crossrename
Björn Jacke [Mon, 8 Mar 2010 11:59:40 +0000 (12:59 +0100)]
s3: add vfs_crossrename
this module adds optional server-side support for limited rename operations
beyond filesystem boundaries, which was the previously the default.
Björn Jacke [Mon, 8 Mar 2010 11:52:13 +0000 (12:52 +0100)]
s3: remove cross-device rename support from vfs_default
cross-device rename support has some major limitations:
- on huge files clients will timeout or hang
- ACLs and EA information is not retained
Usually a client will have to handle this. A Windows Server with a reparse
point will also just return NT_STATUS_NOT_SAME_DEVICE. We will now by default
do the same.
I will add a vfs module which will restore the old cross-device renames.
Jeff Layton [Mon, 8 Mar 2010 14:06:40 +0000 (09:06 -0500)]
samba: remove cifs-utils tools from build systems
Now that cifs-utils are their own project, we need to go ahead and pull
them out of the samba tree. This patch represents the first step toward
that end.
Remove the cifs-utilities from the source3 and source4 builds. Please
pay particular attention to the source4 piece. I'm not at all familiar
with the build system there, and would appreciate someone sanity
checking my changes.
It also adds a small README.cifs-utils file in the topdir. This is
optional, but I think it's a good idea to carry this for a release or
two.
Once this patch looks ok, I'll plan to do another patch to actually
remove the client dir and the relevant docs-xml files from the tree
altogether.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:common - Change counters to "unsigned" where appropriate
To count LDB objects use variables of type "unsigned (int)" or "long long int"
on binary or downto searches.
To count characters in strings use "size_t".
To calculate differences between pointers use "ptrdiff_t".
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 10:43:40 +0000 (11:43 +0100)]
s4:LDB TDB index code - reintroduce accidentally removed code part
This was removed by
95d726f3018ef5d249f89d56bde24b7ee0c24ecf. Sorry.
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 08:58:28 +0000 (09:58 +0100)]
s4:ldb_ldap.c - fix indentation
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:TDB backend - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:SQLITE3 backend - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:LDAP backend - change a counter variable to "unsigned"
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:map - make LDB "signed-safe" on counter variables where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 07:02:32 +0000 (08:02 +0100)]
s4:ldif_handlers - Change "unsigned int" to "uint32_t" which fits better here
Andreas Schneider [Wed, 3 Mar 2010 14:15:03 +0000 (15:15 +0100)]
s4-gensec: Fixed wrong usage of error_string.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:03:21 +0000 (19:03 +0100)]
s4:extended_dn_out LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:02:47 +0000 (19:02 +0100)]
s4:repl_meta_data LDB module - change counter variables to "unsigned" where appropriate
I used "unsigned int" counters where we count LDB objects (LDB specification
prescribes to use "unsigned" index variables).
But on DSDB replication object counters I used "uint32_t" typed variables as it
is suggested.
If a counter variable counts both types of objects I used "unsigned int" since
size(unsigned int) >= size(uint32_t), but on most platforms equal.
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:04:11 +0000 (19:04 +0100)]
s4:local_password LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:18:39 +0000 (19:18 +0100)]
s4:ranged_results LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:18:02 +0000 (19:18 +0100)]
s4:objectguid LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:17:28 +0000 (19:17 +0100)]
s4:objectclass LDB module - change counter variabls to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:16:55 +0000 (19:16 +0100)]
s4:anr LDB module - change counter variable to "unsigned"
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:16:24 +0000 (19:16 +0100)]
s4:acl LDB module - change counter variable to "unsigned"
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:15:37 +0000 (19:15 +0100)]
s4:linked_attributes LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:14:16 +0000 (19:14 +0100)]
s4:kludge_acl LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:13:11 +0000 (19:13 +0100)]
s4:proxy LDB module - Change counter variables to "unsigned" where appropriate
Use "size_t" when counting string index positions.
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:12:30 +0000 (19:12 +0100)]
s4:schema_data LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:11:48 +0000 (19:11 +0100)]
s4:resolve_oids LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:11:03 +0000 (19:11 +0100)]
s4:rootdse LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:10:00 +0000 (19:10 +0100)]
s4:partition LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:schema - Change also here counters to "unsigned" where needed
Counters which are used in the way "for (i = 0; array[i] != NULL; i++)" I
modified to "unsigned" since for sure we don't want to have negative array
indexes there.
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:schema_syntax.c - Change also here counters to "unsigned" where needed
Counters which are used in the way "for (i = 0; array[i] != NULL; i++)" I
modified to "unsigned" since for sure we don't want to have negative array
indexes there.
There were many counter variables typed "uint32_t". This isn't fully correct
since those count LDB objects. The amount is saved in a "num_*" variable which
is "unsigned" without a bitlength specification. Therefore change also these
counters to be plain "unsigned".
Stefan Metzmacher [Fri, 5 Mar 2010 17:30:10 +0000 (18:30 +0100)]
s4:libcli/wrepl: rewrite the low level request handling to use tevent_queue and tstream_context
metze
Stefan Metzmacher [Sun, 7 Mar 2010 15:59:12 +0000 (16:59 +0100)]
s4:wrepl_out_helpers: add a WREPLSRV_PUSH_NOTIFY_STAGE_WAIT_UPDATE stage
This makes the logic more consistent.
metze
Stefan Metzmacher [Fri, 5 Mar 2010 15:03:23 +0000 (16:03 +0100)]
s4:libcli/wrepl: add wrepl_socket_is_connected()
metze
Stefan Metzmacher [Fri, 5 Mar 2010 14:49:27 +0000 (15:49 +0100)]
s4:libcli/wrepl: make struct wrepl_request private to winsrepl.c
metze
Stefan Metzmacher [Fri, 5 Mar 2010 14:22:10 +0000 (15:22 +0100)]
s4:libcli/wrepl: implement wrepl_request_send as a tevent_req based wrapper
metze
Stefan Metzmacher [Fri, 5 Mar 2010 14:03:29 +0000 (15:03 +0100)]
s4:libcli/wrepl: rename enum wrepl_request_state => enum wrepl_request_internal_state
metze
Stefan Metzmacher [Fri, 5 Mar 2010 13:44:23 +0000 (14:44 +0100)]
s4:libcli/wrepl: move wrepl_request_send/recv => wrepl_request_internal_send/recv
metze
Stefan Metzmacher [Fri, 5 Mar 2010 13:34:36 +0000 (14:34 +0100)]
s4:torture/nbt: use wrepl_associate_stop() instead of build the request by hand
metze
Stefan Metzmacher [Fri, 5 Mar 2010 13:29:36 +0000 (14:29 +0100)]
s4:torture/nbt: use wrepl_request() instead of wrepl_request_send() followed by wrepl_request_recv()
metze
Stefan Metzmacher [Fri, 5 Mar 2010 13:17:08 +0000 (14:17 +0100)]
s4:libcli/wrepl: add my copyright
metze
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:39:45 +0000 (19:39 +0100)]
s4:lib/registry/ldb.c - fix trailing whitespaces
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:36:01 +0000 (19:36 +0100)]
s4:registry library - fix up "reg_ldb_set_value"
The previous logic was wrong since it tried to add empty data in some cases
which always ended in an error. This problem should be fixed with the new logic.
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:20:48 +0000 (19:20 +0100)]
s4:registry library - make "reg_ldb_pack/unpack_value" more robust
This to prevent segmentation faults, wrong server inputs ecc.
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 17:51:41 +0000 (18:51 +0100)]
s4:provision.reg - call us Windows 2008 from the current version point of view
Matthias Dieter Wallnöfer [Sat, 7 Nov 2009 20:07:20 +0000 (21:07 +0100)]
s4:libregistry - change counters to be "unsigned"
Also the s4 registry library has to have "unsigned" counters like the Windows
one.
Volker Lendecke [Sat, 6 Mar 2010 11:57:35 +0000 (12:57 +0100)]
s3: Fix the build of net_afs.c with --fake-kaserver=yes, bug 7216
Thanks to Geza Gemes <geza@kzsdabas.hu> for filing this bug
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:tools - change counters to be unsigned
In most cases we do count LDB objects which are enumerated within the "unsigned"
type. Therefore no need to use "signed" counters.
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 10:19:04 +0000 (11:19 +0100)]
s4:lsa RPC - fix up "gendb_*" result codes
Make the resultcodes consistent: that means:
result < 0 -> NT_STATUS_INTERNAL_DB_CORRUPTION since our DB had a critical
error
result >= 0 -> depends on the function usage. I tried to let the logic always as
it was before.
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:26:02 +0000 (19:26 +0100)]
s4:lsa RPC - Change some counters to be "unsigned" where needed
The "count" size specifiers I typed "uint32_t" since they're often returned as
an "uint32_t" (consider the IDL file). LDB counters need to be "signed" if they
count till a limit of a "gendb*" call or "unsigned" if they count directly the
number of objects.
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:26:02 +0000 (19:26 +0100)]
s4:samr RPC - Change some counters to be "unsigned" where needed
The "count" size specifiers I typed "uint32_t" since they're often returned as
an "uint32_t" (consider the IDL file). LDB counters need to be "signed" if they
count till a limit of a "gendb*" call or "unsigned" if they count directly the
number of objects.
Jeremy Allison [Fri, 5 Mar 2010 23:10:30 +0000 (15:10 -0800)]
Fix for bug #7189 - Open txt files with notepad on samba shares creates problem.
Ensure we don't use any of the create_options for Samba private
use. Add a new parameter to the VFS_CREATE call (private_flags)
which is only used internally. Renumber NTCREATEX_OPTIONS_PRIVATE_DENY_DOS
and NTCREATEX_OPTIONS_PRIVATE_DENY_FCB to match the S4 code).
Rev. the VFS interface to version 28.
Jeremy.
Kamen Mazdrashki [Thu, 4 Mar 2010 16:00:15 +0000 (18:00 +0200)]
s4/tort: fix annoying "union spoolss_PrinterInfo" undefined warnings
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Fri, 5 Mar 2010 21:03:26 +0000 (22:03 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 5 Mar 2010 20:56:50 +0000 (21:56 +0100)]
winreg: fix winreg_QueryValue IDL.
Note that before this change pidl generated code that just dereferenced size_is
and length_is values from unique pointers without checking whether these
pointers were actually NULL.
With this change, pidl now throws a warning like:
warning: Got pointer for `data_size', expected fully derefenced variable
which is not correct, probably because pidl does not evaluate the C expression.
Guenther
Andreas Schneider [Fri, 5 Mar 2010 10:15:35 +0000 (11:15 +0100)]
s3-rpcclient: Leave setprinterdata directly if not enough args were passed.
If we don't pass enough arguments we don't have to close the connection.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 5 Mar 2010 14:54:31 +0000 (15:54 +0100)]
s3-rpc_server: Document rpc_pipe_open_internal.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Fri, 5 Mar 2010 19:32:16 +0000 (20:32 +0100)]
s4-smbtorture: fix RPC-SPOOLSS-WIN after PrinterData IDL changes.
Guenther
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 17:57:24 +0000 (18:57 +0100)]
s4:drsuapi RPC - Change also here counters to "unsigned"
No need to have "signed" counters at those places.
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:dsdb/util - Change also here counters to "unsigned"
No need to have "signed" counters at those places.
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:repl - change also here the counter variables to "unsigned"
I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.
Matthias Dieter Wallnöfer [Sat, 7 Nov 2009 20:15:17 +0000 (21:15 +0100)]
s4:wrepl_server - change also here the counter variables to "unsigned"
I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.
Volker Lendecke [Fri, 5 Mar 2010 16:06:08 +0000 (17:06 +0100)]
s3: Make "smbcontrol xx debuglevel" print the correct cluster pid
Günther Deschner [Fri, 5 Mar 2010 15:34:17 +0000 (16:34 +0100)]
s4-spoolss: fix dcesrv_spoolss_GetPrinterData build.
really not my day today...
Guenther
Günther Deschner [Fri, 5 Mar 2010 15:00:14 +0000 (16:00 +0100)]
s4-smbtorture: fix test_SetPrinterDataEx_matrix() call. sorry...
Guenther
Volker Lendecke [Fri, 5 Mar 2010 14:30:22 +0000 (15:30 +0100)]
s3: Remove the unused parameter "persistent" from fetch_locked_internal
Volker Lendecke [Fri, 5 Mar 2010 14:28:39 +0000 (15:28 +0100)]
s3: db->persistent==true was handled earlier, make this more obvious
Günther Deschner [Fri, 5 Mar 2010 13:42:10 +0000 (14:42 +0100)]
s4-smbtorture: when checking PrinterData matrix, include winreg cross reference checks.
Guenther
Günther Deschner [Fri, 5 Mar 2010 13:03:03 +0000 (14:03 +0100)]
s4-smbtorture: hand down printername to test_SetPrinterDataEx_matrix.
Guenther
Günther Deschner [Thu, 4 Mar 2010 23:56:52 +0000 (00:56 +0100)]
s4-smbtorture: add more paranoid checks for REG_DWORD SetPrinterDataEx tests.
Guenther
Günther Deschner [Thu, 4 Mar 2010 22:13:10 +0000 (23:13 +0100)]
s4-smbtorture: remove check for selfmade parsing artefact.
We were checking against a phenomenon that we created ourselves at the pidl
layer...
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:58:49 +0000 (17:58 +0100)]
s3-libads: fix get_remote_printer_publishing_data after spoolss_EnumPrinterDataEx IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:47:33 +0000 (16:47 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx after idl
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:47:10 +0000 (16:47 +0100)]
s3-rpcclient: fix rpcclient after spoolss_EnumPrinterDataEx IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:46:53 +0000 (16:46 +0100)]
s3-net: fix net after spoolss_EnumPrinterDataEx IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:04:19 +0000 (17:04 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:40:31 +0000 (16:40 +0100)]
spoolss: fix spoolss_EnumPrinterDataEx IDL.
Guenther
Günther Deschner [Thu, 4 Mar 2010 21:40:31 +0000 (22:40 +0100)]
s4-smbtorture: fix smbtorture after GetPrinterData{Ex} after IDL changes.
Guenther
Günther Deschner [Thu, 4 Mar 2010 17:21:50 +0000 (18:21 +0100)]
s4-spoolss: fix spoolss_GetPrinterData implementation after IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:46:28 +0000 (15:46 +0100)]
s3-rpcclient: fix rpcclient after spoolss_GetPrinterData{Ex} IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:39:59 +0000 (15:39 +0100)]
s3-spoolss: fix _spoolss_GetPrinterDataEx after IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:02:42 +0000 (17:02 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:38:18 +0000 (15:38 +0100)]
spoolss: rollback GetPrinterData[Ex] IDL.
Guenther
Günther Deschner [Thu, 4 Mar 2010 21:22:45 +0000 (22:22 +0100)]
s4-smbtorture: fix smbtorture after SetPrinterData{Ex} IDL changes.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:34:49 +0000 (15:34 +0100)]
s3-rpcclient: fix rpcclient after spoolss_SetPrinterData{Ex} IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:34:22 +0000 (15:34 +0100)]
s3-net: fix net after spoolss_SetPrinterData{Ex} IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:00:34 +0000 (17:00 +0100)]
s3-spoolss: fix _spoolss_SetPrinterData{Ex} after IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:00:09 +0000 (17:00 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 3 Mar 2010 17:22:57 +0000 (18:22 +0100)]
spoolss: rollback SetPrinterData{Ex} IDL.
Guenther
Matthias Dieter Wallnöfer [Fri, 5 Mar 2010 14:01:07 +0000 (15:01 +0100)]
s4:dcesrv_samr_AddAliasMember - wrap a long "DEBUG" statement
Stefan Metzmacher [Wed, 3 Mar 2010 17:35:55 +0000 (18:35 +0100)]
s4:libcli/wrepl: convert wrepl_associate_stop_send to tevent_req
metze