ab/samba.git/.git
7 years agoselftest.py: Add get_interface.
Jelmer Vernooij [Sun, 25 Mar 2012 20:38:59 +0000 (21:38 +0100)]
selftest.py: Add get_interface.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Mar 27 00:32:48 CEST 2012 on sn-devel-104

7 years agondr: Update ABI.
Jelmer Vernooij [Mon, 26 Mar 2012 16:25:37 +0000 (18:25 +0200)]
ndr: Update ABI.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Mar 26 19:58:25 CEST 2012 on sn-devel-104

7 years agowafsamba: Cope with slight differences in gdb output regarding incomplete sequences.
Jelmer Vernooij [Tue, 20 Mar 2012 01:31:02 +0000 (02:31 +0100)]
wafsamba: Cope with slight differences in gdb output regarding incomplete sequences.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=8820

7 years agoAdd ABI file for libndr.
Jelmer Vernooij [Sat, 24 Mar 2012 14:42:22 +0000 (15:42 +0100)]
Add ABI file for libndr.

7 years agos3: Pass filters explicitly through vfs notify watch
Volker Lendecke [Mon, 26 Mar 2012 10:46:11 +0000 (12:46 +0200)]
s3: Pass filters explicitly through vfs notify watch

This removes a dependency on "struct notify_entry" and makes the nature of the
API more explicit. We depend upon the VFS module to mask out elements from
e->filter and e->subdir_filter that it took over to handle.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Mar 26 17:45:44 CEST 2012 on sn-devel-104

7 years agos3: Fix a typo
Volker Lendecke [Mon, 26 Mar 2012 11:11:02 +0000 (13:11 +0200)]
s3: Fix a typo

7 years agos3: Rename a variable in inotify_watch for clarity
Volker Lendecke [Mon, 26 Mar 2012 11:09:33 +0000 (13:09 +0200)]
s3: Rename a variable in inotify_watch for clarity

7 years agos3: Pass "filter" instead of "notify_entry" to inotify_map
Volker Lendecke [Mon, 26 Mar 2012 11:00:53 +0000 (13:00 +0200)]
s3: Pass "filter" instead of "notify_entry" to inotify_map

This makes the potential modification a bit more obvious

7 years agos3-docs: Prepend '/' to filename argument (Bug #8826)
SATOH Fumiyasu [Mon, 26 Mar 2012 10:13:12 +0000 (19:13 +0900)]
s3-docs: Prepend '/' to filename argument (Bug #8826)

7 years agos4-dsdb: use constant-time search for descriptor -> get_last_structural_class()
Andrew Bartlett [Mon, 26 Mar 2012 01:06:39 +0000 (12:06 +1100)]
s4-dsdb: use constant-time search for descriptor -> get_last_structural_class()

The objectClass list is sorted at this point, as we are called below
the objectclass module here, or are working from a search result.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Mar 26 05:38:13 CEST 2012 on sn-devel-104

7 years agoFix the PyDoc comments in samba.smb.SMB and add a security_info argument to both...
Richard Sharpe [Mon, 26 Mar 2012 00:27:11 +0000 (17:27 -0700)]
Fix the PyDoc comments in samba.smb.SMB and add a security_info argument to both get_acl and set_acl to allow the caller to specify what info is wanted. Defaults to 0 which means all info.

Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Mon Mar 26 04:05:25 CEST 2012 on sn-devel-104

7 years agos4:ldap.py - re-introduce the "(dn=CN=ldaptestUSER3,CN=Users,DC=wallnoefer2,DC=local...
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 10:44:02 +0000 (12:44 +0200)]
s4:ldap.py - re-introduce the "(dn=CN=ldaptestUSER3,CN=Users,DC=wallnoefer2,DC=local)" test

This syntax is not supported by Windows AD and should also be denied by
s4/LDB.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Mar 26 02:30:53 CEST 2012 on sn-devel-104

7 years agoLDB/s4 - deny the "(dn=...)" syntax on search filters when in AD mode
Matthias Dieter Wallnöfer [Wed, 26 Oct 2011 07:47:35 +0000 (09:47 +0200)]
LDB/s4 - deny the "(dn=...)" syntax on search filters when in AD mode

Achieve this by introducing a "disallowDNFilter" flag.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agoLDB/s4 - do not use the "(dn=...)" syntax on filters anymore
Matthias Dieter Wallnöfer [Tue, 25 Oct 2011 18:10:30 +0000 (20:10 +0200)]
LDB/s4 - do not use the "(dn=...)" syntax on filters anymore

Make it AD-compatible using "(distinguishedName=...)".

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4:ldap.py - test the already mentioned structural object class sorting behaviour
Matthias Dieter Wallnöfer [Sun, 25 Mar 2012 21:35:23 +0000 (23:35 +0200)]
s4:ldap.py - test the already mentioned structural object class sorting behaviour

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4:dsdb - enhance "get_last_structural_class()" for optimisations
Matthias Dieter Wallnöfer [Sun, 25 Mar 2012 21:25:01 +0000 (23:25 +0200)]
s4:dsdb - enhance "get_last_structural_class()" for optimisations

If the objectclass entry has been sorted before we are able to determine
the (last) structural or 88 object class in constant time.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4:objectclass LDB module - fix up the sorting in respect to structural or 88 objectc...
Matthias Dieter Wallnöfer [Sun, 25 Mar 2012 20:51:51 +0000 (22:51 +0200)]
s4:objectclass LDB module - fix up the sorting in respect to structural or 88 objectclasses

Please have a look at MS-ADTS 3.1.1.1.4.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos4:objectclass LDB module - clean up "objectclass_sort()"
Matthias Dieter Wallnöfer [Sun, 25 Mar 2012 19:33:52 +0000 (21:33 +0200)]
s4:objectclass LDB module - clean up "objectclass_sort()"

Make it easier to comprehend

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agos3-make: Fix build with new smb2_session file.
Jelmer Vernooij [Sun, 25 Mar 2012 21:18:52 +0000 (23:18 +0200)]
s3-make: Fix build with new smb2_session file.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Mar 26 00:56:13 CEST 2012 on sn-devel-104

7 years agoLIBCLI_SMB2: Depend on cli_smb_common rather than libsmb.
Jelmer Vernooij [Sun, 25 Mar 2012 15:15:42 +0000 (17:15 +0200)]
LIBCLI_SMB2: Depend on cli_smb_common rather than libsmb.

The latter pulls in a fair number of other libraries, including popt and the Samba registry library.

7 years agosmb2: Move smb2cli session setup code to cli_smb_common.
Jelmer Vernooij [Sun, 25 Mar 2012 15:14:56 +0000 (17:14 +0200)]
smb2: Move smb2cli session setup code to cli_smb_common.

7 years agolibcli/smb: Stop generating unused proto file.
Jelmer Vernooij [Sun, 25 Mar 2012 15:14:14 +0000 (17:14 +0200)]
libcli/smb: Stop generating unused proto file.

7 years agoreplace: Avoid DEBUG(), which is not available in libreplace.
Jelmer Vernooij [Sat, 24 Mar 2012 20:18:55 +0000 (21:18 +0100)]
replace: Avoid DEBUG(), which is not available in libreplace.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Mar 25 00:13:59 CET 2012 on sn-devel-104

7 years agolibreplace: Add usleep implementation.
Jelmer Vernooij [Sat, 24 Mar 2012 20:17:56 +0000 (21:17 +0100)]
libreplace: Add usleep implementation.

7 years agouse usleep rather than sys_usleep in various places, in anticipation of usleep moving...
Jelmer Vernooij [Sat, 24 Mar 2012 19:43:07 +0000 (20:43 +0100)]
use usleep rather than sys_usleep in various places, in anticipation of usleep moving to libreplace.

7 years agolib/util: Remove obsolete sys_getpid() and sys_fork().
Jelmer Vernooij [Sat, 24 Mar 2012 19:17:08 +0000 (20:17 +0100)]
lib/util: Remove obsolete sys_getpid() and sys_fork().

The performance of these is minimal (these days) and they can return
invalid results when used as part of applications that do not use
sys_fork().

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 24 21:55:41 CET 2012 on sn-devel-104

7 years agolib/util: Allow calloc use in util.c, too.
Jelmer Vernooij [Sat, 24 Mar 2012 16:16:26 +0000 (17:16 +0100)]
lib/util: Allow calloc use in util.c, too.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 24 18:50:32 CET 2012 on sn-devel-104

7 years agoadt_tree: Fix return types.
Jelmer Vernooij [Sat, 24 Mar 2012 16:11:11 +0000 (17:11 +0100)]
adt_tree: Fix return types.

7 years agoreplace: Work around socket wrapper.
Jelmer Vernooij [Sat, 24 Mar 2012 16:05:29 +0000 (17:05 +0100)]
replace: Work around socket wrapper.

It's fine to ignore socket wrapper here, as it doesn't deal with unix domain sockets.

7 years agoreplace: Add system/network.h for ucred struct.
Jelmer Vernooij [Sat, 24 Mar 2012 15:50:37 +0000 (16:50 +0100)]
replace: Add system/network.h for ucred struct.

7 years agos3-waf: Use samba3-util library instead of lots of tiny libs.
Jelmer Vernooij [Sat, 24 Mar 2012 15:42:47 +0000 (16:42 +0100)]
s3-waf: Use samba3-util library instead of lots of tiny libs.

The smaller libraries are currently all trivial in size and don't have
any dependencies other than samba-util.

Having lots of small private libraries is a pain for packaging,
and there isn't much advantage in this.

7 years agoadt_tree: Avoid WERROR.
Jelmer Vernooij [Sat, 24 Mar 2012 15:41:35 +0000 (16:41 +0100)]
adt_tree: Avoid WERROR.

7 years agolibreplace: Add getpeereid implementation.
Jelmer Vernooij [Sat, 24 Mar 2012 15:00:36 +0000 (16:00 +0100)]
libreplace: Add getpeereid implementation.

7 years agoutil_malloc: Remove unused constant.
Jelmer Vernooij [Sat, 24 Mar 2012 14:44:33 +0000 (15:44 +0100)]
util_malloc: Remove unused constant.

7 years agolib/util: Remove dummy wrapper for getgrgid().
Jelmer Vernooij [Sat, 24 Mar 2012 14:26:36 +0000 (15:26 +0100)]
lib/util: Remove dummy wrapper for getgrgid().

7 years agolib/util: Remove dummy wrapper for getgrnam().
Jelmer Vernooij [Sat, 24 Mar 2012 14:25:48 +0000 (15:25 +0100)]
lib/util: Remove dummy wrapper for getgrnam().

7 years agolib/util: Remove dummy wrapper for getpwuid().
Jelmer Vernooij [Sat, 24 Mar 2012 14:25:05 +0000 (15:25 +0100)]
lib/util: Remove dummy wrapper for getpwuid().

7 years agolib/util: Remove dummy wrapper for getpwnam().
Jelmer Vernooij [Sat, 24 Mar 2012 14:24:15 +0000 (15:24 +0100)]
lib/util: Remove dummy wrapper for getpwnam().

7 years agolib/util: Remove dummy wrappers for setpwent/getpwent/endpwent.
Jelmer Vernooij [Sat, 24 Mar 2012 14:23:02 +0000 (15:23 +0100)]
lib/util: Remove dummy wrappers for setpwent/getpwent/endpwent.

7 years agolib/util: Move calloc_array and memalign_array to top-level libutil.
Jelmer Vernooij [Sat, 24 Mar 2012 14:19:09 +0000 (15:19 +0100)]
lib/util: Move calloc_array and memalign_array to top-level libutil.

7 years agolib/util: Remove prototype for removed sys_memalign.
Jelmer Vernooij [Sat, 24 Mar 2012 14:00:22 +0000 (15:00 +0100)]
lib/util: Remove prototype for removed sys_memalign.

7 years agolib/util: Remove trivial wrapper sys_connect() around connect().
Jelmer Vernooij [Sat, 24 Mar 2012 13:58:09 +0000 (14:58 +0100)]
lib/util: Remove trivial wrapper sys_connect() around connect().

7 years agocli_pipe: Avoid sys_connect.
Jelmer Vernooij [Sat, 24 Mar 2012 13:57:47 +0000 (14:57 +0100)]
cli_pipe: Avoid sys_connect.

7 years agosock_exec: Avoid sys_connect.
Jelmer Vernooij [Sat, 24 Mar 2012 13:57:33 +0000 (14:57 +0100)]
sock_exec: Avoid sys_connect.

7 years agoutil_sock: Avoid sys_connect.
Jelmer Vernooij [Sat, 24 Mar 2012 13:51:23 +0000 (14:51 +0100)]
util_sock: Avoid sys_connect.

7 years agoctdb_conn: Avoid sys_connect.
Jelmer Vernooij [Sat, 24 Mar 2012 13:48:56 +0000 (14:48 +0100)]
ctdb_conn: Avoid sys_connect.

7 years agoreplace: Move memalign() from lib/util/system.c to libreplace.
Jelmer Vernooij [Sat, 24 Mar 2012 13:43:21 +0000 (14:43 +0100)]
replace: Move memalign() from lib/util/system.c to libreplace.

7 years agoImprove the Makefile. Use a standard make macro, not a shell command.
Richard Sharpe [Sat, 24 Mar 2012 04:27:41 +0000 (21:27 -0700)]
Improve the Makefile. Use a standard make macro, not a shell command.

Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Sat Mar 24 07:09:44 CET 2012 on sn-devel-104

7 years agoselftest.py: Add cleanup_pid.
Jelmer Vernooij [Fri, 23 Mar 2012 23:40:49 +0000 (00:40 +0100)]
selftest.py: Add cleanup_pid.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 24 04:52:59 CET 2012 on sn-devel-104

7 years agoselftest.py: Add write_krb5_conf.
Jelmer Vernooij [Fri, 23 Mar 2012 22:46:34 +0000 (23:46 +0100)]
selftest.py: Add write_krb5_conf.

7 years agoselftest.py: Add mk_realms_stanza function.
Jelmer Vernooij [Fri, 23 Mar 2012 22:46:19 +0000 (23:46 +0100)]
selftest.py: Add mk_realms_stanza function.

7 years agoselftest.py: Add selftest.target.samba with bindir_path function.
Jelmer Vernooij [Fri, 23 Mar 2012 22:46:02 +0000 (23:46 +0100)]
selftest.py: Add selftest.target.samba with bindir_path function.

7 years agoMake it possible for developers of out-of-tree modules to use the same names as in...
Richard Sharpe [Fri, 23 Mar 2012 14:39:45 +0000 (07:39 -0700)]
Make it possible for developers of out-of-tree modules to use the same names as in-tree modules.

Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Sat Mar 24 03:18:38 CET 2012 on sn-devel-104

7 years agolib/async_req: Retry read_packet with read(2)
Volker Lendecke [Fri, 23 Mar 2012 14:56:43 +0000 (15:56 +0100)]
lib/async_req: Retry read_packet with read(2)

This way it will also work with pipes

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Mar 23 17:31:24 CET 2012 on sn-devel-104

7 years agos3: Remove the sys_notify dependency from notify_internal
Volker Lendecke [Thu, 22 Mar 2012 13:58:24 +0000 (14:58 +0100)]
s3: Remove the sys_notify dependency from notify_internal

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Mar 23 12:12:51 CET 2012 on sn-devel-104

7 years agos3-build: gss_krb5_export_lucid_sec_context is no longer used in the s3 build
Andrew Bartlett [Thu, 22 Mar 2012 23:32:47 +0000 (10:32 +1100)]
s3-build: gss_krb5_export_lucid_sec_context is no longer used in the s3 build

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Mar 23 04:37:36 CET 2012 on sn-devel-104

7 years agowintest: test demote of DC
Andrew Bartlett [Thu, 22 Mar 2012 22:40:39 +0000 (09:40 +1100)]
wintest: test demote of DC

7 years agolib/tdb: fix transaction issue for HAVE_INCOHERENT_MMAP.
Rusty Russell [Fri, 23 Mar 2012 00:15:18 +0000 (10:45 +1030)]
lib/tdb: fix transaction issue for HAVE_INCOHERENT_MMAP.

We unmap the tdb on expand, the remap.  But when we have INCOHERENT_MMAP
(ie. OpenBSD) and we're inside a transaction, doing the expand can mean
we need to read from the database to partially fill a transaction block.
This fails, because if mmap is incoherent we never allow accessing the
database via read/write.

The solution is not to unmap and remap until we've actually written the
padding at the end of the file.

Reported-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Fri Mar 23 02:53:15 CET 2012 on sn-devel-104

7 years agolib/tdb: fix test/run-die-during-transaction when HAVE_INCOHERENT_MMAP.
Rusty Russell [Fri, 23 Mar 2012 00:13:48 +0000 (10:43 +1030)]
lib/tdb: fix test/run-die-during-transaction when HAVE_INCOHERENT_MMAP.

Since we force mmap on, we don't intercept writes to the db, so we never
see it in an inconsistent state.  #ifdef over the check that we should have
recovered it at least once.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolib/tdb: fix missing return 0 code.
Rusty Russell [Fri, 23 Mar 2012 00:11:55 +0000 (10:41 +1030)]
lib/tdb: fix missing return 0 code.

fde694274e1e5a11d1473695e7ec7a97f95d39e4 made tdb_mmap return an int,
but didn't put the return 0 on the "internal db" case.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agos3:vfs_gpfs: fix some compiler warnings
Christian Ambach [Thu, 22 Mar 2012 17:12:07 +0000 (18:12 +0100)]
s3:vfs_gpfs: fix some compiler warnings

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Mar 22 20:14:34 CET 2012 on sn-devel-104

7 years agos3:vfs_gpfs: remove fallback to linux_setlease
Christian Ambach [Thu, 22 Mar 2012 17:11:47 +0000 (18:11 +0100)]
s3:vfs_gpfs: remove fallback to linux_setlease

if setting the lease in GPFS failed, there is not much sense in trying
to set a lease just locally that would not inform us of openers
on other cluster nodes

7 years agos3:vfs_gpfs: correct use of profiling macros
Christian Ambach [Thu, 22 Mar 2012 17:00:17 +0000 (18:00 +0100)]
s3:vfs_gpfs: correct use of profiling macros

under certain conditions START_PROFILE could have been called, but no END_PROFILE

7 years agos3:vfs_gpfs: Implement fallocate callback for GPFS
Christof Schmitt [Thu, 8 Mar 2012 21:57:12 +0000 (13:57 -0800)]
s3:vfs_gpfs: Implement fallocate callback for GPFS

GPFS provides the gpfs_prealloc call. Implement the fallocate
callback with mode VFS_FALLOCATE_EXTEND_SIZE using this call.
There is no support for VFS_FALLOCATE_KEEP_SIZE, so report
this mode as not available.

7 years agos3:vfs_gpfs: Report disk space and usage on GPFS share according to quotas
Christof Schmitt [Fri, 2 Mar 2012 21:26:24 +0000 (14:26 -0700)]
s3:vfs_gpfs: Report disk space and usage on GPFS share according to quotas

When a client requests the information about free space and space used,
adjust the reported values according to quotas in the GPFS file system:

- Retrieve quotas for the current user, current group and fileset for
  the top level of the share.
- If the soft block quota grace time has expired, report disk as full.
- If a hard block quota has been exceeded, report disk as full.
- If none of the hard block quotas been exceeded, report
  share size and free space according to the lowest limits found in
  the quotas.
- If no applicable hard block quota has been set, report the
  information from the statfs call.

This feature is disabled by default and has to be enabled by setting the
option gpfs:dfreequota.

7 years agos3:vfs_gpfs: add GPFS api calls for quota and free space reporting
Christof Schmitt [Fri, 2 Mar 2012 21:26:19 +0000 (14:26 -0700)]
s3:vfs_gpfs: add GPFS api calls for quota and free space reporting

Add the GPFS api calls for reporting the quotas and free space:
- get_gpfs_quota for querying a quota
- get_gpfs_fset_id for mapping a path to a fileset id

7 years agos3:vfs_gpfs: Export disk_norm function
Christof Schmitt [Fri, 2 Mar 2012 21:26:10 +0000 (14:26 -0700)]
s3:vfs_gpfs: Export disk_norm function

vfs modules implementing the disk_free callback need access
to the function disk_norm for normalizing the data if the parameter
small query is true.

7 years agos3:client correct a wording
Christian Ambach [Thu, 22 Mar 2012 15:49:30 +0000 (16:49 +0100)]
s3:client correct a wording

7 years agos3: Fix smbd -i
Volker Lendecke [Thu, 22 Mar 2012 13:23:11 +0000 (14:23 +0100)]
s3: Fix smbd -i

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Mar 22 18:40:02 CET 2012 on sn-devel-104

7 years agos3: Remove an unused structure field
Volker Lendecke [Thu, 22 Mar 2012 13:18:13 +0000 (14:18 +0100)]
s3: Remove an unused structure field

7 years agos3: Add "notify" cmd to smbclient
Volker Lendecke [Thu, 22 Mar 2012 11:17:26 +0000 (12:17 +0100)]
s3: Add "notify" cmd to smbclient

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Mar 22 13:51:50 CET 2012 on sn-devel-104

7 years agos3: Add sync cli_notify
Volker Lendecke [Thu, 22 Mar 2012 11:17:14 +0000 (12:17 +0100)]
s3: Add sync cli_notify

7 years agos3: Add FILE_NOTIFY_CHANGE_ALL #define
Volker Lendecke [Thu, 22 Mar 2012 11:16:52 +0000 (12:16 +0100)]
s3: Add FILE_NOTIFY_CHANGE_ALL #define

7 years agos3-libsmb: Fix parsing a notify response
Volker Lendecke [Thu, 22 Mar 2012 11:16:17 +0000 (12:16 +0100)]
s3-libsmb: Fix parsing a notify response

7 years agos3: rename "len"->"next", according to wireshark
Volker Lendecke [Thu, 22 Mar 2012 11:09:05 +0000 (12:09 +0100)]
s3: rename "len"->"next", according to wireshark

7 years agolib/tdb2: fix -Wcast-qual warnings.
Rusty Russell [Thu, 22 Mar 2012 00:17:27 +0000 (10:47 +1030)]
lib/tdb2: fix -Wcast-qual warnings.

We use tdb_mkdata() to get rid of many of them from the tests, and
explicit cast_const() in a few places.

tlist_for_each() still causes a warning, but that needs to be fixed in
CCAN.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Thu Mar 22 03:29:32 CET 2012 on sn-devel-104

7 years agolib/tdb2: fix -Wshadow warnings.
Rusty Russell [Thu, 22 Mar 2012 00:17:27 +0000 (10:47 +1030)]
lib/tdb2: fix -Wshadow warnings.

These warnings clutter things up, even though they're of marginal
utility.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolib/tdb2: fix OpenBSD incoherent mmap (tdb2 version)
Rusty Russell [Thu, 22 Mar 2012 00:17:27 +0000 (10:47 +1030)]
lib/tdb2: fix OpenBSD incoherent mmap (tdb2 version)

This handles incoherent mmaps for TDB2 native databases, by forcing
mmap on for such systems, just like we did for tdb1.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolib/tdb2: fix OpenBSD incoherent mmap (tdb1 version)
Rusty Russell [Thu, 22 Mar 2012 00:17:26 +0000 (10:47 +1030)]
lib/tdb2: fix OpenBSD incoherent mmap (tdb1 version)

This is a direct port of the previous patch, to the TDB2 codebase.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolib/tdb: fix OpenBSD incoherent mmap.
Rusty Russell [Thu, 22 Mar 2012 00:17:26 +0000 (10:47 +1030)]
lib/tdb: fix OpenBSD incoherent mmap.

This comment appears in two places in the code (commit
4c6a8273c6dd3e2aeda5a63c4a62aa55bc133099 from 2001):

/*
 * We must ensure the file is unmapped before doing this
 * to ensure consistency with systems like OpenBSD where
 * writes and mmaps are not consistent.
 */

But this doesn't help, because if one process is using mmap and another
using pwrite, we get incoherent results.  As demonstrated by OpenBSD's
failure on the tdb unit tests.

Rather than disable mmap on OpenBSD, we test for this issue and force mmap
to be enabled.  This means that we will fail on very large TDBs on 32-bit
systems, but it's better than the horrendous performance penalty on every
OpenBSD system.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolib/replace: test for incoherent mmap.
Rusty Russell [Thu, 22 Mar 2012 00:17:24 +0000 (10:47 +1030)]
lib/replace: test for incoherent mmap.

We test for other mmap features here, and both tdb1 and tdb2 want this check.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolib/ccan/failtest: compile fix for OpenBSD
Rusty Russell [Wed, 21 Mar 2012 00:50:06 +0000 (11:20 +1030)]
lib/ccan/failtest: compile fix for OpenBSD

OpenBSD doesn't idempotent-wrap sys/mman.h, so when we #define mmap to
an alternative, it fails to compile when sys/mman.h is included again.

Workaround is not to #define mmap to add arguments on Open BSD.

(Imported from CCAN commit e18e80fe175422d26efe689addc0f67bdba0e097)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolib/ccan: namespacize ccan/list to avoid conflict with OpenIndiana's sys/list.h
Rusty Russell [Tue, 20 Mar 2012 14:28:14 +0000 (00:58 +1030)]
lib/ccan: namespacize ccan/list to avoid conflict with OpenIndiana's sys/list.h

CCAN includes a little utility called "namespacize" which prepends ccan_ to
all public methods of a module, and fixes up any dependencies it finds.  It's
a little primitive, but it works here.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolib/tdb: fix up run-die-during-transaction test cases on Solaris.
Rusty Russell [Tue, 20 Mar 2012 14:27:14 +0000 (00:57 +1030)]
lib/tdb: fix up run-die-during-transaction test cases on Solaris.

By using a different include order, we end up with a different version of
FILE_OFFSET_BITS (and probably other things) in parts of the test.  The
different variants get linked together, and the result is weird: the stat
returns 0 size.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agodocs:man:vfs_gpfs: fix formatting of values for gpfs:syncio
Michael Adam [Wed, 21 Mar 2012 23:03:08 +0000 (00:03 +0100)]
docs:man:vfs_gpfs: fix formatting of values for gpfs:syncio

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Mar 22 01:56:08 CET 2012 on sn-devel-104

7 years agodocs:man:vfs_gpfs: Fix documented values for gpfs:hsm
Michael Adam [Wed, 21 Mar 2012 23:01:24 +0000 (00:01 +0100)]
docs:man:vfs_gpfs: Fix documented values for gpfs:hsm

7 years agos3:vfs_tsmsm: Fix a misspelling of a config parameter in the doc-comment
Michael Adam [Wed, 21 Mar 2012 22:40:44 +0000 (23:40 +0100)]
s3:vfs_tsmsm: Fix a misspelling of a config parameter in the doc-comment

The module uses "tsmsm:dmapi attribute" instead of "tsmsm:attribute name".

7 years agos3-selftest: Remove some unnecessary comma
Björn Baumbach [Wed, 9 Nov 2011 12:19:59 +0000 (13:19 +0100)]
s3-selftest: Remove some unnecessary comma

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3-selftest: Add samba3.blackbox.net.registry.check to test list
Björn Baumbach [Wed, 9 Nov 2011 12:19:22 +0000 (13:19 +0100)]
s3-selftest: Add samba3.blackbox.net.registry.check to test list

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3-selftest: introduce new net registry check check
Björn Baumbach [Wed, 9 Nov 2011 12:24:42 +0000 (13:24 +0100)]
s3-selftest: introduce new net registry check check

Add a new check which checks for defects in the net registry
check tool.

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agoFix bug 8823 - source3/smbd/process.c:smb_dump seems to have a memory leak.
Jeremy Allison [Wed, 21 Mar 2012 21:34:34 +0000 (14:34 -0700)]
Fix bug 8823 - source3/smbd/process.c:smb_dump seems to have a memory leak.

Based on code from Richard Sharpe. Move to talloc from malloc.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 22 00:20:41 CET 2012 on sn-devel-104

7 years agos4-samba-tool: add password verification in change user pass
Björn Baumbach [Mon, 19 Mar 2012 13:48:43 +0000 (14:48 +0100)]
s4-samba-tool: add password verification in change user pass

Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Mar 21 17:43:35 CET 2012 on sn-devel-104

7 years agos4-samba-tool: add password verification in add user
Björn Baumbach [Thu, 8 Mar 2012 14:40:58 +0000 (15:40 +0100)]
s4-samba-tool: add password verification in add user

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos4-provision: don't ask only 3 times for passwd in interactive mode
Björn Baumbach [Tue, 20 Mar 2012 10:10:44 +0000 (11:10 +0100)]
s4-provision: don't ask only 3 times for passwd in interactive mode

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos4-provision: add password verification in interactive mode
Björn Baumbach [Thu, 8 Mar 2012 14:27:05 +0000 (15:27 +0100)]
s4-provision: add password verification in interactive mode

Since we do not print the password out (anymore), it is necessary to
verify the entered password.

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3: Move the notify_ctx to the smbd_server_connection
Volker Lendecke [Wed, 21 Mar 2012 11:18:09 +0000 (12:18 +0100)]
s3: Move the notify_ctx to the smbd_server_connection

We only need one notify_ctx per smbd. The notify_array can become quite large.
It's based on absolute paths, so there's no point in having a copy of the
complete array in memory multiple times.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Mar 21 14:26:07 CET 2012 on sn-devel-104

7 years agos3: Remove "conn" param from notify_init()
Volker Lendecke [Wed, 21 Mar 2012 10:59:27 +0000 (11:59 +0100)]
s3: Remove "conn" param from notify_init()

7 years agos3: Remove "conn" param from sys_notify_context_create
Volker Lendecke [Wed, 21 Mar 2012 10:55:55 +0000 (11:55 +0100)]
s3: Remove "conn" param from sys_notify_context_create

7 years agos3: Remove "conn" from sys_notify_context
Volker Lendecke [Wed, 21 Mar 2012 10:52:27 +0000 (11:52 +0100)]
s3: Remove "conn" from sys_notify_context

7 years agos3: Pass "conn" to sys_notify_watch()
Volker Lendecke [Wed, 21 Mar 2012 10:47:50 +0000 (11:47 +0100)]
s3: Pass "conn" to sys_notify_watch()