From e872227bfbf63742b549a32eb98487bf61403532 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 18 Mar 2019 09:41:57 +0100 Subject: [PATCH] libsmb: Fix a "assuming signed overflow does not occur" error Eventually we need to convert internal_resolve_name to "size_t" for "return_count". But that's a patch for another day :-) Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider --- source3/libsmb/namequery.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c index dc563da9798..f61e2507cce 100644 --- a/source3/libsmb/namequery.c +++ b/source3/libsmb/namequery.c @@ -3041,8 +3041,8 @@ static NTSTATUS get_dc_list(const char *domain, char *port_str = NULL; int port; char *name; - int num_addresses = 0; - int local_count, i, j; + size_t num_addresses = 0; + size_t local_count, i; struct ip_service *return_iplist = NULL; struct ip_service *auto_ip_list = NULL; bool done_auto_lookup = false; @@ -3171,6 +3171,7 @@ static NTSTATUS get_dc_list(const char *domain, /* copy any addresses from the auto lookup */ if (strequal(name, "*")) { + int j; for (j=0; j= 4 ) { - DEBUG(4,("get_dc_list: returning %d ip addresses " + DEBUG(4,("get_dc_list: returning %zu ip addresses " "in an %sordered list\n", local_count, *ordered ? "":"un")); -- 2.34.1