From d5408193953c1b185e5e74a7e39bb40d0f6ff093 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Thu, 26 Mar 2020 15:32:36 -0700 Subject: [PATCH] s3: smbd: Inside rename_internals() wildcard case, re-purpose dst_original_lcomp. Pass to rename_internals_fsp() instead of using smb_fname_dst->original_lcomp. Removes one more use of the struct member original_lcomp. Signed-off-by: Jeremy Allison Reviewed-by: Ralph Boehme --- source3/smbd/reply.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index 369398116a4..826387b9914 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -8228,9 +8228,8 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx, break; } - smb_fname_dst->original_lcomp = talloc_strdup(smb_fname_dst, - dname); - if (!smb_fname_dst->original_lcomp) { + dst_original_lcomp = talloc_strdup(smb_fname_dst, dname); + if (dst_original_lcomp == NULL) { status = NT_STATUS_NO_MEMORY; goto out; } @@ -8238,7 +8237,7 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx, status = rename_internals_fsp(conn, fsp, smb_fname_dst, - smb_fname_dst->original_lcomp, + dst_original_lcomp, attrs, replace_if_exists); -- 2.34.1