From bb51c050149c2e2ea5bf81f283da862fc1e840d2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?G=C3=BCnther=20Deschner?= Date: Wed, 19 Jan 2011 00:15:09 +0100 Subject: [PATCH] s4-smbtorture: add some paranoia checks for 0 sized devmodes. Guenther --- source4/torture/rpc/spoolss.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/source4/torture/rpc/spoolss.c b/source4/torture/rpc/spoolss.c index 2dd7164338e..3536b82b50e 100644 --- a/source4/torture/rpc/spoolss.c +++ b/source4/torture/rpc/spoolss.c @@ -2239,10 +2239,20 @@ static bool test_PrinterInfo_DevModes(struct torture_context *tctx, devmode = info.info8.devmode; + if (devmode && devmode->size == 0) { + torture_fail(tctx, + "devmode of zero size!"); + } + torture_assert(tctx, test_GetPrinter_level(tctx, b, handle, 2, &info), ""); devmode2 = info.info2.devmode; + if (devmode2 && devmode2->size == 0) { + torture_fail(tctx, + "devmode of zero size!"); + } + torture_assert(tctx, test_devicemode_equal(tctx, devmode, devmode2), "DM level 8 != DM level 2"); @@ -2384,6 +2394,11 @@ static bool test_PrinterInfo_DevMode(struct torture_context *tctx, devmode = info.info8.devmode; + if (devmode && devmode->size == 0) { + torture_fail(tctx, + "devmode of zero size!"); + } + if (addprinter_devmode) { if (!test_devicemode_equal(tctx, devmode, addprinter_devmode)) { torture_warning(tctx, "current global DM is != DM provided in addprinter"); -- 2.34.1