From a646d9e796902dcb5246eb585433d4859796be2f Mon Sep 17 00:00:00 2001 From: Uri Simchoni Date: Sun, 3 Jul 2016 22:51:56 +0300 Subject: [PATCH] s3-libads: fix a memory leak in ads_sasl_spnego_bind() BUG: https://bugzilla.samba.org/show_bug.cgi?id=12006 Signed-off-by: Uri Simchoni Signed-off-by: Richard Sharpe Signed-off-by: Andreas Schneider --- source3/libads/sasl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/source3/libads/sasl.c b/source3/libads/sasl.c index 10f63e89181..d76d8724ac0 100644 --- a/source3/libads/sasl.c +++ b/source3/libads/sasl.c @@ -696,7 +696,7 @@ static ADS_STATUS ads_sasl_spnego_bind(ADS_STRUCT *ads) struct berval *scred=NULL; int rc, i; ADS_STATUS status; - DATA_BLOB blob; + DATA_BLOB blob = data_blob_null; char *given_principal = NULL; char *OIDs[ASN1_MAX_OIDS]; #ifdef HAVE_KRB5 @@ -792,6 +792,9 @@ static ADS_STATUS ads_sasl_spnego_bind(ADS_STRUCT *ads) done: ads_free_service_principal(&p); TALLOC_FREE(frame); + if (blob.data != NULL) { + data_blob_free(&blob); + } return status; } -- 2.34.1