From 30c56a0c801dfb64085013a87ddedb1cd76b42a9 Mon Sep 17 00:00:00 2001 From: Martin Schwenke Date: Mon, 23 Mar 2015 19:37:35 +1100 Subject: [PATCH] ctdb-scripts: Optimise update_tickles() Use addtickle and deltickle with stdin. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs --- ctdb/config/functions | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/ctdb/config/functions b/ctdb/config/functions index a29daf58f6e..d5443f5767a 100755 --- a/ctdb/config/functions +++ b/ctdb/config/functions @@ -1276,16 +1276,12 @@ update_tickles () sort >"$_my_tickles" # Add tickles for connections that we haven't already got tickles for - comm -23 "$_my_connections" "$_my_tickles" | - while read _src _dst ; do - $CTDB addtickle "$_src" "$_dst" - done + comm -23 "$_my_connections" "$_my_tickles" | \ + $CTDB addtickle # Remove tickles for connections that are no longer there - comm -13 "$_my_connections" "$_my_tickles" | - while read _src _dst ; do - $CTDB deltickle "$_src" "$_dst" - done + comm -13 "$_my_connections" "$_my_tickles" | \ + $CTDB deltickle rm -f "$_my_connections" "$_my_tickles" -- 2.34.1