From 746b299ec1b11ea1e70c130b69a9a379ec478750 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 14 Mar 2011 18:35:36 +0100 Subject: [PATCH] s3: Fix the talloc hierarchy in shadow_copy2_connectpath We have to return on talloc_tos() because we don't have a mem_ctx given to us. So we have to create a separate temporary talloc context. Autobuild-User: Volker Lendecke Autobuild-Date: Mon Mar 14 19:21:11 CET 2011 on sn-devel-104 --- source3/modules/vfs_shadow_copy2.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/source3/modules/vfs_shadow_copy2.c b/source3/modules/vfs_shadow_copy2.c index 93330f4b508..e3c3f9f3a06 100644 --- a/source3/modules/vfs_shadow_copy2.c +++ b/source3/modules/vfs_shadow_copy2.c @@ -684,7 +684,7 @@ static char *shadow_copy2_realpath(vfs_handle_struct *handle, static const char *shadow_copy2_connectpath(struct vfs_handle_struct *handle, const char *fname) { - TALLOC_CTX *tmp_ctx = talloc_stackframe(); + TALLOC_CTX *tmp_ctx; const char *snapdir, *baseoffset, *basedir, *gmt_start; size_t baselen; char *ret; @@ -695,7 +695,14 @@ static const char *shadow_copy2_connectpath(struct vfs_handle_struct *handle, return handle->conn->connectpath; } - fname = shadow_copy2_normalise_path(talloc_tos(), fname, gmt_start); + /* + * We have to create a real temporary context because we have + * to put our result on talloc_tos(). Thus we can't use a + * talloc_stackframe() here. + */ + tmp_ctx = talloc_new(talloc_tos()); + + fname = shadow_copy2_normalise_path(tmp_ctx, fname, gmt_start); if (fname == NULL) { TALLOC_FREE(tmp_ctx); return NULL; -- 2.34.1