vfs_fruit: lp_case_sensitive() does not return a bool
authorRalph Boehme <slow@samba.org>
Wed, 19 Apr 2017 11:12:55 +0000 (13:12 +0200)
committerJeremy Allison <jra@samba.org>
Sat, 22 Apr 2017 03:20:20 +0000 (05:20 +0200)
commit36612723b2b18675116b6197183bdfe5e1d9e06f
treeca4a554db450d745017cc2714a63aca7360bba7a
parent52349a7e69a933cbfe410241c7ad80d012886e02
vfs_fruit: lp_case_sensitive() does not return a bool

lp_case_sensitive() returns an int, not a bool, so with the default
setting of "Auto" by default we set the AAPL flag
SMB2_CRTCTX_AAPL_CASE_SENSITIVE.

This caused the client to believe the volume is case sensitive where it
wasn't, leading to an error when trying to rename files changing only
the case of the name.

Also fix the existing torture test that verifies AAPL context
negotiation and actually expected the server to return "case sensitive",
while the Samba default is really "case insensitive".

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12749

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/modules/vfs_fruit.c
source4/torture/vfs/fruit.c