David Dykstra [Fri, 12 Mar 1999 18:21:53 +0000 (18:21 +0000)]
Include a test for a working getopt_long because the one on some versions
of cygwin doesn't work. Thanks to Martin Krumpolec <krumpo@pobox.sk> for
the patch. At the same time, include cache checks in configure.in for a few
items that were missing the checks.
David Dykstra [Fri, 12 Mar 1999 17:36:52 +0000 (17:36 +0000)]
When -R is used, send the permissions of the original top directories to
the receiver even when not combined with -r. Without this, the directories
were getting created mode 777 because the default umask on receivers is
often 00.
David Dykstra [Thu, 11 Mar 1999 22:17:42 +0000 (22:17 +0000)]
When a file cannot be deleted because of ETXTBSY (in particular, when an
executable is busy on HPUX), rename it instead to .rsyncNNN. Most of
the code was submitted by Ketil Kristiansen <ketil-k@osc.no>
David Dykstra [Tue, 9 Mar 1999 21:55:16 +0000 (21:55 +0000)]
Check for EINVAL from a rename error call in addition to ENOENT because
David Campbell <david@pastornet.net.au> reported that that helps data
be received onto a windows box running cygwin b19.
David Dykstra [Fri, 5 Mar 1999 16:37:44 +0000 (16:37 +0000)]
Update config.guess from a new official GNU version.
I believe this is the latest, which comes with automake 1.4 (somebody
else is in charge of installing the GNU stuff on my system so I'm not
100% sure it's the absolute latest, but it was updated just a couple
weeks ago).
David Dykstra [Thu, 4 Mar 1999 21:48:52 +0000 (21:48 +0000)]
The change a couple days ago to create files initially without group and
other access resulted in group and other access being left off when the
'-p' option was not used. This fixes it by reintroducing the ACCESSPERMS
mask and setting permissions to (file->mode & ACCESSPERMS) if preserve_perms
is off. I decided to change the mask INITPERMMASK to INITACCESSPERMS at
the same time. When preserve_perms is off, rsync is restored to the
previous behavior of having the permissions of the original file with the
umask and setuid/setgid bits shut off.
Also, I decided that a check for "(updated && (file->mode & ~ACCESSPERMS))"
is no longer needed since as far as I can tell that would have only affected
permissions when not running as root and when a chgrp was done to a group
the user was not a member of, using system V chgrp semantics. This is no
longer allowed.
David Dykstra [Tue, 2 Mar 1999 20:56:17 +0000 (20:56 +0000)]
Disable the optimization that treats include-only files as a special case
whenever delete_mode is on. People reported problems when it kicked in
while using --delete and while using --delete-excluded.
David Dykstra [Tue, 2 Mar 1999 16:42:46 +0000 (16:42 +0000)]
Change getgroups to use GETGROUPS_T as the type of the group array returned,
as calculated by the configure macro AC_TYPE_GETGROUPS. Without that, it
doesn't work properly on systems like sunos 4 where gid_t is defined to
be an unsigned short but getgroups is defined to return an array of integers.
David Dykstra [Mon, 1 Mar 1999 21:22:54 +0000 (21:22 +0000)]
Change the mask used when creating temporary files from 777 to 700, to prevent
an obscure race-condition security hole where a file may for a short time
have the wrong group. Could have used 707 instead but that's just too weird
of a permission. The define name used to be ACCESSPERMS but that is defined
as 777 on Linux, so changed the name to INITPERMMASK.
David Dykstra [Mon, 1 Mar 1999 21:16:49 +0000 (21:16 +0000)]
When comparing -1 to a group id, cast -1 with gid_t because on some systems
such as sunos4 gid_t is an unsigned short. This prevented the just-added
non-mapped group test from working on sunos4.
David Dykstra [Mon, 1 Mar 1999 19:24:39 +0000 (19:24 +0000)]
Prevent the -g option from preserving groups that a non-root receiver
does not belong to, in these two ways:
1. If a group mapping doesn't exist for a group name, do not preserve
it for a non-root receiver. This is especially evident with the
sender is a daemon using chroot because then no mappings are
available.
2. Before setting the group on a file make sure that it is in the list
of groups returned by getgroups(). The same thing is done by chgrp
on systems that support bsd-style chown/chgrp, and this enforces
that it happens the same way on all systems. Overhead is very
little, especially since most systems don't allow more then 16
groups per user.
David Dykstra [Thu, 25 Feb 1999 17:58:31 +0000 (17:58 +0000)]
Removed am_client variable. It was being set in one place, when a client
of a socket (that is, a --daemon) server, but never looked at. The way to
test whether or not on a client is (!am_server).
David Dykstra [Thu, 18 Feb 1999 17:23:44 +0000 (17:23 +0000)]
Changed --stats implementation to work without -v in only these two
situations:
1. the client is the receiver of files. Can't do it otherwise yet
because without -v the bytes written from the sender's generator
process will not be counted.
2. both the remote and local protocol versions are >=20. I did not
change the protocol version yet because it is such a minor change
that it isn't worth it, although I did test it with the protocol
version set to 20.
If neither of the situations hold, it prints a message saying to use -v.
David Dykstra [Thu, 18 Feb 1999 16:27:36 +0000 (16:27 +0000)]
Changed exclude/include matching so that normally wildcards will stop at
slashes. The old behavior of crossing slashes can be achieved by using a
double-asterisk ('**') anywhere in a pattern. Note that this can change
some existing exclude patterns in a subtle way. Also note that if the
remote side is an older release the processing on the two sides might not
be exactly the same when there's no double-asterisk, which can affect which
files are excluded from deletion, but they're close enough that people will
probably not notice. I considered changing the protocol version and
checking the remote_version number to ensure the same processing on both
sides, but the exclude patterns are pre-processed before the remote version
number is known and it's just not worth going through extraordinary efforts.
Suggested by Cameron Simpson <cs@zip.com.au>
David Dykstra [Wed, 17 Feb 1999 19:34:40 +0000 (19:34 +0000)]
Added --copy-unsafe-links option which is like --copy-links except it is
only for symlinks that point outside the source tree. Suggested by Charles
Hines <chuck_hines@VNET.IBM.COM> in PR#1376. Also apply the option to any
symbolic links in the source portion of a path when --relative is used,
as suggested by Francis Montagnac <Francis.Montagnac@sophia.inria.fr> on
the rsync mailing list in a message titled "New option: --copy-parent-links".
David Dykstra [Fri, 12 Feb 1999 17:27:22 +0000 (17:27 +0000)]
Change the implementation of memmove in lib/compat.c to call bcopy instead
of memcpy because bcopy is guaranteed to work with overlapping memory and
memcpy is not. Bug fix for PR#1584 in which log entries in the rsync
daemon log on Sunos 4.1.4 were garbled.
David Dykstra [Wed, 10 Feb 1999 22:16:32 +0000 (22:16 +0000)]
A slight compensation I had just added for total bytes read when using -v
was incorrect. It's hard to tell how many bytes are actually read because
transferring the value changes it and depending on its value it may
transfer 4 or 12 bytes so instead change the sender side to not include the
length of the counters it sends at all (it had been including one but three
are sent).
David Dykstra [Wed, 10 Feb 1999 19:33:05 +0000 (19:33 +0000)]
Changed Usage in the rsync --help message to indicate how there can be
multiple SRCs. Also moved the --suffix option to show up right after
--backup and included the default backup suffix and block size along with
their corresponding options rather than at the end. Copied the new help
message to rsync.yo and README and used the Usage also in the SYNOPSIS
section at the top of rsync.yo rather than the different one that used
"path" instead of SRC and DEST. That last change was inspired by a
suggestion from Michael Bleyer in PR #1523.
David Dykstra [Wed, 10 Feb 1999 18:44:25 +0000 (18:44 +0000)]
Changed error message that just said "open %s: %s" to "cannot create %s: %s"
in receiver.c because it confuses people when they do something like
rsync /etc/passwd /tmp/nonexistentdir/passwd
and it printed out something like
open /tmp/noniexistentdir/.passwd.a004d5 : No such file or directory
Reported by kurt_granroth@pobox.com in PR #1253.
David Dykstra [Wed, 10 Feb 1999 18:03:59 +0000 (18:03 +0000)]
Changed the optimized include mode (which kicks in when there are a series
of non-wildcard includes followed by an exclude of *) so that it will silently
ignore included files that don't exist rather than saying "No such file or
directory". This is more like the behavior of the non-optimized include mode.
David Dykstra [Tue, 9 Feb 1999 22:31:52 +0000 (22:31 +0000)]
Support '#' and ';' comments in exclude files. It would actually not
probably cause any harm if they were treated as normal exclude or include
patterns because they just wouldn't match anything, but it's better to
explicitly ignore them. Suggested by David Holland <uholld1@lexis-nexis.com>
David Dykstra [Tue, 9 Feb 1999 19:27:15 +0000 (19:27 +0000)]
Added "strict modes" option. When set false (default is true), it allows
the secrets file to be readable by other users. Added to support the Windows
port under cygwin. Problem reported by Martin Krumpolec krumpo@pobox.sk
David Dykstra [Tue, 9 Feb 1999 18:35:29 +0000 (18:35 +0000)]
Use MAXHOSTNAMELEN (256) for the array holding the host_name in socket.c
instead of 200. Move the defines of True and False to rsync.h. Eliminate
the defines of BOOL in loadparm.c and params.c because it is already
defined in rsync.h. Changes suggested by Roman Gollent roman.gollent@wdr.com
David Dykstra [Wed, 3 Feb 1999 15:38:06 +0000 (15:38 +0000)]
Move the initialization of push_dir, which calls getcwd, to early in main.
The reason for that is that on SVR2-based UTS 2.1.2 (which along with many
other old systems implements getcwd by forking "pwd") getcwd hangs when
called when other child processes are running.
I also added a quick return from push_dir if name == NULL so it doesn't
actually have to chdir anywhere when just initializing.
An initializing call to push_dir("/",0) had previously been put in at the
beginning of daemon_main() to avoid calling getcwd after a chroot, but
since that is no longer I needed I removed it and changed the call to
chdir("/") after chroot into a push_dir("/",0) so it will remember the
correct current directory.
David Dykstra [Wed, 3 Feb 1999 15:15:56 +0000 (15:15 +0000)]
When calling lchown, pass the current known uid and gid rather than -1
to not change it, since the old SVR2-based UTS 2.1.2 does not support
leaving uid and gid alone when the value is -1.
David Dykstra [Wed, 3 Feb 1999 15:11:40 +0000 (15:11 +0000)]
Add alternate implementation of waitpid() for systems that have wait4 but
not wait3, in particular Amdahl's SVR2-based UTS 2.1.2. The code comes
from apache, but I contributed it to apache in the first place.
David Dykstra [Thu, 21 Jan 1999 17:10:32 +0000 (17:10 +0000)]
Fix serious bug with "use chroot = no" option which caused "uid =" and "gid ="
to be ignored. At the same time, change the "uid =" and "gid =" options to
be ignored when not running the daemon as super-user, to make it more
convenient for those people and to make it portable to systems such as
cygwin which don't support the uid/gid notions.
Andrew Tridgell [Fri, 8 Jan 1999 07:51:25 +0000 (07:51 +0000)]
made the "max connections" and "lock file" local rather than global
options so you can set them on a per-module basis (requested by
kernel.org mirror maintiner)
Andrew Tridgell [Tue, 5 Jan 1999 06:31:58 +0000 (06:31 +0000)]
don't try to match checksums of two blocks which are of unequal
size. This explains the high false_alarms rate that I saw for one of
the sample data files used in my thesis.
The bug was harmless as the strong checksum easily caught all the
false matches but it's been bugging me as I couldn't explain it :)
Andrew Tridgell [Tue, 5 Jan 1999 01:15:32 +0000 (01:15 +0000)]
an optimization that tries to make rsync choose adjacent matches if
multiple matching blocks are available. This make the run-length
coding of the output more efficient.
David Dykstra [Mon, 7 Dec 1998 18:48:46 +0000 (18:48 +0000)]
steve.ingram@icl-gis.com noticed several mistakes in rsync.1. Some of
them had already been fixed but yodl2man hadn't been run, and a couple
others were new.
Andrew Tridgell [Sat, 5 Dec 1998 01:56:45 +0000 (01:56 +0000)]
paranoia change - treat list_only like read_only and refuse all
syscalls that might change the filesystem. This shouldn't be needed,
but I like paranoid coding :)
David Dykstra [Wed, 25 Nov 1998 15:37:50 +0000 (15:37 +0000)]
Back out change that treated "refuse options = compress" the same as
"dont compress = *", by request of Tridge. Instead, mention the difference
in the man page. Also, put in a shortcut in set_compression() to recognize
"*" earlier instead of going through malloc/strtok/fnmatch/free cycle.
David Dykstra [Tue, 24 Nov 1998 22:03:16 +0000 (22:03 +0000)]
When "refuse options = compress" is set in rsyncd.conf, silently send files
at compression level 0 instead of printing an error and exitting. This is
the same effect as "dont compress = *".
David Dykstra [Tue, 24 Nov 1998 21:26:38 +0000 (21:26 +0000)]
Always include "." when processing exclude lists. This avoids confusion
when people do --exclude "*". Also, add an example to the man page that
shows explicitly including parent directories when itemizing specific
paths to include followed by --exclude "*".
David Dykstra [Tue, 24 Nov 1998 19:52:35 +0000 (19:52 +0000)]
Make sure secrets file is not other-accessible, and owned by root if the
daemon is running as root. Suggested by
Mike Richardson <mike@quaking.demon.co.uk>
David Dykstra [Fri, 6 Nov 1998 17:07:07 +0000 (17:07 +0000)]
Change sanitize_path() to not use clean_fname() because it removes the
trailing slash. This caused a problem when using "use chroot" and sources
that contained a trailing slash (which prevents the last filename component
of the source from being included in the destination). Instead, have
sanitize_path() remove "." components and duplicated slashes ("//") itself.
David Dykstra [Wed, 4 Nov 1998 16:47:33 +0000 (16:47 +0000)]
Fix confusion between RERR_NOSUPPORT and RERR_UNSUPPORTED for exit codes
that indicate a feature is not supported. Two places that are normally
ifdefed out used RERR_UNSUPPORTED whereas one other place and errcode.h
used RERR_NOSUPPORT. Changed them all to consistently use RERR_UNSUPPORTED.
The two things that had the bad values were #ifndef SUPPORT_LINKS and
#ifdef NO_INT64. The former is probably for non-Unix operating systems
and the latter was at least on the default Unixware compiler.