Andreas Schneider [Thu, 24 Mar 2011 13:39:37 +0000 (14:39 +0100)]
librpc: Added a dcerpc_binding_dup() function.
Andreas Schneider [Thu, 24 Mar 2011 12:07:54 +0000 (13:07 +0100)]
s3-epmapper: Refactor the cleanup of endpoints.
Andreas Schneider [Thu, 24 Mar 2011 12:07:05 +0000 (13:07 +0100)]
s3-epmapper: Use strcmp instead of strequal and check IPv6.
Andreas Schneider [Thu, 24 Mar 2011 09:44:14 +0000 (10:44 +0100)]
s3-epmapper: Increase debug levels.
Volker Lendecke [Thu, 24 Mar 2011 15:03:13 +0000 (16:03 +0100)]
s3: Fix some errno assignments in SMBC_opendir_ctx
Do the assignment as the last action to make sure it's not overwritten
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 24 17:31:57 CET 2011 on sn-devel-104
Volker Lendecke [Thu, 24 Mar 2011 14:59:55 +0000 (15:59 +0100)]
s3: Fix Coverity ID 2325: RESOURCE_LEAK
Andrew Tridgell [Wed, 23 Mar 2011 23:59:41 +0000 (10:59 +1100)]
charcnv: removed the allow_badcharcnv and allow_bad_conv options to convert_string*()
we shouldn't accept bad multi-byte strings, it just hides problems
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
Andrew Tridgell [Wed, 23 Mar 2011 06:12:05 +0000 (17:12 +1100)]
charset: remove another allow_badcharcnv check
better to fail only if there is a bad character
Günther Deschner [Wed, 23 Mar 2011 23:00:22 +0000 (00:00 +0100)]
s3-prototypes: remove protos of some dead functions.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 24 00:52:01 CET 2011 on sn-devel-104
Günther Deschner [Wed, 23 Mar 2011 22:59:11 +0000 (23:59 +0100)]
librpc: bring more librpc prototypes in common.
Guenther
Günther Deschner [Wed, 23 Mar 2011 15:47:26 +0000 (16:47 +0100)]
s3-rpc_client: actually call lsa_open_policy2() in rpccli_lsa_open_policy2().
Found by Sumit Bose <sbose@redhat.com>, thanks!
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 23 20:12:38 CET 2011 on sn-devel-104
Günther Deschner [Tue, 22 Mar 2011 21:02:13 +0000 (22:02 +0100)]
s3-smbta-util: fix some buildwarnings.
Guenther
Günther Deschner [Wed, 23 Mar 2011 12:00:32 +0000 (13:00 +0100)]
s3-globals: silence build warning in smbd_messaging_context().
Guenther
Günther Deschner [Tue, 22 Mar 2011 23:08:13 +0000 (00:08 +0100)]
s3-proto: remove some duplicate prototypes.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:50:26 +0000 (23:50 +0100)]
s3-includes: remove unused cmdline_lp_ctx.
Guenther
Andreas Schneider [Mon, 21 Mar 2011 15:14:19 +0000 (16:14 +0100)]
s3-epmapper: Log error if we can't register the endpoint.
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Wed Mar 23 18:06:54 CET 2011 on sn-devel-104
Andreas Schneider [Thu, 17 Mar 2011 16:56:37 +0000 (17:56 +0100)]
s3-epmapper: Setup epm in smbd to forward np requests.
Andreas Schneider [Thu, 17 Mar 2011 15:59:10 +0000 (16:59 +0100)]
s3-epmapper: Remove unregister on shutdown.
This is done automatically now.
Andreas Schneider [Thu, 17 Mar 2011 10:14:12 +0000 (11:14 +0100)]
s3-epmd: Cleanup endpoints on service pipe disconnect.
Andreas Schneider [Wed, 16 Mar 2011 12:42:26 +0000 (13:42 +0100)]
s3-epmapper: Added function to delete endpoint entries.
Andreas Schneider [Mon, 14 Mar 2011 11:29:49 +0000 (12:29 +0100)]
s3-rpc_server: Added disconnect callback function.
Andreas Schneider [Thu, 10 Mar 2011 12:02:31 +0000 (13:02 +0100)]
s3-rpc_server: Rename req to subreq.
Andreas Schneider [Thu, 10 Mar 2011 09:17:51 +0000 (10:17 +0100)]
s3-rpc_server: Implement an endpoint monitor loop.
Andreas Schneider [Wed, 9 Mar 2011 09:38:00 +0000 (10:38 +0100)]
s3-rpc_server: Added a memory context to the ep regsiter state.
Andreas Schneider [Wed, 9 Mar 2011 09:17:06 +0000 (10:17 +0100)]
s3-librpc: Leave the epm registration connection open.
Andreas Schneider [Mon, 14 Mar 2011 13:50:09 +0000 (14:50 +0100)]
s3-epmd: Cleanup endpoint mapper correctly.
Andreas Schneider [Mon, 14 Mar 2011 16:14:19 +0000 (17:14 +0100)]
s3-epmapper: Shutdown the embedded epmapper cleanly.
Andreas Schneider [Mon, 14 Mar 2011 13:49:51 +0000 (14:49 +0100)]
s3-epmapper: Added a cleanup function.
Andreas Schneider [Mon, 21 Mar 2011 08:29:14 +0000 (09:29 +0100)]
s3-epmapper: Use DCERPC_AUTH_LEVEL_CONNECT for ep ncalrpc.
Andreas Schneider [Mon, 14 Mar 2011 09:47:41 +0000 (10:47 +0100)]
s3-rpc_server: Rename system_user to ncalrpc_as_system.
Volker Lendecke [Wed, 23 Mar 2011 16:27:57 +0000 (17:27 +0100)]
s3: Fix a shadowed declaration warning
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 23 17:19:01 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 23 Mar 2011 16:27:21 +0000 (17:27 +0100)]
s3: Include prctl where it is actually used
Volker Lendecke [Wed, 23 Mar 2011 16:24:25 +0000 (17:24 +0100)]
s3: Attempt to fix the build on FreeBSD
Volker Lendecke [Wed, 23 Mar 2011 12:11:26 +0000 (13:11 +0100)]
s3: Fix Coverity ID 2201, NULL_RETURNS
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 23 13:06:20 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 23 Mar 2011 12:11:26 +0000 (13:11 +0100)]
s3: Fix Coverity ID 2202, NULL_RETURNS
Volker Lendecke [Wed, 23 Mar 2011 12:11:26 +0000 (13:11 +0100)]
s3: Fix Coverity ID 2203, NULL_RETURNS
Volker Lendecke [Wed, 23 Mar 2011 10:08:46 +0000 (11:08 +0100)]
s3: Fix a (invalid) uninitialized variable warning
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 23 11:13:14 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Wed, 23 Mar 2011 07:40:49 +0000 (08:40 +0100)]
async_rec/async_sock.c - add an additional "const"
In order to suppress a build warning.
Acked-by: Volker and Metze
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Mar 23 10:26:23 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Wed, 23 Mar 2011 07:36:52 +0000 (08:36 +0100)]
ndrdump - make "in_pipes" and "out_pipes" const
In order to suppress a build warning.
Andrew Bartlett [Fri, 18 Mar 2011 08:10:23 +0000 (19:10 +1100)]
lib/util: Merge basic string length and comparison functions
These functions now use the codepoints for more accurate string
handling and now form common code.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar 23 08:21:54 CET 2011 on sn-devel-104
Andrew Bartlett [Wed, 23 Mar 2011 06:00:02 +0000 (17:00 +1100)]
s3-lib prepare Samba3 to use common codepoint based string functions
This patch changes the source3 util_str.c functions so that the next
patch just contains the move into common code, without code changes.
Andrew Bartlett
Andrew Bartlett [Tue, 22 Mar 2011 10:03:59 +0000 (21:03 +1100)]
s3-safe_string: Add checked_strlcpy()
This is strlcpy, just with an extra check of the parameters with
sizeof(), use only where that works.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar 23 03:39:35 CET 2011 on sn-devel-104
Andrew Bartlett [Tue, 22 Mar 2011 09:57:36 +0000 (20:57 +1100)]
s3-safe_str: Futher simplify the macros by removing indirection
Now that we don't need to pass in the function name and string,
another level of indirection can be safely removed, and the operation
of these macros made much clearer.
Andrew Bartlett
Andrew Bartlett [Tue, 22 Mar 2011 04:30:43 +0000 (15:30 +1100)]
s3-lib Remove the clobber_region() code.
This code wrote to the full buffer in fstrcpy(), pstrcpy() and other
fixed-length string manipulation functions.
The hope of this code was to find out at run time if we were mixing up
pstring and fstring etc, and to record where this came from. It has a
runtime performance impact (particularly if compiled with
--enable-developer).
It is being removed because of the complexity it adds, and the
distinct lack of bugs that this complexity has been credited in
finding.
The macro-based compile-time checking of string sizes remains.
Andrew Bartlett
Andrew Tridgell [Wed, 23 Mar 2011 01:16:44 +0000 (12:16 +1100)]
charcnv: remove the automatic fail on allow_badcharcnv true
we should just fail the call if the string really is bad
Andrew Tridgell [Wed, 23 Mar 2011 01:15:33 +0000 (12:15 +1100)]
waf: prevent an error in the symbol checking code
Andrew Tridgell [Wed, 23 Mar 2011 00:22:15 +0000 (11:22 +1100)]
s3-config: say which config file we failed to open
saves having to strace it to work that out
Andrew Tridgell [Tue, 22 Mar 2011 23:37:54 +0000 (10:37 +1100)]
fault: fixed smb_panic() prototypes
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Mar 23 01:51:44 CET 2011 on sn-devel-104
Andrew Tridgell [Tue, 22 Mar 2011 23:30:36 +0000 (10:30 +1100)]
fault: fixed call to fault_setup() to use new syntax
Andrew Tridgell [Tue, 22 Mar 2011 23:30:19 +0000 (10:30 +1100)]
fault: moved fault.c into common library
Andrew Tridgell [Tue, 22 Mar 2011 23:27:40 +0000 (10:27 +1100)]
fault: switch s4 to use the common fault.c
Andrew Tridgell [Tue, 22 Mar 2011 05:17:39 +0000 (16:17 +1100)]
fault: get fault.c ready for use by s4
this moves the s3 specific dumpcore code into source3/lib/dumpcore.c,
and uses a function pointer to setup which smb_panic call to use
Andrew Tridgell [Tue, 22 Mar 2011 23:25:01 +0000 (10:25 +1100)]
fault: moved s3 fault.c to top level
Andrew Tridgell [Tue, 22 Mar 2011 23:22:15 +0000 (10:22 +1100)]
fault: rename fault.c to fault_s4.c
this is in preparation for merging the s3 fault code into common
Michael Adam [Tue, 1 Feb 2011 10:58:14 +0000 (11:58 +0100)]
s3:WHATSNEW: document changes of the id mapping system
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Mar 22 23:57:29 CET 2011 on sn-devel-104
Björn Baumbach [Thu, 10 Mar 2011 14:58:05 +0000 (15:58 +0100)]
s3:selftest: fix Samba3.pm deprecated idmap config
Replace deprecated idmap uid and gid option with new
idmap config * : range
Michael Adam [Thu, 10 Mar 2011 22:41:17 +0000 (23:41 +0100)]
s3:idmap: make sure that the id mapping system is initialized for first access
Michael Adam [Thu, 10 Mar 2011 22:40:19 +0000 (23:40 +0100)]
s3:loadparm: set the default "idmap config * : backend" in initialize_globals().
Michael Adam [Tue, 8 Mar 2011 06:15:36 +0000 (07:15 +0100)]
s3:loadparm: deprecate "idmap uid/gid/backend" and have them set "idmap config * : range/backend"
Michael Adam [Tue, 22 Mar 2011 16:09:47 +0000 (17:09 +0100)]
s3:WHATSNEW: remove mention of "idmap read only" as new parameter
Michael Adam [Tue, 22 Mar 2011 16:08:42 +0000 (17:08 +0100)]
s3:docs: remove documentation of "idmap read only" which was removed.
Michael Adam [Fri, 4 Mar 2011 13:25:58 +0000 (14:25 +0100)]
s3:loadparm: remove unused parameter "idmap read only".
This has not been released yet and is now useless since we
use the "idmap config * : read only = ..." syntax.
Michael Adam [Thu, 3 Mar 2011 16:50:28 +0000 (17:50 +0100)]
s3:idmap: remove (now) unneeded function parse_idmap_module()
Michael Adam [Thu, 3 Mar 2011 16:48:43 +0000 (17:48 +0100)]
s3:idmap: simply call idmap_init_named_domain for "*" in idmap_init_default_domain
The default domain "*" is now treated exactly the same as other explicitly
configured domains.
Michael Adam [Thu, 3 Mar 2011 16:40:36 +0000 (17:40 +0100)]
s3:idmap: remove passdb argument from idmap_init_domain()
Michael Adam [Wed, 2 Mar 2011 22:00:58 +0000 (23:00 +0100)]
s3:idmap: remove the params argument from the init function
Michael Adam [Wed, 2 Mar 2011 16:08:01 +0000 (17:08 +0100)]
s3:idmap: remove special treatment of domain "*" from idmap_ldap_init.
The default config via domain "*" is now treated just as the explicit
domain configs.
Michael Adam [Wed, 2 Mar 2011 16:04:59 +0000 (17:04 +0100)]
s3:idmap: remove use of params from idmap_ldap_init - it is not used any more
Michael Adam [Wed, 2 Mar 2011 14:41:06 +0000 (15:41 +0100)]
s3:idmap: remove the special treatment of the default domain "*" from idmap_init_domain
Matthias Dieter Wallnöfer [Mon, 21 Mar 2011 09:32:24 +0000 (10:32 +0100)]
s4:python bindings - handle NULL returns from "loadparm_init_global"
Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Mar 22 19:52:57 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Mon, 21 Mar 2011 09:25:52 +0000 (10:25 +0100)]
s4:param/loadparm.c - check for OOM
Return NULL if the loadparm context hasn't been allocated
Reviewed-by: Jelmer
Matthias Dieter Wallnöfer [Mon, 21 Mar 2011 09:25:09 +0000 (10:25 +0100)]
s4:auth/system_session.c - check for OOM
Reviewed-by: Jelmer
Stefan Metzmacher [Tue, 22 Mar 2011 15:34:36 +0000 (16:34 +0100)]
s4:ntvfs/posix: name->dos.attrib isn't initialized in pvfs_access_check_create()
That's why we have the 'container' parameter to indicate
the caller wants to create a directory.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Mar 22 17:39:11 CET 2011 on sn-devel-104
Michael Adam [Tue, 22 Mar 2011 12:08:10 +0000 (13:08 +0100)]
s3:docs: fix xml of "printnotifybackchannel" parameter (missing closing tag)
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Mar 22 13:57:25 CET 2011 on sn-devel-104
Andrew Tridgell [Tue, 22 Mar 2011 03:05:23 +0000 (14:05 +1100)]
s3-fault: removed the cont_fn from fault_setup()
cont_fn() was supposed to be a way to continue after a seg fault. It
could never be called however, as smb_panic() from fault_report()
could never return, as dump_core() never returns at the end of
smb_panic()
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 22 05:07:58 CET 2011 on sn-devel-104
Stefan Metzmacher [Mon, 21 Mar 2011 10:21:57 +0000 (11:21 +0100)]
libcli/security: make sure that we don't grant SEC_STD_DELETE to the owner by default
In the file server SEC_STD_DELETE is granted on the file/directory
or by FILE_DELETE_CHILD on the parent directory.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Mar 21 23:25:05 CET 2011 on sn-devel-104
Stefan Metzmacher [Fri, 18 Mar 2011 15:45:08 +0000 (16:45 +0100)]
s3:smbd: access checks should not depend on share mode flags
metze
Stefan Metzmacher [Mon, 21 Mar 2011 12:59:27 +0000 (13:59 +0100)]
s4:ntvfs/posix: grant SEC_STD_DELETE if the parent grants SEC_DIR_DELETE_CHILD
metze
Volker Lendecke [Mon, 21 Mar 2011 09:56:10 +0000 (10:56 +0100)]
s3: Fix Coverity ID 1048, CHECKED_RETURN
This is a real bug: tevent_req_set_endtime already calls tevent_req_nomem.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 21 16:29:22 CET 2011 on sn-devel-104
Volker Lendecke [Mon, 21 Mar 2011 09:46:53 +0000 (10:46 +0100)]
s3: Fix Coverity ID 770, REVERSE_INULL
We dereference "res" in various places, no point in checking. All current
callers send "res!=NULL".
Volker Lendecke [Mon, 21 Mar 2011 11:48:41 +0000 (12:48 +0100)]
idmap.idl: Fix whitespace
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 21 13:36:48 CET 2011 on sn-devel-104
Matthieu Patou [Sat, 26 Feb 2011 18:35:27 +0000 (21:35 +0300)]
pyldb: minor fixup, fix a memory leak
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Mar 20 12:13:50 CET 2011 on sn-devel-104
Matthieu Patou [Sat, 26 Feb 2011 18:34:43 +0000 (21:34 +0300)]
pyldb: add more tests for control manipulation
Matthieu Patou [Mon, 7 Mar 2011 22:03:16 +0000 (01:03 +0300)]
dsdb: read acl, sd can be null and ret == LDB_SUCCESS
Matthieu Patou [Sat, 5 Mar 2011 19:22:00 +0000 (22:22 +0300)]
dsdb: acl_read fix a missed talloc_steal
Matthieu Patou [Sun, 27 Feb 2011 09:16:43 +0000 (12:16 +0300)]
upgradeprovision: Fix typo
Matthieu Patou [Fri, 4 Mar 2011 21:03:12 +0000 (00:03 +0300)]
ldb:fix control parsing for dirsync
Matthieu Patou [Sat, 26 Feb 2011 18:07:51 +0000 (21:07 +0300)]
ldapcli: allocate control value on the control object not on the control container
Volker Lendecke [Sun, 20 Mar 2011 09:35:18 +0000 (10:35 +0100)]
s3: Fix early tldap_search cancels
A callback of tldap_search_send might not interested in the rest of the results
and could do a TALLOC_FREE of the search request. In this case, "subreq" is
already free'ed. So we have to set it to pending before the callback is called.
The TALLOC_FREE of the search request will set it to non-pending again via
tldap_msg_destructor.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 20 11:26:57 CET 2011 on sn-devel-104
Jelmer Vernooij [Sat, 19 Mar 2011 14:54:51 +0000 (15:54 +0100)]
lib/replace/test: Add missing include for prototype.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 19 16:45:56 CET 2011 on sn-devel-104
Jelmer Vernooij [Sat, 19 Mar 2011 14:34:45 +0000 (15:34 +0100)]
rpc_server/remote: Add missing prototype.
Jelmer Vernooij [Sat, 19 Mar 2011 14:33:29 +0000 (15:33 +0100)]
lib/registry/tests: Fix prototypes.
Stefan Metzmacher [Fri, 18 Mar 2011 09:03:05 +0000 (10:03 +0100)]
selftest/Samba3: use 'debug pid=yes'
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Mar 19 10:55:34 CET 2011 on sn-devel-104
Stefan Metzmacher [Fri, 18 Mar 2011 15:01:26 +0000 (16:01 +0100)]
s3:smbd: remove uses of "./" in unlink_internals()
Commit
78b931ce6c840ade646c1c6030fa2d6acb77208b tried to do that,
but didn't have any effect.
metze
Christian Ambach [Mon, 14 Mar 2011 12:08:58 +0000 (08:08 -0400)]
s3: use getgrset() when it is available
When getgrouplist() is not defined, use getgrset() if it is defined
instead of using the initgroups() + getgroups() combo
Major contributions from Yannick Bergeron <yaberger@ca.ibm.com>
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 19 10:09:38 CET 2011 on sn-devel-104
Jelmer Vernooij [Sat, 19 Mar 2011 02:20:29 +0000 (03:20 +0100)]
pidl: Fix prototype for server init functions.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 19 04:07:40 CET 2011 on sn-devel-104
Jelmer Vernooij [Fri, 18 Mar 2011 23:46:08 +0000 (00:46 +0100)]
lib/: Fix prototypes for functions.
Jelmer Vernooij [Fri, 18 Mar 2011 23:45:56 +0000 (00:45 +0100)]
libcli/: Fix prototypes for all functions.
Jelmer Vernooij [Fri, 18 Mar 2011 23:45:45 +0000 (00:45 +0100)]
source4/: Fix prototypes for all functions in various subsystems.
Jelmer Vernooij [Fri, 18 Mar 2011 23:45:36 +0000 (00:45 +0100)]
source4/lib: Fix prototypes for all functions.