Matthieu Patou [Fri, 12 Nov 2010 17:45:07 +0000 (20:45 +0300)]
python: use the ldbMessage + modify notation instead of modify_ldif that we try to avoid
Matthieu Patou [Mon, 8 Nov 2010 11:09:04 +0000 (14:09 +0300)]
Fix typo
Matthieu Patou [Tue, 26 Oct 2010 12:38:42 +0000 (16:38 +0400)]
unit tests: add testing for dns account password change
Matthieu Patou [Fri, 12 Nov 2010 17:00:57 +0000 (20:00 +0300)]
upgradeprovision: use relaxed control while adding missing object container
Matthieu Patou [Tue, 26 Oct 2010 12:37:50 +0000 (16:37 +0400)]
upgradeprovision: fix pb with dns-hostname, regenerate a correct keytab
Matthieu Patou [Sat, 23 Oct 2010 18:01:30 +0000 (22:01 +0400)]
upgradeprovision: use the relax/(upgrade)provision when modifying object
For certain attribute we use the relax/provision control so that we
try to respect checks as this is not a good idea to always force
unwanted behavior.
Matthieu Patou [Sat, 23 Oct 2010 18:00:04 +0000 (22:00 +0400)]
upgradeprovision: use the (upgrade)provision control also
Matthieu Patou [Sat, 23 Oct 2010 17:57:16 +0000 (21:57 +0400)]
upgradeprovision: update revision for forestupdate and domainupdate objects
Matthieu Patou [Fri, 12 Nov 2010 16:58:09 +0000 (19:58 +0300)]
samldb: relax groupType modification checks
Allow programs with the PROVISION control to bypass groupType checks.
This is needed by upgradeprovision for older alpha (11, 10 ...)
Matthieu Patou [Fri, 22 Oct 2010 09:37:32 +0000 (13:37 +0400)]
Update WHATSNEW4 to add information related to samba_backup
Matthieu Patou [Fri, 22 Oct 2010 09:28:40 +0000 (13:28 +0400)]
Add a script to make backup of samba provision
Matthias Dieter Wallnöfer [Fri, 12 Nov 2010 18:49:47 +0000 (19:49 +0100)]
s4:objectclass LDB module - we should not simply ignore additional "objectClass" attribute changes
There first one we perform all other tentatives are terminated with
ERR_ATTRIBUTE_OR_VALUE_EXISTS (tested against Windows).
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Nov 12 19:39:07 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Fri, 12 Nov 2010 18:28:48 +0000 (19:28 +0100)]
s4:repl_meta_data LDB module - convert two debug messages into error messages
These regarding "objectGUID".
Matthias Dieter Wallnöfer [Fri, 12 Nov 2010 17:57:57 +0000 (18:57 +0100)]
s4:samldb/objectclass_attrs LDB modules - move "description" logic from "objectclass_attrs" into "samldb"
This according to an answer from dochelp is SAM specific behaviour.
Jelmer Vernooij [Fri, 12 Nov 2010 17:27:46 +0000 (18:27 +0100)]
waf/samba_version: Simplify git show command.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Nov 12 18:38:21 UTC 2010 on sn-devel-104
Jelmer Vernooij [Fri, 12 Nov 2010 17:20:02 +0000 (18:20 +0100)]
samba_version: Make COMMIT_IS_CLEAN an int rather than a string.
Jelmer Vernooij [Fri, 12 Nov 2010 17:19:00 +0000 (18:19 +0100)]
samba_version: Simplify dirty tree detection.
Jelmer Vernooij [Fri, 12 Nov 2010 17:06:43 +0000 (18:06 +0100)]
waf/samba_version: Support integer defines.
Jelmer Vernooij [Fri, 12 Nov 2010 17:06:20 +0000 (18:06 +0100)]
s3: Rename GIT_COMMIT_{TIME,DATE} to COMMIT_{TIME,DATE}.
This avoids some special casing in the waf code.
Jelmer Vernooij [Fri, 12 Nov 2010 16:59:07 +0000 (17:59 +0100)]
s4: Remove obsolete mkversion.sh
Jelmer Vernooij [Fri, 12 Nov 2010 16:54:41 +0000 (17:54 +0100)]
samba_version: When working from git checkout, display git revision SHA1 rather
than Bazaar revision ids.
Jelmer Vernooij [Fri, 12 Nov 2010 16:26:06 +0000 (17:26 +0100)]
samba_version: Support retrieving snapshot identity from bzr.
Jelmer Vernooij [Fri, 12 Nov 2010 16:18:30 +0000 (17:18 +0100)]
samba_version: Cope with building snapshots in directories without git checkout.
Error out when run in a git checkout in which git fails.
Jelmer Vernooij [Fri, 12 Nov 2010 16:13:37 +0000 (17:13 +0100)]
Put git tree finding into a separate function.
Jelmer Vernooij [Fri, 12 Nov 2010 16:08:09 +0000 (17:08 +0100)]
sambaversion.py: Some cleanups, make less git-specific.
Jelmer Vernooij [Fri, 12 Nov 2010 16:00:42 +0000 (17:00 +0100)]
wafsamba: Support make dist from bzr checkout.
Jelmer Vernooij [Fri, 12 Nov 2010 15:23:03 +0000 (16:23 +0100)]
torture: Only add in tests for socket_wrapper/nss_wrapper when they have been enabled.
Jelmer Vernooij [Fri, 12 Nov 2010 15:22:43 +0000 (16:22 +0100)]
unix_privs: Add missing dependency on libreplace.
Jelmer Vernooij [Fri, 12 Nov 2010 15:22:16 +0000 (16:22 +0100)]
socket_wrapper: Only add as global dependency when enabled.
Jelmer Vernooij [Fri, 12 Nov 2010 15:12:14 +0000 (16:12 +0100)]
heimdal_build: Add missing dependency on replace, necessary because replace.h is included.
Jelmer Vernooij [Fri, 12 Nov 2010 11:55:14 +0000 (12:55 +0100)]
s4-waf: Only enable various wrappers if they're actually used.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Nov 12 14:33:34 UTC 2010 on sn-devel-104
Jelmer Vernooij [Fri, 12 Nov 2010 11:17:45 +0000 (12:17 +0100)]
Lowercase DNS_UPDATE_SRV name.
Stefan Metzmacher [Thu, 11 Nov 2010 08:36:25 +0000 (09:36 +0100)]
tdb: set tdb->name early, as it's needed for tdb_name()
tdb_name() might be used within the given log function,
which might be called from within tdb_open_ex().
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov 12 11:22:21 UTC 2010 on sn-devel-104
Andrew Tridgell [Fri, 12 Nov 2010 06:23:34 +0000 (17:23 +1100)]
s4-kdc: added proxying of kdc requests for RODCs
when we are an RODC and we get a request for a principal that we don't
have the right secrets for, we need to proxy the request to a
writeable DC. This happens for both TCP and UDP requests, for both
krb5 and kpasswd
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Nov 12 08:03:20 UTC 2010 on sn-devel-104
Andrew Bartlett [Fri, 12 Nov 2010 01:32:50 +0000 (12:32 +1100)]
s4-kdc Return HDB_ERR_NOT_FOUND_HERE on un-revealed accounts on an RODC
This means that when we are an RODC, and an account does not have the
password attributes, we can now indicate to the kdc code that it
should forward the request to a real DC.
(The proxy code itself is not in this commit).
Andrew Bartlett
Andrew Bartlett [Fri, 12 Nov 2010 01:31:33 +0000 (12:31 +1100)]
heimdal Return HDB_ERR_NOT_FOUND_HERE to the caller
This means that no reply packet should be generated, but that instead
the user of the libkdc API should forward the packet to a real KDC,
that has a full database.
Andrew Bartlett
Andrew Tridgell [Thu, 11 Nov 2010 03:22:40 +0000 (14:22 +1100)]
s4-kdc: split the kdc process return into a tri-state
this is in preparation for doing forwarding of packets for RODCs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 11 Nov 2010 03:13:01 +0000 (14:13 +1100)]
s4-kdc: we don't need the special include handling now
the special handling was to cope with the conflict with the kdc.h
header
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 11 Nov 2010 03:09:41 +0000 (14:09 +1100)]
s4-kdc: rename kdc/kdc.h to kdc/kdc-glue.h
kdc.h conflicts with a heimdal header name
Kamen Mazdrashki [Wed, 10 Nov 2010 04:14:20 +0000 (06:14 +0200)]
s4-tests: Make repl_schema.py test part of Samba4 test suite
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Thu Nov 11 19:38:18 UTC 2010 on sn-devel-104
Kamen Mazdrashki [Wed, 10 Nov 2010 01:45:22 +0000 (03:45 +0200)]
s4-repl: Propagate remote prefixMap in DRSUAPI data conversion functions
Kamen Mazdrashki [Wed, 10 Nov 2010 00:32:29 +0000 (02:32 +0200)]
s4-dsdb_syntax: Warning message that we can't find requested ATTID in Schema Cache
Kamen Mazdrashki [Tue, 9 Nov 2010 02:36:24 +0000 (04:36 +0200)]
s4-prefixMap: dsdb_schema_pfm_oid_from_attid() to use const prefixMap
It is not supposed to change supplied prefixMap
Kamen Mazdrashki [Tue, 9 Nov 2010 02:12:57 +0000 (04:12 +0200)]
s4-dsdb_syntax: Use remote prefixMap to handle generic cases in drsuapi_to_ldb conversions
Kamen Mazdrashki [Tue, 9 Nov 2010 02:12:16 +0000 (04:12 +0200)]
s4-dsdb_syntax: Add remote prefixMap member for dsdb_syntax conversions
Kamen Mazdrashki [Sun, 7 Nov 2010 21:04:33 +0000 (23:04 +0200)]
s4-repl: dsdb_extended_replicated_objects_convert -> dsdb_replicated_objects_convert/
It is part of dsdb_replicated_* family of functions
Kamen Mazdrashki [Sun, 7 Nov 2010 20:51:11 +0000 (22:51 +0200)]
s4-repl: dsdb_extended_replicated_objects_commit -> dsdb_replicated_objects_commit
It is part of dsdb_replicated_* family of functions
Kamen Mazdrashki [Sun, 7 Nov 2010 19:47:39 +0000 (21:47 +0200)]
s4-repl: dsdb_convert_object -> dsdb_origin_object_convert
It is used in dsdb_origin_objects_commit() func,
hence the dsdb_origin_ prefix
Kamen Mazdrashki [Thu, 11 Nov 2010 18:19:47 +0000 (20:19 +0200)]
s4-test: repl_schema - Make sure LdbError and ERR_NO_SUCH_OBJECT are visible
Volker Lendecke [Thu, 11 Nov 2010 18:08:20 +0000 (19:08 +0100)]
s3: Well... Fix a stupid error
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 11 18:54:00 UTC 2010 on sn-devel-104
Volker Lendecke [Thu, 11 Nov 2010 14:58:34 +0000 (15:58 +0100)]
s3: Make cli_set_ea_fnum return NTSTATUS
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 11 16:59:27 UTC 2010 on sn-devel-104
Volker Lendecke [Thu, 11 Nov 2010 14:51:46 +0000 (15:51 +0100)]
s3: Make cli_set_ea_path return NTSTATUS
Volker Lendecke [Thu, 11 Nov 2010 14:51:16 +0000 (15:51 +0100)]
s3: Remove two pointless variables
Volker Lendecke [Thu, 11 Nov 2010 14:40:06 +0000 (15:40 +0100)]
s3: Convert cli_set_ea() to cli_trans()
Volker Lendecke [Thu, 11 Nov 2010 13:54:25 +0000 (14:54 +0100)]
s3: Convert cli_dfs_get_referral to cli_trans
Volker Lendecke [Thu, 11 Nov 2010 13:46:58 +0000 (14:46 +0100)]
s3: cli_dfs_check_error does not need to depend on cli->inbuf
Volker Lendecke [Thu, 11 Nov 2010 13:04:06 +0000 (14:04 +0100)]
s3: Make split_dfs_path return bool
Volker Lendecke [Thu, 11 Nov 2010 12:45:00 +0000 (13:45 +0100)]
s3: Remove some dead code
Volker Lendecke [Thu, 11 Nov 2010 12:44:28 +0000 (13:44 +0100)]
s3: Untangle an if-expression
Anatoliy Atanasov [Mon, 8 Nov 2010 06:11:11 +0000 (08:11 +0200)]
s4/test: Expand BindTest
The test now binds with user@realm, domain\user, user dn, computer dn
Autobuild-User: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>
Autobuild-Date: Thu Nov 11 16:15:30 UTC 2010 on sn-devel-104
Anatoliy Atanasov [Fri, 5 Nov 2010 07:27:48 +0000 (09:27 +0200)]
s4/test: Add bind.py to make test
bind.py is a place to have tests for ldb binding with different credentials.
For starter we have a simple bind with machine account.
Andrew Bartlett [Thu, 11 Nov 2010 09:44:16 +0000 (20:44 +1100)]
heimdal Don't dereference NULL in error verify_checksum error path
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Nov 11 10:37:03 UTC 2010 on sn-devel-104
Andrew Bartlett [Thu, 11 Nov 2010 08:55:26 +0000 (19:55 +1100)]
s4-provision UTF16 encode the password in sam.ldb, not secrets.ldb
The password in secrets.ldb is UTF8, while clearTextPassword in
sam.ldb is UTF16.
This corrects commit
bd5039546e520b6d6897a658bc0a358f0511f7c7, which
had these the wrong way around.
Andrew Bartlett
Andrew Bartlett [Thu, 11 Nov 2010 07:36:06 +0000 (18:36 +1100)]
s4-dsdb Remove incorrectly declared ** variable used as *.
The cleartext_utf16_str variable was declared char **, but due to the
cast on convert_string_talloc() and the lack of type checking here and
on data_blob_const (due to void *) it was able to be used as if it was
a char *.
The simple solution seems to be to fill in cleartext_utf16 blob directly.
Andrew Bartlett
Andrew Bartlett [Thu, 11 Nov 2010 07:33:14 +0000 (18:33 +1100)]
s4-dsdb Convert new krbtgt_xxx password into UTF16
The new stricter test on clearTextPassword values caught out that
we did not provide a utf16 password here.
Andrew Bartlett
Andrew Bartlett [Thu, 11 Nov 2010 06:59:16 +0000 (17:59 +1100)]
s4-dsdb Return an error if we can't convert UTF16MUNGED -> UTF8
The UTF16MUNGED helper will map all invalid sequences (except odd
input length) to valid input sequences, per the rules. Therefore if
it fails, we need to bail out, somehing serious is wrong.
Andrew Bartlett
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 15:21:41 +0000 (16:21 +0100)]
s4:pytevent.c - fix a discard const warning
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 11 09:47:55 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 15:20:38 +0000 (16:20 +0100)]
ldb:ldb_ldap.c rename operation - check for the RDN name and value
Make it more similar to "ldb_ildap.c" and also more save
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 15:05:16 +0000 (16:05 +0100)]
s4:dsdb - proof against empty RDN values where expected
This should prevent crashes as pointed out on the mailing list.
Zahari Zahariev [Tue, 9 Nov 2010 12:55:32 +0000 (14:55 +0200)]
Cannot create OU using custom Schema class
If we define our own child class 'subClassOf' system Schema class
e.g. organizationalUnit then we cannot create OU in the Dafualt
Naming Context that has this custom Schama class in the objectClass
attribute.
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 14:12:02 +0000 (15:12 +0100)]
s4:objectclass LDB module - allow RDNs also to come from superclasses
Detected by a testcase written by Zahari Zahariev.
Matthias Dieter Wallnöfer [Tue, 9 Nov 2010 14:04:47 +0000 (15:04 +0100)]
s4:passwords.py - add a test for the normal "userPassword" behaviour
Just to make sure that this works now too
Matthias Dieter Wallnöfer [Tue, 9 Nov 2010 13:39:30 +0000 (14:39 +0100)]
s4:password_hash and acl LDB modules - handle the "userPassword" attribute according to the "dSHeuristics"
Matthias Dieter Wallnöfer [Tue, 9 Nov 2010 13:45:18 +0000 (14:45 +0100)]
s4:password_hash LDB module - move "samdb_msg_find_old_and_new_ldb_val" into the password_hash LDB module
It's only used there and so I think it doesn't really belong in
"dsdb/common/util.c" (I first thought that it could be useful for ACL checking
but obviously it wasn't).
Matthias Dieter Wallnöfer [Tue, 9 Nov 2010 17:46:37 +0000 (18:46 +0100)]
s4:libnet/libnet_samsync_ldb.c - remove "userPassword" remove code
It could also be a normal attribute with a normal content, and if it's not
like that then it's for sure empty.
Matthias Dieter Wallnöfer [Tue, 9 Nov 2010 17:42:26 +0000 (18:42 +0100)]
s4:local_password LDB module - remove schema checking code and fix some typos
This is now done by the "objectclass_attrs" LDB module.
Matthias Dieter Wallnöfer [Tue, 9 Nov 2010 18:44:27 +0000 (19:44 +0100)]
s4:ldb_modules/util.c - "dsHeuristics" -> "dSHeuristics"
Matthias Dieter Wallnöfer [Thu, 11 Nov 2010 09:01:26 +0000 (10:01 +0100)]
s4:selftest/tests.py - skip the "passwords.py" suite on Windows 2000 domain function level
The "userPassword" password change functionality isn't available and so it
causes big parts of the testsuite to fail. On the other hand we've basic tests
in "acl.py" and indirectly also over SAMR and kpasswd so I propose to simply
skip it.
Matthias Dieter Wallnöfer [Thu, 11 Nov 2010 08:33:06 +0000 (09:33 +0100)]
s4:acl.py - two password change tests are expected to fails on Windows 2000 function level
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 13:01:58 +0000 (14:01 +0100)]
s4:upgradehelpers.py - use "clearTextPassword" rather than "userPassword"
It's the default internal s4 password change attribute
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 12:26:31 +0000 (13:26 +0100)]
s4:speedtest.py - use "unicodePwd" for setting user's password
It's available on all AD hosts (including Windows 2000) and on all configurations!
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 12:28:22 +0000 (13:28 +0100)]
s4:speedtest.py - remove duplicated code
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 12:37:46 +0000 (13:37 +0100)]
s4:speedtest.py - fix script name in the help text
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 12:29:14 +0000 (13:29 +0100)]
s4:speedtest.py - make it executable
Matthias Dieter Wallnöfer [Wed, 10 Nov 2010 12:35:30 +0000 (13:35 +0100)]
s4:python tests - fix script names in the help text
Andrew Tridgell [Thu, 11 Nov 2010 02:56:44 +0000 (13:56 +1100)]
s4-loadparm: fix the FLAG_DEFAULT settings on specially handled parameters
parameters with special handlers also need to clear the FLAG_DEFAULT
flag when set
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 11 03:39:23 UTC 2010 on sn-devel-104
Andrew Tridgell [Thu, 11 Nov 2010 02:09:29 +0000 (13:09 +1100)]
s4-provision: include command line provision options in the generated smb.conf
this saves the smb.conf using lp.dump_globals() to ensure that any
command line options (for example directory overrides) are saved in
the generated smb.conf
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 11 Nov 2010 00:18:48 +0000 (11:18 +1100)]
s4-devel: useful script for testing join with empty smb.conf
this sets up all the needed --options for a join with a prefix other
than the one compiled in
Andrew Tridgell [Thu, 11 Nov 2010 00:16:23 +0000 (11:16 +1100)]
s4-test: use IPC$ instead of ADMIN$ for srvsvc NetShareGetInfo test
IPC$ is guaranteed to exist on servers that do RPC, whereas ADMIN$
isn't
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 10 Nov 2010 23:45:13 +0000 (10:45 +1100)]
s4-join: use the command line loadparm in provision during a join
this allows a join with an empty smb.conf to override locations of
files correctly with --option
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 10 Nov 2010 23:39:19 +0000 (10:39 +1100)]
s4-loadparm: fixed dumping of non-default parms with testparm
when using testparm without -v we should only dump non-default
parameters. This patch fixes up the handling of the FLAG_DEFAULT flag
in loadparm to correctly mark parameters as default or not, including
parametric options
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 10 Nov 2010 23:35:38 +0000 (10:35 +1100)]
s4-server: move the creation of the IPC$ share into ntvfs
the IPC$ share is only used by the ntvfs backends, and doesn't need to
be created on every load of smb.conf. This fixes a problem with
testparm showing the ipc$ share when it isn't defined in smb.conf.
This also removes the admin$ share, which really shouldn't be on by
default. The admin$ share is used for remote software installation,
and normally exposes the c:\windows directory on a windows
server. That makes no sense on Samba. If for some reason a admin$
share is needed, then the admin can create one as usual. Exposing /tmp
via admin$ by default seems like a bad idea.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Jeremy Allison [Thu, 11 Nov 2010 01:59:05 +0000 (17:59 -0800)]
Fix bug #7791 - gvfsd-smb (Gnome vfs) fails to copy files from a SMB share using SMB signing.
The underlying problem is that the old code invoked by cli_write() increments
cli->mid directly when issuing outstanding writes. This should now be done only
in libsmb/clientgen.c to make metze's new signing engine works correctly. Just
deleting this code fixes the problem.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Nov 11 02:50:08 UTC 2010 on sn-devel-104
Jeremy Allison [Thu, 11 Nov 2010 01:54:57 +0000 (17:54 -0800)]
Add test that detects problems in the SMB signing code when run through cli_write() (which doesn't use the new async methods).
Unfortunately, and I think due to the socket wrapper code, this doesn't
detect the failure on the build farm, but running the RW-SIGNING test
separately against a Samba or Windows server using signing does.
Jeremy.
Björn JACKE [Wed, 10 Nov 2010 23:12:07 +0000 (10:12 +1100)]
autobuild: perfer to use git mail address in autobuild comment
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Nov 10 23:56:37 UTC 2010 on sn-devel-104
Günther Deschner [Wed, 10 Nov 2010 14:21:15 +0000 (15:21 +0100)]
s4-smbtorture: use test_GetPrinterData{Ex}_checktype calls in RPC-SPOOLSS tests.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov 10 15:07:12 UTC 2010 on sn-devel-104
David Disseldorp [Fri, 5 Nov 2010 14:24:22 +0000 (15:24 +0100)]
s3-spoolss: fix spoolss GetPrinterData behaviour
Windows sends spoolss GetPrinterData requests with an offered buffer
size of zero, Model and TrayFormTable data is commonly requested in
this way.
Samba's GetPrinterData response for the above case includes the correct
error code (WERR_MORE_DATA), however the type field is set to REG_NONE.
This causes Windows (seen on XP and 2k3) to give up on the request.
If the type field is retained (not set to REG_NONE) when responding with
WERR_MORE_DATA, Windows reissues the GetPrinterData request with an
increased offered buffer size.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Wed, 10 Nov 2010 09:19:01 +0000 (10:19 +0100)]
s4-smbtorture: allow to test returned type after specific error code in PrinterData tests.
Guenther
Björn Jacke [Wed, 10 Nov 2010 11:39:41 +0000 (12:39 +0100)]
s3/time_audit: fix a change that was just for debuggin purposeѕ
Autobuild-User: Björn Jacke <bjacke@samba.org>
Autobuild-Date: Wed Nov 10 12:28:41 UTC 2010 on sn-devel-104
Kamen Mazdrashki [Mon, 8 Nov 2010 22:21:57 +0000 (00:21 +0200)]
s4-pyldb: Handle internal errors in py_ldb_contains() properly
It is an exceptional condition for ldb_search() to return
more than one results during SCOPE_BASE search on DN
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Nov 10 09:02:00 UTC 2010 on sn-devel-104