Volker Lendecke [Sun, 18 Jun 2006 09:26:05 +0000 (09:26 +0000)]
r16338: Fix Klocwork ID 150
Volker Lendecke [Sun, 18 Jun 2006 08:35:27 +0000 (08:35 +0000)]
r16337: Add configure fixes by Bjoern Jacke <samba@j3e.de>.
Volker
Volker Lendecke [Sun, 18 Jun 2006 07:54:06 +0000 (07:54 +0000)]
r16336: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
1111
Volker
Volker Lendecke [Sat, 17 Jun 2006 07:43:56 +0000 (07:43 +0000)]
r16335: Fix Klocwork IDs 107 108 109 111 112 113 114 116 117 118 121
Volker Lendecke [Sat, 17 Jun 2006 07:20:47 +0000 (07:20 +0000)]
r16334: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
1111
Volker
Jeremy Allison [Fri, 16 Jun 2006 23:26:48 +0000 (23:26 +0000)]
r16326: Klocwork #509. Always check return allocs.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 23:21:36 +0000 (23:21 +0000)]
r16324: Klocwork #499. Allways check results from alloc.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 23:14:12 +0000 (23:14 +0000)]
r16322: Klocwork #481., Don't deref null on malloc fail.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 23:07:42 +0000 (23:07 +0000)]
r16320: Ensure variable is not null before calling fclose.
Klocwork #412.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 23:04:13 +0000 (23:04 +0000)]
r16317: Klocwork #300. Check for error return on malloc.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 22:44:28 +0000 (22:44 +0000)]
r16313: Not a problem - but ensure Klocwork is quiet (#872).
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 22:40:07 +0000 (22:40 +0000)]
r16311: Check for NULL return. Klocwork #998.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 22:36:12 +0000 (22:36 +0000)]
r16309: Fix Klocwork #1596. Check for NULL on talloc.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 22:29:53 +0000 (22:29 +0000)]
r16307: Make sure we know we must pass a valid pointer here.
Klocwork #1129.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 22:25:17 +0000 (22:25 +0000)]
r16306: Error handling in this asn1 code *sucks*. Fix a generic
class of memory leak bugs on error found by Klocwork (#123).
Many of these functions didn't free allocated memory on
error exit.
Jeremy.
Volker Lendecke [Fri, 16 Jun 2006 21:10:19 +0000 (21:10 +0000)]
r16301: Fix a memleak
Jeremy Allison [Fri, 16 Jun 2006 20:44:49 +0000 (20:44 +0000)]
r16299: Fix another "dereferencing type-punned pointer will break
strict-aliasing rules" gcc4 warning.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 18:50:01 +0000 (18:50 +0000)]
r16298: On request of jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM>
change priv_op and priv_info to names that don't
conflict with the solaris namespace.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 18:42:39 +0000 (18:42 +0000)]
r16295: Fix gcc4 "warning: dereferencing type-punned pointer will break
strict-aliasing rules" warning.
Jeremy.
Lars Müller [Fri, 16 Jun 2006 14:34:36 +0000 (14:34 +0000)]
r16294: Fix syntax error.
Credits to Andreas Schwab from SUSE Linux for this fix.
Volker Lendecke [Fri, 16 Jun 2006 12:30:39 +0000 (12:30 +0000)]
r16290: Fix Coverity bugs 298 and 298
James Peach [Fri, 16 Jun 2006 04:44:59 +0000 (04:44 +0000)]
r16289: Fix smbclient test hang. This is caused by readline refusing to believe
the end of file it receives when reading from a pipe after we force
interactive mode.
Jeremy Allison [Fri, 16 Jun 2006 02:23:02 +0000 (02:23 +0000)]
r16287: Use intptr_t to return an integer of an unknown type cast
to void *.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 02:01:29 +0000 (02:01 +0000)]
r16285: On a 64-bit box, size_t != uint32. Ensure we use
the right parameter type.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 01:47:02 +0000 (01:47 +0000)]
r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 01:35:08 +0000 (01:35 +0000)]
r16281: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 01:33:13 +0000 (01:33 +0000)]
r16280: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 01:32:19 +0000 (01:32 +0000)]
r16277: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
in a format string.
Jeremy.
Jeremy Allison [Fri, 16 Jun 2006 01:30:42 +0000 (01:30 +0000)]
r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
in a format string.
Jeremy.
James Peach [Thu, 15 Jun 2006 23:51:20 +0000 (23:51 +0000)]
r16274: Fix the smbclient prompting behaviour for both systems that have
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.
Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
James Peach [Thu, 15 Jun 2006 23:47:41 +0000 (23:47 +0000)]
r16273: Add smbclient tests to verify that
in interactive mode, smbclient always prompts on stdout
in non-interactive mode, smbclient never prompts
Günther Deschner [Thu, 15 Jun 2006 21:59:25 +0000 (21:59 +0000)]
r16272: Fix memleak.
Guenther
Jeremy Allison [Thu, 15 Jun 2006 21:46:15 +0000 (21:46 +0000)]
r16270: Fix Klocwork #706 - ensure sscanf has correct format
specifier.
Jeremy.
Günther Deschner [Thu, 15 Jun 2006 21:45:10 +0000 (21:45 +0000)]
r16269: Fix the build.
Guenther
Günther Deschner [Thu, 15 Jun 2006 21:25:57 +0000 (21:25 +0000)]
r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls.
This patch is mainly based on the work of Todd Stecher
<tstecher@isilon.com> and has been reviewed by Jeremy.
I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal
0.7.2 and 0.6.1rc3.
Guenther
Jeremy Allison [Thu, 15 Jun 2006 21:03:40 +0000 (21:03 +0000)]
r16267: Fix Klocwork #401, #402 - ensure format specifier
limited. Fix memleak in printing gencache contents.
Jeremy.
Günther Deschner [Thu, 15 Jun 2006 16:09:31 +0000 (16:09 +0000)]
r16261: Smaller fixes for net ads password.
Guenther
Gerald Carter [Thu, 15 Jun 2006 12:37:05 +0000 (12:37 +0000)]
r16255: Fix 'net ads join' when the workgroup is set incorrectly
in smb.conf. This did work before the join rewrite.
Samba will have problems if you try to run any of the daemons
with an incorrect workgroup but it should not fail to join.
The summary is that a member server should always use it's
own machine name when setting up schannel since that is
the only account it has. Thanks to Volker for the discussion.
Günther Deschner [Thu, 15 Jun 2006 11:58:13 +0000 (11:58 +0000)]
r16253: Fix another host/ UPN case in (the currently unused)
cli_rpc_pipe_open_krb5.
Guenther
Volker Lendecke [Thu, 15 Jun 2006 11:44:57 +0000 (11:44 +0000)]
r16252: Fix Klocwork ID 1119, 1121.
Volker
Volker Lendecke [Thu, 15 Jun 2006 11:24:01 +0000 (11:24 +0000)]
r16251: for i in `seq 1 1000`
do
echo "I will always compile before commit :-)"
done
Also fix Klokwork ID 806.
Volker
Volker Lendecke [Thu, 15 Jun 2006 11:17:57 +0000 (11:17 +0000)]
r16250: Fix Klokwork IDs 148, 151, 152, 154.
Volker
Volker Lendecke [Thu, 15 Jun 2006 10:48:53 +0000 (10:48 +0000)]
r16249: Fix Klokwork ID 130
Volker Lendecke [Thu, 15 Jun 2006 10:12:29 +0000 (10:12 +0000)]
r16248: Fix Coverity ID 297
Volker Lendecke [Thu, 15 Jun 2006 10:06:09 +0000 (10:06 +0000)]
r16247: Fix Coverity ID 296
Jeremy Allison [Thu, 15 Jun 2006 05:32:21 +0000 (05:32 +0000)]
r16245: Cope with string being zero len. Klocwork bug #410.
Jeremy.
Jeremy Allison [Thu, 15 Jun 2006 05:20:21 +0000 (05:20 +0000)]
r16243: Fix Klocwork bugs #581 and #706, ensure we check
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
Jeremy Allison [Thu, 15 Jun 2006 01:54:09 +0000 (01:54 +0000)]
r16241: Fix Klocwork #106 and others like it.
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
Jeremy Allison [Wed, 14 Jun 2006 21:36:49 +0000 (21:36 +0000)]
r16230: Fix Klocwork #861 and others. localtime and asctime
can return NULL. Ensure we check all returns correctly.
Jeremy.
Günther Deschner [Wed, 14 Jun 2006 14:43:15 +0000 (14:43 +0000)]
r16222: Fix DEBUG statements.
Guenther
Günther Deschner [Wed, 14 Jun 2006 14:38:59 +0000 (14:38 +0000)]
r16221: No need for friednly error messages at log level 10.
Guenther
Gerald Carter [Wed, 14 Jun 2006 12:00:53 +0000 (12:00 +0000)]
r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader.
Jeremy Allison [Wed, 14 Jun 2006 02:06:28 +0000 (02:06 +0000)]
r16216: Add debug messages to make it possible to try and
debug why a job pause or resume command is not being
done.
Jeremy.
Jeremy Allison [Wed, 14 Jun 2006 00:37:52 +0000 (00:37 +0000)]
r16213: Fix Klocwork #852. iface_n_ip can potentially
return NULL. Ensure we don't deref.
Jeremy.
Jeremy Allison [Tue, 13 Jun 2006 21:21:44 +0000 (21:21 +0000)]
r16209: Klocwork bug #66, ensure no null deref.
Jeremy.
Jeremy Allison [Tue, 13 Jun 2006 21:01:08 +0000 (21:01 +0000)]
r16207: Ensure we don't allocate an OID string unless
we know we don't have an error. Klocwork #6.
Jeremy.
Gerald Carter [Tue, 13 Jun 2006 20:29:00 +0000 (20:29 +0000)]
r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: 0' so work around that
Gerald Carter [Tue, 13 Jun 2006 20:02:50 +0000 (20:02 +0000)]
r16205: Fix 'make install' when srcdir != builddir
Volker Lendecke [Tue, 13 Jun 2006 19:56:26 +0000 (19:56 +0000)]
r16204: Fix Klocwork # 14
localtime() can return NULL.
Volker
Volker Lendecke [Tue, 13 Jun 2006 19:40:28 +0000 (19:40 +0000)]
r16203: Fix potentially writing one result of strtok beyond the end of alt_path.
Found by Klocwork, ID 653.
Volker
Jeremy Allison [Tue, 13 Jun 2006 18:15:03 +0000 (18:15 +0000)]
r16202: Fix Klocwork #3. Strange - was already fixed in HEAD.
Jeremy.
Volker Lendecke [Tue, 13 Jun 2006 18:09:37 +0000 (18:09 +0000)]
r16201: Fix Klocwork 439
Jeremy Allison [Tue, 13 Jun 2006 18:09:04 +0000 (18:09 +0000)]
r16199: Fix Klocwork #1 - ensure we test the first
strtok for NULL.
Jeremy.
Volker Lendecke [Tue, 13 Jun 2006 18:06:12 +0000 (18:06 +0000)]
r16198: Fix Klocwork 1023
Volker Lendecke [Tue, 13 Jun 2006 18:01:58 +0000 (18:01 +0000)]
r16197: Fix Klocwork id 1338
Volker Lendecke [Tue, 13 Jun 2006 17:55:39 +0000 (17:55 +0000)]
r16196: A bit of defensive programming:
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where
it could be NULL. I think you can construct extreme racy conditions where this
actually could happen.
Volker
Gerald Carter [Tue, 13 Jun 2006 15:57:00 +0000 (15:57 +0000)]
r16195: starting development for 3.0.24pre1
Gerald Carter [Tue, 13 Jun 2006 15:49:22 +0000 (15:49 +0000)]
r16193: fix packaging dependency on RH platforms for the Unicode::MapUTF8 perl module (caused by upgarde in smbldap-tools)
Günther Deschner [Tue, 13 Jun 2006 14:39:52 +0000 (14:39 +0000)]
r16192: Fix timeformats in the winbind response struct.
(pam_winbind users were forced to change a password inappropriately)
Guenther
Günther Deschner [Tue, 13 Jun 2006 13:41:04 +0000 (13:41 +0000)]
r16190: Fix more memleaks.
Guenther
Günther Deschner [Tue, 13 Jun 2006 11:37:51 +0000 (11:37 +0000)]
r16187: Fix memleak.
Guenther
Volker Lendecke [Mon, 12 Jun 2006 18:32:25 +0000 (18:32 +0000)]
r16156: Fix storing NULL in the wrong place. Klocwork id's 127 and 128.
Volker
Jeremy Allison [Mon, 12 Jun 2006 15:42:43 +0000 (15:42 +0000)]
r16155: Janitor for jelmer.
Fix typo in DEBUG()
Jeremy.
Günther Deschner [Mon, 12 Jun 2006 13:59:22 +0000 (13:59 +0000)]
r16154: Fix winbind function table typo.
Guenther
Volker Lendecke [Mon, 12 Jun 2006 12:45:06 +0000 (12:45 +0000)]
r16153: Fix possible NULL dereference found by Klocwork # 252
Volker Lendecke [Mon, 12 Jun 2006 11:03:49 +0000 (11:03 +0000)]
r16150: Fix possible NULL dereference found by Klocwork ID # 17
Volker Lendecke [Sun, 11 Jun 2006 16:13:41 +0000 (16:13 +0000)]
r16141: Dummy commit to make the build farm re-test against Samba4 16140
Alexander Bokovoy [Sat, 10 Jun 2006 15:18:46 +0000 (15:18 +0000)]
r16138: By default, rootsbindir relies on SBINDIR so import it here
Alexander Bokovoy [Sat, 10 Jun 2006 15:16:01 +0000 (15:16 +0000)]
r16136: By default, rootsbindir relies on SBINDIR so import it here
Gerald Carter [Fri, 9 Jun 2006 22:06:01 +0000 (22:06 +0000)]
r16131: fix RedHat 9 spec files
Gerald Carter [Fri, 9 Jun 2006 21:57:42 +0000 (21:57 +0000)]
r16130: fix a shell portability issue for Solaris sh in installman.sh
Jeremy Allison [Fri, 9 Jun 2006 17:19:59 +0000 (17:19 +0000)]
r16126: Janitor for Volker..... This looks correct to me.
Jeremy.
Fix a parsing error that became apparent in 'make test': If we have no
group
rids in the info3 we set the array buffer pointer to "1" but fail to
actually
ship the array.
Volker.
Günther Deschner [Fri, 9 Jun 2006 13:04:47 +0000 (13:04 +0000)]
r16122: As we use 'inetOrgPerson' as structural objectclass for new accounts for
eDir, we already add 'sn' as required attribute on LDAP add
operations.
When we modify an entry, we need to request 'sn' as well in our
attribute lists, so that we don't try to add it a second time.
Guenther
Günther Deschner [Fri, 9 Jun 2006 12:55:07 +0000 (12:55 +0000)]
r16121: Fix a eDir related memory leak.
Guenther
Günther Deschner [Fri, 9 Jun 2006 11:02:52 +0000 (11:02 +0000)]
r16117: Make winbindd work again in security=ads.
We still used the old HOST/* UPN to get e.g. users, now we need
samaccountname$@REA.LM.
Guenther
James Peach [Fri, 9 Jun 2006 10:50:45 +0000 (10:50 +0000)]
r16116: Hoist the slow CLOCK_REALTIME message inside the branch so we never
confuse an uninitialised __profile_clock with CLOCK_REALTIME. Flip the
condition argument to SMB_WARN around so that it's correct (though
completely non-intuitive).
Günther Deschner [Fri, 9 Jun 2006 10:50:28 +0000 (10:50 +0000)]
r16115: Make "net ads changetrustpw" work again.
(adapt to the new UPN/SPN scheme).
Guenther
Günther Deschner [Fri, 9 Jun 2006 10:33:29 +0000 (10:33 +0000)]
r16114: Make winbindd's group enumeration (set|get|endgrent) work again (when
enabled).
Do not bail out when a group just has 0 members.
Jeremy, please check, this has been removed with r13915.
Guenther
Jeremy Allison [Fri, 9 Jun 2006 01:36:58 +0000 (01:36 +0000)]
r16112: Added Volker's fix for extra odd byte at the end
of UNIX_BASIC infolevel. Checked client implementations
(cifsfs and libsmb) and they ignore it. Thanks Volker.
Jeremy.
James Peach [Fri, 9 Jun 2006 01:02:54 +0000 (01:02 +0000)]
r16111: Patch from Björn JACKE <samba@j3e.de>.
This fixes a problem where the clock definition for clock_gettime() is
present at compile time, but is not available on the running system. In
this case, we fall back to less-preferred clocks until we find one that
we can use.
Paul Green [Thu, 8 Jun 2006 18:41:15 +0000 (18:41 +0000)]
r16103: Properly rebuild timelimit on systems with executable extensions.
Paul
Günther Deschner [Wed, 7 Jun 2006 13:06:49 +0000 (13:06 +0000)]
r16080: Re-add accidentially excluded in-forest domain trusts (fixes bug #3823).
Guenther
Gerald Carter [Wed, 7 Jun 2006 12:35:16 +0000 (12:35 +0000)]
r16079: How embarassing. :-( Broke the build.
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
I will *always* compile before checking in...
Gerald Carter [Wed, 7 Jun 2006 12:01:54 +0000 (12:01 +0000)]
r16078: Patch from Aleksey Fedoseev <fedoseev@ru.ibm.com> to correctly
set the type of 'acl compatibility from string to integer
after the changes in r14207.
Jeremy Allison [Wed, 7 Jun 2006 04:45:50 +0000 (04:45 +0000)]
r16076: Fix for machine password timeout overflow from Shlomi Yaakobovich
<Shlomi@exanet.com>.
Jeremy.
Volker Lendecke [Tue, 6 Jun 2006 20:34:26 +0000 (20:34 +0000)]
r16065: Re-add a strlower_m(account) in samr_create_user that was dropped for no
reason but to increase fidelity with W2k3. Tom Bork has raised valid concerns
that Unix scripts might rely on the account names being lower-case, so keep
that. We might later decide to only lower-case the unix name passed to
'add [user|group] script' but keep the passdb entry upper-case. But there are
enough user-visible changes in 3_0 already so that we should push this off to
a later date.
Tom, waiting for more bug reports from you ;-))
Thanks for insisting!
Volker
Volker Lendecke [Tue, 6 Jun 2006 20:18:11 +0000 (20:18 +0000)]
r16064: Bug fix for another one Tom Bork has reported:
'valid users = +unixgroup' failed with smbpasswd if 'unixgroup' has a
(non-algorithmic) group mapping.
Thanks a lot!
People out there listening, please test current code, this release is
**BIG**
:-)
Volker
Volker Lendecke [Tue, 6 Jun 2006 14:18:12 +0000 (14:18 +0000)]
r16060: This is one of the more dirty patches I've put in lately. Parse enough of
SetUserInfo level 25 to survive the join method XP uses if the user did not
exist before. For good taste this contains way too much cut&paste, but for a
real fix there is just not enough time.
Up to 3.0.22 we completely ignored that a full level 21 is being sent together
with level 25, but we got away with that because on creation we did not set
the "disabled" flag on the workstation account. Now we correctly follow W2k3
in this regard, and we end up with a disabled workstation after join.
Man, I hate rpc_parse/. The correct fix would be to import PIDL generated samr
parsing, but this is would probably be a bit too much for .23...
Thanks to Tom Bork for finding this one.
Volker
James Peach [Tue, 6 Jun 2006 07:43:17 +0000 (07:43 +0000)]
r16057: Coalesce the DMAPI configure tests into a single macro. Add
a more specific probe to try and eliminate old, incompatible
DMAPI implementations provided by IRIX 6.4 and AIX 4.3.
Jeremy Allison [Tue, 6 Jun 2006 00:34:26 +0000 (00:34 +0000)]
r16054: Janitor for Volker ? Volker - some reason you didn't
fix this in 3.0 ?
Jeremy.
We had no way to return NT_STATUS_OK from the netlogon serverpwset,
although
we successfully set the machine password...
One thing the samba3 join test found.
Volker