Andrew Tridgell [Mon, 11 Sep 2000 07:03:10 +0000 (07:03 +0000)]
a simple test program I use to test the debug message system
Andrew Tridgell [Mon, 11 Sep 2000 07:02:43 +0000 (07:02 +0000)]
the first cut of the internal messaging system.
The motivation for this system is to replace the UDP message for
oplocks, but this commit only does the "set debug level" message.
Jeremy Allison [Sat, 9 Sep 2000 00:19:35 +0000 (00:19 +0000)]
Implemented DELETEPRINTERDATA (tested with Gerald's Win32 progs).
Jeremy.
Jeremy Allison [Fri, 8 Sep 2000 21:24:45 +0000 (21:24 +0000)]
Fixed up get_a_printer_driver_3 so it looks in the tdb using the correct
key name for a driver info. Version needs to be adjusted in the same
way that it is adjusted when the driver info is stored in the tdb.
AddPrinterConnection() Win32 call caught this one.
Jeremy.
Jeremy Allison [Fri, 8 Sep 2000 02:20:48 +0000 (02:20 +0000)]
Fixed typo where docname was being checked for datatype - was causing
STARTDOCPRINTER call to fail. I *love* Gerald's test code :-).
Jeremy.
Jeremy Allison [Fri, 8 Sep 2000 00:28:07 +0000 (00:28 +0000)]
Win32 API is explicit that EnumPrinterData returns ERROR_MORE_DATA not
ERROR_INSUFICIENT_BUFFER when working out what space is needed. This fix
gives us the same return that WinNT does.
Jeremy.
Jeremy Allison [Thu, 7 Sep 2000 20:56:24 +0000 (20:56 +0000)]
Fixed the printerdata code to return NO_MORE_ITEMS if a size is requested
and the parameter index doesn't exist. I think this code can be simplified
considerably, but JF needs to check to be sure.
Jeremy.
Jeremy Allison [Thu, 7 Sep 2000 19:12:59 +0000 (19:12 +0000)]
Added code to return NO_MORE_ENTRIES when trying to determine
size using "NT mega hack". I think this is the correct thing to
do but JF should also examine the.
Jeremy.
Tim Potter [Thu, 7 Sep 2000 08:43:05 +0000 (08:43 +0000)]
Hopefully this should fix the primary group permission problem.
Jeremy Allison [Wed, 6 Sep 2000 23:20:35 +0000 (23:20 +0000)]
Temporary fix to convert from level6 (Win2k) to level 3 (NT4)
for driver download files.
Jeremy.
Jeremy Allison [Wed, 6 Sep 2000 01:55:36 +0000 (01:55 +0000)]
Fix from John Reilly for double free of printer struct.
Jeremy.
Jeremy Allison [Wed, 6 Sep 2000 01:06:39 +0000 (01:06 +0000)]
Fix for the SID history problem when using a Win2k domain controller
with security=domain. Also fixed to dynamically allocate the SIDs and GIDs.
Jeremy.
Jeremy Allison [Tue, 5 Sep 2000 20:56:09 +0000 (20:56 +0000)]
Implemented GETFORM tested and working using Gerald's Win32 test progs....
Jeremy.
David O'Neill [Fri, 1 Sep 2000 18:49:26 +0000 (18:49 +0000)]
Changes from APPLIANCE_HEAD (per Tim Potter):
- make proto
- addition of function to convert from errno values to NT status codes
(source/lib/error.c)
- purge queue done without full access permission will purge only the
jobs owned by that user, rather than failing.
- unlock job database tdb before sending job to printer
- in print_job_start(), ensure that we don't pick a jobid with an existing
temporary file that may be owned by another user, as it causes silent
failures.
- fixes for printer permission checking for NT5 clients
(source/include/rpc_spoolss.h, source/printing/nt_printing.c,
source/printing/printing.c, source/rpc_server/srv_spoolss_nt.c)
- change from uint8 to 'enum SID_NAME_USE' (source/rpc_server/srv_lsa.c)
- fixed memory leaks for win95 driver download process
(source/smbd/lanman.c)
- properly free prs_structs and dacl in testsuite/printing/psec.c
Jeremy Allison [Fri, 1 Sep 2000 17:13:44 +0000 (17:13 +0000)]
Fix from John Reilly @ HP for my typo with the parameters being reversed. Ooops.
Jeremy.
Gerald Carter [Fri, 1 Sep 2000 06:25:15 +0000 (06:25 +0000)]
-U% should be an anonymous connection. Fixed bug where
the password was being set to "" instead of NULL.
..and yes Elrond, I'll merge this into TNG.
P
jerry
Tim Potter [Fri, 1 Sep 2000 02:06:20 +0000 (02:06 +0000)]
Fix for swat to return correct MIME type for text files. From "Ron
Alexander" <rcalex@home.com>
Jeremy Allison [Thu, 31 Aug 2000 19:04:51 +0000 (19:04 +0000)]
Implemented DELETEFORM tested using Gerald's Win32 test code :-).
Jeremy.
Andrew Tridgell [Thu, 31 Aug 2000 07:11:59 +0000 (07:11 +0000)]
make sure a couple of variables are initialised
Andrew Tridgell [Thu, 31 Aug 2000 07:11:45 +0000 (07:11 +0000)]
fixed "admin users" option with new security code
Tim Potter [Thu, 31 Aug 2000 04:27:38 +0000 (04:27 +0000)]
Removed compiler warning.
Jeremy Allison [Wed, 30 Aug 2000 22:54:54 +0000 (22:54 +0000)]
Fixed overrun write error when using debuglevel > 50.
Jeremy.
Jeremy Allison [Wed, 30 Aug 2000 21:09:21 +0000 (21:09 +0000)]
Fixed error returns for moving printer driver files around so generic
"Access denied" isn't always returned. More fixes found using Gerald's
wonderful Win32 test progs :-).
Jeremy.
Jeremy Allison [Wed, 30 Aug 2000 18:33:56 +0000 (18:33 +0000)]
Added vfs_unlink call to ensure vfs is used on unlink from client.
Jeremy.
Jeremy Allison [Wed, 30 Aug 2000 17:34:35 +0000 (17:34 +0000)]
Fix for bind interfaces only sometimes picking the wrong IP address
for a name query. From Steve Langasek <vorlon@netexpress.net>.
Jeremy.
Jeremy Allison [Wed, 30 Aug 2000 00:45:59 +0000 (00:45 +0000)]
Implemented AbortPrinter() from Gerald's Win32 test code. Just purge all
possible printjobs from that printer (I think this is correct).
Added error code returns for print_queue_XXX() functions.
Jeremy.
Gerald Carter [Tue, 29 Aug 2000 16:47:20 +0000 (16:47 +0000)]
missed removing the static declaration of strwicmp()
jerry
Gerald Carter [Tue, 29 Aug 2000 14:57:37 +0000 (14:57 +0000)]
make proto
Gerald Carter [Tue, 29 Aug 2000 14:43:42 +0000 (14:43 +0000)]
added -P (for no prompt) and -A <authfile> options
jerry
Gerald Carter [Tue, 29 Aug 2000 14:42:10 +0000 (14:42 +0000)]
added a #define for SPOOLSSGETPRINTERDATAEX. Although we do not
support the RPC yte (win2k specific), I added it for documentation
purposes.
jerry
Gerald Carter [Tue, 29 Aug 2000 14:38:38 +0000 (14:38 +0000)]
fixed previous bug spotted by Elrond in get_printerdrivernumber().
Thought I had already committed this.
jerry
Gerald Carter [Tue, 29 Aug 2000 14:35:31 +0000 (14:35 +0000)]
added -A <authfile> option to smbclient for the reading of username /
password credentials from a file.
--jerry
Gerald Carter [Tue, 29 Aug 2000 14:33:39 +0000 (14:33 +0000)]
needed to use strwicmp() in smbclient code, so I moved it to util_str.c
and made it non-static
--jerry
Gerald Carter [Tue, 29 Aug 2000 14:32:23 +0000 (14:32 +0000)]
make rpcclent by default.
--jerry
Gerald Carter [Tue, 29 Aug 2000 14:31:27 +0000 (14:31 +0000)]
added the -A <authfile> option for allowing the reading of user
name and password credentials from a file. Designed for use
when needed to passwd credentials between scripts
--jerry
Gerald Carter [Tue, 29 Aug 2000 14:29:53 +0000 (14:29 +0000)]
first draft at rpcclient man page for HEAD branch. Taken heavily
from the man page in TNG. Updated for newer spoolss commands.
jerry
Jeremy Allison [Tue, 29 Aug 2000 00:29:15 +0000 (00:29 +0000)]
This doesn't compile but is a placeholder for moving the UNIX
acl code over to POSIX acls.
Jeremy.
Jeremy Allison [Mon, 28 Aug 2000 20:45:00 +0000 (20:45 +0000)]
smbd/password.c: Fixed typo in Tim's new code that caused insure overrun error.
smbd/reply.c: Fixed lowercasing UNIX character set problem.
Jeremy.
Herb Lewis [Mon, 28 Aug 2000 18:58:46 +0000 (18:58 +0000)]
added a little description of useage and output format since this gives
more info than just what parameters are not supported by SWAT.
Gerald Carter [Mon, 28 Aug 2000 13:41:46 +0000 (13:41 +0000)]
fixed typos spotted by Ron Alexander <rcalex@home.com>
--jerry
Gerald Carter [Mon, 28 Aug 2000 13:35:10 +0000 (13:35 +0000)]
script written by herb for reporting which smb.conf parameters
are in loarparm.c but not supported by SWAT. I just thought it looked fun.
:-)
--jerry
Tim Potter [Mon, 28 Aug 2000 07:25:18 +0000 (07:25 +0000)]
Merge bug - still getting used to dirdiff.
Tim Potter [Mon, 28 Aug 2000 06:50:45 +0000 (06:50 +0000)]
Oops - missed a file.
Tim Potter [Mon, 28 Aug 2000 06:46:53 +0000 (06:46 +0000)]
Merge from appliance branch.
Andrew Tridgell [Mon, 28 Aug 2000 04:42:31 +0000 (04:42 +0000)]
yipee!
The spoolss AddJob function has an [in,out] buffer not an [in] buffer
(despite the comment in the code to the contrary). Also, we must fail
this function - not just blindly reply "no problem" as AddJob should
always fail on non-local printers.
This fixes a bug where the "print test page" failed about half the
time. I suspect it will also fix a bunch of other intermittent spoolss
bugs where the client (incorrectly) tries to use the AddJob printing
interface.
Andrew Tridgell [Mon, 28 Aug 2000 03:17:22 +0000 (03:17 +0000)]
made reopen_logs() always re-open logs, not try and be smart about not
re-opening in some circumstances. This fixes a problem where a HUP
does not re-open logs and leaves the log open on a unlinked file.
Andrew Tridgell [Mon, 28 Aug 2000 02:06:25 +0000 (02:06 +0000)]
arrgh.
whoever added "auto" parameters in loadparam only supported "True", "False"
and "Auto", and did not support "Yes" and "No" like booleans. This
means anyone using "preferred master = yes" didn't get what they
expected!
Jeremy Allison [Fri, 25 Aug 2000 20:44:33 +0000 (20:44 +0000)]
vfs write data fix. Fix for name matching in addtosmbpass
Jeremy.
Tim Potter [Fri, 25 Aug 2000 04:18:50 +0000 (04:18 +0000)]
Replaced "\\MAILSLOT\\NET\\NETLOGON" with NET_LOGON_MAILSLOT constant.
Andrew Tridgell [Fri, 25 Aug 2000 03:58:02 +0000 (03:58 +0000)]
- fixed the %U macro so that the old (and documented) semantics work
again. This got broken with one of the substitute.c updates a couple
of months ago.
- also fixed %u to return the username from the current_user structure
when called via a method that does not have direct access to the
username. I cache the uidtoname() result to prevent thrashing nss.
Tim Potter [Fri, 25 Aug 2000 00:55:27 +0000 (00:55 +0000)]
Updated file with version in TNG.
Jeremy Allison [Thu, 24 Aug 2000 19:48:31 +0000 (19:48 +0000)]
Modified to use sid_to_uid and sid_to_gid. Now ready for POSIX ACL
code....
Jeremy.
Jeremy Allison [Wed, 23 Aug 2000 23:05:49 +0000 (23:05 +0000)]
Tidied up some error returns from printing calls. Still need to map UNIX
errors to NT error for print job failure returns. Patch from John Reilly at HP.
Jeremy.
Jeremy Allison [Wed, 23 Aug 2000 17:38:52 +0000 (17:38 +0000)]
Documentation on NT_USER_TOKEN. Requested by Sander.
Jeremy.
Jeremy Allison [Wed, 23 Aug 2000 00:45:40 +0000 (00:45 +0000)]
Added code to do SID to uid/gid conversion. Needed for ACL support.
Jeremy.
Tim Potter [Tue, 22 Aug 2000 06:28:33 +0000 (06:28 +0000)]
Patch from John Reilly <jreilly@hp.com> for not processing duplicate files
when moving printer driver to download area.
Jeremy Allison [Mon, 21 Aug 2000 19:30:19 +0000 (19:30 +0000)]
Fix for safe_free freeing static strings. From Robert August Vincent, II.
Jeremy.
Luke Leighton [Fri, 18 Aug 2000 06:27:24 +0000 (06:27 +0000)]
oops. must return "" string and length zero when strlen(filebuf) == 0
Gerald Carter [Fri, 18 Aug 2000 06:03:13 +0000 (06:03 +0000)]
fixed an off by one error where I was tromping on memory
when initializing a driver_info_3 struct. See spoolss_addprinterdriver()
jerry
Gerald Carter [Fri, 18 Aug 2000 05:57:09 +0000 (05:57 +0000)]
fixed initialization errors (again!) I must have forgot to
check these in before.
jerry
Luke Leighton [Fri, 18 Aug 2000 05:56:19 +0000 (05:56 +0000)]
getfileline() - line with length of zero -> filebuf[strlen(filebuf)-1]
is NOT ok.
Gerald Carter [Fri, 18 Aug 2000 05:55:37 +0000 (05:55 +0000)]
changing some debug message levels
j-
Gerald Carter [Thu, 17 Aug 2000 20:05:05 +0000 (20:05 +0000)]
Fix for Win9x driver downloads when information is
stored in the TDB. See the message I posted about
this on samba-technical
* If the admin does not desire the new NT print driver
support, nothing needs to be done. All existing
parameters work the same.
* If the admin wants to take advantage of NT printer
driver support but does not want to migrate the 9x drivers
to the new setup, the leave the existing printers.def
file. When smbd attempts to locate a 9x driver for the
printer in the TDB and fails it will drop down to
using the printers.def (and all associated parameters).
The make_printerdef tool will also remain for backwards
compatibility but will be moved to the "this tool is the
old way of doing it" pile.
* If the admin installs a 9x driver for a printer on
a Samba host (in the printing TDB), this information will
take precedence and the three old printing parameters
will be ignored (including print driver location).
* If an admin wants to migrate the printers.def file into
the new setup, I can write a script to do this using
rpcclient. The main problem is the driver namespace
(we need the NT driver name first in order to
be consistent).
jerry
Gerald Carter [Thu, 17 Aug 2000 20:03:53 +0000 (20:03 +0000)]
added comment for my own memory purposes
jerry
Gerald Carter [Wed, 16 Aug 2000 03:44:04 +0000 (03:44 +0000)]
hack for unmarshalling unistr's on machines with BIG_ENDIAN arch
I think we have a lot more of these bugs lurking (i'm fairly
confident of it).
jerry
Gerald Carter [Wed, 16 Aug 2000 03:41:02 +0000 (03:41 +0000)]
- fixed memcpy bug in copy_unistr2()
- init_unistr2_from_unistr() does not NULL terminate
the buffer
--jerry
Gerald Carter [Wed, 16 Aug 2000 03:38:52 +0000 (03:38 +0000)]
fixed unitialized struct bug in enum_users (whatever it is called)
jerry
Gerald Carter [Wed, 16 Aug 2000 03:34:58 +0000 (03:34 +0000)]
fixed typo.
jerry
Gerald Carter [Tue, 15 Aug 2000 23:36:05 +0000 (23:36 +0000)]
fixed error in [public] spotted by Ron Alexander <rcalex@home.com>
changed to read only = yes
jerry
Tim Potter [Tue, 15 Aug 2000 21:09:54 +0000 (21:09 +0000)]
Merge ... uninitialised variable fix from APPLIANCE_HEAD.
Jeremy Allison [Tue, 15 Aug 2000 02:33:27 +0000 (02:33 +0000)]
Tidied up extra ()'s.
Jeremy
Jeremy Allison [Mon, 14 Aug 2000 23:48:07 +0000 (23:48 +0000)]
Reverted the change Luke made. Removed IS_BITS_SET_XX macros.
Do not re-add them. These macros are unsafe as they are not understood.
Change all TNG code using them to correct '&' and '|' please.
IS_BITS_SET_ALL was being used in cmd_interp.c when IS_BITS_SET_SOME
should have been used.
Jeremy.
Tim Potter [Mon, 14 Aug 2000 21:27:54 +0000 (21:27 +0000)]
Merge.
Gerald Carter [Mon, 14 Aug 2000 21:18:02 +0000 (21:18 +0000)]
fixed a few bugs in new_smb_io_relarraystr().
Marshalling code path now uses spoolss_smb_io_unistr()
also caught a NULL pointer case.
i'll update TNG later.
Tim Potter [Mon, 14 Aug 2000 18:39:51 +0000 (18:39 +0000)]
NT printer permissions test program.
Luke Leighton [Mon, 14 Aug 2000 11:03:30 +0000 (11:03 +0000)]
restored IS_BITS_SET_xxx macros.
Luke Leighton [Mon, 14 Aug 2000 07:37:12 +0000 (07:37 +0000)]
hey, jerry: turns out you _have_ converted to get_safe_nt_errmsg!!!
[got confused with which way dirdiff was going :)].
... but you forgot to update TNG's lib/cmd_interp.c...
Luke Leighton [Mon, 14 Aug 2000 07:33:34 +0000 (07:33 +0000)]
jeremy,
please do not remove IS_BITS_SET_XXX macros just because you happen
"not to like them". whilst still working on merging, you are not
responsible for this code, therefore do not hinder its development
whilst people are attempting to do merges. after the merge from
TNG to cvs main is completed, you can do what the hell you like.
thank you.
jerry,
please could you consider adding underlying routines (in this case
get_safe_smb_errstr()) instead of reverting to a [less secure]
previous coding method. thanks.
Gerald Carter [Mon, 14 Aug 2000 03:18:17 +0000 (03:18 +0000)]
minor formatting fixes.
jerry
Gerald Carter [Mon, 14 Aug 2000 03:17:17 +0000 (03:17 +0000)]
fix for new_smb_io_relarraystr() and new_smb_io_relstr()
to use spool_smb_io_unistr() as this does not call prs_align()
befrore parsing the UNISTR.
Parsing a void* buffer from an RPC should not be aligned
on 4 byte boundaries. Don't think this change affects
any marshalling code, only unmarshalling...
jerry
Gerald Carter [Sat, 12 Aug 2000 14:51:36 +0000 (14:51 +0000)]
removed the prs_align in spoolss_smb_io_unistr() (JF, please check)
as it was throwing things off when parsing buffers passed in SPOOLSS
RPCs
fixed the unmarshalling of UNISTR arrays to be double NULL terminated
jerry
Gerald Carter [Sat, 12 Aug 2000 14:31:29 +0000 (14:31 +0000)]
fixes to prs_unistr UNMARSHALLING only. Problem was due to talloc's
of 0 bytes.
jerry
Gerald Carter [Sat, 12 Aug 2000 14:26:01 +0000 (14:26 +0000)]
FIxed some unmarshalling problems with relstr and unistr arrays
jerry
Gerald Carter [Sat, 12 Aug 2000 14:20:40 +0000 (14:20 +0000)]
fixed unistr_to_ascii to deal with NULL src strings
jerry
Gerald Carter [Sat, 12 Aug 2000 14:14:40 +0000 (14:14 +0000)]
reworked talloc() to in order to help track down invalid
memory access.
Tridge, I don't think using 0xdeadbeef for size allocations
of 0 is going to work. I ended up having to use NULL
as much code that works on UNISTR checks to see if the buffer ptr
is NULL. So valid code ends up with a seg fault.
Rather than rewriting it all, I added a DEBUG_TALLOC
#ifdef in talloc.h that sets a macro BAD_PTR.
This is the value assigned to ptr for an allocation of 0 bytes.
jerry
Gerald Carter [Sat, 12 Aug 2000 14:10:27 +0000 (14:10 +0000)]
removed (void) typecast from SMB_ASSERT
jerry
John Terpstra [Sat, 12 Aug 2000 02:41:42 +0000 (02:41 +0000)]
Updated by Patrick Powell <papowell@lprng.org>
Jeremy Allison [Fri, 11 Aug 2000 23:13:09 +0000 (23:13 +0000)]
Fixed the problem with UNISTR marshalling in a buffer5 struct.
The smb_io_unistr() code called a prs_align, this was not being
counted in the size or taken account of in the offset calculation.
Fixed size_ calculation to always return a size a multiple of 4
and also set the offset correctly. This fixes the problem I saw
and will hopefully fix the problem HP reported. JF please check
this change.
Jeremy.
Christopher R. Hertel [Fri, 11 Aug 2000 22:29:44 +0000 (22:29 +0000)]
First shot at actually *doing* WINS failover.
If libsmb/namequery.c:name_query() times out while doing a non-broadcast
query, I mark that WINS server 'dead'. Note that I don't try the new
WINS server. I think I can get that working too.
This is only for queries, not registrations. The biggest problem is that
I may have to fiddle with the UNICAST SUBNET, but I need to check talk
that over with someone (Jeremy?) before I hack at it.
I can't actually test the above change, I'm 'fraid. I'm getting:
4 errors detected in the compilation of "rpc_server/srv_spoolss_nt.c".
in head branch.
Chris -)-----
Jeremy Allison [Fri, 11 Aug 2000 00:53:13 +0000 (00:53 +0000)]
Fix case where volumename could be returned as UNIX charset or DOS codepage
depending on where it came from.
Jeremy.
Jeremy Allison [Thu, 10 Aug 2000 23:41:16 +0000 (23:41 +0000)]
Added "add_printer_hook" call to update printer for Win9x clients.
Patch from John Reilly <jreilly@hp.com>.
Jeremy.
Jeremy Allison [Thu, 10 Aug 2000 19:51:45 +0000 (19:51 +0000)]
Tidied up security rights definitions.
Jeremy.
Jeremy Allison [Thu, 10 Aug 2000 17:48:15 +0000 (17:48 +0000)]
Removed requirement that sid have an owner before being interpreted.
Thanks to Elrond for pointing this out.
Jeremy.
Gerald Carter [Thu, 10 Aug 2000 14:05:19 +0000 (14:05 +0000)]
Working on spoolss_getprinterdriver() as it does not display all the
dependentfiles.
jery
Gerald Carter [Thu, 10 Aug 2000 14:03:13 +0000 (14:03 +0000)]
working on the unmarshalling of dependentfiles to a DRIVER_INFO_3
struct. Not wuite there.
jerry
Gerald Carter [Thu, 10 Aug 2000 14:02:07 +0000 (14:02 +0000)]
code formatting cleanup
jerry
Gerald Carter [Thu, 10 Aug 2000 14:00:40 +0000 (14:00 +0000)]
deal with allocation size of 0 in prs_unistr when UNMARSHALLING
jerry
Gerald Carter [Thu, 10 Aug 2000 14:00:05 +0000 (14:00 +0000)]
Deal will NULL UNISTR in unistr_to_ascii
jerry
Gerald Carter [Thu, 10 Aug 2000 13:58:15 +0000 (13:58 +0000)]
talloc returns 0xdeadbeef when asked to allocate 0 bytes
jerry
Gerald Carter [Thu, 10 Aug 2000 04:10:29 +0000 (04:10 +0000)]
Needed to add the SHARED attribute bit when creating a printer
on a Samba host. Also needed to add an option to pass the share
name (printer name) on the command line.
And fixed the checking of the return code for spoolss_r_addprinterex()
jerry