Jeremy Allison [Sun, 11 Mar 2007 02:33:17 +0000 (02:33 +0000)]
r21783: Add in the "create info" field to the reply
from POSIX_OPEN and POSIX_MKDIR as specified
by Stevef in the wikki (extra 4 byte field).
Also fix horrible bug in James's code (James
you should review this for your Apple patch
tree) where he failed to allocate the correct
return memory size when returning a INFO2
struct. Added #define for the size of the
INFO2 struct and made sure we allocate the
correct size for return.
Jeremy.
Volker Lendecke [Sat, 10 Mar 2007 18:04:47 +0000 (18:04 +0000)]
r21782: Fix a memleak
Herb Lewis [Fri, 9 Mar 2007 19:48:50 +0000 (19:48 +0000)]
r21780: let smbcontrol use POPT_COMMON_SAMBA options to allow setting debug
level. Fix calculation of argc after options are stripped. I couldn't
find a popt function that returned this.
James Peach [Fri, 9 Mar 2007 19:28:35 +0000 (19:28 +0000)]
r21779: I missd a call to krb5_get_init_creds_opt_alloc in r21778.
James Peach [Fri, 9 Mar 2007 18:51:48 +0000 (18:51 +0000)]
r21778: Wrap calls to krb5_get_init_creds_opt_free to handle the different
calling convention in the latest MIT changes. Apparantly Heimdal
is also changing to this calling convention.
Jeremy Allison [Fri, 9 Mar 2007 18:33:16 +0000 (18:33 +0000)]
r21777: As Stevef requested and the Apple guys agreed, make
mode_t in posix_open/posix_mkdir -> 8 bytes to match
the SET_UNIX_INFO_BASIC call. Steve is updating the
Wikki.
Jeremy.
Simo Sorce [Fri, 9 Mar 2007 16:55:56 +0000 (16:55 +0000)]
r21776: fix bugs #4438 #4440
Herb Lewis [Fri, 9 Mar 2007 15:34:12 +0000 (15:34 +0000)]
r21775: make messages more understandable - don't leave part dangling after newline
Günther Deschner [Fri, 9 Mar 2007 11:34:24 +0000 (11:34 +0000)]
r21774: Fix the build with Fedora Core 6.
tridge/vl: please check.
Guenther
Jeremy Allison [Fri, 9 Mar 2007 02:40:49 +0000 (02:40 +0000)]
r21770: For old DOS style searches we must remember if
the initial search had a wildcard in order to
correctly return no error on end of search.
Found by Samba4 torture tester.
Jeremy.
Jeremy Allison [Fri, 9 Mar 2007 02:16:03 +0000 (02:16 +0000)]
r21769: Attempt to fix bug #4384 in old search code.
We were accessing a pathname that hadn't gone
through unix_convert ! That's a big no-no...
Jeremy.
Jeremy Allison [Thu, 8 Mar 2007 23:54:57 +0000 (23:54 +0000)]
r21768: Fix the client dfs code such that smbclient can
process deep dfs links (ie. links that go to non root
parts of a share). Make the directory handling conanonical
in POSIX and Windows pathname processing.
dfs should not be fully working in client tools. Please
bug me if not.
Jeremy.
James Peach [Thu, 8 Mar 2007 21:30:15 +0000 (21:30 +0000)]
r21767: Revert all the bits I accidentally committed in r21766.
James Peach [Thu, 8 Mar 2007 20:54:13 +0000 (20:54 +0000)]
r21766: Fix compiler warning.
James Peach [Thu, 8 Mar 2007 18:45:44 +0000 (18:45 +0000)]
r21765: Fix the build for HP-UX.
Jeremy Allison [Thu, 8 Mar 2007 18:43:39 +0000 (18:43 +0000)]
r21764: Fix warning in debug comment.
Jeremy.
James Peach [Thu, 8 Mar 2007 18:05:55 +0000 (18:05 +0000)]
r21763: Add support for the UNIX_INFO2 infolevel.
James Peach [Thu, 8 Mar 2007 17:06:16 +0000 (17:06 +0000)]
r21762: Fix the build by enabling shared modules and adding the config.*
files. Add norify_watch and chflags operations. Fix a bunch of
warnings.
Jeremy Allison [Thu, 8 Mar 2007 03:00:42 +0000 (03:00 +0000)]
r21759: Fix the same bug in a more elegant way, strrchr_m
is an expensive call....
Jeremy.
Jeremy Allison [Thu, 8 Mar 2007 02:51:41 +0000 (02:51 +0000)]
r21758: Fix a very specific dfs bug when passing in POSIX
pathnames. When we're working out how much we've
consumed we need to backtrack by either a '/' or '\\'
component, as both are valid separators.
Jeremy.
James Peach [Thu, 8 Mar 2007 01:40:49 +0000 (01:40 +0000)]
r21757: Add SMB_VFS_CHFLAGS operation.
Jeremy Allison [Wed, 7 Mar 2007 23:58:40 +0000 (23:58 +0000)]
r21756: An invarient the dfs code depended on for POSIX paths
is no longer true, so fix it.
Jeremy.
Jeremy Allison [Wed, 7 Mar 2007 22:29:21 +0000 (22:29 +0000)]
r21755: Memory leak fixes from Zack Kirsch <zack.kirsch@isilon.com>.
Jeremy.
Jeremy Allison [Wed, 7 Mar 2007 22:12:58 +0000 (22:12 +0000)]
r21754: Volker is completely correct. There's no need for
the RESOLVE_DFSPATH macros and their varients
any more. Fix reporting profile bug with all
error returns.
Jeremy.
Volker Lendecke [Wed, 7 Mar 2007 21:13:51 +0000 (21:13 +0000)]
r21753: Enable building ndrdump with the builtin popt. Jelmer, please check!
Jeremy Allison [Wed, 7 Mar 2007 19:45:22 +0000 (19:45 +0000)]
r21750: Sync up with SAMBA_3_0_25. Only client changes are in libsmbclient
right now.
Jeremy.
Volker Lendecke [Wed, 7 Mar 2007 14:25:07 +0000 (14:25 +0000)]
r21748: More cosmetic alignment. One change to call_nt_transact_create(): We were
asking open_file_ntcreate for a batch oplock if the client asked us to do so,
even if it did not ask for an oplock in the first place. Did not test it, but
I think this is bogus anyway.
Volker
Volker Lendecke [Wed, 7 Mar 2007 13:57:32 +0000 (13:57 +0000)]
r21747: Cosmetic checkin to bring ntcreate and nttranscreate closer together
James Peach [Wed, 7 Mar 2007 05:09:37 +0000 (05:09 +0000)]
r21738: Remove unused file.
Jeremy Allison [Wed, 7 Mar 2007 02:27:54 +0000 (02:27 +0000)]
r21734: Fix bug #4369. Patch from David Leonard <dleonard@vintela.com>.
Jeremy.
Jeremy Allison [Wed, 7 Mar 2007 01:28:19 +0000 (01:28 +0000)]
r21731: Fix long-standing bug in our chain processing code.
Should fix a bug with WinPE. Probably a candidate
for the Vista patchset.
Jeremy.
Jeremy Allison [Tue, 6 Mar 2007 22:14:09 +0000 (22:14 +0000)]
r21726: Fix stupid cut-n-paste typo. Thanks to volker for
being on the ball..... :-).
Jeremy.
Jeremy Allison [Tue, 6 Mar 2007 22:01:03 +0000 (22:01 +0000)]
r21725: Fix for memalign used without test guards. Was
breaking the build on *BSD's. Tested by Herb.
Jeremy.
Jeremy Allison [Tue, 6 Mar 2007 21:59:51 +0000 (21:59 +0000)]
r21724: Optimization pointed out by Volker. If we don't
have any outstanding locks or blocking locks then
we don't need to read the lock db. on close.
Jeremy.
Volker Lendecke [Tue, 6 Mar 2007 10:40:18 +0000 (10:40 +0000)]
r21723: Make use of the per-hashchain "freelists"
Volker Lendecke [Tue, 6 Mar 2007 10:11:15 +0000 (10:11 +0000)]
r21722: Add the dead record functionality presented on samba-technical@samba.org. If
you do a tdb_set_max_dead(tdb, n), then for this tdb a delete operation will
only mark a record as dead and re-use it if a new record is created. The
parameter n allows for at most n dead records per hash chain. If this number
is exceeded, all dead records are put on the central freelist.
Volker
James Peach [Tue, 6 Mar 2007 00:54:05 +0000 (00:54 +0000)]
r21717: Support the SMB_QUERY_POSIX_WHOAMI info level on QueryFsInfo.
Jeremy Allison [Tue, 6 Mar 2007 00:20:32 +0000 (00:20 +0000)]
r21715: Fix torture utime code.
Jeremy.
Jeremy Allison [Mon, 5 Mar 2007 23:40:03 +0000 (23:40 +0000)]
r21714: Change the VFS interface to use struct timespec
for utimes - change the call to ntimes. This preserves
nsec timestamps we get from stat (if the system supports
it) and only maps back down to usec or sec resolution
on time set. Looks bigger than it is as I had to move
lots of internal code from using time_t and struct utimebuf
to struct timespec.
Jeremy.
Volker Lendecke [Mon, 5 Mar 2007 20:09:27 +0000 (20:09 +0000)]
r21706: get_delete_on_close_flag() is the perfect candidate for tdb_parse_record()
Herb Lewis [Mon, 5 Mar 2007 18:27:20 +0000 (18:27 +0000)]
r21705: add modify rights defines
Herb Lewis [Mon, 5 Mar 2007 18:20:36 +0000 (18:20 +0000)]
r21704: open sockets immediately in process_loop
Herb Lewis [Mon, 5 Mar 2007 17:02:20 +0000 (17:02 +0000)]
r21703: fix build when O_SYNC not defined
Jeremy Allison [Sat, 3 Mar 2007 01:35:58 +0000 (01:35 +0000)]
r21672: The cannonical file access pattern should look like this :
srvstr_get_path(inbuf, name, smb_buf(inbuf) + 1, sizeof(name), 0, STR_TERMINATE, &status);
if (!NT_STATUS_IS_OK(status)) {
return ERROR_NT(status);
}
RESOLVE_DFSPATH(name, conn, inbuf, outbuf);
status = unix_convert(conn, name, False, NULL, &sbuf);
if (!NT_STATUS_IS_OK(status)) {
return ERROR_NT(status);
}
status = check_name(conn, name);
if (!NT_STATUS_IS_OK(status)) {
return ERROR_NT(status);
}
Make sure that every access pattern (including the
wildcard generated paths from unlink, rename, and copy)
do the same. Tidy things up a bit....
Jeremy.
Jeremy Allison [Fri, 2 Mar 2007 23:06:53 +0000 (23:06 +0000)]
r21667: posix_unlink should break existing oplocks.
Jeremy.
Jeremy Allison [Fri, 2 Mar 2007 23:04:44 +0000 (23:04 +0000)]
r21666: (only in 3.0, not 3.0.25). Fix bad parameter to call.
Jeremy.
Jeremy Allison [Fri, 2 Mar 2007 22:19:53 +0000 (22:19 +0000)]
r21665: Fix bug #4428 reported by Jason Mader <jason@ncac.gwu.edu>.
Jeremy.
Jeremy Allison [Fri, 2 Mar 2007 20:56:18 +0000 (20:56 +0000)]
r21664: Fix #4425 - patch from Jason Mader <jason@ncac.gwu.edu>.
Jeremy
Jeremy Allison [Fri, 2 Mar 2007 20:15:11 +0000 (20:15 +0000)]
r21663: Fix from the Wine guys: Robert Shearman <rob@codeweavers.com>
The background behind this patch is that we're using ntlm_auth with
Wine. Windows allows us to pass in a NULL domain and a username of the
form of "user@domain" and this is converted into an NTLMSSP_AUTH packet
with a NULL domain name and a username of the same form.
Jeremy.
Herb Lewis [Fri, 2 Mar 2007 15:08:09 +0000 (15:08 +0000)]
r21657: get rid of warning - not everyone understands %F
Jelmer Vernooij [Fri, 2 Mar 2007 14:26:19 +0000 (14:26 +0000)]
r21655: Regenerate after pidl bugfix.
Jelmer Vernooij [Fri, 2 Mar 2007 13:10:12 +0000 (13:10 +0000)]
r21652: Fix samba3-specific initialization
Jelmer Vernooij [Fri, 2 Mar 2007 12:54:37 +0000 (12:54 +0000)]
r21651: Add ndrdump to samba 3. This only works from external source at the
moment. To use, use something like:
./bin/ndrdump -l bin/smbd winreg winreg_EnumValue in <filename>
or to see what functions are available:
./bin/ndrdump -l bin/smbd winreg
James Peach [Fri, 2 Mar 2007 03:51:22 +0000 (03:51 +0000)]
r21647: Allow unit on for size parameters.
Jeremy Allison [Thu, 1 Mar 2007 23:57:37 +0000 (23:57 +0000)]
r21646: Patch from SATOH Fumiyasu <fumiyas@osstech.co.jp>
- add minsize parameter. Bug #4409.
Jeremy.
Jeremy Allison [Thu, 1 Mar 2007 23:03:46 +0000 (23:03 +0000)]
r21645: Make posix_unlink work - on open files too !
Jeremy.
Jeremy Allison [Thu, 1 Mar 2007 22:44:02 +0000 (22:44 +0000)]
r21644: Allow mkdir on platforms with no O_DIRECTORY.
Add proper debug to all possible setfilepathinfo
functions.
Jeremy.
Jeremy Allison [Thu, 1 Mar 2007 22:15:30 +0000 (22:15 +0000)]
r21643: Put the correct bits on the wire for posix_mkdir.
We're not yet deleting open files on unlink. Investigating...
Jeremy.
Volker Lendecke [Thu, 1 Mar 2007 22:12:49 +0000 (22:12 +0000)]
r21642: Fix bug 4365. Please note that this was only tested with Vista so far, it
needs testing with other clients as well. I'm afraid I'm visiting a conference
tomorrow and saturday, so I'd be happy to get support in this.
Thanks,
Volker
Jeremy Allison [Thu, 1 Mar 2007 21:56:54 +0000 (21:56 +0000)]
r21641: Add test code for POSIX pathname calls into smbclient.
Jeremy.
Jeremy Allison [Thu, 1 Mar 2007 21:36:05 +0000 (21:36 +0000)]
r21640: Fix the build for broken platoforms without O_DIRECT or O_DIRECTORY.
Jeremy.
Jeremy Allison [Thu, 1 Mar 2007 21:05:29 +0000 (21:05 +0000)]
r21639: Add in implementations of POSIX open/mkdir/unlink/rmdir.
Jeremy.
Jeremy Allison [Thu, 1 Mar 2007 21:01:22 +0000 (21:01 +0000)]
r21638: Change POSIX_UNLINK to allow clients to differentiate
between unlink/rmdir calls.
Jeremy.
Jim McDonough [Thu, 1 Mar 2007 20:52:14 +0000 (20:52 +0000)]
r21637: Get "password never expires" account policy working.
0x8000000000000000LL is "infinity" to NT and should
not be converted numerically to time_t.
Gerald Carter [Thu, 1 Mar 2007 19:22:31 +0000 (19:22 +0000)]
r21636: Was almost right before. We have to specify the short domain name to get the
Krb5 config stuff to work in the server affinity settings.
Gerald Carter [Thu, 1 Mar 2007 18:48:52 +0000 (18:48 +0000)]
r21635: Don't free talloc()'d memory. I wish people would check the callers
when changing how memory is allocated.
Gerald Carter [Thu, 1 Mar 2007 14:44:25 +0000 (14:44 +0000)]
r21633: First real fix from me found during the bug hunt.
ads_cached_connection() does not call get_dc_name()
before ads_connect() and therefore does not setup
the environment to look at krb5.conf.DOMAIN file
before sending the TGT request. The failure I'm seeing
occurs ni a multi-DC domain where we get back preuath
failed after we just joined the domain.
Gerald Carter [Thu, 1 Mar 2007 14:34:06 +0000 (14:34 +0000)]
r21632: Remove ununsed variable
Gerald Carter [Thu, 1 Mar 2007 05:52:38 +0000 (05:52 +0000)]
r21626: Fix memory leak on error path noticed by
SATOH Fumiyasu <fumiya@samba.gr.jp>
Simo Sorce [Thu, 1 Mar 2007 05:17:33 +0000 (05:17 +0000)]
r21623: Fix copy/paste error
Gerald Carter [Thu, 1 Mar 2007 04:58:52 +0000 (04:58 +0000)]
r21622: Fix bad merge caught by James.
Gerald Carter [Thu, 1 Mar 2007 03:16:38 +0000 (03:16 +0000)]
r21616: Delay initialization of idmap and nss_info backends until necessary
so they can honor the offline logon state.
Gerald Carter [Thu, 1 Mar 2007 03:15:22 +0000 (03:15 +0000)]
r21615: don't wait until the last second to try to renew a Krb5 ticket as it is took late
Gerald Carter [Thu, 1 Mar 2007 03:14:20 +0000 (03:14 +0000)]
r21614: The memset() called on aligned memory was causing crashes
on x86_64 Linux boxes. Since it is not needed, just use malloc()
on Linux.
Gerald Carter [Thu, 1 Mar 2007 03:12:16 +0000 (03:12 +0000)]
r21613: perform variable subsitution on home directories and shells provided by the nss_info backend
Gerald Carter [Thu, 1 Mar 2007 03:10:29 +0000 (03:10 +0000)]
r21612: Make pam_winbind do the same username fixup on AIX as the WINBINDD
LAM module does to work around a system that does not support
>8 character usernames. Without the change, pam_winbind tries
to authenticate _#uid in the domain.
Gerald Carter [Thu, 1 Mar 2007 03:07:57 +0000 (03:07 +0000)]
r21611: I'm not entirely sure about this patch but it is working.
su - DOM\user was unable to set the process crendentials
without listing the "id" and other attributes in the attrlist[].
More fixes to come, but I didn't want this to get lost.
Gerald Carter [Thu, 1 Mar 2007 03:05:51 +0000 (03:05 +0000)]
r21610: put libraries preceeding the @SONAMEFLAG@ variable as on AIX this ends up commenting out the remainder of the line and we have missing libraries in the link
Jeremy Allison [Thu, 1 Mar 2007 02:43:33 +0000 (02:43 +0000)]
r21609: Fix memory leaks in error code paths (and one in winbindd_group.c).
Patch from Zack Kirsch <zack.kirsch@isilon.com>.
Jeremy.
Jeremy Allison [Thu, 1 Mar 2007 01:17:36 +0000 (01:17 +0000)]
r21608: Fix a couple of memleaks in error code paths before
Coverity finds them :-)
Jeremy.
Simo Sorce [Thu, 1 Mar 2007 00:50:56 +0000 (00:50 +0000)]
r21607: While committing I saw I had not newline terminated this string ...
Simo Sorce [Thu, 1 Mar 2007 00:49:28 +0000 (00:49 +0000)]
r21606: Implement escaping function for ldap RDN values
Fix escaping of DN components and filters around the code
Add some notes to commandline help messages about how to pass DNs
revert jra's "concistency" commit to nsswitch/winbindd_ads.c, as it was
incorrect.
The 2 functions use DNs in different ways.
- lookup_usergroups_member() uses the DN in a search filter,
and must use the filter escaping function to escape it
Escaping filters that include escaped DNs ("\," becomes "\5c,") is the
correct way to do it (tested against W2k3).
- lookup_usergroups_memberof() instead uses the DN ultimately as a base dn.
Both functions do NOT need any DN escaping function as DNs can't be reliably
escaped when in a string form, intead each single RDN value must be escaped
separately.
DNs coming from other ldap calls (like ads_get_dn()), do not need escaping as
they come already escaped on the wire and passed as is by the ldap libraries
DN filtering has been tested.
For example now it is possible to do something like:
'net ads add user joe#5' as now the '#' character is correctly escaped when
building the DN, previously such a call failed with Invalid DN Syntax.
Simo.
Jeremy Allison [Thu, 1 Mar 2007 00:22:51 +0000 (00:22 +0000)]
r21605: Fix small typo noticed by Raúl Sánchez Siles <rss@barracuda.es>.
Jeremy.
Jeremy Allison [Wed, 28 Feb 2007 22:29:14 +0000 (22:29 +0000)]
r21604: I got this wrong also in libsmb :-(.
Jeremy.
Jeremy Allison [Wed, 28 Feb 2007 21:59:39 +0000 (21:59 +0000)]
r21603: Horrible backwards compatibility hack as an old server bug
allowed a CIFS client bug to remain unnoticed :-(.
I suck.
Jeremy.
Volker Lendecke [Wed, 28 Feb 2007 09:04:05 +0000 (09:04 +0000)]
r21581: Add an error code I just got
Jeremy Allison [Wed, 28 Feb 2007 00:38:49 +0000 (00:38 +0000)]
r21577: Remove unneeded #define (part of earlier patch that was
removed).
Jeremy.
Jeremy Allison [Wed, 28 Feb 2007 00:35:58 +0000 (00:35 +0000)]
r21576: Patch based on work from Todd Stecher <todd.stecher@isilon.com>
to allow client to fragment large SPNEGO blobs (large krb5
tickets). Tested against W2K3R2. Should fix bug #4400.
Jeremy.
Jeremy Allison [Tue, 27 Feb 2007 22:04:23 +0000 (22:04 +0000)]
r21569: Fix bug reported by Martin Zielinski <mz@seh.de>
where return value was incorrectly initialized.
Jeremy.
Jeremy Allison [Tue, 27 Feb 2007 20:34:10 +0000 (20:34 +0000)]
r21566: If we're going to be broken, at least be *consistently*
broken :-). This will do until Simo fixes the escape
calls properly.
Jeremy.
Jelmer Vernooij [Tue, 27 Feb 2007 18:52:38 +0000 (18:52 +0000)]
r21565: Import ndrdump (doesn't compile yet, needs table support functions).
Volker Lendecke [Tue, 27 Feb 2007 17:21:21 +0000 (17:21 +0000)]
r21563: Fix a memleak: We only need dispinfo structs for "our" and for the builtin
domain. Without this patch we leaked a DISPINFO for the (NULL) domain per
samr_connect*() call.
Volker
Jelmer Vernooij [Tue, 27 Feb 2007 17:17:16 +0000 (17:17 +0000)]
r21562: Regenerate gen_ndr after pidl changes.
Günther Deschner [Tue, 27 Feb 2007 14:24:49 +0000 (14:24 +0000)]
r21561: It makes absolutely no sense to call krb5_kt_resolve() two times
directly after another.
Guenther
Günther Deschner [Tue, 27 Feb 2007 13:42:15 +0000 (13:42 +0000)]
r21560: Convert name_to_fqdn to BOOL.
Guenther
Günther Deschner [Tue, 27 Feb 2007 13:31:42 +0000 (13:31 +0000)]
r21558: Safe more indent, again no code changes.
Guenther
Günther Deschner [Tue, 27 Feb 2007 13:27:31 +0000 (13:27 +0000)]
r21557: indent only fix. No code change.
Guenther
Günther Deschner [Tue, 27 Feb 2007 13:25:42 +0000 (13:25 +0000)]
r21556: Remove superfluos return check in ads_keytab_verify_ticket().
Guenther
Lars Müller [Mon, 26 Feb 2007 23:07:54 +0000 (23:07 +0000)]
r21552: Ensure to check for proto_exists before linking any binary. No make
proto should be required before creating any binary from now on.
Remove proto_exists from the all, pam_smbpass, and pam_bindind rule.
Volker Lendecke [Mon, 26 Feb 2007 23:06:17 +0000 (23:06 +0000)]
r21551: Ok, this is more subtle. More tomorrow :-)