jra [Thu, 9 Dec 2004 22:10:40 +0000 (22:10 +0000)]
Optimisation from Nadav Danieli <nadavd@exanet.com>. If we're oplocked,
short circuit some is_locked() tests.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4121
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 9 Dec 2004 21:42:00 +0000 (21:42 +0000)]
Never, ever, doubt valgrind :-). Fix order of evaluation bug that's been in the
bitmap code for ever. Remove silly extra space in paranoid malloc.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4120
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 9 Dec 2004 01:07:06 +0000 (01:07 +0000)]
As check_self is *always* False in every invokation, remove the
logic for it. We still pass Samba4 RAW-LOCK test.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4108
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
herb [Wed, 8 Dec 2004 17:30:50 +0000 (17:30 +0000)]
lock timeout is in milliseconds (as in reply.c)
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4103
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Wed, 8 Dec 2004 03:02:29 +0000 (03:02 +0000)]
BUG 2107: fix memory bloating caused by large numbers of print_queue_updates() requests sent via messages.tdb
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4094
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 8 Dec 2004 01:52:23 +0000 (01:52 +0000)]
Bring into line with new *alloc rules.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4092
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Tue, 7 Dec 2004 19:00:45 +0000 (19:00 +0000)]
fix logic error in add_a_form() that only compared N characters instead of the entire form name
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4089
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 7 Dec 2004 18:25:53 +0000 (18:25 +0000)]
Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4088
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Mon, 6 Dec 2004 19:25:25 +0000 (19:25 +0000)]
consolidate printer searches to use find_service rather than for loops
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4083
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Thu, 2 Dec 2004 17:11:18 +0000 (17:11 +0000)]
BUG 2091: don't remove statically defined printers in remove_stale_printers()
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4043
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 2 Dec 2004 00:55:47 +0000 (00:55 +0000)]
Fix bug #2110 - ensure we convert to ucs2 correctly.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4032
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Wed, 1 Dec 2004 21:11:54 +0000 (21:11 +0000)]
patch from Rob -- don't force the cups printer-make-and-model tag as the comment for autoloaded printers
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4030
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Wed, 1 Dec 2004 21:01:27 +0000 (21:01 +0000)]
solaris packaging fixes from Rob
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4029
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Wed, 1 Dec 2004 20:11:31 +0000 (20:11 +0000)]
* prevent the background LPQ daemon from updating
the print queue cache just because multiple smbd
processes sent a message that it was out of date.
* add some extra debug messages while trying to track down
down jobs being left in the queue after printing has
completed.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4028
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 30 Nov 2004 22:57:41 +0000 (22:57 +0000)]
Code tidyup to fix bug #2098.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4023
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 30 Nov 2004 18:58:58 +0000 (18:58 +0000)]
Fix for crash reported by Bård Kalbakk <baard@inett.biz>.
Don't go fishing for the authorisation data unless we
know it's there.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4020
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Tue, 30 Nov 2004 15:55:27 +0000 (15:55 +0000)]
better error logging in register_message_flags() from Rob
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4019
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Tue, 30 Nov 2004 15:52:46 +0000 (15:52 +0000)]
* move claim_connection from the netbios session request
reply code to the negprot reply code to cope with
client connections on port 445. Fixes the spurious
"register_message_flags: tdb fetch failed" errors.
* don't run the backgroup LPQ daemon when we are running
in interactive mode.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4018
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 30 Nov 2004 06:41:38 +0000 (06:41 +0000)]
Fix for bug found by Steve French client code (cifsfs) on
POSIX ACL set. You need to *get* a permset_t pointer from the entry before
any of the permset code will accept it as a valid value
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4016
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 30 Nov 2004 01:01:43 +0000 (01:01 +0000)]
Fix from Timur Bakeyev <timur@com.bat.ru> for bugid #2100,
change the way we check for errors after a dlopen (which
may set internal warnings which get picked up by mistake
in dlsym).
Jeremy
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4009
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 30 Nov 2004 00:22:04 +0000 (00:22 +0000)]
Fix bug #2088 - ensure inherit permissions is only applied on a new file,
not an existing one.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4007
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Mon, 29 Nov 2004 19:28:12 +0000 (19:28 +0000)]
Fix for bug #2071 reported by Jason Mader <jason@ncac.gwu.edu>.
Use correct enum type for comparisons.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@4005
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Sat, 27 Nov 2004 19:02:45 +0000 (19:02 +0000)]
Use sys_readdir() instead of readdir()
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3987
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Sat, 27 Nov 2004 18:57:44 +0000 (18:57 +0000)]
Fix bug with 64bit fs support
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3985
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Thu, 25 Nov 2004 20:55:31 +0000 (20:55 +0000)]
- Fix assignment of a couple of fields in pdb_{mysql,pgsql}
- Use new DTD URL in pdb_xml
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3974
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
tridge [Thu, 25 Nov 2004 04:10:19 +0000 (04:10 +0000)]
bring Samba3 into line with the Samba4 password change code
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3954
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 25 Nov 2004 00:59:44 +0000 (00:59 +0000)]
Fix for bugid #2081 reported by John Janosik <jpjanosi@us.ibm.com> - ensure
SE_DESC_DACL_PROTECTED is set if "map acl inherit = no".
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3951
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 25 Nov 2004 00:25:53 +0000 (00:25 +0000)]
Fix incorrect declaration. Bug #2083.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3948
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 25 Nov 2004 00:07:01 +0000 (00:07 +0000)]
Fix for bugid #2085 reported by Jason Mader <jason@ncac.gwu.edu>. Use consistent
enum type for Protocol extern.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3946
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 24 Nov 2004 22:05:59 +0000 (22:05 +0000)]
Fix the problem we get on Linux where sendfile fails, but we've already sent the
header using send(). As our implementation of sendfile can't return EINTR (it
restarts in that case) use an errno of EINTR to signal the linux sendfile fail
after header case. When that happens send the rest of the data and then turn
off sendfile. Sendfile should be safe to enable on all systems now (even though
it may not help in all performance cases).
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3944
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Wed, 24 Nov 2004 09:44:57 +0000 (09:44 +0000)]
typo.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3940
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 24 Nov 2004 05:24:38 +0000 (05:24 +0000)]
Ensure LARGE_READX response must fit within reply buffer.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3936
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 24 Nov 2004 03:42:01 +0000 (03:42 +0000)]
Correctly check for the top length bit in LARGE_READX.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3934
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 24 Nov 2004 01:03:23 +0000 (01:03 +0000)]
Fix all "may be used uninitialized" and "shadow" warnings.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3931
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 23 Nov 2004 23:13:48 +0000 (23:13 +0000)]
Dead code elimination fix for bug #2075 from jason@ncac.gwu.edu.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3929
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
tpot [Tue, 23 Nov 2004 20:50:16 +0000 (20:50 +0000)]
Fix duplicate call to pdb_get_acct_desc(). Bugzilla #2080.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3928
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Tue, 23 Nov 2004 16:35:14 +0000 (16:35 +0000)]
patch from Thomas Bork <tombork@web.de> to fix configure.in with GNU ld versions that don't output a date string in the --version
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3925
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Tue, 23 Nov 2004 15:27:53 +0000 (15:27 +0000)]
fix installswat once again after the image target location had changed in the docs
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3924
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Tue, 23 Nov 2004 14:52:56 +0000 (14:52 +0000)]
BUG 2073: fall back to smb_name if current_user_info is not available in lp_file_list_changed()
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3923
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Tue, 23 Nov 2004 01:05:31 +0000 (01:05 +0000)]
Allow to set OWNER- and GROUP-entries while setting security descriptors
with smbcacls and using with the -S or -M switch. Fixes #404 and #2076.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3918
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Mon, 22 Nov 2004 15:20:38 +0000 (15:20 +0000)]
More fixes to have proper german in swat.
(The new german orthography is another story...)
Thanks to Reiner Klaproth and Björn Jacke <bjacke@sernet.de>.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3912
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Mon, 22 Nov 2004 14:34:45 +0000 (14:34 +0000)]
typo.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3911
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Sat, 20 Nov 2004 21:24:52 +0000 (21:24 +0000)]
Fix for bug #2045. May also fix other timestamp bugs with Excel
(Volker please test). Setting a last write timestamp from Windows
overrides any subsequent write timestamp changes and must be immediately
seen by and findfirst/findnexts. This is a racy solution, but should
work most of the time. This may also fix #1061, not sure.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3895
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Sat, 20 Nov 2004 20:10:43 +0000 (20:10 +0000)]
Fix "might be used uninitialized" error.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3892
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Sat, 20 Nov 2004 02:48:34 +0000 (02:48 +0000)]
Only set mtime from pending_modtime if it's not already zero...
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3889
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 19 Nov 2004 21:01:23 +0000 (21:01 +0000)]
Fix error return -- thanks to rsharpe
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3883
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 19 Nov 2004 20:55:54 +0000 (20:55 +0000)]
Fix bug 2069 -- thanks to jason@ncac.gwu.edu
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3882
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 19 Nov 2004 19:45:03 +0000 (19:45 +0000)]
Tidy up some unused/shadowed variable usage.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3880
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 19 Nov 2004 19:32:31 +0000 (19:32 +0000)]
Final (I hope :-) fix for #2050 from Lars Müller for select maxfd's.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3877
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Fri, 19 Nov 2004 13:26:17 +0000 (13:26 +0000)]
Allow to look up at least or own sid in _lsa_lookup_sids.
This fixes Bugzilla #1076 and Exchange 5.5 SP4 can then be finally
installed on NT4 in a samba-controlled domain.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3875
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 19 Nov 2004 12:11:13 +0000 (12:11 +0000)]
The semantics of the parameter 'printcap name' are a bit tricky. I had seen
the effect that I could not list printers with smbclient -L. I have cups
libraries but no running cups server, so remove_stale_printers() removed all
my printer definitions from the share list. So I said 'printing = bsd' but it
still would not work.
This happened because init_globals() would initialize Globals.szPrintcapname
to "cups", and the explicit 'printing = bsd' did not reset it. 'printing=bsd'
can't reset it, as this might overwrite an explicit setting. Thus I separated
the lp_printcapname into a function of its own, looking at
Globals.szPrintcapname and subsequently at sDefault.iPrinting.
Please revisit, there are just too many cases to cover.
Thanks,
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3873
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 19 Nov 2004 11:59:56 +0000 (11:59 +0000)]
Fix memleak
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3871
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Thu, 18 Nov 2004 23:25:37 +0000 (23:25 +0000)]
Fix reverted logic of detecting HAVE_WRFILE_KEYTAB (Bugzilla 2059)
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3868
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 18 Nov 2004 22:46:04 +0000 (22:46 +0000)]
Fix from david.hu@hp.com - make a copy of an incoming message
rather than indirecting into it as a struct (may not be on an
even byte boundary). Bug #2052.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3867
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 18 Nov 2004 22:11:20 +0000 (22:11 +0000)]
Fix from Lars Müller <lmuelle@suse.de> for bug #2050.
Make nmbd use maxfd+1 in select also.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3864
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 18 Nov 2004 21:22:24 +0000 (21:22 +0000)]
Fix from Lars Müller <lmuelle@suse.de>, check for HAVE_WRFILE_KEYTAB
was inverted.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3862
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 18 Nov 2004 19:36:50 +0000 (19:36 +0000)]
Ensure if num_acls is set to 0xFFFF this field is ignored.
Use def_acl everywhere instead of dir_acl.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3859
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 18 Nov 2004 19:03:17 +0000 (19:03 +0000)]
Shut up gcc about erroneous "used uninitialised" warning.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3857
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 18 Nov 2004 18:40:39 +0000 (18:40 +0000)]
Sync up with the one in the main source dir (yes, this should probably
be a symlink...).
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3855
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 16:14:13 +0000 (16:14 +0000)]
Fix an uninitialized variable warning. Jeremy, there are some of these in
charcnv.c.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3853
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 15:52:02 +0000 (15:52 +0000)]
Fix the build...
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3852
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 15:44:01 +0000 (15:44 +0000)]
I get the impression that some developers here are using gcc 3.4. This one
only warns you about possibly uninitialized variables if you have at least
-O1.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3850
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 15:13:58 +0000 (15:13 +0000)]
Fix for bug 2057. Only partially applied the patch, the second part seems not
necessary.
I'm using gcc 3.4.1, this does not detect the possibly uninitialized
variable. Does anybody know how to get 3.4.1 to warn me?
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3848
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 13:29:10 +0000 (13:29 +0000)]
Typo fix. Bug 2055. Lars, I'm available on irc.... :-)
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3846
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 12:19:16 +0000 (12:19 +0000)]
Attempt to get the build farm in line. Some systems seem to have defined
rewinddir as a macro and don't like the construct to call a function pointer
called rewinddir. Work around by renaming the function pointer...
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3844
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 11:57:49 +0000 (11:57 +0000)]
If a connection to a DC is requested, open connections simultaeneously to all
DCs found. The first one to reply wins.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3843
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 11:43:14 +0000 (11:43 +0000)]
Time out in ads search queries. Even AD servers can hang.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3841
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 18 Nov 2004 08:16:59 +0000 (08:16 +0000)]
Some more specific NT security descriptors we've come across. Map them to
defined AFS acls. Thanks to Horst Birthelmer.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3839
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Wed, 17 Nov 2004 21:22:35 +0000 (21:22 +0000)]
Fix crash in api_RNetShareEnum. ServicePtrs[] may contain invalid
entries. Happened after rev3708 removed non-existing cups printers.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3824
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 17 Nov 2004 21:05:47 +0000 (21:05 +0000)]
Fix bug reported by Tom Dickson <tdickson@inostor.com> with
follow symlinks = no reporting an incorrect error when it should
be access denied.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3823
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 17 Nov 2004 20:05:31 +0000 (20:05 +0000)]
Updated config.guess/config.sub from
ftp://ftp.gnu.org/pub/gnu/config/config.guess
ftp://ftp.gnu.org/pub/gnu/config/config.sub
as requested in bugid #2048.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3819
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 17 Nov 2004 19:52:26 +0000 (19:52 +0000)]
Fix from Lars Müller <lmuelle@suse.de> for bug #2050, calculate
max_fd for select correctly.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3817
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 17 Nov 2004 18:56:48 +0000 (18:56 +0000)]
Added fn to remove an ACL from a file. Now need client code to test this.
How do the share mask/modes fit into this code... Need to think about this.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3816
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 17 Nov 2004 17:51:27 +0000 (17:51 +0000)]
At least use a proper constant name (aRONLY :-) not a number.
That way we can at least remember why we did this :-).
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3814
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Wed, 17 Nov 2004 15:56:47 +0000 (15:56 +0000)]
Believe it or not, but this patch seems to be necessary. If someone sets a
folder icon in the start menu and saves the profile on a samba server, after
logging in again this setting is gone. Why is this? The folder for which the
icon is set must have the read only flag set. If it is not set, the
desktop.ini file (the file containing the icon reference) inside that folder
is ignored.
lp_profile_acls is a hack for such a situation, so overload this parameter
with another profile-related hack.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3811
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 17 Nov 2004 01:43:36 +0000 (01:43 +0000)]
Patch from Jay Fenlason <fenlason@redhat.com>. Don't free static buffers.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3796
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 17 Nov 2004 01:35:35 +0000 (01:35 +0000)]
Added set posix acl functionality into the UNIX extensions code.
One part missing - delete file acl (to be added asap). No client
code yet, also needs testing with valgrind.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3794
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Tue, 16 Nov 2004 03:27:19 +0000 (03:27 +0000)]
BUG 2023: patch from Buchan Milne <bgmilne@mandrake.org> fix mandrake packaging for Samba 3.0.9 -- still need to review this libsmbclient install location
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3778
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Mon, 15 Nov 2004 23:03:37 +0000 (23:03 +0000)]
Fix for bug #2038 from Johann Hanne <jhml@gmx.net>. Don't check
for no groups after every lookup - move check to the end as we should
only fail if all lookups fail.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3776
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Mon, 15 Nov 2004 21:21:50 +0000 (21:21 +0000)]
BUG 2006: patch from Michel Gravey <michel.gravey@optogone.com>; fix build when using gcc 3.0
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3772
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jmcd [Mon, 15 Nov 2004 20:57:27 +0000 (20:57 +0000)]
Fix bug #1952: no comment on XP shutdown
Try INITSHUTDOWN pipe first, used by newer clients. If it fails, fall back
to WINREG.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3771
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Mon, 15 Nov 2004 18:57:22 +0000 (18:57 +0000)]
Ensure on failure that *res is always NULL.
Check for malloc fail. Fixes for bug #2036.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3764
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jmcd [Mon, 15 Nov 2004 17:20:58 +0000 (17:20 +0000)]
Fix bug #1932: crash when non-root invokes net getlocalsid
First check to see if we can open secrets.tdb.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3761
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Mon, 15 Nov 2004 13:18:12 +0000 (13:18 +0000)]
Increase a debug level. This error condition can actually happen in real life
if you have several competing winbinds that might get a lag due to
replication.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3758
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jmcd [Sun, 14 Nov 2004 03:12:46 +0000 (03:12 +0000)]
Update from Rob Foehl (rwf@loonybin.net):
Try modifying printer before adding it,since add logic appends ObjectClass to mods, which caused a contraint violation when modifying an already published printer.
Also cleanup the check_published_printers() logic when verifying published status on startup.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3727
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Sat, 13 Nov 2004 00:35:31 +0000 (00:35 +0000)]
Getfacl now seems to work on files and directories. Next do setfacl
and port to Samba4.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3714
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 12 Nov 2004 23:42:12 +0000 (23:42 +0000)]
Implementation of get posix acls in UNIX extensions. Passes valgrind.
Need to add printout functions in client and set posix acl in server.
SteveF - take a look at this for the cifsfs client !
Once this is working and tested the next step is to write this up for
the UNIX extensions spec. documents.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3713
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Fri, 12 Nov 2004 23:13:03 +0000 (23:13 +0000)]
Fix KRB5_SETPW-defines, no change in behaviour.
A value of '2' is due to an expired internet draft, while 0xff80 comes
from RFC3244. See Bugzilla #1661 for details.
Thanks to Luke Mewburn <lukem@NetBSD.org> for his research.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3711
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Fri, 12 Nov 2004 22:15:55 +0000 (22:15 +0000)]
fix another safe_strcpy() warning SPAM with the printer drivcename
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3710
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Fri, 12 Nov 2004 22:05:27 +0000 (22:05 +0000)]
Allow to build testsuite for libsmbclient when libsmbclient.so is
located not in -L/root/samba-head-old/source/bin.
Patch from Lars Mueller <lmuelle@suse.de>, closes Bugzilla #2013.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3709
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Fri, 12 Nov 2004 17:39:32 +0000 (17:39 +0000)]
BUG 1838: patch from Gavrie Philipson <gavrie@disksites.com> to remove stale printers when reloading after a sighup
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3708
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Fri, 12 Nov 2004 17:23:01 +0000 (17:23 +0000)]
2028: avoid false error messages when copying a long printer name to the device mode
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3707
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 12 Nov 2004 15:49:47 +0000 (15:49 +0000)]
Nobody has commented, so I'll take this as an ack...
abartlet, I'd like to ask you to take a severe look at this!
We have solved the problem to find the global groups a user is in twice: Once
in auth_util.c and another time for the corresponding samr call. The attached
patch unifies these and sends them through the passdb backend (new function
pdb_enum_group_memberships). Thus it gives pdb_ldap.c the chance to further
optimize the corresponding call if the samba and posix accounts are unified by
issuing a specialized ldap query.
The parameter to activate this ldapsam behaviour is
ldapsam:trusted = yes
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3705
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 12 Nov 2004 15:30:51 +0000 (15:30 +0000)]
Implement a cache get saves the result of a pdb_getsampwnam for later
retrieval by pdb_getsampwsid. This solves our problem that we do lots of calls
to LDAP during a typical XP login. XP does a lookupnames, then an openuser and
some queryinfo stuff. Lookupnames triggers the initial getsampwnam, and all
the subsequent ones make us call getsampwsid. This patch gets this down to one
call to LDAP.
Yes, a more "correct" way would be to stick the information to the open user
handle, but this one is simpler and saves the LDAP roundtrip for the openuser
call.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3704
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 12 Nov 2004 15:01:40 +0000 (15:01 +0000)]
This is a getpwnam-cache. It is mainly to speed up Samba with slow nss
backends such as nss_ldap.
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3702
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Fri, 12 Nov 2004 03:36:15 +0000 (03:36 +0000)]
BUG 2027: fix multiple declaration of MD5_CTX (do we really care about DOS compilers?). Will watch build farm though.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3697
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 12 Nov 2004 02:16:00 +0000 (02:16 +0000)]
Correctly detect errno for no acl/ea support.
Jeremy
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3693
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Thu, 11 Nov 2004 23:30:32 +0000 (23:30 +0000)]
fix output of smbstatus to make the man page; fix -L, -p, & -S and the -u <username> functionality
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3688
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Thu, 11 Nov 2004 20:41:28 +0000 (20:41 +0000)]
setting the 3.0 branch to 3.0.10pre1-svn
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3685
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Thu, 11 Nov 2004 18:11:40 +0000 (18:11 +0000)]
BUG 2017: fix testparm reporting for the passwd program string
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@3683
0c0555d6-39d7-0310-84fc-
f1cc0bd64818