Jeremy Allison [Wed, 28 Jun 2006 20:39:07 +0000 (20:39 +0000)]
r16642: Fix show-stopper bug #3876. Double-free in wins
server code. Jerry please merge for 3.0.23.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 18:56:45 +0000 (18:56 +0000)]
r16640: Fix bug #3886 reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 18:46:47 +0000 (18:46 +0000)]
r16638: Fix bug #3885, reported by jason@ncac.gwu.edu. Use
the correct enumerated type in the macro.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 18:22:21 +0000 (18:22 +0000)]
r16636: Fix bug #3884 reported by jason@ncac.gwu.edu
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 18:18:23 +0000 (18:18 +0000)]
r16634: Fix bug #3883 reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 18:16:33 +0000 (18:16 +0000)]
r16632: Fix bug #3882 reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 17:58:47 +0000 (17:58 +0000)]
r16630: Fix bug #3881, reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 17:56:10 +0000 (17:56 +0000)]
r16628: Fix bug #3880, reported by jason@ncac.gwu.edu
by ensuring we return the correct enum for sid
type, not a uint32.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 17:26:48 +0000 (17:26 +0000)]
r16626: Fix bug #3878. Reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 17:11:06 +0000 (17:11 +0000)]
r16624: Fix bug #3877, reported by jason@ncac.gwu.edu
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 05:00:09 +0000 (05:00 +0000)]
r16616: Klocwork #2025. Stop null deref. I actually don't
think this can happen in real life but the code is
too complicated to be sure....
Jerry please merge this for 3.0.23.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 04:56:23 +0000 (04:56 +0000)]
r16614: Klocwork #2012. memleak on error path.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 04:51:23 +0000 (04:51 +0000)]
r16612: Klocwork fix #2011. memleak on error path.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 04:43:19 +0000 (04:43 +0000)]
r16610: Subtle one from Klocwork #2076. If multiple flags
are set in a winbindd request it might overwrite existing
state->response.extra_data.data values without freeing.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 04:30:51 +0000 (04:30 +0000)]
r16608: Klocwork #2035. Null deref (bit of a stretch... :-).
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 04:27:43 +0000 (04:27 +0000)]
r16606: Klocwork #1990. Malloc the correct size.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 02:22:28 +0000 (02:22 +0000)]
r16603: Klockwork #2028. Fix null deref on error path.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 02:12:53 +0000 (02:12 +0000)]
r16601: Klocwork #2038. Fix memleak on error path.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 02:02:26 +0000 (02:02 +0000)]
r16599: Make it clear to Klocwork we're not dereferencing. Issue #2026.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 01:59:04 +0000 (01:59 +0000)]
r16597: Klocwork #2006. Fix possible null deref.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 01:56:41 +0000 (01:56 +0000)]
r16595: Klocwork #2067. Fix possible memleak on error exit.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 01:52:01 +0000 (01:52 +0000)]
r16593: Make the invarient explicit to Klocwork. Bug #2023.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 01:25:29 +0000 (01:25 +0000)]
r16591: Belt and braces approach to shut Klocwork up - bug #2001.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 01:21:54 +0000 (01:21 +0000)]
r16589: Fix Klocwork #1999. Although it should be impossible to
get duplicate OID's returned in the oids_out list it is
still good programming practice to clear out a malloc'ed
string before re-writing it (especially in a loop).
Jeremy
Jeremy Allison [Wed, 28 Jun 2006 01:11:17 +0000 (01:11 +0000)]
r16587: Fix Klocwork #1987. Memleak on reusing x_dbf.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 01:00:48 +0000 (01:00 +0000)]
r16585: Fix Klocwork #1976. Possible null deref.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 00:50:14 +0000 (00:50 +0000)]
r16582: Fix Klocwork #1997 and all generic class of problems
where we don't correctly check the return from memdup.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 00:07:53 +0000 (00:07 +0000)]
r16581: Fix Klocwork #2017. Possible null deref.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 00:05:53 +0000 (00:05 +0000)]
r16579: Fix Klocwork #2016. Possible null deref.
Jeremy.
Jeremy Allison [Wed, 28 Jun 2006 00:01:28 +0000 (00:01 +0000)]
r16576: Fix Klocwork #2015. Possible null deref.
Jeremy.
Christopher R. Hertel [Tue, 27 Jun 2006 17:58:55 +0000 (17:58 +0000)]
r16570: Corrected the copyright notice. I had requested and received permission
from my management at the University to release under my own copyright.
My mistake for entering the wrong info.
Jeremy Allison [Tue, 27 Jun 2006 03:59:34 +0000 (03:59 +0000)]
r16554: Sorry, just had to change this. Don't use int when
you're passing a BOOL parameter, don't use "clever"
code in while statement - make things easier and
clearer to understand when triggering something
with an if.
Jeremy.
Derrell Lipman [Tue, 27 Jun 2006 03:07:02 +0000 (03:07 +0000)]
r16552: Fix bug 3849.
Added a next_token_no_ltrim() function which does not strip leading separator
characters. The new function is used only where really necessary, even though
it could reasonably be used in many more places, to avoid superfluous code
changes.
Derrell
Derrell Lipman [Tue, 27 Jun 2006 02:30:58 +0000 (02:30 +0000)]
r16550: Fix bug 3866. Thanks for the report!
Although I've never met a computer or compiler that produced pointers to
functions which are a different size than pointers to data, I suppose they
probably exist. Assigning a pointer to a function is technically illegal in C
anyway.
Change casts of the option_value based on the option_name to use of variable
argument lists.
For binary compatibility, I've maintained but deprecated the old behavior of
debug_stderr (which expected to be passed a NULL or non-NULL pointer) and
added a new option debug_to_stderr which properly expects a boolean (int)
parameter.
Derrell
Jeremy Allison [Tue, 27 Jun 2006 01:03:58 +0000 (01:03 +0000)]
r16548: Fix bug #3867 reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Tue, 27 Jun 2006 00:55:08 +0000 (00:55 +0000)]
r16546: Fix bug #3865 reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Tue, 27 Jun 2006 00:49:14 +0000 (00:49 +0000)]
r16544: Fix bug #3864 reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Tue, 27 Jun 2006 00:42:24 +0000 (00:42 +0000)]
r16542: Fix #3863, reported by jason@ncac.gwu.edu
Jeremy.
Jeremy Allison [Tue, 27 Jun 2006 00:15:00 +0000 (00:15 +0000)]
r16541: Fix #3862 reported by jason@ncac.gwu.edu.
Jeremy.
Jeremy Allison [Mon, 26 Jun 2006 23:36:03 +0000 (23:36 +0000)]
r16537: Fix for bug #3858, all files in a directory not
being deleted when hide unreadable set to true.
Here's the scoop.
This one is really interesting. The pattern of deleting a directory is to do a
findfirst to get the first part of the list, then for each name returned it
does a open/set delete on close/close -> thus deleting the file. Then it does a
findnext with the last file name THAT IT JUST DELETED ! Now we can handle this
in the findnext in the case where hide unreadable is set to false as we look
back in our cache of names and just seek to the right point. The bug is
actually fixed in the first hunk of this patch - the one that removes the
is_visible_file() check after SearchDir returns false. We don't actually need
it and in this case it's causing the delete to be aborted because it can't find
the name (doh ! it was just deleted). We don't need it as SearchDir is only
ever called from findnext, and findnext should only ever be returning names we
gave it.
The rest of the patch are the debugs I used to find
the problem but they're generically useful.
Phew - that one took a while to track down.....
Jerry, please merge for 3.0.23 final.
Jeremy.
Gerald Carter [Mon, 26 Jun 2006 20:18:28 +0000 (20:18 +0000)]
r16528: Self-confidence is plummeting. How could one person goof
the same change 3 times......
Fix pam_winbind compilation again.
Günther Deschner [Mon, 26 Jun 2006 16:14:40 +0000 (16:14 +0000)]
r16521: Fix different extended_dn handling for win2k/2k3 (thanks to Frederic
Brin at Novell).
Guenther
Gerald Carter [Sun, 25 Jun 2006 12:22:12 +0000 (12:22 +0000)]
r16510: fix from Nicholas Brealey <nick@brealey.org> for building pam_winbind.so
Volker Lendecke [Sat, 24 Jun 2006 09:41:27 +0000 (09:41 +0000)]
r16490: Fix a memleak and two typos
Gerald Carter [Fri, 23 Jun 2006 14:39:40 +0000 (14:39 +0000)]
r16486: fix RedHat init scripts to rely on OS provided killproc() function
James Peach [Fri, 23 Jun 2006 06:19:45 +0000 (06:19 +0000)]
r16484: Bugzilla 3805. Only define _ABS if it is not already defined.
James Peach [Fri, 23 Jun 2006 06:00:16 +0000 (06:00 +0000)]
r16483: Turn off some useless MIPSPro warnings be default.
James Peach [Fri, 23 Jun 2006 05:28:34 +0000 (05:28 +0000)]
r16482: Fix bugzilla 3801 by forcing MIPSPro warning 1035 to be an error.
Günther Deschner [Fri, 23 Jun 2006 01:17:33 +0000 (01:17 +0000)]
r16480: (Ugly) workaround before the set_dc_type_flags & friends cleanup:
When trying to login using krb5 with a trusted domain account, we
need to make sure that our and the remote domain are AD.
Guenther
Günther Deschner [Thu, 22 Jun 2006 23:56:20 +0000 (23:56 +0000)]
r16479: When dcip_to_name failed to get the name of the ip in saf_servername we
cannot put saf_name in the failed conn cache as it's uninitialized.
Store saf_servername (the ip) in that case.
Volker, please check.
Guenther
Gerald Carter [Thu, 22 Jun 2006 22:00:43 +0000 (22:00 +0000)]
r16478: small cleanup to make pam_winbind.so build and iniparser
include directory like other parts of the build files.
Günther Deschner [Thu, 22 Jun 2006 20:33:42 +0000 (20:33 +0000)]
r16475: destroy talloc ctx when we weren't able to collect onlinestatus
messages.
Guenther
Günther Deschner [Thu, 22 Jun 2006 20:31:02 +0000 (20:31 +0000)]
r16474: There is no point in figuring out lockout policies if we do not allow
offline logons at all.
Guenther
Günther Deschner [Thu, 22 Jun 2006 20:07:08 +0000 (20:07 +0000)]
r16473: There is no point in calling set_dc_type_and_flags() before each
pam_auth login (when using kerberos).
Guenther
Gerald Carter [Thu, 22 Jun 2006 19:47:44 +0000 (19:47 +0000)]
r16471: Bug reported by Vitaly Protsko <villy@sft.ru> in 3.0.23rc1.
Add missing automatic add of the Administrators SID in the absence
of winbindd and precense of Domain Admins SID in the user's token.
Gerald Carter [Thu, 22 Jun 2006 19:42:38 +0000 (19:42 +0000)]
r16470: remove ntlm_auth_proto.h and passwd_proto.h in 'make clean
Günther Deschner [Thu, 22 Jun 2006 08:52:01 +0000 (08:52 +0000)]
r16458: Increase debuglevel of cli_rpc_pipe_close().
Guenther
Günther Deschner [Wed, 21 Jun 2006 23:46:07 +0000 (23:46 +0000)]
r16453: Fix another memleak.
Guenther
Günther Deschner [Wed, 21 Jun 2006 23:43:33 +0000 (23:43 +0000)]
r16452: Fix memleak in the CLDAP processing (found by valgrind).
Guenther
Jeremy Allison [Wed, 21 Jun 2006 02:31:12 +0000 (02:31 +0000)]
r16435: Add in the uid info that Jerry needs into the
share_mode struct. Allows us to know the unix
uid of the opener of the file/directory. Needed
for info level queries on open files.
Jeremy.
Jeremy Allison [Wed, 21 Jun 2006 00:17:14 +0000 (00:17 +0000)]
r16433: Fix Coverity #300 (triggered by a Klockwork bugfix
I think). If a alloc fails just return NT_STATUS_NO_MEMORY,
don't go to "done" label and deref pointers.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 20:43:05 +0000 (20:43 +0000)]
r16429: Fix final 4 Klocwork bugs we're going to fix before
release - #785, #786, #787, #788.
Jeremy.
Volker Lendecke [Tue, 20 Jun 2006 20:05:39 +0000 (20:05 +0000)]
r16427: Fix bug # 3848. Thanks to Wilco Baan Hofman for testing the release candidate!
Volker
Jeremy Allison [Tue, 20 Jun 2006 19:21:14 +0000 (19:21 +0000)]
r16426: Klocwork #1544, #1545, #1546, #1549, #1550, #1552, #1553, #1554
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 19:06:57 +0000 (19:06 +0000)]
r16424: Fix possible null deref and a memory leak found by
examining Klockwork #1519. get_printer_subkeys()
could return zero without initializing it's return
pointer arg. Fixed this. Added free of subkey pointer
return in registry/reg_printing.c (interesting that
neithe Coverity or Klocwork found this one).
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 18:30:24 +0000 (18:30 +0000)]
r16422: winbindd_demote_client isn't used and generates
a Klocwork issue (#1844). Remove it
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 18:14:33 +0000 (18:14 +0000)]
r16420: Fix Klocwork #1674. Null deref.
Jeremy.
Günther Deschner [Tue, 20 Jun 2006 12:20:11 +0000 (12:20 +0000)]
r16415: Also delete object files from iniparser.
Guenther
Volker Lendecke [Tue, 20 Jun 2006 11:06:09 +0000 (11:06 +0000)]
r16411: Fix compilation of vfs_afsacl, thanks to Greszler Szilard for trying
Volker Lendecke [Tue, 20 Jun 2006 09:16:53 +0000 (09:16 +0000)]
r16409: Fix Klocwork ID's.
1177
In reg_perfcount.c: 1200 1202 1203 1204
In regfio.c: 1243 1245 1246 1247 1251
Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This
is really your code, and I'm not sure I did the right thing to return an
error.
smbcacls.c: 1377
srv_eventlog_nt.c: 1415 1416 1417
srv_lsa_nt.c: 1420 1421
srv_netlog_nt.c: 1429
srv_samr_nt: 1458 1459 1460
Volker
Volker
Jeremy Allison [Tue, 20 Jun 2006 02:38:28 +0000 (02:38 +0000)]
r16397: Fix Klocwork #11767 and drasticly simplify the
logic in smbd/process.c. All interested (Volker,
Jerry, James etc). PLEASE REVIEW THIS CHANGE.
The logic should be identical but *much* easier
to follow and change (and shouldn't confuse Klockwork :-).
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 01:32:50 +0000 (01:32 +0000)]
r16396: Klocwork #1170. Null deref.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 01:27:39 +0000 (01:27 +0000)]
r16393: Klocwork #1164. Null deref.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 01:25:31 +0000 (01:25 +0000)]
r16392: Klockwork #1168. Protect against null deref.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 01:20:38 +0000 (01:20 +0000)]
r16390: Klocwork #604 - ensure if NULL pointer we assert
if len != 0.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 01:12:44 +0000 (01:12 +0000)]
r16388: Klocwork #320. Null deref.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 01:08:57 +0000 (01:08 +0000)]
r16386: Klockwork #lots. Ensure talloc_get_type_abort aborts
if handed a NULL pointer, not returns NULL.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 01:03:04 +0000 (01:03 +0000)]
r16383: Klocwork #1086. No null deref.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 01:00:39 +0000 (01:00 +0000)]
r16381: Now samu can't be null don't check it on set. Klockwork
related fix.
Jeremy.
Jeremy Allison [Tue, 20 Jun 2006 00:21:39 +0000 (00:21 +0000)]
r16378: Klocwork #1079. Allow BUFFER5 to cope with a NULL
dependentfiles pointer.
Jeremy.
Jeremy Allison [Mon, 19 Jun 2006 23:21:47 +0000 (23:21 +0000)]
r16377: Klocwork #1077.
Jeremy.
Jeremy Allison [Mon, 19 Jun 2006 23:19:24 +0000 (23:19 +0000)]
r16375: Klocwork #1670.
Jeremy.
Jeremy Allison [Mon, 19 Jun 2006 22:59:03 +0000 (22:59 +0000)]
r16373: Fix Klocwork #1071.
Jeremy
Jeremy Allison [Mon, 19 Jun 2006 22:55:03 +0000 (22:55 +0000)]
r16371: Fix Klocwork #1048.
Jeremy.
Jeremy Allison [Mon, 19 Jun 2006 21:47:46 +0000 (21:47 +0000)]
r16369: Klocwork #1035.
Jeremy.
Jeremy Allison [Mon, 19 Jun 2006 21:42:07 +0000 (21:42 +0000)]
r16367: Missed one, Klocwork #915.
Jeremy.
Jeremy Allison [Mon, 19 Jun 2006 21:36:19 +0000 (21:36 +0000)]
r16365: Fix Klocwork #895, #898, #899, #915, #932, #938 and a
few other problems Klocwork missed.
Jeremy.
Volker Lendecke [Mon, 19 Jun 2006 20:00:51 +0000 (20:00 +0000)]
r16363: Fix Klocwork ID 981 1652
Volker
Volker Lendecke [Mon, 19 Jun 2006 19:56:22 +0000 (19:56 +0000)]
r16362: That's the best way to fix a Klocwork bug: Remove the (unused...;-) code
altogether. This was essentially a second implementation if string_to_sid.
Klocwork ID 1038
Volker
Volker Lendecke [Mon, 19 Jun 2006 19:41:56 +0000 (19:41 +0000)]
r16361: Fix Klocwork ID 1731 1770 1771 1775 1796
Volker
Volker Lendecke [Mon, 19 Jun 2006 19:07:39 +0000 (19:07 +0000)]
r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749
in net_rpc_audit.c: 754 755 756
in net_rpc_join.c: 757
in net_rpc_registry: 766 767
in net_rpc_samsync.c: 771 773
in net_sam.c: 797 798
Volker
Jeremy Allison [Mon, 19 Jun 2006 18:49:51 +0000 (18:49 +0000)]
r16358: ALWAYS compile this stuff on a 64-bit box before
checking in. size_t != uint32 on a 64-bit machine.
Jeremy.
Jeremy Allison [Mon, 19 Jun 2006 17:23:54 +0000 (17:23 +0000)]
r16356: Helping derrell out. Jeremy.
Only set the DFS capability flag if the share is a DFS root. Fixes bug 3814.
Jeremy Allison [Mon, 19 Jun 2006 17:22:53 +0000 (17:22 +0000)]
r16355: Remove derrell-test created by mistake.
Jeremy.
Derrell Lipman [Mon, 19 Jun 2006 16:48:59 +0000 (16:48 +0000)]
r16354: r14595@cabra: derrell | 2006-05-09 00:00:35 -0400
Made a trivial change to the file so I can have one more check-in
Derrell Lipman [Mon, 19 Jun 2006 16:48:51 +0000 (16:48 +0000)]
r16353: r14594@cabra: derrell | 2006-05-08 23:59:42 -0400
Added first draft of README file, testing SVK's --patch facility
Günther Deschner [Mon, 19 Jun 2006 16:25:19 +0000 (16:25 +0000)]
r16350: Fix the build.
GUenther
Günther Deschner [Mon, 19 Jun 2006 16:00:32 +0000 (16:00 +0000)]
r16349: Another fix to make winbind more robust in large domains:
We may only feed rpc_useraliases with chunks of 1024 entries. This is
important as the token generation otherwise fails when a user is member
of more then 1024 groups.
Volker, please check.
Guenther
Günther Deschner [Mon, 19 Jun 2006 10:02:04 +0000 (10:02 +0000)]
r16346: Allow to exit a "net rpc shell" with 'quit' or 'exit'.
Guenther
Günther Deschner [Mon, 19 Jun 2006 10:01:02 +0000 (10:01 +0000)]
r16345: Improve the chance that our users can discover one of the coolest 'net'
features.
Guenther