Jeremy Allison [Fri, 22 Jun 2007 19:33:46 +0000 (19:33 +0000)]
r23591: Fix bug #4725. Don't crash when no eventlogs specified. Needs
merging for 3.0.25b.
Jeremy.
(This used to be commit
ae239fec6faa79018c818506b391b829ccd685f8)
Jeremy Allison [Fri, 22 Jun 2007 17:36:10 +0000 (17:36 +0000)]
r23590: Fix realloc leak on failure case from Jim Meyering <jim@meyering.net>.
Jeremy.
(This used to be commit
d7b39e4534d85c84e8b24668ab7d7a93d5647c23)
Jeremy Allison [Fri, 22 Jun 2007 17:19:08 +0000 (17:19 +0000)]
r23589: Ensure we will always release any timeout handler
on fsp close or removal of oplock. Mulitple removals
are safe.
Jeremy.
(This used to be commit
6de0970704b3eff2b71e6bf499c6dda45d4d5e2d)
Günther Deschner [Fri, 22 Jun 2007 14:54:39 +0000 (14:54 +0000)]
r23588: Some more cleanups and error checks in the krb5 renew function.
Guenther
(This used to be commit
277e07c8553e2ed20bc95493cdc996be43feb6bd)
Günther Deschner [Fri, 22 Jun 2007 14:50:15 +0000 (14:50 +0000)]
r23587: Cleanup redundant code in the krb5 renew function.
Guenther
(This used to be commit
0b9acc8610ae2ba9c42168e9ceb2e9ea8bc2f5bd)
Günther Deschner [Fri, 22 Jun 2007 14:43:42 +0000 (14:43 +0000)]
r23586: Fix heimdal path in the krb5 renew routine when we need to compose the tgt
string ourselves.
Guenther
(This used to be commit
1e4a7af99303fb17ebca499ff7e0a017a2017754)
Michael Adam [Fri, 22 Jun 2007 11:43:50 +0000 (11:43 +0000)]
r23585: Add a "drop" function to "net conf" that clears the
whole configuration stored in registry.
Michael
(This used to be commit
6d8973762ef2773ec64ed790f900253120e00d38)
Michael Adam [Fri, 22 Jun 2007 11:42:17 +0000 (11:42 +0000)]
r23584: Use a while loop instead of a for loop without increment... :-)
Michael
(This used to be commit
fb4ade3b4d203eead7798b8d98938cff2abb9c29)
Michael Adam [Fri, 22 Jun 2007 11:21:59 +0000 (11:21 +0000)]
r23583: Add a utility function to recursively delete a Registry
key with all its subkeys. (reg_deletekey will refuse to
delete a key with subkeys with WERR_ACCESS_DENIED).
Michael
(This used to be commit
41c3ff6e277601a9c7ac29009fd89ff9c961ca46)
Günther Deschner [Fri, 22 Jun 2007 11:20:37 +0000 (11:20 +0000)]
r23582: Fix event based krb5 ticket refreshing in winbindd.
We were incorrectly using the renew_till timestamp instead of the renewed
ticket's endtime to calculate the next refreshing date.
Guenther
(This used to be commit
aa3511a5b5e6a96a02110a7ad0ab1d43e6d25766)
Michael Adam [Fri, 22 Jun 2007 11:03:48 +0000 (11:03 +0000)]
r23581: Move regkey_open_onelevel from reg_frontend to reg_api,
where it actually belongs, and make it static.
Michael
(This used to be commit
aa702e53a7416b5599ed114089327aef8a4e35b8)
Michael Adam [Thu, 21 Jun 2007 23:11:21 +0000 (23:11 +0000)]
r23579: Up to now, the "allparameters" argument to lp_next_parameter was
not effective for the global section (snum < 0). This checkin
makes it effective for the global section, too.
This does not produce changes in the results of the present calls of
lp_next_parameter: Beside the new use in utils/net_conf.c (which is
hereby fixed), the only calls of lp_next_parameter are in web/swat.c,
where it is effectively always called with allparameters == 1.
Michael
(This used to be commit
56f82485ec3b14ddcbcf7f5823926a94b17683f3)
Michael Adam [Thu, 21 Jun 2007 22:18:42 +0000 (22:18 +0000)]
r23578: When calling DeleteKey for a key that has subkey(s), Windows
returns WERR_ACCESS_DENIED. This adapts reg_deletekey to behave
the same way.
Michael
(This used to be commit
0c9cb69b45e8c51b8c3fa0b0d034a6cad2374055)
Jeremy Allison [Thu, 21 Jun 2007 22:10:41 +0000 (22:10 +0000)]
r23577: Fix winbindd (sorry). Ensure I set the new child_pid
variable at the correct point just before the write
call is scheduled.
Jeremy.
(This used to be commit
e076dc16462a3ce11105bf9a729ec59ddd9bdc75)
James Peach [Thu, 21 Jun 2007 21:17:06 +0000 (21:17 +0000)]
r23576: Fix some confusion between HAVE_BROKEN_GETGROUPS and USE_BSD_SETGROUPS.
(This used to be commit
8f6cf4b8c2568c737fa31494b844ae021a42a4fc)
Michael Adam [Thu, 21 Jun 2007 20:56:56 +0000 (20:56 +0000)]
r23575: Fix a segfault when lp_load is called before init_registry.
Michael
(This used to be commit
235a5ae4cdf3ea238728c2e89a4318c18257426a)
Jeremy Allison [Thu, 21 Jun 2007 19:40:51 +0000 (19:40 +0000)]
r23574: Remove double-null check (I hate people bitching at me
on the lists :-).
Jeremy.
(This used to be commit
f075620d2071aaecb72e93cbda32c4f624f23d86)
Jeremy Allison [Thu, 21 Jun 2007 18:44:14 +0000 (18:44 +0000)]
r23573: Cope with terminating winbindd children on read/write/timeout
communication failures. Set timeout to 5 mins. Ensure that
we're terminating the correct child (the one we thought we
were talking to). Still setting up my testing environment
but I have high hopes for this being the fix for the 3.0.25b
showstopper.
Jeremy.
(This used to be commit
c366df2fe7f1aa1e8fd9bca35bc3b029d76b3abc)
Jeremy Allison [Thu, 21 Jun 2007 17:25:13 +0000 (17:25 +0000)]
r23572: Ensure we obey Unicode consortium restrictions. Code
based on patch from MORIYAMA Masayuki <moriyama@miraclelinux.com>.
Jeremy.
(This used to be commit
0f10d2ed312115998d5ce1dc88a8d9207c9e4959)
Simo Sorce [Thu, 21 Jun 2007 17:05:59 +0000 (17:05 +0000)]
r23571: Fix, parsing of multi byte share names.
Thanks to SATOH Fumiyasu
Fixes 4720
Jerry,
this is a showstopper for 3.0.25b, please grab it into
SAMBA_3_0_RELEASE before cuting the tarballs.
Simo.
(This used to be commit
d2846e6b90e8774a729e6cf3a0c809aa8ff4a93a)
Günther Deschner [Thu, 21 Jun 2007 15:12:51 +0000 (15:12 +0000)]
r23569: Also dump fd_event in dump_event_list().
Guenther
(This used to be commit
27fdf995d13611ebc9e57895f886c184e9027c4d)
Günther Deschner [Thu, 21 Jun 2007 14:32:09 +0000 (14:32 +0000)]
r23568: Remove last traces of Heimdal KCM support (and don't misuse wbinfo where a
torture test would be much more appropriate). Fix #4408.
Guenther
(This used to be commit
7514a370cae9c6fdacffd2b885fd93cb1230ce96)
Volker Lendecke [Thu, 21 Jun 2007 14:30:40 +0000 (14:30 +0000)]
r23567: Fix bug 4721
(This used to be commit
f2050f5a3af382ad88071a5d5f6b172af4143e0f)
Michael Adam [Thu, 21 Jun 2007 14:23:06 +0000 (14:23 +0000)]
r23566: Fix the sys_bsd_setgroups function. The actual workaround was inactive.
Michael
(This used to be commit
4b5d9b2ba773e6ce57c38e3c0d5af72ad5a98b51)
Günther Deschner [Thu, 21 Jun 2007 14:04:55 +0000 (14:04 +0000)]
r23565: Avoid double NULL pointer checks.
Guenther
(This used to be commit
5456ea59ba12593b0aac9745b41cdd0f5ec0a559)
Günther Deschner [Thu, 21 Jun 2007 13:05:56 +0000 (13:05 +0000)]
r23564: Handle MSG_DUMP_EVENT_LIST only in winbindd for now.
Guenther
(This used to be commit
2592e68a43a73474e1bb53f83642c864fd159b45)
Günther Deschner [Thu, 21 Jun 2007 13:04:28 +0000 (13:04 +0000)]
r23563: Add dump-event-list command to smbcontrol.
Guenther
(This used to be commit
0d956a8e45cd4421cddb8e077e1960dafac3a4d0)
Günther Deschner [Thu, 21 Jun 2007 13:03:27 +0000 (13:03 +0000)]
r23562: Add dump_event_list() for debugging the event list.
Guenther
(This used to be commit
4e1e697ac48513719bd3a2152f17871bc00df796)
Jeremy Allison [Wed, 20 Jun 2007 23:24:18 +0000 (23:24 +0000)]
r23556: Fix for error path from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>.
Jeremy.
(This used to be commit
3f70c1b10589965ee95ef7497ff6fb7c39475569)
Jeremy Allison [Wed, 20 Jun 2007 18:05:48 +0000 (18:05 +0000)]
r23555: Fix some uninitialiazed variable uses.
Jeremy
(This used to be commit
dc287adff249e45a5584ec5fb9177e62152a7403)
Jeremy Allison [Wed, 20 Jun 2007 17:38:42 +0000 (17:38 +0000)]
r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.
Long overdue fix....
Jeremy.
(This used to be commit
073fdc5a58139796dbaa7ea9833dca5308f11282)
Michael Adam [Wed, 20 Jun 2007 10:08:31 +0000 (10:08 +0000)]
r23553: Also ignore "lock directory" in registry global options.
Michael
(This used to be commit
3695a66166c6aa88051b21ad40a19f1cc8b87c7b)
Michael Adam [Wed, 20 Jun 2007 08:47:13 +0000 (08:47 +0000)]
r23552: Use proper comparison function an fix logic.
Michael
(This used to be commit
a4714b34284f9e205556166166f41ce9dad4d3da)
Jeremy Allison [Wed, 20 Jun 2007 01:26:18 +0000 (01:26 +0000)]
r23550: Add more UNIX error -> NT status mappings.
Jeremy.
(This used to be commit
1e66a8340e7db9c42507d93d67ad33abadabd2a1)
Michael Adam [Tue, 19 Jun 2007 21:40:27 +0000 (21:40 +0000)]
r23549: Make "net conf setparm" always use registry data type "sz".
This simplifies the usage of this command from
"net conf setparm <section> <param> <type> <value>"
to
"net conf setparm <section> <param> <value>".
Micheal
(This used to be commit
41a8f8ec5f5361f536d047c4ca5d90203b16ff06)
Michael Adam [Tue, 19 Jun 2007 21:08:46 +0000 (21:08 +0000)]
r23548: Fix comments.
Michael
(This used to be commit
73e41c1d0a7af7488b35b54182ea532103b51fd4)
Michael Adam [Tue, 19 Jun 2007 21:06:31 +0000 (21:06 +0000)]
r23547: Ignore parameter "include" in regsitry globals.
Michael
(This used to be commit
f0992c0d79bb6a5810c84a9eac208d83390bb047)
Michael Adam [Tue, 19 Jun 2007 11:11:01 +0000 (11:11 +0000)]
r23543: Adjust comments.
(This used to be commit
ec22c30581f0809b6a008982abceb97b4f9cd12e)
James Peach [Mon, 18 Jun 2007 16:10:00 +0000 (16:10 +0000)]
r23541: Linking the LSA pipe module only once is probably enough.
(This used to be commit
1d941961e0739c22d32720bac4ecd6beef6d74c5)
Kai Blin [Mon, 18 Jun 2007 13:59:09 +0000 (13:59 +0000)]
r23539: Remove code duplication and unify behaviour of winbind_nss_*.h files
(This used to be commit
13c6eacff02b55b9fd6201406802f271dcf13e8e)
Volker Lendecke [Mon, 18 Jun 2007 12:22:42 +0000 (12:22 +0000)]
r23538: Fix for wild-card rename: We can't return directly on error, we need to
CloseDir.
(This used to be commit
48cdafc10a0eb615d79057ec9e235ffe9a85e016)
Volker Lendecke [Mon, 18 Jun 2007 09:25:31 +0000 (09:25 +0000)]
r23537: Revert the inbuf/outbuf part of r23528: This caused the Solaris CC make test
to break. The Solaris CC put the static char InBuffer[TOTAL_BUFFER_SIZE] on an
odd address, the malloc'ed one is always aligned. The problem showed up in
pull_ucs2, ucs2_align uses the address of InBuffer as an indication whether to
bump up the src of the string by one. Unfortunately in the trans calls the
data portion is malloced and thus has different alignment guarantees than a
static variable. This one is bigger....
Volker
(This used to be commit
6affd7818f6981be2a9f44fcf302e7fddb468347)
Michael Adam [Sun, 17 Jun 2007 23:13:32 +0000 (23:13 +0000)]
r23536: Fix a typo. James: Please check!
Michael
(This used to be commit
d90aa8368af624761a19cd1e55ed9f18bc64f45d)
Jeremy Allison [Sun, 17 Jun 2007 19:23:32 +0000 (19:23 +0000)]
r23530: Fix bugs #4678 and #4697 which had the same root cause.
In make_server_info_pw() we assign a user SID in our
authoritative SAM, even though this may be from a
pure "Unix User" that doesn't exist in the SAM.
This causes lookups on "[in]valid users" to fail as they
will lookup this name as a "Unix User" SID to check against
the user token. Fix this by adding the "Unix User"\unix_username
SID to the sid array. The correct fix should probably be
changing the server_info->sam_account user SID to be a
S-1-22 Unix SID, but this might break old configs where
plaintext passwords were used with no SAM backend.
Jeremy
(This used to be commit
80d1da7e6cce451d3934751feaa6ad60a337e3db)
Volker Lendecke [Sun, 17 Jun 2007 05:19:30 +0000 (05:19 +0000)]
r23528: Two changes to make the valgrind massif (heap profiler) output readable:
Remove the allocated inbuf/output. In async I/O we copy the buffers
explicitly now, so NewInBuffer is called exactly once. This does not
reduce memory footprint, but removes one of the larger chunks that
clobber the rest of the massif output
In getgroups_unix_user on Linux 2.6 we allocated 64k groups x 4 bytes
per group x 2 (once in the routine itself and once in libc) = 512k just
to throw it away directly again. This reduces it do a more typical limit
of 32 groups per user. We certainly cope with overflow fine if 32 is not
enough. Not 100% sure about this one, a DEVELOPER only thing?
(This used to be commit
009af0909944e0f303c5d496b56fb65ca40a41d5)
Simo Sorce [Sat, 16 Jun 2007 22:52:51 +0000 (22:52 +0000)]
r23527: Use existing escaping function pointed by James
(This used to be commit
9dcbef9615aec7cfe8f72e6f21f01af4e4fcc90e)
Simo Sorce [Sat, 16 Jun 2007 18:59:02 +0000 (18:59 +0000)]
r23525: I believe this patch is ok, got no reply of it being not ok.
This closes #4624 for me.
(This used to be commit
3635b304155299ac93fda57e5e9ece0acd605e77)
Simo Sorce [Sat, 16 Jun 2007 18:54:13 +0000 (18:54 +0000)]
r23524: Fix bug 2319.
Got report this is all ok form a tester. Close a loong
standing bug preventing people to freely use any character
in their password when printing via cups were involved.
(This used to be commit
54ca011212982cf1d94a76ca9d39c391783da04f)
Volker Lendecke [Sat, 16 Jun 2007 18:19:42 +0000 (18:19 +0000)]
r23523: Gaa -- had renamed "name" to "path" and apparently not compiled after
that....
Volker
(This used to be commit
1a45ea28ced3775acd6127e05e844873ed23d40b)
Volker Lendecke [Sat, 16 Jun 2007 18:07:44 +0000 (18:07 +0000)]
r23522: Save us a kilobyte stack space in a hot code path: I can't see a reason
why check_path_syntax should not be able to run in-line. The destination
pointer either walks side by side with the source pointer or is
decremented. So as far as I can see s>=d is true throughout the whole
routine.
Jeremy, I'm checking this only into 3_0 for now. Please review and ack
or directly merge this to 3_0_26.
Thanks,
Volker
(This used to be commit
34a13c82a3b72d6900614b57c58fbaefeeca8fa7)
Volker Lendecke [Sat, 16 Jun 2007 11:48:11 +0000 (11:48 +0000)]
r23518: Remove the silly assumption that string_replace requires a pstring.
Jeremy, I am always very confused about the different length arguments
in convert_string and friends. Can you take a look at the change in
string_replace and verify it's ok? Thanks!
While at it, remove the pstring limit for strhasupper and strhaslower.
(This used to be commit
e6e5703658aeaeb0cca5d7281095e17553001d4b)
Volker Lendecke [Sat, 16 Jun 2007 10:02:51 +0000 (10:02 +0000)]
r23517: After Jeremy has given is ack on irc:
Change rename_internals to open the file/directory and then call
rename_internals_fsp. Two reasons: Remove code duplication and remove a
race condition. The race condition was due to the fact that in
can_rename the share mode check closed the file and then after that did
the rename.
(This used to be commit
aa16d8a649d1a38593edd5ca94ed2c7d4291911b)
Jeremy Allison [Sat, 16 Jun 2007 01:04:22 +0000 (01:04 +0000)]
r23516: Fix bug found & fixed by Doug Rudoff (doug_rudoff@isilon.com)
- when cleaning up invalid locks make sure we mark the lck
struct as modified so it'll get saved back correctly (that
was the original intent).
Jeremy.
(This used to be commit
cbf0829abcc3689edd7ab225054dfc79d43c6309)
Jeremy Allison [Sat, 16 Jun 2007 00:54:58 +0000 (00:54 +0000)]
r23515: Ensure status isn't used uninitialized.
Jeremy.
(This used to be commit
5b2836e2d5f9081b5e39637538d8f2d19e1115c4)
Jeremy Allison [Sat, 16 Jun 2007 00:39:52 +0000 (00:39 +0000)]
r23514: Remove unused function ads_get_dn_from_extended_dn().
Jeremy.
(This used to be commit
03763bc5287fef5f100c911041668e23d4305f8d)
Jeremy Allison [Fri, 15 Jun 2007 23:52:01 +0000 (23:52 +0000)]
r23513: Fix one more use of VALUE_PREFIX.
Jeremy.
(This used to be commit
fca5637dc6c91a57c4e087670068688557e5bf32)
Jeremy Allison [Fri, 15 Jun 2007 23:47:40 +0000 (23:47 +0000)]
r23512: Fix conflict in #define for SECDESC_PREFIX. Ensure all
reg #defines use "REG_" prefix. Michael - please check
gcc warnings on compiles.
Jeremy.
(This used to be commit
7885b68bb5df0ebe290feca0e74b4a20ef59e718)
James Peach [Fri, 15 Jun 2007 21:58:49 +0000 (21:58 +0000)]
r23510: Tidy calls to smb_panic by removing trailing newlines. Print the
failed expression in SMB_ASSERT.
(This used to be commit
171dc060e2a576d724eed1ca65636bdafffd7713)
Michael Adam [Fri, 15 Jun 2007 21:38:10 +0000 (21:38 +0000)]
r23509: This activates the global options from the registry in loadparm.
The global options are stored as values in the subkey "global"
of the SMBCONF registry key.
The activation is accomplished in smb.conf though a new special
semantic of the "include" parameter: "include = registry" triggers
the processing of the registry global options exactly at the
position of the include statement. Options read from the registry
take the same precedence as parameters loaded from a file via
include. Need to reload the registry globals is detected by
watching the tdb sequence number.
Registry shares are automatically activated when the registry
globals are processed.
So a "registry only" configuration can be realized by an
smb.conf that looks as follows:
================================
[global]
include = registry
================================
The global options and registry shares can be conveniently
edited with the "net conf" utility.
Caveat:
A possible pitfall consists in using "include = registry"
together with the "lock directory" directive in the registry.
This problem will be addressed in the next time.
Note on the code:
Processing of the registry options is accomplished by a function
process_registry_globals() in loadparm.c The current version is
only an interim solution: It is handcoded instead of using the
infrastructure of reg_api.c. The reason for this is that using
reg_api still has too large linker dependencies, bloating virtually
all targets by PASSDB_OBJ, SMBLDAP_OBJ, GROUPDB_OBJ and LDB stuff.
A version of process_registry_globals that uses reg_api is
included but commented out. The goal is to eventually refactor
and restructure the registry code so that one can use the reg_api
to access only the registry tdb and not link all the dynamic
backends with all their linking implications.
(This used to be commit
24b0cbcb3741dd14b04728448a85cc04a057e7d0)
Jeremy Allison [Fri, 15 Jun 2007 19:24:04 +0000 (19:24 +0000)]
r23508: Fix sync_file() to return NTSTATUS and return this
on failure in the write path.
Jeremy.
(This used to be commit
cd3f7dbee809fb40194af0e7509142166e02b252)
Michael Adam [Fri, 15 Jun 2007 15:51:45 +0000 (15:51 +0000)]
r23507: Split one general function normalize_dbkey from reg_db.c into util_reg.c
(To be used in other place in subsequent commit.)
Michael
(This used to be commit
6fd71140499e30b8fd0f083301512db7b8c2f236)
Michael Adam [Fri, 15 Jun 2007 10:40:36 +0000 (10:40 +0000)]
r23504: Use tdb_wrap_open (instead of usual tdb_open) in reg_db.
This eliminates the need of maintaining reg_db's own
reference counter for the tdb. Maybe as a next step...
Michael
(This used to be commit
31d64767fc8a73be1f6b81e2712d687897f812a0)
James Peach [Thu, 14 Jun 2007 18:48:51 +0000 (18:48 +0000)]
r23502: Restore exit-on-idle. Small refactoring for clarity. Exit if
we are idle and we timed out waiting for something to do.
(This used to be commit
b4ab1a0cd992cf9e966b8edb9796d1eae53db744)
Volker Lendecke [Thu, 14 Jun 2007 15:50:47 +0000 (15:50 +0000)]
r23501: Move notify_rename before rename_internals_fsp and call it from there.
(This used to be commit
8d3828871c561cd05e6461e157db4c0ccddd5f22)
Volker Lendecke [Thu, 14 Jun 2007 14:45:37 +0000 (14:45 +0000)]
r23500: Two changes to survive the now activated test for rename_internals_fsp:
With the target being open we have to return NT_STATUS_ACCESS_DENIED and
root_fid != 0 leads to NT_STATUS_INVALID_PARAMETER
(This used to be commit
b599e5b1e10bdf825b2ce53de4a6ec35726d00f6)
Gerald Carter [Thu, 14 Jun 2007 14:35:29 +0000 (14:35 +0000)]
r23497: Disable building of libaddns (no defined API) and
libmsrpc (unmaintained).
(This used to be commit
13d78ace49d0f7c5330c5297ef563284f573239a)
Gerald Carter [Thu, 14 Jun 2007 14:12:53 +0000 (14:12 +0000)]
r23496: Fix logic error in getgrnam_recv() that broke
getgrnam() for machine and domain local groups.
(This used to be commit
4d4c1eca30ce57b4072e9f8c59fcc49bf3a5c48e)
Michael Adam [Thu, 14 Jun 2007 13:26:31 +0000 (13:26 +0000)]
r23495: Replace literal occurrences of libsmb/errormap.o by $(ERRORMAP_OBJ).
(This used to be commit
2041c35a305e0d6ee015b54fb17fe416dc14a8bc)
Michael Adam [Thu, 14 Jun 2007 13:12:32 +0000 (13:12 +0000)]
r23494: Synchronize some occurrences of BINARY_PREREQS and bin/.dummy.
Further reduce the diff between 3_0 and 3_0_26 by some reformatting
and rearrangements.
Michael
(This used to be commit
02685358d104775e6b8cad156aa70458ab3a55f6)
Michael Adam [Thu, 14 Jun 2007 12:29:04 +0000 (12:29 +0000)]
r23489: (Re-)Add tdbtorture as a build target to 3_0_26.
Add the tdbtorture test to the test script in 3_0 and 3_0_26.
Michael
(This used to be commit
30d71cf4b8decd6fad0c44a3eb57e29ea7d898a0)
Volker Lendecke [Thu, 14 Jun 2007 12:03:46 +0000 (12:03 +0000)]
r23486: Ok, this time with a hopefully successful make test in the right place:
Remove two local variables
(This used to be commit
575e594e936c3cb197945063309f0b424dcdefc8)
Michael Adam [Thu, 14 Jun 2007 11:29:35 +0000 (11:29 +0000)]
r23485: This checkin consists mostly of refactorings in preparation of the
activation of global registry options in loadparm.c, mainly to
extract functionality from net_conf.c to be made availabel elsewhere
and to minimize linker dependencies.
In detail:
* move functions registry_push/pull_value from lib/util_reg.c to new file
lib/util_reg_api.c
* create a fake user token consisting of builtin administrators sid and
se_disk_operators privilege by hand instead of using get_root_nt_token()
to minimize linker deps for bin/net.
+ new function registry_create_admin_token() in new lib/util_reg_smbconf.c
+ move dup_nt_token from auth/token_util.c to new file lib/util_nttoken.c
+ adapt net_conf.c and Makefile.in accordingly.
* split lib/profiles.c into two parts: new file lib/profiles_basic.c
takes all the low level mask manipulation and format conversion functions
(se_priv, privset, luid). the privs array is completely hidden from
profiles.c by adding some access-functions. some mask-functions are not
static anymore.
Generally, SID- and LUID-related stuff that has more dependencies
is kept in lib/profiles.c
* Move initialization of regdb from net_conf.c into a function
registry_init_regdb() in lib/util_reg_smbconf.c.
Michael
(This used to be commit
efd3e2bfb756ac5c4df7984791c67e7ae20a582e)
Günther Deschner [Thu, 14 Jun 2007 09:59:07 +0000 (09:59 +0000)]
r23484: When chasing AD referrals make sure to honor the base returned from the server.
Guenther
(This used to be commit
865bdcacae49299c19d7000242832fa41fdfa9d2)
Volker Lendecke [Thu, 14 Jun 2007 09:51:13 +0000 (09:51 +0000)]
r23483: Revert 23482, I must have run 'make test' in the wrong subdir.
(This used to be commit
1ce0c582bccc90e54a69b1e70973ed7ccb47cbbb)
Volker Lendecke [Thu, 14 Jun 2007 09:45:39 +0000 (09:45 +0000)]
r23482: Slightly simplify the rename code: Remove two local variables that are
not really needed.
(This used to be commit
e068e38ef3b364f2c6477f9d8d6ef3b81a6207ca)
James Peach [Thu, 14 Jun 2007 04:00:35 +0000 (04:00 +0000)]
r23480: Fix DEVELOPER_CFLAGS quoting.
(This used to be commit
4cdc7eaac78f04f19f1ed738fd918862bd2f7d4c)
James Peach [Thu, 14 Jun 2007 03:38:43 +0000 (03:38 +0000)]
r23478: Change the handling of the developer CFLAGS so that they are always
emited to the Makefile in the DEVELOPER_CFLAGS variable. This makes
it easy to turn developer mode on and off without waiting for
configure to run. The developer flags are only added to CFLAGS for
the --enable-developer and --enable-krb5developer cases.
(This used to be commit
4b392a76eb392375f369c8c64fccd138833dcb52)
Gerald Carter [Wed, 13 Jun 2007 21:59:39 +0000 (21:59 +0000)]
r23477: Build farm fix: Use int rather than MIT's krb5_int32 when setting context flags.
(This used to be commit
903145e957cd05b219fdf7d5fc1e35430938a24e)
James Peach [Wed, 13 Jun 2007 21:42:31 +0000 (21:42 +0000)]
r23475: Fix the prototype for sys_broken_setgroups and log *BSD group list
truncation a bit more verbosely.
(This used to be commit
e3ea997289f9f2613c304c016b42b2d35af48c84)
Gerald Carter [Wed, 13 Jun 2007 20:49:20 +0000 (20:49 +0000)]
r23474: Here's a small patch that disables the libkrb5.so replay cache
when verifying a ticket from winbindd_pam.c.
I've found during multiple, fast, automated SSH logins (such
as from a cron script) that the replay cache in MIT's krb5
lib will occasionally fail the krb5_rd_req() as a replay attack.
There seems to be a small window during which the MIT krb5
libs could reproduce identical time stamps for ctime and cusec
in the authenticator since Unix systems only give back
milli-seconds rather than the micro-seconds needed by the
authenticator. Checked against MIT 1.5.1. Have not
researched how Heimdal does it.
My thinking is that if someone can spoof the KDC and TDS
services we are pretty hopeless anyways.
(This used to be commit
cbd33da9f78373e29729325bbab1ae9040712b11)
Gerald Carter [Wed, 13 Jun 2007 20:43:49 +0000 (20:43 +0000)]
r23472: add missing default setting for 'winbind nss info' (merge from 3.0.26)
(This used to be commit
1f80f9d14553650fb9d24f1d4c36e5cf7986ce23)
Gerald Carter [Wed, 13 Jun 2007 20:40:54 +0000 (20:40 +0000)]
r23471: Here's a rough patch for expanding domain group membership
in the winbindd_getgrnam() call. Couple of comments:
* Adds "winbind expand groups" parameter which defines the
max depth winbindd will expand group members. The default
is the current behavior of one level of expansion.
* The entire getrgnam() interface should be async. I
haven't done that.
* Refactors the domain users hack in fill_grent_mem() into
its own function.
(This used to be commit
3d3a8130351753dc5caa2a270d130e2150da6b54)
James Peach [Wed, 13 Jun 2007 20:40:50 +0000 (20:40 +0000)]
r23470: Fix supplementary group list truncation for *BSD. We need to pass
the correct group list length and only truncate to NGROUPS_MAX if
it is too long.
(This used to be commit
07f562be7a64a2ded7ec0e6f5910447dc5b8b85f)
Volker Lendecke [Wed, 13 Jun 2007 19:01:41 +0000 (19:01 +0000)]
r23469: Fix a comment
(This used to be commit
47cc9359aa1b4d5fcd9469be0b1378030ac388fc)
Michael Adam [Wed, 13 Jun 2007 13:15:16 +0000 (13:15 +0000)]
r23468: Open registry.tdb with sequence number.
Add a function to retrieve the registry db sequence number.
This is in preparation of loadparm integration of registry global
smb.conf options: this will allow to detect changes in order to trigger reload.
Michael
(This used to be commit
ebe2ea8f22bfe0855beee087af771c690db443c1)
Volker Lendecke [Wed, 13 Jun 2007 12:52:36 +0000 (12:52 +0000)]
r23467: Next little simplification: In rename_internals it's a bit pointless to
first ask for existence of a file when we do the open_file_ntcreate in
can_rename later on anyway. That also gets us the right error message in
case the file is not there automatically.
(This used to be commit
f3d582cb908f95c1b557bda5d41b5a8aff75b124)
Volker Lendecke [Wed, 13 Jun 2007 11:32:46 +0000 (11:32 +0000)]
r23466: Fix RAW-NOTIFY: by using delete on close the notify is triggered deep
inside close_file() already.
(This used to be commit
0b29e3ad0f2b1759eb195fb37f1f8667d87f5670)
Michael Adam [Wed, 13 Jun 2007 11:04:31 +0000 (11:04 +0000)]
r23465: There was this diff between reg_printing in 3_0 and 3_0_26:
before writing to secdesc_buf->sd,
3_0 checked secdesc_buf->sd while 3_0_26 checked secdesc_buf->sd_size.
This patch makes both revisions check _both_ befor writing.
Jerry / Jeremy : please check if this is correct!
Michael
(This used to be commit
dfc42178708144ef0b9273438ee15451078d3f4e)
Michael Adam [Wed, 13 Jun 2007 10:12:33 +0000 (10:12 +0000)]
r23460: Re-add whitespace to reduce diff between branches.
Sorry for the noise...
Michael
(This used to be commit
c7d004dec4822c0d8e5c7fd6519850f906c7bb1a)
Michael Adam [Wed, 13 Jun 2007 10:07:05 +0000 (10:07 +0000)]
r23459: Remove one superfluous cast.
(This used to be commit
beed87550786052891969f6014088c17a5d77157)
Michael Adam [Wed, 13 Jun 2007 10:06:17 +0000 (10:06 +0000)]
r23458: Cosmetic fix in debug output.
(This used to be commit
03dbdb561a16a6e3dbd99ee29aac598457873002)
Volker Lendecke [Wed, 13 Jun 2007 09:55:13 +0000 (09:55 +0000)]
r23457: After Jeremy's ack:
The attached patch removes a little race condition for
people with real kernel oplock support, and reduces some
code paths. It changes reply_unlink to open_file_ntcreate,
set_delete_on_close and close_file.
The race condition happens if we break the oplock in
can_delete via open_file_ntcreate, we close the file,
someone else gets a batch oplock and we try to unlink.
It reduces code paths by calling SMB_VFS_UNLINK in 2 fewer
places.
(This used to be commit
0342ce7057045a362134281bcc7030111276dea0)
Jeremy Allison [Tue, 12 Jun 2007 19:59:38 +0000 (19:59 +0000)]
r23450: max_params_return is complete fiction when getting a changenotify
request. Ignore it. Should fix bug #4689 but more tests and
valgrinding will follow.
Jeremy.
(This used to be commit
c23e08cc09b8de860ab9c7ac9d0e7c2502dfccd9)
Jeremy Allison [Tue, 12 Jun 2007 19:53:51 +0000 (19:53 +0000)]
r23448: Doh ! Don't call winbind_child_died() *before* the
kill call as that sets pid = 0 ! :-).
Jeremy.
(This used to be commit
bcfce39094ef30a1d1ae4dba5a90738e2678bcbf)
Jeremy Allison [Tue, 12 Jun 2007 19:47:33 +0000 (19:47 +0000)]
r23447: Add kill signal to child dead path. After talking
to Jerry add to 3.0.25b.
Jeremy.
(This used to be commit
ade91e78cbe2871d3a8df18fa1f92bc16a7600a8)
Volker Lendecke [Tue, 12 Jun 2007 19:19:35 +0000 (19:19 +0000)]
r23446: Restore Jeremy's original formatting, just fix the comment.
(This used to be commit
5b983957e3a0a05f77bfb8a10a7986c22b81088d)
Jeremy Allison [Tue, 12 Jun 2007 18:14:16 +0000 (18:14 +0000)]
r23445: Fix suggested by Volker. Don't call rename_open_files
if the name wasn't changed.
Jeremy.
(This used to be commit
7a9629365eb4eb2829982fe2b2bfffd840648e6f)
Michael Adam [Tue, 12 Jun 2007 12:35:24 +0000 (12:35 +0000)]
r23434: Coorect a comment.
(This used to be commit
c9f38fa30e9b784a56f08d0ab4765e9c7a42aa7d)
Michael Adam [Tue, 12 Jun 2007 12:01:52 +0000 (12:01 +0000)]
r23433: remove superfluous semicolon.
(This used to be commit
b8269f454338c8b20b90451f3866fc193871e9af)
Michael Adam [Tue, 12 Jun 2007 11:54:25 +0000 (11:54 +0000)]
r23432: Remove superfluous comment.
(A relict from regkey_open_internal days.)
Michael
(This used to be commit
4025cbc2024acf36e96d7236225b439dbd3e4df0)