metze/old/v3-2-winbind-ndr.git
16 years agouse the GPLv3 boilerplate as recommended by the FSF and the license text
tridge [Tue, 10 Jul 2007 00:52:41 +0000 (00:52 +0000)]
use the GPLv3 boilerplate as recommended by the FSF and the license text

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23784 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoProcessing the UAS change message was causing problems on ppc64 Linux
tridge [Tue, 10 Jul 2007 00:47:40 +0000 (00:47 +0000)]
Processing the UAS change message was causing problems on ppc64 Linux
systems. Rather than trying to fix this, it's much better just to
remove the code, as it serves no purpose at all (the message that is
generated is ignored by smbd).

This sort of parsing should really be done by PIDL generated code.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23783 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoI tested this against NT4 PDC, W2K Server, W2K3 Dc, and a Win XP std alone
idra [Mon, 9 Jul 2007 22:15:22 +0000 (22:15 +0000)]
I tested this against NT4 PDC, W2K Server, W2K3 Dc, and a Win XP std alone
client and they all work with this code.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23782 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFind and fix more GPL2 -> GPL3.
jra [Mon, 9 Jul 2007 19:46:27 +0000 (19:46 +0000)]
Find and fix more GPL2 -> GPL3.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23780 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoChange from v2 or later to v3 or later.
jra [Mon, 9 Jul 2007 19:25:36 +0000 (19:25 +0000)]
Change from v2 or later to v3 or later.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23779 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoChange to GPLv3. Now to go through all internal source
jra [Mon, 9 Jul 2007 18:59:33 +0000 (18:59 +0000)]
Change to GPLv3. Now to go through all internal source
and headers. Probably will be a long day.... :-).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23778 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoSet template release note files
jerry [Mon, 9 Jul 2007 18:28:46 +0000 (18:28 +0000)]
Set template release note files

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23777 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoSetting version in 3.2 branch to 3.2.1pre1-SVN
jerry [Mon, 9 Jul 2007 18:26:53 +0000 (18:26 +0000)]
Setting version in 3.2 branch to 3.2.1pre1-SVN
Setting version in 3.2.0 branch to 3.2.0pre1-SVN

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23776 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agobranch 3.2 from 3.0
jerry [Mon, 9 Jul 2007 18:16:03 +0000 (18:16 +0000)]
branch 3.2 from 3.0

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@23774 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoOne pstring a day...
vlendec [Mon, 9 Jul 2007 16:27:13 +0000 (16:27 +0000)]
One pstring a day...

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23773 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAdd ads_find_samaccount() helper function.
gd [Mon, 9 Jul 2007 16:03:00 +0000 (16:03 +0000)]
Add ads_find_samaccount() helper function.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23772 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoMerge useful W_ERROR_NOT_OK_RETURN macro from samba4.
gd [Mon, 9 Jul 2007 15:53:08 +0000 (15:53 +0000)]
Merge useful W_ERROR_NOT_OK_RETURN macro from samba4.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23771 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoSome minor cleanups in libgpo
gd [Mon, 9 Jul 2007 15:48:17 +0000 (15:48 +0000)]
Some minor cleanups in libgpo
(including some valgrind errors, uninitialized vars, etc.)

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23770 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoMove removal of the tdb from the generic tdb_validate function
obnox [Mon, 9 Jul 2007 15:34:46 +0000 (15:34 +0000)]
Move removal of the tdb from the generic tdb_validate function
to the caller (winbindd_validate_cache in this case).
Next, there will be a backup handling for the tdb files.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23769 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoGet rid of the three global variables for the case semantics. I think
vlendec [Mon, 9 Jul 2007 14:43:36 +0000 (14:43 +0000)]
Get rid of the three global variables for the case semantics. I think
this is really not worth globals.

Jeremy, please check for 3.0.26.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23768 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAdd GTYPE_SECURITY_UNIVERSAL_GROUP to adsearch.pl as well.
gd [Mon, 9 Jul 2007 13:31:32 +0000 (13:31 +0000)]
Add GTYPE_SECURITY_UNIVERSAL_GROUP to adsearch.pl as well.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23767 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAdd GTYPE_SECURITY_UNIVERSAL_GROUP define.
gd [Mon, 9 Jul 2007 13:28:46 +0000 (13:28 +0000)]
Add GTYPE_SECURITY_UNIVERSAL_GROUP define.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23766 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAnother error-path restore_case_semantics().
vlendec [Mon, 9 Jul 2007 13:24:31 +0000 (13:24 +0000)]
Another error-path restore_case_semantics().

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23765 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoDo restore_case_semantics in an error path. Jeremy, please check!
vlendec [Mon, 9 Jul 2007 13:04:44 +0000 (13:04 +0000)]
Do restore_case_semantics in an error path. Jeremy, please check!

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23764 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix a typo in DEBUG message.
obnox [Mon, 9 Jul 2007 12:59:17 +0000 (12:59 +0000)]
Fix a typo in DEBUG message.
Thanks to Karolin Seeger (ks@sernet.de)

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23763 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoRename reduce_name to check_reduced_name
vlendec [Mon, 9 Jul 2007 09:43:41 +0000 (09:43 +0000)]
Rename reduce_name to check_reduced_name

The function name reduce_name is misleading, making the user believe it
changes an argument.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23761 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoUntangle use of strrchr_m and strequal and add some checks
obnox [Mon, 9 Jul 2007 09:35:03 +0000 (09:35 +0000)]
Untangle use of strrchr_m and strequal and add some checks
for the validity of the given registry key name.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23760 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix make test -- sorry
vlendec [Mon, 9 Jul 2007 08:45:14 +0000 (08:45 +0000)]
Fix make test -- sorry

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23759 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix Coverity id 385
vlendec [Mon, 9 Jul 2007 08:04:43 +0000 (08:04 +0000)]
Fix Coverity id 385

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23758 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix Coverity id 386
vlendec [Mon, 9 Jul 2007 08:00:50 +0000 (08:00 +0000)]
Fix Coverity id 386

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23757 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix Coverity id 388
vlendec [Mon, 9 Jul 2007 07:55:09 +0000 (07:55 +0000)]
Fix Coverity id 388

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23756 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix Coverity id 384
vlendec [Mon, 9 Jul 2007 07:51:39 +0000 (07:51 +0000)]
Fix Coverity id 384

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23755 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix bug introduced by checkin 22920, allow large
jra [Mon, 9 Jul 2007 00:48:07 +0000 (00:48 +0000)]
Fix bug introduced by checkin 22920, allow large
readX. Fix from Dmitry Shatrov <dhsatrov@linux.vnet.ibm.com>.

"In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set
to an invalid large value due to integer overflow.
As for me, this resulted in MS Word hanging while trying to save
a 1.5Mb document."

This isn't in shipping code.

Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23752 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoCall tdb_close even when validation was not successful.
obnox [Sun, 8 Jul 2007 22:01:43 +0000 (22:01 +0000)]
Call tdb_close even when validation was not successful.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23751 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoChange the behaviour of net conf import when there is a global section
obnox [Sat, 7 Jul 2007 23:57:25 +0000 (23:57 +0000)]
Change the behaviour of net conf import when there is a global section
in the current registry and there is no global section in the input
file (or only global options with default values):
In that case the existing global section is now not touched. Before, it
would have been deleted and recreated empty. The new behaviour is how
other shares are treated too.

Note that since the input file is parsed by lp_load, there is currently
no way to distinguish between a section with only default parameters
and a non-existing section in net conf import.

Michael

PS: A couple of trailing white-spaces have been eliminated
and a line was broken to be not longer than 80 chars, too.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23750 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoSimplify prototype of reg_setvalue_internal:
obnox [Sat, 7 Jul 2007 22:33:45 +0000 (22:33 +0000)]
Simplify prototype of reg_setvalue_internal:
eliminate "type" parameter since we store only REG_SZ.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23749 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoClean use of talloc in import_process_service:
obnox [Sat, 7 Jul 2007 22:29:34 +0000 (22:29 +0000)]
Clean use of talloc in import_process_service:
create a temporary talloc ctx for the function.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23748 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoMove formatting of a parameter's value into a value string
obnox [Sat, 7 Jul 2007 22:18:54 +0000 (22:18 +0000)]
Move formatting of a parameter's value into a value string
to a function of its own. (for storing it in registry),
Eliminate the valtype variable : store everything as "sz".
Eliminate some trailing white spaces on the way.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23747 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix missing assignments to target string of asprintf in import function.
obnox [Sat, 7 Jul 2007 21:41:59 +0000 (21:41 +0000)]
Fix missing assignments to target string of asprintf in import function.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23746 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix: Check whether top subkeyname instead of whole registry key name
obnox [Sat, 7 Jul 2007 21:33:48 +0000 (21:33 +0000)]
Fix: Check whether top subkeyname instead of whole registry key name
is equal to GLOBAL_NAME.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23745 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoRemove TODO-comment. lp_load returns False if opening
obnox [Sat, 7 Jul 2007 20:40:59 +0000 (20:40 +0000)]
Remove TODO-comment. lp_load returns False if opening
of the config file fails. That's enough of checking for
existence and readbility to my taste.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23744 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoSimplify stat_cache_lookup() logic. For the history of this, see
vlendec [Sat, 7 Jul 2007 09:57:27 +0000 (09:57 +0000)]
Simplify stat_cache_lookup() logic. For the history of this, see
http://article.gmane.org/gmane.network.samba.internals/32486.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23743 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoRe-add commented out code snipped that got lost by accident
vlendec [Sat, 7 Jul 2007 08:46:26 +0000 (08:46 +0000)]
Re-add commented out code snipped that got lost by accident

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23738 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoUse local variable of smb_flag2 instead of using the macro every time.
jra [Fri, 6 Jul 2007 23:07:40 +0000 (23:07 +0000)]
Use local variable of smb_flag2 instead of using the macro every time.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23736 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoSecond part of the bugfix for #4763
jra [Fri, 6 Jul 2007 21:46:43 +0000 (21:46 +0000)]
Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23735 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoLimit LDAP lookup in lookup_usergroups_member() to security groups.
lmuelle [Fri, 6 Jul 2007 18:49:49 +0000 (18:49 +0000)]
Limit LDAP lookup in lookup_usergroups_member() to security groups.

Credits to Ralf Haferkamp for the discussion and help on this.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23733 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoremoved reference to non-existent structure
herb [Fri, 6 Jul 2007 17:48:19 +0000 (17:48 +0000)]
removed reference to non-existent structure

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23732 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoForgot one reference to inbuf
vlendec [Fri, 6 Jul 2007 16:39:58 +0000 (16:39 +0000)]
Forgot one reference to inbuf

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23731 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoSquashed commit of the following:
jerry [Thu, 5 Jul 2007 19:55:40 +0000 (19:55 +0000)]
Squashed commit of the following:

commit 3941269fa01038fca242a197e8d7c1f234d45ea7
Author: Gerald (Jerry) Carter <jerry@samba.org>
Date:   Thu Jul 5 14:52:03 2007 -0500

    Two fixes for "winbind expand groups".

    (a) Update the counter for the number of new groups to resolve else
        we'll only expand one group member per level and drop the rest.
    (b) Don't reset the num_names counter in winbindd_ads.c:lookup_groupmem()
        or we'll drop the SIDs resolved to names via cache from the resulting
        list.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23730 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFirst part of bugfix for #4763. Limit notify responses
jra [Thu, 5 Jul 2007 18:28:18 +0000 (18:28 +0000)]
First part of bugfix for #4763. Limit notify responses
to client max buf size.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23728 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoExplicitly pass down FLAGS2 to srvstr_get_path.
vlendec [Thu, 5 Jul 2007 16:36:15 +0000 (16:36 +0000)]
Explicitly pass down FLAGS2 to srvstr_get_path.

Next step is to remove the bug that in the trans2 code we use the inbuf
as the base pointer to decide whether we need ucs2 alignment where we
need to use the beginning of the params buffer

Jeremy, last one for today to reviw :-)

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23727 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoExplicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
vlendec [Thu, 5 Jul 2007 16:33:37 +0000 (16:33 +0000)]
Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23726 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoRemove get_current_mid()
vlendec [Thu, 5 Jul 2007 16:27:47 +0000 (16:27 +0000)]
Remove get_current_mid()

Jeremy, next one to review :-)

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23725 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoReduce access to the global inbuf a tiny bit. Add a struct smb_request
vlendec [Thu, 5 Jul 2007 16:26:27 +0000 (16:26 +0000)]
Reduce access to the global inbuf a tiny bit. Add a struct smb_request
that contains some of the fields from the SMB header, removing the need
to access inbuf directly. This right now is used only in the open file
code & friends, and creating that header is only done when needed. This
needs more work, but it is a start.

Jeremy, I'm only checking this into 3_0, please review before I merge it
to _26.

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23724 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAlexander Larsson pointed me at a missing mapping in clierror.c
idra [Thu, 5 Jul 2007 13:46:47 +0000 (13:46 +0000)]
Alexander Larsson pointed me at a missing mapping in clierror.c
When renaming a file across 2 filesystem a samba server returns
NT_STATUS_NOT_SAME_DEVICE but thius is not translated to EXDEV,
and the generic EINVAL is returned instead.
This should fix it, Jeremy or Derrel please check if this is ok.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23723 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix the build of the catia module
vlendec [Thu, 5 Jul 2007 10:32:51 +0000 (10:32 +0000)]
Fix the build of the catia module

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23722 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agobut now:
obnox [Thu, 5 Jul 2007 00:12:24 +0000 (00:12 +0000)]
but now:

This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test
scenarios.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23714 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoOops accidentially checked in the wrong file - sorry!
obnox [Thu, 5 Jul 2007 00:11:07 +0000 (00:11 +0000)]
Oops accidentially checked in the wrong file - sorry!

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23713 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoThis script allows for adding lists of users (or other objects)
obnox [Thu, 5 Jul 2007 00:07:40 +0000 (00:07 +0000)]
This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test
scenarios.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23712 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoRefactor the actual creation of object into its own small function.
obnox [Wed, 4 Jul 2007 23:21:51 +0000 (23:21 +0000)]
Refactor the actual creation of object into its own small function.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23711 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoRemove some code duplication, we do have a random number generator
vlendec [Wed, 4 Jul 2007 22:30:25 +0000 (22:30 +0000)]
Remove some code duplication, we do have a random number generator

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23710 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoC++ warnings
vlendec [Wed, 4 Jul 2007 22:28:04 +0000 (22:28 +0000)]
C++ warnings

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23709 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years ago- Add define for WINBIND_WARN_PWD_EXPIRE.
lmuelle [Wed, 4 Jul 2007 20:25:29 +0000 (20:25 +0000)]
- Add define for WINBIND_WARN_PWD_EXPIRE.
- Add parameter config_flag to get_config_item_int() and do the same
  check as in get_conf_item_string.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23708 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years ago- Move the asprintf() call to create the key even in
lmuelle [Wed, 4 Jul 2007 19:52:51 +0000 (19:52 +0000)]
- Move the asprintf() call to create the key even in
  get_conf_item_string() to the later if statement.
- Also move the key definition to the later if statement in
  get_conf_item_string() and get_conf_item_int().

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23707 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAdd a script to create domainusers,-groups and -aliases.
obnox [Wed, 4 Jul 2007 16:17:48 +0000 (16:17 +0000)]
Add a script to create domainusers,-groups and -aliases.
This is done via rpc client. The main purpose is to
be able to fill a domain controller with a large number
of users / groups easily. A the object names are
built as <prefix><num> where number ranges from a given
start number counting up until a given number of objects
has been created.

In a next step, I will submit scripts to add (many) users to
a group and to add a user to (many) groups.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23706 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAdd suggestion for vim from Andreas 'GlaDiaC' Schneider to show tabs,
lmuelle [Wed, 4 Jul 2007 14:15:26 +0000 (14:15 +0000)]
Add suggestion for vim from Andreas 'GlaDiaC' Schneider to show tabs,
trailing whitespace, and continued lines visually.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23705 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAdd pam_pwd_expire feature as discussed on samba-technical.
lmuelle [Wed, 4 Jul 2007 14:03:10 +0000 (14:03 +0000)]
Add pam_pwd_expire feature as discussed on samba-technical.

This is a slightly modified version to set warn_pwd_expire to the
default value if 0, no, or a broken value is set.

This version also has one if statement less in get_config_item_int().

Thanks a lot to Andreas 'GlaDiaC' Schneider for this feature!

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23704 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoMake sure that when builddir != srcdir, we can still find the exports
jerry [Wed, 4 Jul 2007 00:41:58 +0000 (00:41 +0000)]
Make sure that when builddir != srcdir, we can still find the exports
files and library-versions file.

Also move the "-o $@" from the individual targets and into the SHLD_DSO
command.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23694 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoCouldn't wait, sorry :-). Did the style change.
jra [Tue, 3 Jul 2007 23:48:02 +0000 (23:48 +0000)]
Couldn't wait, sorry :-). Did the style change.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23692 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agofix for bug on touching files as described here:
idra [Tue, 3 Jul 2007 23:34:01 +0000 (23:34 +0000)]
fix for bug on touching files as described here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243897

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23691 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoSquashed commit of the following:
jerry [Tue, 3 Jul 2007 19:55:02 +0000 (19:55 +0000)]
Squashed commit of the following:

commit 0d4bbd197198a94bf4e29e0ccd175a40a60097f3
Author: Gerald (Jerry) Carter <jerry@samba.org>
Date:   Mon Jul 2 20:08:19 2007 -0500

    Introduce GNU ld linker export-script for hiding non-public symbols
    in shared libraries.

    Based on initial patch from Julien Cristau <jcristau@debian.org>
    and suggestions from James Peach <jpeach@samba.org>.  Currently
    the libsmbsharemodes libraries still exports *.  Signed off on
    my Derrell as well.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23689 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix bug #4759 reported by Raul <ismell@ismell.org>.
jra [Tue, 3 Jul 2007 18:00:54 +0000 (18:00 +0000)]
Fix bug #4759 reported by Raul <ismell@ismell.org>.
"N" is not a valid format entry for ber_printf, should be "n"
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23688 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agomerge from SAMBA_4_0:
metze [Tue, 3 Jul 2007 14:46:06 +0000 (14:46 +0000)]
merge from SAMBA_4_0:

Only use the bzr and git information when there's
a .bzr or .git in the top branch directory

I use bzr for my home directory and
bzr version-info in ~/devel/samba/4.0/samba4-git
gives the info about the ~/.bzr branch

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23685 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoCheck ports are in the correct range (1-65535)
idra [Tue, 3 Jul 2007 13:11:56 +0000 (13:11 +0000)]
Check ports are in the correct range (1-65535)

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23683 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoOld patch I forgot in one of my 3.0.25 trees.
idra [Tue, 3 Jul 2007 13:07:56 +0000 (13:07 +0000)]
Old patch I forgot in one of my 3.0.25 trees.
Make sure we honour the directive not to allow machine password changes.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23682 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoCheck for integer wrap on incoming data.
jra [Mon, 2 Jul 2007 20:51:09 +0000 (20:51 +0000)]
Check for integer wrap on incoming data.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23673 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoAllow msrpc_name_to_sid() to be called without a domain_name and just a name.
gd [Mon, 2 Jul 2007 09:46:18 +0000 (09:46 +0000)]
Allow msrpc_name_to_sid() to be called without a domain_name and just a name.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23672 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoRemove unused code -- 16416 bytes of bss space...
vlendec [Sun, 1 Jul 2007 19:40:04 +0000 (19:40 +0000)]
Remove unused code -- 16416 bytes of bss space...

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23671 0c0555d6-39d7-0310-84fc-f1cc0bd64818

16 years agoFix mkversion.sh for the git case: Only use the first line where
vlendec [Sun, 1 Jul 2007 19:11:40 +0000 (19:11 +0000)]
Fix mkversion.sh for the git case: Only use the first line where
"commit" occurs

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23670 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoMove a variable into the only block where it is used.
obnox [Sun, 1 Jul 2007 00:09:20 +0000 (00:09 +0000)]
Move a variable into the only block where it is used.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23669 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoWhen creating a new string value, win2k regedit delivers
obnox [Sat, 30 Jun 2007 23:52:23 +0000 (23:52 +0000)]
When creating a new string value, win2k regedit delivers
one byte of data despite characters being two-byte.

This modifies registry_pull_value, to change the data
to the correct two-byte version of the empty string,
(as delivered by winxp), when only one byte of data is
received.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23668 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoPrevent storing of forbidden parameter names in registry
obnox [Sat, 30 Jun 2007 22:31:13 +0000 (22:31 +0000)]
Prevent storing of forbidden parameter names in registry
configuration as values. I would really like to check whether
the valuename is a valid parameter name (with lp_parameter_is_valid)
here, but unfortunately, regedit cereates new values as
"New Value #1" (and so on) first, before dropping into the
rename box. So this is impossible here.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23667 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoRename lp_parameter_valid -> lp_parameter_is_valid.
obnox [Sat, 30 Jun 2007 21:35:39 +0000 (21:35 +0000)]
Rename lp_parameter_valid -> lp_parameter_is_valid.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23666 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoRemove two unneeded global variables
vlendec [Sat, 30 Jun 2007 09:15:33 +0000 (09:15 +0000)]
Remove two unneeded global variables

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23665 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix incorrect index - should be j not i. How did we ever
jra [Sat, 30 Jun 2007 00:22:59 +0000 (00:22 +0000)]
Fix incorrect index - should be j not i. How did we ever
live without valgrind :-).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23664 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix bug #4308 - Excel save operation corrupts file ACLs.
jra [Fri, 29 Jun 2007 17:57:05 +0000 (17:57 +0000)]
Fix bug #4308 - Excel save operation corrupts file ACLs.
You don't want to know what I discovered about Windows
ACLs to make this work :-(. See :

http://www.codeproject.com/win32/accessctrl2.asp

Search for "Q. How does Inheritance come into this?"
for details.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23663 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAccording to simo, check_dos_char is needed
vlendec [Fri, 29 Jun 2007 17:51:31 +0000 (17:51 +0000)]
According to simo, check_dos_char is needed

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23662 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAnother static pstring
vlendec [Fri, 29 Jun 2007 17:40:37 +0000 (17:40 +0000)]
Another static pstring

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23661 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAnybody know what check_dos_char() was used for? It wasn't called at
vlendec [Fri, 29 Jun 2007 17:27:59 +0000 (17:27 +0000)]
Anybody know what check_dos_char() was used for? It wasn't called at
all, so it's gone. With it 8k bss went away.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23660 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agofile_pload is not used outside of util_file.c
vlendec [Fri, 29 Jun 2007 17:09:39 +0000 (17:09 +0000)]
file_pload is not used outside of util_file.c

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23659 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoOne pstring a day....
vlendec [Fri, 29 Jun 2007 16:04:26 +0000 (16:04 +0000)]
One pstring a day....

This one was particularly tasty, it was a static one. So 1k less
footprint per process.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23658 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoPrevent setting of a global option in a share definition
obnox [Fri, 29 Jun 2007 13:07:54 +0000 (13:07 +0000)]
Prevent setting of a global option in a share definition
in "net conf setparm".

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23657 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAdd initial checking of the validity of a paramter
obnox [Fri, 29 Jun 2007 12:30:41 +0000 (12:30 +0000)]
Add initial checking of the validity of a paramter
given to "net conf setparm". Add a utility function
lp_parameter_valid() for this to loadparm.c.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23656 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix a comment and adjust some code formatting.
obnox [Fri, 29 Jun 2007 12:15:41 +0000 (12:15 +0000)]
Fix a comment and adjust some code formatting.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23655 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoRemove misleading inline comment.
gd [Fri, 29 Jun 2007 11:54:29 +0000 (11:54 +0000)]
Remove misleading inline comment.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23654 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoUse the recursive delete function instead of the original one
obnox [Fri, 29 Jun 2007 10:22:18 +0000 (10:22 +0000)]
Use the recursive delete function instead of the original one
when deleting a share. Just to be sure...

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23652 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAlways, always, always compile before commit...
gd [Fri, 29 Jun 2007 09:58:11 +0000 (09:58 +0000)]
Always, always, always compile before commit...

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23651 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix remaining callers of krb5_kt_default().
gd [Fri, 29 Jun 2007 09:54:39 +0000 (09:54 +0000)]
Fix remaining callers of krb5_kt_default().

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23650 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix the build (by moving smb_krb5_open_keytab() to clikrb5.c).
gd [Fri, 29 Jun 2007 09:42:14 +0000 (09:42 +0000)]
Fix the build (by moving smb_krb5_open_keytab() to clikrb5.c).

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23649 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAllow to list a custom krb5 keytab file with:
gd [Fri, 29 Jun 2007 09:01:29 +0000 (09:01 +0000)]
Allow to list a custom krb5 keytab file with:

net ads keytab list /path/to/krb5.keytab

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23648 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoUse smb_krb5_open_keytab() in smbd as well.
gd [Fri, 29 Jun 2007 08:58:03 +0000 (08:58 +0000)]
Use smb_krb5_open_keytab() in smbd as well.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23647 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoGeneralize our internal keytab handling to support a broader range of default
gd [Fri, 29 Jun 2007 08:56:35 +0000 (08:56 +0000)]
Generalize our internal keytab handling to support a broader range of default
keytabnames (like "ANY:FILE:/etc/krb5.keytab,krb4:/etc/srvtab"). This also
fixes keytab support with Heimdal (which supports the WRFILE pragma as well
now).

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23646 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoadd examples and try to answer some common questions in the coding style guide
jerry [Thu, 28 Jun 2007 19:27:30 +0000 (19:27 +0000)]
add examples and try to answer some common questions in the coding style guide

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23645 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoPut check for forbidden values in smbconf into a function.
obnox [Thu, 28 Jun 2007 10:32:52 +0000 (10:32 +0000)]
Put check for forbidden values in smbconf into a function.
(This will be used in a next step to prevent storing these
values in reg_smbconf.c.)

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23641 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoWhen we support the SeSecurity privilage, this is where
jra [Wed, 27 Jun 2007 22:45:08 +0000 (22:45 +0000)]
When we support the SeSecurity privilage, this is where
we'll check it.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23640 0c0555d6-39d7-0310-84fc-f1cc0bd64818