Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242717 Uninitialized scalar variable
In an error path we are closing domain_pol without opening it
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242718 Uninitialized scalar variable
In an error path we are closing user_pol without opening it
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242719 Uninitialized scalar variable
In an error path we are closing domain_pol without opening it
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242720 Uninitialized scalar variable
In an error path we are closing domain_pol without opening it
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242721 Uninitialized scalar variable
In an error path we are closing domain_pol without opening it
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242722 Uninitialized scalar variable
In an error path we are closing domain_handle without opening it
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242723 Uninitialized scalar variable
In an error path we are closing hnd without opening it
Volker Lendecke [Wed, 9 May 2012 08:59:49 +0000 (10:59 +0200)]
s3: Fix Coverity ID 241961 Uninitialized scalar variable
Volker Lendecke [Wed, 9 May 2012 08:56:54 +0000 (10:56 +0200)]
s3: Fix Coverity ID 242724 Uninitialized scalar variable
In an error path we are closing pol without opening it
Volker Lendecke [Wed, 9 May 2012 08:51:54 +0000 (10:51 +0200)]
s3: Fix Coverity ID 242725 Uninitialized scalar variable
Not a functional bug, but we copy all of the "key" structure inside
dcerpc_winreg_CreateKey.
Volker Lendecke [Wed, 9 May 2012 08:51:54 +0000 (10:51 +0200)]
s3: Fix Coverity ID 242726 Uninitialized scalar variable
Not a functional bug, but we copy all of the "key" structure inside
dcerpc_winreg_OpenKey.
Volker Lendecke [Wed, 9 May 2012 08:41:06 +0000 (10:41 +0200)]
s3: Fix Coverity ID 242754 Dereference null return value
Volker Lendecke [Wed, 9 May 2012 08:30:47 +0000 (10:30 +0200)]
s3: Fix Coverity ID 242184 Dereference after null check
rpc_query_user unconditionally dereferences user_info if successfull
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242691 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242692 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242693 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242694 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242695 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242696 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242697 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242698 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242699 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242700 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242701 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242702 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242703 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242704 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242705 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Volker Lendecke [Wed, 9 May 2012 07:16:54 +0000 (09:16 +0200)]
s3: Fix Coverity ID 242706 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
Andrew Bartlett [Thu, 10 May 2012 05:07:32 +0000 (15:07 +1000)]
build: Avoid printing the ABI signature normalisation during the default build
This appears to have been accidentily left in
acd63fdb86769ff4328ccb6a4096181e65e4d30f
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu May 10 09:00:20 CEST 2012 on sn-devel-104
Lukasz Zalewski [Wed, 9 May 2012 13:24:01 +0000 (14:24 +0100)]
When listing group members allow fallback to cn attribute when samAccountName is not available
Andrew Bartlett [Mon, 23 Apr 2012 01:37:39 +0000 (11:37 +1000)]
build:ignore solaris _GLOBAL_OFFSET_TABLE_ in duplicate symbol checker
Alejandro Escanero Blanco [Wed, 9 May 2012 09:35:51 +0000 (11:35 +0200)]
s3:auth/server_info: the primary rid should be in the groups rid array (bug #8798)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed May 9 19:36:01 CEST 2012 on sn-devel-104
Günther Deschner [Wed, 9 May 2012 13:33:04 +0000 (15:33 +0200)]
allow to use system iniparser library.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 9 17:38:33 CEST 2012 on sn-devel-104
Günther Deschner [Tue, 8 May 2012 12:45:02 +0000 (14:45 +0200)]
waf: remove pointless WINBIND_KRB5_LOCATOR env.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 9 15:16:34 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 9 May 2012 04:35:55 +0000 (14:35 +1000)]
s3-smbd: Fix the creation of duplicate SMB_ACL_GROUP entries
The issue was a simple copy and paste bug, which casued a duplicate SMB_ACL_GROUP
to be added when we already had one.
Andrew Bartlett
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 9 13:17:29 CEST 2012 on sn-devel-104
Andreas Schneider [Mon, 7 May 2012 07:36:35 +0000 (09:36 +0200)]
s3-spoolss: Set DWORD values correctly.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed May 9 11:13:00 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 8 May 2012 13:39:35 +0000 (23:39 +1000)]
s3-lib/sysacls: Do not include an embedded \0 between ACL entries in sys_acl_to_text()
This makes it possible to print the entire string again.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 9 06:07:06 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 8 May 2012 04:11:27 +0000 (14:11 +1000)]
s3-lib: Add const to sys_acl_to_text
Andrew Bartlett [Tue, 8 May 2012 04:02:27 +0000 (14:02 +1000)]
s3-vfs: Show the invalid ACL when we say it is invalid for set
Andrew Bartlett [Tue, 8 May 2012 04:02:07 +0000 (14:02 +1000)]
s3-lib: Fix indentation in sys_acl_to_text()
Stefan Metzmacher [Mon, 7 May 2012 15:01:08 +0000 (17:01 +0200)]
Revert "selftest: mark ^samba4.raw.context.session1 as flapping, the test was wrong"
This reverts commit
794a9da38fbd88eb3d358d453cc5d21998604caa.
The test is fixed now.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed May 9 02:53:24 CEST 2012 on sn-devel-104
Stefan Metzmacher [Sun, 6 May 2012 19:09:47 +0000 (21:09 +0200)]
s4:smb_server/smb: only create a new session with vuid == 0
metze
Stefan Metzmacher [Tue, 1 May 2012 11:33:14 +0000 (13:33 +0200)]
s4:torture/raw/context: test a session setup with a given invalid vuid
On a session setup with EXTENDED_SECURITY we'll get ERRSRV:ERRbaduid,
while a session setup without EXTENDED_SECURITY ignores the given vuid.
Before this test was doing a reauth of a given vuid, which works for newer
Windows versions, but Windows 2000 gives INVALID_PARAMETER.
metze
Stefan Metzmacher [Mon, 7 May 2012 10:32:28 +0000 (12:32 +0200)]
selftest: mark ^samba4.raw.context.session1 as flapping, the test was wrong
metze
Stefan Metzmacher [Mon, 7 May 2012 10:33:45 +0000 (12:33 +0200)]
s3:libsmb: remove unused var in smb2cli_set_info_done
Christian Ambach [Tue, 8 May 2012 15:16:49 +0000 (17:16 +0200)]
s3:winbindd:autorid check that transaction start did work
this fixes Coverity #700172 CHECKED_RETURN
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Wed May 9 00:27:08 CEST 2012 on sn-devel-104
Christian Ambach [Tue, 8 May 2012 14:03:13 +0000 (16:03 +0200)]
s3:smbd fix some compiler warnings
Alexander Werth [Fri, 20 Jan 2012 18:17:21 +0000 (19:17 +0100)]
s3:vfs/gpfs: Have inherited deny ACE's show up in ACLs
Don't use the mode for the get_acl call that surpresses
inherited deny ACE's. This is now possible since
the inherited ACE flag exists now in GPFS and Samba.
Michael Adam [Tue, 8 May 2012 14:46:03 +0000 (16:46 +0200)]
s4:libcli:raw: fix a comment typo in smb_setfileinfo()
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue May 8 20:45:16 CEST 2012 on sn-devel-104
Michael Adam [Tue, 8 May 2012 14:45:10 +0000 (16:45 +0200)]
s4:torture: add a new smb2.session.reauth5 test: rename after reauth to anon - fails
Michael Adam [Tue, 8 May 2012 14:44:06 +0000 (16:44 +0200)]
s4:torture: add a new smb2.session.reauth4 test: setting security descriptor after reauth to anon - works
Karolin Seeger [Tue, 8 May 2012 14:33:07 +0000 (16:33 +0200)]
s3-docs: Fix bug #7930.
Add hint that setting "profile acls = yes" on normal shares can cause trouble.
Karolin
Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Tue May 8 18:47:59 CEST 2012 on sn-devel-104
Karolin Seeger [Tue, 8 May 2012 14:03:18 +0000 (16:03 +0200)]
s3-po: Fix typo in comment.
Karolin
Karolin Seeger [Tue, 8 May 2012 14:01:14 +0000 (16:01 +0200)]
s3-net: Fix typo in comment.
Karolin
Kai Blin [Wed, 28 Mar 2012 10:19:51 +0000 (12:19 +0200)]
s4 dns: unify error handling when bailing out
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Tue May 8 15:48:25 CEST 2012 on sn-devel-104
Kai Blin [Tue, 13 Mar 2012 07:04:14 +0000 (08:04 +0100)]
s4 dns: Add TSIG and TKEY records to idl
Karolin Seeger [Tue, 8 May 2012 10:01:28 +0000 (12:01 +0200)]
s3-docs: Fix several typos.
Part of a fix for bug #7938. Based on a patch provided by John Bradshaw
<john@johnbradshaw.org>.
Karolin
Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Tue May 8 13:56:32 CEST 2012 on sn-devel-104
Karolin Seeger [Tue, 8 May 2012 09:05:37 +0000 (11:05 +0200)]
s3-docs: overrided -> overridden
Fix typo. Part of a fix for bug #7938. Based on a patch provided by John
Bradshaw <john@johnbradshaw.org>.
Christian Ambach [Tue, 8 May 2012 07:15:12 +0000 (09:15 +0200)]
s3:vfs/shadow_copy2 fix some compiler warnings
about unused variables
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue May 8 11:15:07 CEST 2012 on sn-devel-104
Christian Ambach [Tue, 8 May 2012 07:11:36 +0000 (09:11 +0200)]
s3:vfs/shadow_copy2 make descending sort order the default
otherwise Explorer won't work correctly when trying to restore a folder
Christian Ambach [Mon, 7 May 2012 17:17:18 +0000 (19:17 +0200)]
docs:autorid document ignore builtin parameter
Christian Ambach [Mon, 7 May 2012 17:14:56 +0000 (19:14 +0200)]
s3:winbindd/autorid add ignore builtin parameter
BUILTIN should be handled by passdb, however if passdb does not know
about a SID, autorid creates a range for BUILTIN and does deterministic mapping
make it possible to turn off this behavior
Christian Ambach [Mon, 7 May 2012 17:02:23 +0000 (19:02 +0200)]
docs:autorid document read-only parameter
Christian Ambach [Mon, 7 May 2012 12:19:26 +0000 (14:19 +0200)]
s3:winbindd/autorid add support for read-only mode
make it possible to set read-only = yes for the backend
so users can replicate an autorid.tdb to another server
to use the same mappings without risking that updates
are done on both sides
Christian Ambach [Mon, 7 May 2012 17:08:10 +0000 (19:08 +0200)]
docs:autorid document how well-known SIDs will be mapped
they consume space of the allocation pool and a list of most known well-known SIDs is
preallocated to create a deterministic mapping
Christian Ambach [Fri, 4 May 2012 15:56:26 +0000 (17:56 +0200)]
s3:winbindd/autorid preallocate well-known SIDs
preallocate the list of well-known SIDs that Win2008R2 reports
to be groups and that are on the list in KB243330
This will allow for deterministic mapping of these SIDs, even if they
are stored in the allocation pool as this is the first thing that autorid
will allocate from the pool during module initialization
Andreas Schneider [Thu, 3 May 2012 15:10:27 +0000 (17:10 +0200)]
krb5samba: Add smb_krb5_make_pac_checksum.
Signed-off-by: Simo Sorce <idra@samba.org>
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Tue May 8 08:30:52 CEST 2012 on sn-devel-104
Andreas Schneider [Thu, 3 May 2012 15:10:53 +0000 (17:10 +0200)]
s4-auth: Use smb_krb5_make_pac_checksum.
Signed-off-by: Simo Sorce <idra@samba.org>
Simo Sorce [Fri, 4 May 2012 15:02:48 +0000 (11:02 -0400)]
krb5samba: Add krb5_free_checksum_contents wrapper
Andrew Bartlett [Mon, 7 May 2012 09:21:10 +0000 (19:21 +1000)]
lib/util: Map 0x7fffffffffffffffLL as 0x7fffffffffffffffLL in time conversion
TIME_T_MAX is not actually INT64_MAX at the moment, so check both
values and set to the magic end-of-time value.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue May 8 06:41:43 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 7 May 2012 07:06:23 +0000 (17:06 +1000)]
s4-provision Ensure we have posix ACLs before we permit a s3fs-based Samba4 to be configured
Andrew Bartlett [Mon, 7 May 2012 06:24:03 +0000 (16:24 +1000)]
s3-python: Add python bindings for posix ACL layer
This will allow us to check that posix ACLs work in the s4 provision, and avoid
--use-s3fs if they do not.
Andrew Bartlett
Stefan Metzmacher [Thu, 3 May 2012 12:41:21 +0000 (14:41 +0200)]
s4:torture/raw/context: add subtests as torture testcases
TODO: add test_session with 'use spnego = false'.
We need a way to do set an option just for one test case.
Note: the 'use spnego = false' was ignored before as it's
only used on the first session setup on a connection.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 8 04:50:39 CEST 2012 on sn-devel-104
Stefan Metzmacher [Tue, 1 May 2012 10:38:06 +0000 (12:38 +0200)]
s4:torture/raw/context: INVALID_PARAMETER vs. LOGON_FAILURE...
If the try a session setup without EXTENDED_SECURITY after
one with EXTENDED_SECURITY Windows 2008 R2 returns INVALID_PARAMETER,
while Windows 2000 sp4 returns LOGON_FAILURE...
metze
Stefan Metzmacher [Wed, 2 May 2012 11:46:34 +0000 (13:46 +0200)]
s4:torture/raw: make torture_raw_context a test suite
metze
Stefan Metzmacher [Tue, 1 May 2012 10:39:21 +0000 (12:39 +0200)]
s4:torture/raw/context: make use of torture_* macros and avoid 'printf'
metze
Stefan Metzmacher [Tue, 1 May 2012 10:35:28 +0000 (12:35 +0200)]
s4:torture/raw/context: pass tctx to test_pid_exit_only_sees_open()
metze
Stefan Metzmacher [Mon, 7 May 2012 09:50:59 +0000 (11:50 +0200)]
selftest: samba4 doesn't support reauth
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 8 02:43:49 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 7 May 2012 09:32:32 +0000 (11:32 +0200)]
s4:torture/raw/session: make sure we got a reauth of the existing session
metze
Stefan Metzmacher [Mon, 7 May 2012 10:07:30 +0000 (12:07 +0200)]
selftest: mark ^samba4.raw.session.reauth as flapping
Because the test is wrong...
metze
Andreas Schneider [Mon, 7 May 2012 09:57:34 +0000 (11:57 +0200)]
talloc: Update doxygen config.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Mon May 7 21:13:15 CEST 2012 on sn-devel-104
Pavel Březina [Mon, 7 May 2012 10:30:44 +0000 (12:30 +0200)]
doc: Remove latex to doxygen conversion leftovers in talloc.
Signed-off-by: Andreas Schneider <asn@samba.org>
Andreas Schneider [Mon, 7 May 2012 09:56:39 +0000 (11:56 +0200)]
doc: Fixes for the talloc best practices tutorial.
Andreas Schneider [Mon, 7 May 2012 09:42:44 +0000 (11:42 +0200)]
doc: Fixes for the talloc debugging tutorial.
Andreas Schneider [Mon, 7 May 2012 09:36:37 +0000 (11:36 +0200)]
doc: Fixes for the talloc pool tutorial.
Andreas Schneider [Mon, 7 May 2012 09:30:06 +0000 (11:30 +0200)]
doc: Fixes for the talloc destructor tutorial.
Andreas Schneider [Mon, 7 May 2012 09:25:50 +0000 (11:25 +0200)]
doc: Fixes for the talloc dynamic type system tutorial.
Andreas Schneider [Mon, 7 May 2012 09:18:26 +0000 (11:18 +0200)]
doc: Fixes for the talloc stealing tutorial.
Andreas Schneider [Mon, 7 May 2012 09:09:56 +0000 (11:09 +0200)]
doc: Fixes for the talloc context tutorial.
Pavel Březina [Sun, 6 May 2012 12:34:48 +0000 (14:34 +0200)]
doc: Add talloc tutorial.
Signed-off-by: Andreas Schneider <asn@samba.org>
Jelmer Vernooij [Mon, 7 May 2012 14:43:17 +0000 (16:43 +0200)]
heimdal: Cope with newer Heimdal versions accepting a keyset argument to
hdb_enctype2key.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon May 7 18:33:10 CEST 2012 on sn-devel-104
Michael Adam [Mon, 7 May 2012 12:09:28 +0000 (14:09 +0200)]
s3:registry: let reg_values_need_update() return true if the backend does not implement the method
Otherwise the value cache might become outdated.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon May 7 16:11:05 CEST 2012 on sn-devel-104
Michael Adam [Mon, 7 May 2012 12:08:13 +0000 (14:08 +0200)]
s3:registry: let reg_subkeys_need_update() return true if the backend does not implement the method
Otherwise the subkey cache might become outdated.
Amitay Isaacs [Mon, 7 May 2012 01:46:27 +0000 (11:46 +1000)]
s4-dns: Build BIND DLZ modules with correct private library
This fixes rpath for samdb-common private library after make install.
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Mon May 7 07:40:29 CEST 2012 on sn-devel-104
Stefan Metzmacher [Sat, 5 May 2012 07:31:39 +0000 (09:31 +0200)]
lib/param: add support for "SMB3_00"
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun May 6 16:38:00 CEST 2012 on sn-devel-104
Stefan Metzmacher [Sat, 5 May 2012 07:35:17 +0000 (09:35 +0200)]
s3:smb2_negprot: add support for PROTOCOL_SMB3_00
metze
Stefan Metzmacher [Sat, 5 May 2012 07:55:59 +0000 (09:55 +0200)]
s4:libcli/smb2: use PROTOCOL_LATEST
metze
Stefan Metzmacher [Sat, 5 May 2012 07:42:28 +0000 (09:42 +0200)]
s3:torture/test_smb2: add support for PROTOCOL_SMB3_00
metze
Stefan Metzmacher [Sat, 5 May 2012 07:33:43 +0000 (09:33 +0200)]
libcli/smb/smbXcli: add support for PROTOCOL_SMB3_00
metze