Michael Adam [Thu, 10 Jan 2008 14:33:51 +0000 (15:33 +0100)]
Remove redundant parameter fd from SMB_VFS_READ().
Michael
Michael Adam [Thu, 10 Jan 2008 13:27:52 +0000 (14:27 +0100)]
Move transfer_file and transfer_file_internal to a module of their own.
Also, don't auto-generate prototypes of the (two) exported functions
but make a start in having handwritten prototypes in dedicated header
files (not in includes.h ... :-)
Michael
Michael Adam [Thu, 10 Jan 2008 12:55:46 +0000 (13:55 +0100)]
Reformat some code I just touched.
Michael
Michael Adam [Thu, 10 Jan 2008 12:55:16 +0000 (13:55 +0100)]
Make casts to (void *) explicit to remove compiler warnings.
Michael
Michael Adam [Thu, 10 Jan 2008 13:18:46 +0000 (14:18 +0100)]
Fix a really silly typo.
Michael
Michael Adam [Thu, 10 Jan 2008 12:30:43 +0000 (13:30 +0100)]
Correctly abstract the transfer_file mechanism with callbacks and void ptrs.
This removes the in_fsp and out_fsp global variables hack from smbd/vfs.c.
Michael
Volker Lendecke [Sun, 6 Jan 2008 13:17:15 +0000 (14:17 +0100)]
use talloc_tos() in share_access_check()
Volker Lendecke [Sun, 6 Jan 2008 15:15:45 +0000 (16:15 +0100)]
Some more talloc_tos()
Volker Lendecke [Sun, 6 Jan 2008 13:21:25 +0000 (14:21 +0100)]
use talloc_tos in a few more places
Günther Deschner [Thu, 10 Jan 2008 10:13:23 +0000 (11:13 +0100)]
Remove unused string.
Guenther
Volker Lendecke [Thu, 10 Jan 2008 10:35:40 +0000 (11:35 +0100)]
Fix a c++ warning
Volker Lendecke [Thu, 10 Jan 2008 10:35:17 +0000 (11:35 +0100)]
talloc_free_children can only reset pool if it's empty
Volker Lendecke [Thu, 10 Jan 2008 10:34:07 +0000 (11:34 +0100)]
Mark talloc_pool memory for valgrind
Volker Lendecke [Thu, 10 Jan 2008 09:55:20 +0000 (10:55 +0100)]
Fix suspicious Makefile line
If @WINBIND_KRB5_LOCATOR@ is not defined, this leads to a line with just one
tab in.
Volker Lendecke [Thu, 10 Jan 2008 08:53:51 +0000 (09:53 +0100)]
Form a proper hierarchy in talloc_stack
This way talloc_stackframe() can benefit from a pool put on the stack further
up. No need to remove talloc_stackframe().
Jeremy Allison [Thu, 10 Jan 2008 01:32:26 +0000 (17:32 -0800)]
Fixup hot paths - add macro for toupper (c < 0x80).
This now matches 3.0.x on my micro-tests.
Jeremy.
Jeremy Allison [Thu, 10 Jan 2008 01:11:04 +0000 (17:11 -0800)]
Make use of talloc_pool in the main codepaths. Remove the sub-contexts.
Jeremy.
Jeremy Allison [Thu, 10 Jan 2008 01:08:20 +0000 (17:08 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 10 Jan 2008 01:07:58 +0000 (17:07 -0800)]
Add the calls to make use of talloc_pools in a talloc_stackframe.
Jeremy.
Volker Lendecke [Sat, 5 Jan 2008 17:26:54 +0000 (18:26 +0100)]
Implement talloc_pool()
A talloc pool is a chunk of memory that can be used as a context for further
talloc calls. Allocations with the pool as the parent just chew from that
memory by incrementing a pointer. If the talloc pool is full, then we fall back
to the normal system-level malloc(3) to get memory.
The use case for talloc pools is the transient memory that is used for handling
a single SMB request. Incrementing a pointer will be way faster than any malloc
implementation.
There is a downside of this: If you use talloc_steal() to move something out of
the pool, the whole pool memory is kept around until the last object inside the
pool is freed. So if you talloc_free() the pool, it might happen that the
memory is freed later. So don't hang anything off a talloc pool that should
live long.
Volker
Michael Adam [Thu, 10 Jan 2008 00:04:47 +0000 (01:04 +0100)]
Try and fix the AIX build.
The __ss_family workaround is in lib/replace/system/network.h ...
Michael
Michael Adam [Wed, 9 Jan 2008 23:45:54 +0000 (00:45 +0100)]
Enable building the notify_fam module.
Found by Timur I. Bakeyev <timur@com.bat.ru>.
Michael
Jeremy Allison [Wed, 9 Jan 2008 22:35:37 +0000 (14:35 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Wed, 9 Jan 2008 22:35:15 +0000 (14:35 -0800)]
Try and fix the AIX build.
Jeremy.
Jeremy Allison [Wed, 9 Jan 2008 22:35:00 +0000 (14:35 -0800)]
Ensure we don't take address of one past buffer.
Jeremy.
Volker Lendecke [Wed, 9 Jan 2008 22:00:48 +0000 (23:00 +0100)]
Fix the max_dead_record calculations
Michael Adam [Wed, 9 Jan 2008 22:15:56 +0000 (23:15 +0100)]
Try to fix the build on hosts that HAVE_LDAP but don't HAVE_KRB5.
Michael
Michael Adam [Wed, 9 Jan 2008 21:25:52 +0000 (22:25 +0100)]
Fix a memleak found by the IBM checker.
Michael
Michael Adam [Wed, 9 Jan 2008 21:09:55 +0000 (22:09 +0100)]
Fix memleak in ldapsam_rename_sam_account() found by IBM checker.
The check for out of memory was the wrong way round.
Michael
Günther Deschner [Wed, 9 Jan 2008 11:47:13 +0000 (12:47 +0100)]
Another attempt to fix builds w/o ldap and/or krb5.
Guenther
Günther Deschner [Wed, 9 Jan 2008 11:28:44 +0000 (12:28 +0100)]
Re-run make idl to get even nicer pidl generated server code.
Guenther
Karolin Seeger [Tue, 8 Jan 2008 18:21:26 +0000 (19:21 +0100)]
Correct comment. Default debug level of smbclient is 1, not 0.
Volker Lendecke [Wed, 9 Jan 2008 10:44:40 +0000 (11:44 +0100)]
Attempt to fix the compile of source/utils/net_dns.c
Jeremy, please check!
Günther Deschner [Wed, 9 Jan 2008 10:59:11 +0000 (11:59 +0100)]
Re-run make idl. The pidl generated code now fully complies to coding standards.
Guenther
Michael Adam [Wed, 9 Jan 2008 10:22:29 +0000 (11:22 +0100)]
Fix memory handling in torture/cmd_vfs.c:cmd_open and don't leak fsp_name.
Michael
Volker Lendecke [Tue, 8 Jan 2008 09:17:05 +0000 (10:17 +0100)]
Reduce stat cache size default
Now that we have a LRU scheme for the stat cache we can live with a lot less
Volker Lendecke [Wed, 9 Jan 2008 09:29:34 +0000 (10:29 +0100)]
Replace an uninitialized variable
Reported by the IBM checker
Günther Deschner [Tue, 8 Jan 2008 17:59:57 +0000 (18:59 +0100)]
Add libnet_join_derive_salting_principal().
Guenther
Günther Deschner [Tue, 8 Jan 2008 15:57:16 +0000 (16:57 +0100)]
Fix build warning for libsmbclient example.
Guenther
Michael Adam [Wed, 9 Jan 2008 01:35:34 +0000 (02:35 +0100)]
git-ignore generated files under examples/VFS/
Michael
Michael Adam [Wed, 9 Jan 2008 01:32:56 +0000 (02:32 +0100)]
Ignore test directory.
Michael
Volker Lendecke [Wed, 9 Jan 2008 06:59:12 +0000 (07:59 +0100)]
ensure uni_name.buffer is initialised
merge from http://samba.org/~tridge/3_0-ctdb
Jeremy Allison [Wed, 9 Jan 2008 02:51:55 +0000 (18:51 -0800)]
Fix CID 461 - resource leak on error.
Jeremy.
Jeremy Allison [Wed, 9 Jan 2008 02:48:04 +0000 (18:48 -0800)]
Fix CID 460 - resource leak on error.
Jeremy.
Jeremy Allison [Wed, 9 Jan 2008 02:44:19 +0000 (18:44 -0800)]
Fix resource leak found by coverity (CID 521).
Jeremy.
Michael Adam [Wed, 9 Jan 2008 00:17:13 +0000 (01:17 +0100)]
Change registry_create_admin_token() to return NTSTATUS.
Michael
Michael Adam [Tue, 8 Jan 2008 23:25:27 +0000 (00:25 +0100)]
Move content of comment.
Michael
Michael Adam [Tue, 8 Jan 2008 23:11:31 +0000 (00:11 +0100)]
Convert add_sid_to_array() add_sid_to_array_unique() to return NTSTATUS.
Michael
Michael Adam [Tue, 8 Jan 2008 22:02:50 +0000 (23:02 +0100)]
Fix prototype: Add a void to an empty function parameter list.
Michael
Michael Adam [Tue, 8 Jan 2008 20:51:07 +0000 (21:51 +0100)]
Don't leak data.dptr on error path.
Michael
Michael Adam [Tue, 8 Jan 2008 14:21:08 +0000 (15:21 +0100)]
Extend a comment.
Michael
Michael Adam [Wed, 9 Jan 2008 00:35:43 +0000 (01:35 +0100)]
Add a comment.
Michael
Michael Adam [Wed, 9 Jan 2008 00:34:21 +0000 (01:34 +0100)]
Fix talloctort: move size check after referenced ptr check.
Michael
Jeremy Allison [Wed, 9 Jan 2008 00:08:39 +0000 (16:08 -0800)]
Simplify... plus add a debug message.
Jeremy.
Jeremy Allison [Tue, 8 Jan 2008 23:57:08 +0000 (15:57 -0800)]
Correctly identify enc/non-enc packets.
Jeremy.
Volker Lendecke [Tue, 8 Jan 2008 22:18:03 +0000 (23:18 +0100)]
Save one popular malloc
Volker Lendecke [Tue, 8 Jan 2008 21:42:27 +0000 (22:42 +0100)]
Don't shrink a talloc area if we have less than 1k to gain
Michael Adam [Tue, 8 Jan 2008 21:51:21 +0000 (22:51 +0100)]
Fix returns in void functions.
Michael
Michael Adam [Tue, 8 Jan 2008 21:13:25 +0000 (22:13 +0100)]
Fix examples/VFS after VFS API changes.
Michael
Volker Lendecke [Tue, 8 Jan 2008 21:12:35 +0000 (22:12 +0100)]
Only realloc the talloc stack if necessary
Volker Lendecke [Tue, 8 Jan 2008 20:45:21 +0000 (21:45 +0100)]
Allocate dirp->name_cache on demand only
Jeremy Allison [Tue, 8 Jan 2008 21:11:12 +0000 (13:11 -0800)]
Move the DNS tsig update to using struct sockaddr_storage
from struct in_addr. Still only does IPv4 updates but now
it'll be easy to add IPv6 when we have time.
Jeremy.
Günther Deschner [Tue, 8 Jan 2008 17:07:55 +0000 (18:07 +0100)]
Pedantic cosmetics: rerun make idl.
Guenther
Jelmer Vernooij [Tue, 8 Jan 2008 14:43:11 +0000 (15:43 +0100)]
Merge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
Günther Deschner [Tue, 8 Jan 2008 13:06:18 +0000 (14:06 +0100)]
Use ads_get_upn() in net_derive_salting_principal().
Guenther
Günther Deschner [Tue, 8 Jan 2008 13:03:12 +0000 (14:03 +0100)]
Fix define check s/WITH_LDAP/HAVE_LDAP/ in libnet_join.
Guenther
Günther Deschner [Tue, 8 Jan 2008 12:46:54 +0000 (13:46 +0100)]
Do not ignore provided machine_name in ads_get_upn().
Guenther
Karolin Seeger [Tue, 8 Jan 2008 11:23:25 +0000 (12:23 +0100)]
Add missing quote. Fix bug 5172. Thanks to Jason Filley <jason@snakelegs.org> for reporting!
Karolin
Günther Deschner [Tue, 8 Jan 2008 11:25:47 +0000 (12:25 +0100)]
Correctly talloc ctx->remote_path in libgpo (thanks Michael for the pointer).
Guenther
Michael Adam [Tue, 8 Jan 2008 11:20:51 +0000 (12:20 +0100)]
Remove redundant parameter fd from SMB_VFS_AIO_CANCEL().
Michael
Günther Deschner [Tue, 8 Jan 2008 10:55:45 +0000 (11:55 +0100)]
Correctly free buffers in netdomjoin-gui.
Guenther
Günther Deschner [Tue, 8 Jan 2008 10:54:51 +0000 (11:54 +0100)]
Make name_buffer in NetGetJoinInformation() talloced.
Guenther
Günther Deschner [Tue, 8 Jan 2008 10:53:38 +0000 (11:53 +0100)]
Add NetApiBufferFree() to libnetapi.
Guenther
Günther Deschner [Tue, 8 Jan 2008 10:49:35 +0000 (11:49 +0100)]
Fix crash bug when strequal is used too late in libnetapi_free.
Guenther
Günther Deschner [Tue, 8 Jan 2008 10:46:11 +0000 (11:46 +0100)]
When unjoining fails (e.g. missing creds) make sure we still correct config.
Guenther
Michael Adam [Tue, 8 Jan 2008 10:47:33 +0000 (11:47 +0100)]
Remove redundant parameter fd from SMB_VFS_FSETXATTR().
Michael
Michael Adam [Tue, 8 Jan 2008 10:29:09 +0000 (11:29 +0100)]
Remove redundant parameter fd from SMB_VFS_FREMOVEXATTR().
Michael
Michael Adam [Tue, 8 Jan 2008 09:51:40 +0000 (10:51 +0100)]
Remove redundant parameter fd from SMB_VFS_FLISTXATTR().
Michael
Michael Adam [Tue, 8 Jan 2008 09:00:47 +0000 (10:00 +0100)]
Remove redundant parameter fd from SMB_VFS_FGETXATTR().
Michael
Michael Adam [Tue, 8 Jan 2008 00:56:56 +0000 (01:56 +0100)]
Remove forgotton fd from solarisacl_sys_acl_get_fd().
Michael
Michael Adam [Tue, 8 Jan 2008 00:54:19 +0000 (01:54 +0100)]
Remove redundant parameter fd from SMB_VFS_SYS_ACL_SET_FD().
Michael
Michael Adam [Tue, 8 Jan 2008 00:14:24 +0000 (01:14 +0100)]
Remove redundant parameter fd from SMB_VFS_FCHMOD_ACL().
Michael
Michael Adam [Mon, 7 Jan 2008 23:21:58 +0000 (00:21 +0100)]
Add comment.
Michael
Michael Adam [Mon, 7 Jan 2008 22:53:34 +0000 (23:53 +0100)]
Remove redundant parameter fd from SMB_VFS_SYS_ACL_GET_FD().
Michael
Günther Deschner [Mon, 7 Jan 2008 22:05:58 +0000 (23:05 +0100)]
Refactor our DsGetDcName call a bit (before it will move into libnetapi).
Guenther
Günther Deschner [Mon, 7 Jan 2008 21:48:19 +0000 (22:48 +0100)]
Enable talloc reporting in libnetapi if DEVELOPER compiled.
Guenther
Michael Adam [Mon, 7 Jan 2008 21:18:50 +0000 (22:18 +0100)]
Remove redundant parameter fd from SMB_VFS_GETLOCK().
Michael
Michael Adam [Mon, 7 Jan 2008 20:47:53 +0000 (21:47 +0100)]
Remove redundant parameter fd from SMB_VFS_LINUX_SETLEASE().
Michael
Volker Lendecke [Mon, 7 Jan 2008 11:57:10 +0000 (12:57 +0100)]
Do not talloc_strdup filename and servicepath
Volker Lendecke [Sun, 6 Jan 2008 23:41:26 +0000 (00:41 +0100)]
make db_tdb_fetch use tdb_parse_record
Volker Lendecke [Sun, 6 Jan 2008 23:14:24 +0000 (00:14 +0100)]
Change db_tdb_fetch_locked to use only one talloc
Volker Lendecke [Sun, 6 Jan 2008 16:25:20 +0000 (17:25 +0100)]
talloc_stackframe only needs 1 talloc
Günther Deschner [Mon, 7 Jan 2008 19:56:34 +0000 (20:56 +0100)]
Trying to make the buildfarm w/o krb5 happy.
Guenther
Günther Deschner [Mon, 7 Jan 2008 19:41:55 +0000 (20:41 +0100)]
There is no LDAP in some corners of this world. Fix the build...
Guenther
Günther Deschner [Mon, 7 Jan 2008 19:20:03 +0000 (20:20 +0100)]
Finally use libnet_join_set_* functions in libnetjoin.
Guenther
Günther Deschner [Mon, 7 Jan 2008 19:16:57 +0000 (20:16 +0100)]
Merge remaining post-AD-join functions from net into libnet_join.
Guenther
Günther Deschner [Mon, 7 Jan 2008 19:10:47 +0000 (20:10 +0100)]
In libnetapi example, use libnetapi_get_error_string().
Guenther
Günther Deschner [Mon, 7 Jan 2008 19:08:45 +0000 (20:08 +0100)]
In the local path of NetJoinDomain, try to get error string from libnetjoin.
Guenther
Günther Deschner [Mon, 7 Jan 2008 19:06:41 +0000 (20:06 +0100)]
Add libnetapi_set_error_string and libnetapi_get_error_string.
Guenther
Günther Deschner [Mon, 7 Jan 2008 19:03:32 +0000 (20:03 +0100)]
Add krb5 cc env to libnetapi_ctx.
Guenther