Günther Deschner [Thu, 16 Jun 2005 09:36:53 +0000 (09:36 +0000)]
r7632: Cleanup "net share migrate"-code.
* Allow to copy share security descriptors to already existing shares
separatly.
* Added abstraction function to enum all or a single share info
Guenther
Gerald Carter [Thu, 16 Jun 2005 00:46:43 +0000 (00:46 +0000)]
r7624: * removed unmatched tdb_lock_by_string() call (should fix build farm issues)
* comment out services.tdb code until I finish rewriting it
Gerald Carter [Wed, 15 Jun 2005 19:28:14 +0000 (19:28 +0000)]
r7620: when adding a new printer driver, we should copy the files
(not move) to the W32X86/{2,3}/ directory. Printmig.exe
copies the driver files for all drivers to print$/W32X86
and the calls AddPrinterDriver() for each driver. If we
move the file, then adding a driver which shares a file with
a previous driver will fail.
I can now restore drivers in bulk to a Samba 3 server.
Jeremy Allison [Wed, 15 Jun 2005 18:49:43 +0000 (18:49 +0000)]
r7618: Typo...
Jeremy.
Jeremy Allison [Wed, 15 Jun 2005 18:37:34 +0000 (18:37 +0000)]
r7617: Fix for bug #2801 - delete veto files was broken with the new
large directory code.
Jeremy.
Gerald Carter [Wed, 15 Jun 2005 17:03:34 +0000 (17:03 +0000)]
r7614: convert move_driver_to_download_area() to return WERROR in order to provide better error messages to clients when a AddPrinterDriver[Ex]() call fails
Gerald Carter [Wed, 15 Jun 2005 16:32:12 +0000 (16:32 +0000)]
r7613: small changes to _svcctl_open_service() and create_open_service_handle() to prevent invalid service names from being accepted; printmig.exe now migrates drivers successfully
Gerald Carter [Wed, 15 Jun 2005 15:18:18 +0000 (15:18 +0000)]
r7610: can successfully stop and start the 'spooler' service by setting the state for the 'disable spoolss' parameter in memory for an individual smbd
Lars Müller [Wed, 15 Jun 2005 14:24:11 +0000 (14:24 +0000)]
r7609: Move top level dir handling in from of the loop. This makes the code
much straither.
copy_top_level_perms() is jra's work.
I modified the copy_top_level_perms() function to use the copy_clistate.
And I don't forget trunk.
Lars
Günther Deschner [Wed, 15 Jun 2005 13:01:19 +0000 (13:01 +0000)]
r7607: Some minor fixes (typos, const)
Guenther
Günther Deschner [Wed, 15 Jun 2005 12:43:36 +0000 (12:43 +0000)]
r7606: add WERR_NET_NAME_NOT_FOUND. This is what windows returns when
trying to manipulate non-existing shares.
Guenther
Gerald Carter [Wed, 15 Jun 2005 03:10:36 +0000 (03:10 +0000)]
r7603: * fix a bug in the SERVICE_ALL_ACCESS security mask
* add calls to start and stop a service (to be filled
in by the backend routines in services/svc_*.c
Gerald Carter [Wed, 15 Jun 2005 00:54:43 +0000 (00:54 +0000)]
r7595: start trying to split out the svcctl functions into separate files for better maintenance; add SERVICE_CONTROL_OPS for spoolss service
Jeremy Allison [Wed, 15 Jun 2005 00:22:59 +0000 (00:22 +0000)]
r7591: Don't call getpeeraddr on a disconnected socket.
Jeremy.
Gerald Carter [Tue, 14 Jun 2005 20:50:37 +0000 (20:50 +0000)]
r7584: cleanup the default printer security descriptor
Gerald Carter [Tue, 14 Jun 2005 20:11:59 +0000 (20:11 +0000)]
r7583: * more rearranging and renaming of functions
* add access checks to _svcctl_XXX() calls based on
the access granted on the handle
Gerald Carter [Tue, 14 Jun 2005 19:04:39 +0000 (19:04 +0000)]
r7581: fix bad merge
Gerald Carter [Tue, 14 Jun 2005 18:38:15 +0000 (18:38 +0000)]
r7578: use global well known DOM_SID objects when possible
Gerald Carter [Tue, 14 Jun 2005 18:31:06 +0000 (18:31 +0000)]
r7577: switching to macro for IS_DC
Gerald Carter [Tue, 14 Jun 2005 18:08:39 +0000 (18:08 +0000)]
r7576: implement access checks for open_scm and open_service
according to default security descriptor described in MSDN.
no one can get in to due to the permissions, but i'll fix
that next.
Gerald Carter [Tue, 14 Jun 2005 15:40:51 +0000 (15:40 +0000)]
r7573: you can't make an omlette without break a few eggs....start reworking the svcctl code
Gerald Carter [Tue, 14 Jun 2005 03:17:31 +0000 (03:17 +0000)]
r7563: svcctl patches from Marcin; have cleaned up formating and am checking the code in to snapshot it before I start changing more things
Jeremy Allison [Mon, 13 Jun 2005 22:26:08 +0000 (22:26 +0000)]
r7554: Refactor very messy code in util_sock.c Remove write_socket_data/read_socket_data
as they do nothing that write_socket/read_socket don't do. Add a more useful
error message when read_socket/write_socket error out on the main client fd
for a process (ie. try and list the IP of the client that errored).
Jeremy.
Jeremy Allison [Mon, 13 Jun 2005 20:42:21 +0000 (20:42 +0000)]
r7550: Steal the correct error return for invalid TID on NTcreateX from Samba4
(thanks tridge !).
Jeremy.
Gerald Carter [Mon, 13 Jun 2005 19:53:09 +0000 (19:53 +0000)]
r7547: removing unused fields in the REGISTRY_KEY structure associated with open handles
Jeremy Allison [Mon, 13 Jun 2005 18:45:17 +0000 (18:45 +0000)]
r7544: Fix for bug #2196 from Denis Sbragion <d.sbragion@infotecna.it>.
Allow absolute path (system wide) recycle bin.
Jeremy.
Jeremy Allison [Mon, 13 Jun 2005 17:41:52 +0000 (17:41 +0000)]
r7542: Patch from Renaud Duhaut <rd@duhaut.com> for a parameter
"directory_mode" when creating recycle directories.
Bug #1040.
Jeremy.
Jeremy Allison [Mon, 13 Jun 2005 16:49:57 +0000 (16:49 +0000)]
r7541: Patch from core@road-star.jp for bug #2792. Ensure the shadow copy
module hooks seekdir, telldir, rewinddir to match updated large
directory code.
Jeremy.
Günther Deschner [Mon, 13 Jun 2005 14:39:40 +0000 (14:39 +0000)]
r7537: Print passwords in display charset.
Guenther
Günther Deschner [Mon, 13 Jun 2005 13:16:55 +0000 (13:16 +0000)]
r7534: Add missing cli_srvsvc_net_share_set_info-function and
rpcclient-testers.
Needed in preparation of share-ACL migration in net.
Guenther
Günther Deschner [Mon, 13 Jun 2005 11:18:00 +0000 (11:18 +0000)]
r7532: compile fix.
Guenther
Günther Deschner [Mon, 13 Jun 2005 09:33:09 +0000 (09:33 +0000)]
r7529: Apply some const, remove unused variable.
Guenther
Lars Müller [Sun, 12 Jun 2005 21:18:16 +0000 (21:18 +0000)]
r7512: Fix net share migrate files to also migrate the ACLs of the top level
dir of a share. Till now we excluded '.' and '..' in general. For the
fix the information about top or lower level dir is stored in the
copy_clistate. src and dst share are now also part of this struct and
we only pass a pointer to the struct to the functions.
This bug was found by Bill Calero of Novell. Thanks Bill!
With this checkin no new functionality was added. But the copy_clistate
already knows about a mode. Later beside the migrate an additional
report mode will be added.
This changes are coordinated with Günther <gd>.
Lars
Lars Müller [Sun, 12 Jun 2005 16:00:29 +0000 (16:00 +0000)]
r7511: Add three new command line switches to testparm:
--show-all-parameters
Enumerates all available parameters, grouped in to sections
[local] and [global] by the class of the parameter. Each line
is formated name=type[,enum values],flags
--parameter-name
Display the setting of the named parameter. The global section
is assumed if no other is set with --section-name
--section-name
Limit the view of testparm to the named section. Use 'global'
to only view the settings of the global section.
This fixes bug #2767.
Lars
Jeremy Allison [Fri, 10 Jun 2005 23:13:25 +0000 (23:13 +0000)]
r7474: A *foul* and *disgusting* hack to ensure that, at the very lowest
level, . and .. are the first two entries returned when reading a
directory. This also means we can't seek to these offsets, but we
will never be doing that anyway (as far as I can think). The reason
we have to do this is that the NT4 explorer will happily display a
folder marked ".." as a clickable folder (and probably would display
"." as a clickable folder too) if these are not in positions zero
and one of the returned file list. W2K seems to have fixed this but
there are too many older systems out there... Never mind, more for
the "Undocumented CIFS talk", coming to a CIFS2005 conference near
you soon.... :-).
Jeremy.
Gerald Carter [Fri, 10 Jun 2005 22:03:33 +0000 (22:03 +0000)]
r7472: fix smbpasswd user password change (still worked by bad error messages) due to trying to strdup a NULL pointer
Gerald Carter [Fri, 10 Jun 2005 18:34:36 +0000 (18:34 +0000)]
r7470: fix block size caculation error when request size > 4096 bytes
Gerald Carter [Fri, 10 Jun 2005 03:26:39 +0000 (03:26 +0000)]
r7454: couple of winbindd fixes
* make sure to use our domain as the account name in the net_req_auth2()
request when running on a Samba DC
* make sure to lookup the correct domain (not default to ours) when getting an async
getpwnam() call
Jeremy Allison [Fri, 10 Jun 2005 00:31:59 +0000 (00:31 +0000)]
r7452: Set sparse flag if needed. Based on code from jpeach@sgi.com.
Fixes bug #2774.
Jeremy.
Gerald Carter [Thu, 9 Jun 2005 18:45:56 +0000 (18:45 +0000)]
r7450: fix my bone head mistake with ntlm authentcation and 'map to guest = bad uid'; make sure the authentication suceeds
Jeremy Allison [Thu, 9 Jun 2005 18:15:23 +0000 (18:15 +0000)]
r7447: Sync up a little between HEAD and 3.0 in preparation for moving
the AIO code across.
Jeremy.
Gerald Carter [Thu, 9 Jun 2005 15:20:11 +0000 (15:20 +0000)]
r7440: * merge registry server changes from trunk (so far) for more
printmig.exe work
* merge the sys_select_signal(char c) change from trunk
in order to keeo the winbind code in sync
Volker Lendecke [Thu, 9 Jun 2005 07:45:29 +0000 (07:45 +0000)]
r7423: Fix the build on sol10
Gerald Carter [Wed, 8 Jun 2005 22:10:34 +0000 (22:10 +0000)]
r7415: * big change -- volker's new async winbindd from trunk
Jeremy Allison [Wed, 8 Jun 2005 20:52:42 +0000 (20:52 +0000)]
r7412: Now we're not memset'ing ensure we're valgrind clean.
Jeremy.
Gerald Carter [Wed, 8 Jun 2005 14:57:37 +0000 (14:57 +0000)]
r7398: commiting abartlet's patch for kerberos authentication when using a keytab and security != ads
Gerald Carter [Wed, 8 Jun 2005 14:37:14 +0000 (14:37 +0000)]
r7396: cleaning up vestiges of winbind local accounts code
Gerald Carter [Wed, 8 Jun 2005 14:23:49 +0000 (14:23 +0000)]
r7395: * new feature 'map to guest = bad uid' (based on patch from
aruna.prabakar@hp.com).
This re-enables the Samba 2.2 behavior where a user that was
successfully authenticated by a remote DC would be mapped
to the guest account if there was not existing UNIX account
for that user and we could not create one.
Günther Deschner [Wed, 8 Jun 2005 13:59:03 +0000 (13:59 +0000)]
r7391: - Added client-support for various lsa_query_trust_dom_info-calls and a
rpcclient-tester for some info-levels.
Jerry, I tried to adopt to prs_pointer() where possible and to not
interfere with your work for usrmgr.
- Add "net rpc trustdom vampire"-tool.
This allows to retrieve Interdomain Trust(ed)-Relationships from
NT4-Servers including cleartext-passwords (still stored in the local
secrets.tdb).
The net-hook was done in cooperation with Lars Mueller
<lmuelle@suse.de>.
To vampire trusted domains simply call:
net rpc trustdom vampire -S nt4dc -Uadmin%pass
Guenther
Volker Lendecke [Wed, 8 Jun 2005 12:47:00 +0000 (12:47 +0000)]
r7390: Revision 7371 did not help :-(
Jeremy Allison [Wed, 8 Jun 2005 03:48:40 +0000 (03:48 +0000)]
r7385: Rewrite the RPC bind parsing functions to follow the spec. I haven't yet
tested this so I may have screwed this up - however it now follows the
DCE spec. valgrinded tests to follow....
Jeremy.
Gerald Carter [Tue, 7 Jun 2005 19:01:45 +0000 (19:01 +0000)]
r7374: BUG 1261: remove unusable libbiconv after discussion with Timur (FreeBSD Samba maintainer)
Gerald Carter [Tue, 7 Jun 2005 17:52:19 +0000 (17:52 +0000)]
r7372: abartet's patch for BUG 2391 (segv caused by free a static pointer)
Volker Lendecke [Tue, 7 Jun 2005 15:59:14 +0000 (15:59 +0000)]
r7371: On one build farm box dirtest1 does not return, I think this might be due to
it being too slow. The build farm re-runs that with debuglevel 10, and this
ends up with a 400MB logfile which is not synced. Lets see if with this change
the machine pops up on build.samba.org....
Volker
Volker Lendecke [Mon, 6 Jun 2005 15:21:09 +0000 (15:21 +0000)]
r7344: Correctly return if malloc fails.
Jeremy, you might want to check this.
Thanks,
Volker
Gerald Carter [Mon, 6 Jun 2005 14:37:31 +0000 (14:37 +0000)]
r7339: only check for dfs proxy referrals when the server supports dfs
Gerald Carter [Mon, 6 Jun 2005 13:30:45 +0000 (13:30 +0000)]
r7335: patch from Joerg Sonnenberger <joerg@britannica.bec.de> to fix dragonfly detection
Jeremy Allison [Mon, 6 Jun 2005 04:07:10 +0000 (04:07 +0000)]
r7318: Unify HEAD and 3.0 socket functions. Add HEAD functions here #ifdef'ed out.
Correct branch this time !
Jeremy.
Derrell Lipman [Fri, 3 Jun 2005 18:54:32 +0000 (18:54 +0000)]
r7245: bug fixes in libsmbclient, setting time attributes
Volker Lendecke [Fri, 3 Jun 2005 15:42:03 +0000 (15:42 +0000)]
r7243: Don't look at gencache.tdb for the trusted domains if winbind is around.
Volker
Volker Lendecke [Fri, 3 Jun 2005 09:24:48 +0000 (09:24 +0000)]
r7217: Only allow schannel connections if a successful Auth2 has been done
before. Things tested: Domain join and subsequent interactive and network
logon to NT4, W2kSP and XPSP2 workstations and a NT4 domain trusting us. Right
now I've got problems with my W2k3 domain trusts. So this needs testing,
although I'm really confident that this does not break.
Volker
Jeremy Allison [Fri, 3 Jun 2005 05:35:04 +0000 (05:35 +0000)]
r7210: Fix my own mistakes up, sorry.
Jeremy.
Steve French [Fri, 3 Jun 2005 00:34:13 +0000 (00:34 +0000)]
r7202: lock mtab when updating it during umount.cifs, also delete only one matching entry at a time
Jeremy Allison [Thu, 2 Jun 2005 23:18:52 +0000 (23:18 +0000)]
r7200: Don't use memset, use SET_STAT_INVALID (has the same effect).
Jeremy.
Gerald Carter [Thu, 2 Jun 2005 16:11:14 +0000 (16:11 +0000)]
r7197: fix build failure when running 'make torture' without
first running 'make all' first
Jeremy Allison [Thu, 2 Jun 2005 06:19:02 +0000 (06:19 +0000)]
r7191: Squeezing out more unnecessary memset's gets us up 20% over older code :-).
Getting medieval on our ass about memset....
Jeremy.
Jeremy Allison [Thu, 2 Jun 2005 05:27:37 +0000 (05:27 +0000)]
r7190: I *love* valgrind/cachegrind.....
By removing unneeded memsets in qfilepathinfo I just improved our netbench performance
by *********15%**********. Check it out :-).
Jeremy.
Derrell Lipman [Wed, 1 Jun 2005 20:25:33 +0000 (20:25 +0000)]
r7175: fix incorrect comment
Derrell Lipman [Wed, 1 Jun 2005 20:17:16 +0000 (20:17 +0000)]
r7172: This is the proper fix for setting file times from libsmbclient. We now
try setpathinfo, and if that doesn't work (e.g. on win98), revert to the
previous slower method.
Derrell Lipman [Wed, 1 Jun 2005 17:40:40 +0000 (17:40 +0000)]
r7168: Updating file times from libsmbclient was not working for win98. Although
the function that was being used to set attributes is a core protocol
function (SMBsetatr = 0x09), it does not appear to work on win98. As a
temporary measure, when file times are to be set, this version opens the
file and uses SMBsetattrE = 0x22 instead. (The other advantage of this
function over the original one is that it supports setting access time as
well as modification time.)
The next step, the proper solution if it can be made to work, is to write
functions that use TRANS2_SET_PATH_INFO instead.
Jeremy Allison [Wed, 1 Jun 2005 00:00:07 +0000 (00:00 +0000)]
r7157: Ensure we abort a directory listing if we see the same
name twice between packets.
Jeremy.
Derrell Lipman [Tue, 31 May 2005 23:42:29 +0000 (23:42 +0000)]
r7156: file was missing; svn isn't smart enough to even notify me. sigh.
Derrell Lipman [Tue, 31 May 2005 20:12:34 +0000 (20:12 +0000)]
r7153: add better test facilities to testutime
Jeremy Allison [Tue, 31 May 2005 19:06:52 +0000 (19:06 +0000)]
r7151: Fix for bug #2698. If a unicode to unix charset conversion fails (due to buggy iconv?) we can
be left with a filename that doesn't exist on the remote machine. If we then do a findnext
with this file the server gets confused and restarts from the beginning of the directory,
causing directory listing loops. Fix this by keeping a copy of the "raw" filename data and
length and using this as the argument to findnext. This won't fix the incorrect iconv
conversion into the finfo struct but at least it ensures that directory listings always
terminate. Tested against NTFS and FAT directories.
Jeremy.
Jim McDonough [Tue, 31 May 2005 18:36:38 +0000 (18:36 +0000)]
r7148: Fix #2736: winbind race condition with detecting idle clients
winbind idle connection closing logic is getting invoked under high loads for
clients which may already have commands in the pipe. This race condition
causes clients to fail with NSS_STATUS_UNAVAIL sometimes. We now retry several
times hoping (still not guaranteed, though) it will work.
Günther Deschner [Tue, 31 May 2005 16:21:06 +0000 (16:21 +0000)]
r7145: reuse the WINBIND_REQUIRED_MEMBERSHIP constant.
This is just cosmetic but prevents people from thinking that the
pam_winbind "require_membership_of"-option is not yet implemented :)
Guenther
Gerald Carter [Tue, 31 May 2005 16:10:22 +0000 (16:10 +0000)]
r7143: removing unused file
Gerald Carter [Tue, 31 May 2005 16:09:58 +0000 (16:09 +0000)]
r7142: removing 'ldap filter' smb.conf option
Gerald Carter [Tue, 31 May 2005 13:48:37 +0000 (13:48 +0000)]
r7140: removing aparser directory since it is obselete in light of pidl
Gerald Carter [Tue, 31 May 2005 13:46:45 +0000 (13:46 +0000)]
r7139: trying to reduce the number of diffs between trunk and 3.0; changing version to 3.0.20pre1
Gerald Carter [Tue, 31 May 2005 02:23:47 +0000 (02:23 +0000)]
r7130: remove 'winbind enable local accounts' code from the 3.0 tree
Gerald Carter [Tue, 31 May 2005 01:44:44 +0000 (01:44 +0000)]
r7126: fixing paranoid malloc checker failures
Gerald Carter [Fri, 27 May 2005 20:34:19 +0000 (20:34 +0000)]
r7041: compile fixes....long day I guess
Jeremy Allison [Fri, 27 May 2005 20:07:28 +0000 (20:07 +0000)]
r7039: Ensure we always call read_socket_with_timeout() when
timeout > 0. Better solution after much helpful input
from derrell@samba.org. We may eventually change the
read_socket_with_timeout() interface to count down the
timeout value.
Jeremy.
Gerald Carter [Fri, 27 May 2005 19:02:30 +0000 (19:02 +0000)]
r7038: * upgrade version of nt*tdb files. Have to fix
some issues in the printer security descriptors.
Ensure that each printer sd has an oaner and group SID
(BUILTIN\Administrators) and that we utilize more than
the generic bits assigned in <= 3.0.14a.
Jeremy Allison [Fri, 27 May 2005 17:47:24 +0000 (17:47 +0000)]
r7034: Revert change in util_sock.c from derrell until this is
discussed more on samba-technical.
Jeremy.
Jeremy Allison [Fri, 27 May 2005 16:21:19 +0000 (16:21 +0000)]
r7033: Call a spade a spade :-).
Jeremy.
Jeremy Allison [Fri, 27 May 2005 16:15:56 +0000 (16:15 +0000)]
r7031: Added encrypt/decrypt function for LSA secrets and trusted
domain passwords on the wire.
Jeremy.
Derrell Lipman [Fri, 27 May 2005 14:38:00 +0000 (14:38 +0000)]
r7025: 1 if not all data is available at the time we go to read a packet, retry
the read using a timeout to ensure that all data for the packet is received.
2 some minor changes to meet coding standards
3 eliminate some compiler warnings
Gerald Carter [Fri, 27 May 2005 14:19:57 +0000 (14:19 +0000)]
r7024: reverting mistaken commit
Gerald Carter [Fri, 27 May 2005 13:58:04 +0000 (13:58 +0000)]
r7020: fixing printer ace values and getting rid of false compiler warning about unitialized variable
Gerald Carter [Thu, 26 May 2005 20:36:04 +0000 (20:36 +0000)]
r6995: * fixing segfault when writing out registry values of zero length
* add RegSaveKey() client function
* add 'net rpc registry save' subcommand
Jeremy Allison [Thu, 26 May 2005 19:39:40 +0000 (19:39 +0000)]
r6994: Fix for bugid #2729 - it turns out resume keys are *mandatory* for
a search when listing a W2K and above server from a FATxx filesystem
only. Thanks to Steve Langasek <vorlon@debian.org> for giving me the
essential info that allowed me to reproduce and thus fix this.
Jeremy.
Gerald Carter [Thu, 26 May 2005 14:03:25 +0000 (14:03 +0000)]
r6992: syncing printer permissions changes from trunk
Jeremy Allison [Wed, 25 May 2005 20:31:46 +0000 (20:31 +0000)]
r6979: Tidyups.
Jeremy.
Jeremy Allison [Wed, 25 May 2005 19:25:35 +0000 (19:25 +0000)]
r6977: Fix bug #2735 (not mangling control characters) plus
ensure we don't create files with control characters
either.
Jeremy.
Jeremy Allison [Wed, 25 May 2005 00:51:39 +0000 (00:51 +0000)]
r6965: Remove some dead code from util_unistr.c.
Start of fix for #2735 - we are not mangling some
names we should. More fixes to follow.
Jeremy.
Deryck Hodge [Tue, 24 May 2005 17:37:04 +0000 (17:37 +0000)]
r6959: Meant to fix this before commiting, just to be consistent.
deryck
Deryck Hodge [Tue, 24 May 2005 17:33:47 +0000 (17:33 +0000)]
r6958: Properly display quotes in SWAT. Thanks to Jay
Fenlason <fenlason@redhat.com> for spotting this issue.
deryck
Volker Lendecke [Tue, 24 May 2005 07:55:02 +0000 (07:55 +0000)]
r6953: Many compilers in the build farm don't like static variables initialized with
strlen(..). Jerry, I think this needs another fix. I just want to make the
build farm happy.
Not merging to trunk, this needs further looking at.
Volker