Andrew Tridgell [Thu, 10 Feb 2011 03:12:51 +0000 (14:12 +1100)]
ldb: use #include <ldb.h> for ldb
thi ensures we are using the header corresponding to the version of
ldb we're linking against. Otherwise we could use the system ldb for
link and the in-tree one for include
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 10 Feb 2011 03:12:15 +0000 (14:12 +1100)]
s4-krb5: authkrb5 should depend on ldb
this fixes the include path to add ldb
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Wed, 9 Feb 2011 06:02:58 +0000 (17:02 +1100)]
s3-auth Remove unused pam_handle
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Bartlett [Wed, 9 Feb 2011 05:52:35 +0000 (16:52 +1100)]
s3-auth Rename cryptic 'ptok' to security_token
This will allow the auth_serversupplied_info struct to be migrated
to auth_session_info easier.
Adnrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Bartlett [Wed, 9 Feb 2011 03:22:16 +0000 (14:22 +1100)]
libcli/named_pipe_auth Change from 'info3' to auth_session_info_transport
This changes the structure being used to convey the current user state
from the netlogon-derived 'netr_SamInfo3' structure to a purpose-built
structure that matches the internals of the Samba auth subsystem and
contains the final group list, as well as the final privilege set and
session key.
These previously had to be re-created on the server side of the pipe
each time.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Bartlett [Wed, 9 Feb 2011 03:22:02 +0000 (14:22 +1100)]
auth.idl fix size_is() reference in IDL
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Bartlett [Wed, 9 Feb 2011 00:59:50 +0000 (11:59 +1100)]
libcli/named_pipe_auth Remove support for unused levels 0-2.
The only client and server for this code uses level 3 exclusively.
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Bartlett [Wed, 9 Feb 2011 05:05:54 +0000 (16:05 +1100)]
auth Move auth_sam_reply into the top level.
These functions provide conversions between some netlogon.idl and
auth.idl structures
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Andrew Tridgell [Thu, 10 Feb 2011 01:35:10 +0000 (12:35 +1100)]
ldb: added ldb 1.0.0 ABI signatures
Andrew Tridgell [Thu, 10 Feb 2011 01:06:34 +0000 (12:06 +1100)]
ldb: change version number to 1.0.0
Simo pointed out that the module loading change should have been
combined with a major version number. That seems like a good excuse
for a 1.0 release
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 10 Feb 2011 01:05:48 +0000 (12:05 +1100)]
ldb: fixed two warnings in the ldb_ldap backend
Andrew Tridgell [Thu, 10 Feb 2011 01:04:36 +0000 (12:04 +1100)]
ldb: added a include/ldb_version.h
this fixes a problem with the installed ldb_modules.h header, which
depended on LDB_VERSION being defined.
Thanks to Simo for noticing this!
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Jeremy Allison [Thu, 10 Feb 2011 00:31:06 +0000 (16:31 -0800)]
Put OpenDir() back the way it was - don't overload with an fsp arg. Create OpenDir_fsp for new usage.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Feb 10 02:43:31 CET 2011 on sn-devel-104
Jeremy Allison [Wed, 9 Feb 2011 23:06:40 +0000 (15:06 -0800)]
Make it clear we're using the open file pathname.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Feb 10 01:06:29 CET 2011 on sn-devel-104
Jeremy Allison [Wed, 9 Feb 2011 23:05:58 +0000 (15:05 -0800)]
Allow SMB2_FIND to actually use the open fd handle if we support fdopendir. Fallback to pathname opendir if not.
Jeremy Allison [Wed, 9 Feb 2011 23:00:56 +0000 (15:00 -0800)]
Correctly plumb in VFS_FDOPENDIR.
Günther Deschner [Wed, 9 Feb 2011 21:43:41 +0000 (22:43 +0100)]
s3-waf: make ads support detection a little more robust.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb 9 23:38:50 CET 2011 on sn-devel-104
Günther Deschner [Wed, 9 Feb 2011 19:56:57 +0000 (20:56 +0100)]
s3: move some stuff out of smb.h to better locations.
Guenther
Günther Deschner [Wed, 9 Feb 2011 19:51:47 +0000 (20:51 +0100)]
s3: remove unused struct uuid_flat.
Guenther
Günther Deschner [Wed, 9 Feb 2011 19:51:12 +0000 (20:51 +0100)]
s3-waf: make sure we dont activate dnsupdate support w/o gssapi.
Guenther
Jeremy Allison [Wed, 9 Feb 2011 20:18:55 +0000 (12:18 -0800)]
Oops. Need to test for if(!NT_STATUS_IS_OK(..)) for error.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb 9 22:06:05 CET 2011 on sn-devel-104
Jeremy Allison [Wed, 9 Feb 2011 18:43:56 +0000 (10:43 -0800)]
Fix up some buildfarm warnings.
Jeremy Allison [Wed, 9 Feb 2011 18:28:08 +0000 (10:28 -0800)]
Don't use asprintf in this library - breaks the build on many systems. Fake with malloc/memcpy.
Jeremy Allison [Wed, 9 Feb 2011 01:04:19 +0000 (17:04 -0800)]
Move to opening an fd on directory opens. Get more careful about symlink races.
Jeremy Allison [Wed, 9 Feb 2011 00:51:17 +0000 (16:51 -0800)]
Remove unneeded stat call.
Matthias Dieter Wallnöfer [Wed, 9 Feb 2011 15:51:52 +0000 (16:51 +0100)]
s4:WAF build - remove "source4/configure.developer"
This isn't needed anymore - discussed with abartlet.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Feb 9 19:44:05 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:34:44 +0000 (20:34 +0100)]
ldb:tools - return LDB_ERR_OPERATIONS_ERROR on generic errors
Use "return" when located in "main" for consistency ("exit" would do the
same).
The patchset has been discussed with Jelmer Vernooij and afterwards LDB
maintainer Simo Sorce.
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:26:12 +0000 (20:26 +0100)]
ldb:tools - always check if ldb connection has been estabilished
Otherwise return "LDB_ERR_OPERATIONS_ERROR".
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:48:52 +0000 (20:48 +0100)]
ldb:ldbsearch tool - use LDB result constants where possible
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:40:27 +0000 (20:40 +0100)]
ldb:ldbsearch tool - simplify error code return
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:51:26 +0000 (20:51 +0100)]
ldb:ldbsearch tool - use "%u" for printing unsigned integers
Matthias Dieter Wallnöfer [Sat, 5 Feb 2011 12:19:56 +0000 (13:19 +0100)]
ldb:ldbedit tool - don't forget about the "do_edit" result code
Use it for computing the program exit code. The "result" has not to be
free'd explicitly since it's a child by "ldb" which itself is child by
"mem_ctx".
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:48:54 +0000 (12:48 +0100)]
ldb:ldbedit tool - fix bug #7914
"modify_record" returns "-1" when failing, otherwise the number of
modifies performed as an "unsigned int" converted to "int".
When we get "-1" we immediately need to stop (the error message has
already been generated by the function itself).
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:39:42 +0000 (12:39 +0100)]
ldb:ldbedit tool - use unsigned counters for consistency with other LDB tools
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:52:33 +0000 (20:52 +0100)]
ldb:ldbedit tool - use "%u" for printing out unsigned integers
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:39:04 +0000 (12:39 +0100)]
ldb:ldbedit tool - use LDB result constants where needed
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:38:10 +0000 (12:38 +0100)]
ldb:ldbrename tool - use LDB result constant where needed
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:37:32 +0000 (12:37 +0100)]
ldb:ldbmodify tool - use unsigned counters for consistency with other LDB tools
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:36:13 +0000 (12:36 +0100)]
ldb:ldbdel tool - use LDB result constants for consistency
Matthias Dieter Wallnöfer [Tue, 1 Feb 2011 19:37:58 +0000 (20:37 +0100)]
ldb:ldbadd tool - use LDB return codes where possible
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:34:47 +0000 (12:34 +0100)]
ldb:ldbadd tool - use "%u" for printing out unsigned integers
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:34:08 +0000 (12:34 +0100)]
ldb:ldbadd tool - use LDB result constants for consistency
Günther Deschner [Wed, 9 Feb 2011 16:56:45 +0000 (17:56 +0100)]
s3-waf: we check for attr in ../lib/util/script already, so we cannot set to EMPTY here.
Hopefully fixes the irix build.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb 9 18:58:15 CET 2011 on sn-devel-104
Günther Deschner [Wed, 9 Feb 2011 16:37:40 +0000 (17:37 +0100)]
s3-waf: as long as we dont have --with-featureX=yes|no|auto handling, avoid exiting.
Guenther
Günther Deschner [Wed, 9 Feb 2011 16:43:54 +0000 (17:43 +0100)]
s3-waf: check k5crypto in some more locations.
Guenther
Günther Deschner [Wed, 9 Feb 2011 16:43:30 +0000 (17:43 +0100)]
s3-waf: support non-default krb5-config and cups-config locations.
Guenther
Volker Lendecke [Wed, 9 Feb 2011 14:50:34 +0000 (15:50 +0100)]
tevent: Fix typos
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 9 18:13:18 CET 2011 on sn-devel-104
Andreas Schneider [Wed, 9 Feb 2011 13:21:24 +0000 (14:21 +0100)]
s3-rpc_server: We need a messaging context for rpc.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Feb 9 17:26:00 CET 2011 on sn-devel-104
Andreas Schneider [Wed, 9 Feb 2011 13:08:34 +0000 (14:08 +0100)]
s3-rpc_server: Fixed possible segfault with client_id.
Christian Ambach [Wed, 9 Feb 2011 14:35:24 +0000 (15:35 +0100)]
s3:utils enable sharesec for registry shares
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Feb 9 16:41:31 CET 2011 on sn-devel-104
Gregor Beck [Tue, 8 Feb 2011 23:04:48 +0000 (00:04 +0100)]
s3:net idmap: implement net idmap delete
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Feb 9 15:06:06 CET 2011 on sn-devel-104
Michael Adam [Wed, 9 Feb 2011 12:47:21 +0000 (13:47 +0100)]
s3:net idmap dump: report correct database file when failed to open idmap db.
Gregor Beck [Tue, 8 Feb 2011 11:40:23 +0000 (12:40 +0100)]
s3:net idmap dump: use net_idmap_dbfile
Michael Adam [Tue, 8 Feb 2011 22:24:57 +0000 (23:24 +0100)]
s3:net idmap restore: correctly abort operation if dbfile could not be determined
Michael Adam [Tue, 8 Feb 2011 22:16:31 +0000 (23:16 +0100)]
s3:net idmap: fix error reporting in net_idmap_dbfile()
The last case which results in dbfile == NULL is not an
out of memory case but means no --db has been specified
and the idmap backend is not supported for auto-determining
the idmap tdb file.
Gregor Beck [Tue, 8 Feb 2011 11:06:07 +0000 (12:06 +0100)]
s3:net factor out net_idmap_dbfile
Gregor Beck [Tue, 8 Feb 2011 11:03:08 +0000 (12:03 +0100)]
s3:net idmap restore: fix segfault on missing input file
Gregor Beck [Tue, 8 Feb 2011 11:01:34 +0000 (12:01 +0100)]
s3:net add option --db
Michael Adam [Wed, 9 Feb 2011 12:45:22 +0000 (13:45 +0100)]
s3:testparm: add "--option" to testparm
This way one can test the --option feature with testparm.
E.g.:
testparm -s -v --option="parameter=value" | grep parameter
should print "parameter = value"
Michael Adam [Wed, 9 Feb 2011 12:44:42 +0000 (13:44 +0100)]
s3:popt: add POPT_COMMON_OPTION to provide only the "--option" feature
Michael Adam [Wed, 9 Feb 2011 12:42:38 +0000 (13:42 +0100)]
s3:loadparm: skip leading spaces in parameter values from the command line
Jelmer Vernooij [Sun, 30 Jan 2011 09:59:41 +0000 (10:59 +0100)]
provision: Add missing dependency on pyldb-util.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Feb 9 13:55:10 CET 2011 on sn-devel-104
Jelmer Vernooij [Sun, 30 Jan 2011 09:59:14 +0000 (10:59 +0100)]
dlinklist: Change license to LGPLv3+ (checked with tridge).
Stefan Metzmacher [Wed, 9 Feb 2011 05:56:25 +0000 (06:56 +0100)]
s3:rpc_server: create binding_handle in rpc_pipe_open_external()
metze
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 9 12:30:50 CET 2011 on sn-devel-104
Stefan Metzmacher [Wed, 9 Feb 2011 05:55:33 +0000 (06:55 +0100)]
s3:rpc_client: make rpccli_bh_create() non-static for now
metze
Kamen Mazdrashki [Wed, 9 Feb 2011 01:40:52 +0000 (03:40 +0200)]
s4/tests: Implement a blackbox test for 'samba-tool drs' command
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Feb 9 11:45:30 CET 2011 on sn-devel-104
Kamen Mazdrashki [Wed, 9 Feb 2011 01:40:17 +0000 (03:40 +0200)]
s4/tests: Move command line processing into separate method to be reused
Kamen Mazdrashki [Wed, 9 Feb 2011 01:01:16 +0000 (03:01 +0200)]
s4/tests: Implement BlackboxTestCase.check_output() method
I am going to need this to check if output is OK (kind of)
Kamen Mazdrashki [Wed, 9 Feb 2011 01:00:06 +0000 (03:00 +0200)]
s4/samba-tool/drs: Make use of Command.message() method instead of using 'print'
Kamen Mazdrashki [Mon, 7 Feb 2011 12:13:06 +0000 (14:13 +0200)]
s4/samba-tool/drs: Move get_dsServiceName function at module level to be re-used
Kamen Mazdrashki [Fri, 4 Feb 2011 02:14:13 +0000 (04:14 +0200)]
s4/samba-tool: 'drs options' command implementation
Current implementation handle only one flag change per call
Andrew Bartlett [Tue, 8 Feb 2011 23:59:18 +0000 (10:59 +1100)]
waf Remove debugging hacks left in the top level build
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Feb 9 01:55:15 CET 2011 on sn-devel-104
Andrew Bartlett [Tue, 8 Feb 2011 23:50:57 +0000 (10:50 +1100)]
s4-waf Remove source4 build system.
The top level build is the official build system now.
Andrew Bartlett
Andrew Bartlett [Tue, 8 Feb 2011 23:46:21 +0000 (10:46 +1100)]
s4-auth Fix setting of bad_password_count in auth_convert_user_info_dc_sambaseinfo()
Discovered during the convertion to auth_user_info.
Andrew Bartlett
Andrew Bartlett [Tue, 8 Feb 2011 09:38:05 +0000 (20:38 +1100)]
s4-selftest Fix valgrind and gdb options for top level build
Andrew Bartlett
Andrew Bartlett [Tue, 8 Feb 2011 05:53:13 +0000 (16:53 +1100)]
s4-auth Rework auth subsystem to remove struct auth_serversupplied_info
This changes auth_serversupplied_info into the IDL-defined struct
auth_user_info_dc. This then in turn contains a struct
auth_user_info, which is the only part of the structure that is
mainted into the struct session_info.
The idea here is to avoid keeping the incomplete results of the
authentication (such as session keys, lists of SID memberships etc) in
a namespace where it may be confused for the finalised results.
Andrew Barltett
Andrew Bartlett [Tue, 8 Feb 2011 05:39:34 +0000 (16:39 +1100)]
s4-auth Add auth.idl to encode auth subsystem structures in IDL
This is not only a useful way to encode stuff, it also allows python
to handle the structures, and natrually allows them to be NDR encoded.
Andrew Bartlett
Jeremy Allison [Tue, 8 Feb 2011 23:07:48 +0000 (15:07 -0800)]
Add fdopendir to the VFS. We will use this to reuse a directory fd already open by NtCreateX.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb 9 00:55:22 CET 2011 on sn-devel-104
Jeremy Allison [Tue, 8 Feb 2011 23:05:00 +0000 (15:05 -0800)]
Pass fsp to dptr_CloseDir(). Cope with setting the fd if we're closing an fd that opendir knows about.
Jeremy Allison [Tue, 8 Feb 2011 23:04:47 +0000 (15:04 -0800)]
Add configure checks for fdopendir.
Jeremy Allison [Tue, 8 Feb 2011 22:43:07 +0000 (14:43 -0800)]
Add fdopendir().
Volker Lendecke [Tue, 8 Feb 2011 22:08:21 +0000 (23:08 +0100)]
s3: Fix some nonempty blank lines and some typos
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 9 00:01:45 CET 2011 on sn-devel-104
Günther Deschner [Tue, 8 Feb 2011 13:56:32 +0000 (14:56 +0100)]
selftest: remove make oldtest.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 8 22:16:31 CET 2011 on sn-devel-104
Günther Deschner [Tue, 8 Feb 2011 13:55:12 +0000 (14:55 +0100)]
s3-selftest: let valgrindtest use the new make test.
Guenther
Günther Deschner [Tue, 8 Feb 2011 19:44:55 +0000 (20:44 +0100)]
waf: bring back shared Makefile and configure (needed by s3-waf).
Guenther
Revert "build: removed unused build scripts"
This reverts commit
2e520ca91180920e4c8b71be4eaa7fabb56d2a12.
Günther Deschner [Tue, 8 Feb 2011 16:19:23 +0000 (17:19 +0100)]
s3-spoolss: Dont wipe out all drivers when only one should be deleted.
Great catch from Bjoern Baumbach <bb@sernet.de> !
Andreas, Simo, please check.
We now have a torture test (rpc.spoolss.driver.driver.multiple_drivers) for this.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 8 18:11:48 CET 2011 on sn-devel-104
Günther Deschner [Tue, 8 Feb 2011 16:16:51 +0000 (17:16 +0100)]
s4-smbtorture: add torture test to check proper add and delete driver operations.
Thanks to Bjoern Baumbach <bb@sernet.de> for pushing us to test and verify this.
Guenther
Günther Deschner [Tue, 8 Feb 2011 14:16:44 +0000 (15:16 +0100)]
s3-selftest: mark the driver timestamp test as knownfail for now.
Guenther
Günther Deschner [Tue, 8 Feb 2011 14:16:20 +0000 (15:16 +0100)]
s4-smbtorture: also run the driver timestamp spoolss test against samba.
Guenther
Günther Deschner [Fri, 28 Jan 2011 13:02:55 +0000 (14:02 +0100)]
s4-waf: split out wscript_build for ndrdump binary.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 8 14:50:54 CET 2011 on sn-devel-104
Günther Deschner [Tue, 8 Feb 2011 13:00:02 +0000 (14:00 +0100)]
lib/compression: add shared wscript_build.
Guenther
Günther Deschner [Tue, 8 Feb 2011 10:49:33 +0000 (11:49 +0100)]
libndr: apply some const and make is_valid_policy_hnd a callback to policy_handle_empty.
Guenther
Günther Deschner [Tue, 8 Feb 2011 09:45:39 +0000 (10:45 +0100)]
pam: share pam errors in a common location.
Guenther
Jelmer Vernooij [Sun, 30 Jan 2011 09:57:30 +0000 (10:57 +0100)]
pysecurity: Add missing dependency on pytalloc-util.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Feb 8 13:16:43 CET 2011 on sn-devel-104
Gregor Beck [Fri, 28 Jan 2011 09:58:03 +0000 (10:58 +0100)]
s3:net: remove unused net_idmap_help
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Feb 8 11:50:37 CET 2011 on sn-devel-104
Andreas Schneider [Mon, 7 Feb 2011 17:06:40 +0000 (18:06 +0100)]
s3: Added file for clang complete support in vim.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Tue Feb 8 10:40:42 CET 2011 on sn-devel-104
Andreas Schneider [Mon, 7 Feb 2011 17:06:04 +0000 (18:06 +0100)]
s3: Added missing files in .gitignore.
Günther Deschner [Mon, 7 Feb 2011 23:04:20 +0000 (00:04 +0100)]
libndr: share some uuid helpers.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Feb 8 09:52:56 CET 2011 on sn-devel-104
Günther Deschner [Mon, 7 Feb 2011 22:27:57 +0000 (23:27 +0100)]
ndr: merge ndr_map_error2string and ndr_errstr.
Guenther
Günther Deschner [Mon, 7 Feb 2011 22:21:41 +0000 (23:21 +0100)]
ndr: move null_ndr_syntax_id to the common libndr location.
Guenther