Rusty Russell [Tue, 21 Jul 2009 06:53:35 +0000 (16:23 +0930)]
tdb: fix locking error
54a51839ea65aa788b18fce8de0ae4f9ba63e4e7 "Make tdb transaction lock
recursive (samba version)" was broken: I "cleaned it up" and prevented
it from ever unlocking.
To see the problem:
$ bin/tdbtorture -s
1248142523
tdb_brlock failed (fd=3) at offset 8 rw_type=1 lck_type=14 len=1
tdb_transaction_lock: failed to get transaction lock
tdb_transaction_start failed: Resource deadlock avoided
My testcase relied on the *count* being correct, which it was. Fixing that
now.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
Tim Prouty [Mon, 20 Jul 2009 21:32:32 +0000 (14:32 -0700)]
s3: Add some asserts to the filename util functions
In the smb_filename struct stream_name must equal NULL if there
is no stream name. These asserts should catch any future offenders
of this invariant early.
Tim Prouty [Fri, 10 Jul 2009 22:43:21 +0000 (15:43 -0700)]
s3: Plumb smb_filename through open_fake_file
Tim Prouty [Fri, 10 Jul 2009 22:35:08 +0000 (15:35 -0700)]
s3: Separate out a new file: filename_utils.c
This is to ease the linking pain of everything that links LOCKING_OBJ
Tim Prouty [Fri, 10 Jul 2009 22:10:35 +0000 (15:10 -0700)]
s3: Move is_ntfs_stream*() to filename.c
Tim Prouty [Sat, 11 Jul 2009 01:11:32 +0000 (18:11 -0700)]
s3: Finish plumbing the fsp->fsp_name smb_fname conversion through the modules.
Tim Prouty [Fri, 10 Jul 2009 21:50:37 +0000 (14:50 -0700)]
s3: Change fsp->fsp_name to be an smb_filename struct!
Tim Prouty [Fri, 10 Jul 2009 18:50:30 +0000 (11:50 -0700)]
s3 onefs oplocks: Replace static fstring with talloc'd dbg_ctx()
Tim Prouty [Fri, 10 Jul 2009 17:38:56 +0000 (10:38 -0700)]
s3: Change file_structs to be allocated with talloc instead of malloc
Tim Prouty [Mon, 20 Jul 2009 22:37:18 +0000 (15:37 -0700)]
lib util: Fix const warning
Jeremy Allison [Mon, 20 Jul 2009 22:15:08 +0000 (15:15 -0700)]
Make cli_send_mailslot() static. Preparing to do away with unexpected.tdb....
Jeremy.
Rusty Russell [Sat, 18 Jul 2009 05:58:58 +0000 (15:28 +0930)]
Make tdb transaction lock recursive (samba version)
This patch replaces
6ed27edbcd3ba1893636a8072c8d7a621437daf7 and
1a416ff13ca7786f2e8d24c66addf00883e9cb12, which fixed the bug where traversals
inside transactions would release the transaction lock early.
This solution is more general, and solves the more minor symptom that nested
traversals would also release the transaction lock early. (It was also suggestd in
Volker's comment in
6ed27ed).
This patch also applies to ctdb, if the traverse.c part is removed (ctdb's tdb
code never received the previous two fixes).
Tested using the testsuite from ccan (adapted to the samba code). Thanks to
Michael Adam for feedback.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
Jelmer Vernooij [Mon, 20 Jul 2009 08:25:25 +0000 (10:25 +0200)]
Re-add accidently removed shares test.
Andrew Bartlett [Sat, 18 Jul 2009 00:15:55 +0000 (10:15 +1000)]
s4:kdc Add in a simple check for constrained delegation to self
To do this properly, we must use the PAC, but for now this is enough
to check that we are delegating to another name on the same host
(which must be safe).
(Windows 7 does this a lot, also noted in bug 6273)
Andrew Bartlett
Matthias Dieter Wallnöfer [Fri, 10 Jul 2009 10:48:18 +0000 (12:48 +0200)]
[SAMBA 4 directory] Refactoring and clean up of directory structure
- Adds more system objects which make sense to have them in SAMBA 4 also to
have them when we add more and more services related to the directory (volume
support, DFS, replication service, COM...)
- Make sure that "isCriticalSystemObject" and "showInAdvancedViewOnly" attributes
are set correctly on each object
Jelmer Vernooij [Sun, 19 Jul 2009 19:12:56 +0000 (21:12 +0200)]
pidl: Print actual type names in errors about unknown origins rather than 'HASH(0x....)'.
Jelmer Vernooij [Sun, 19 Jul 2009 18:42:52 +0000 (20:42 +0200)]
pidl: Print proper errors when arrays don't have a specified size rather than spewing pages of perl warnings.
Jelmer Vernooij [Sun, 19 Jul 2009 16:58:22 +0000 (18:58 +0200)]
Remove unused parameter setting.
Jelmer Vernooij [Sun, 19 Jul 2009 16:51:15 +0000 (18:51 +0200)]
Remove unnecessary imports.
Jelmer Vernooij [Sun, 19 Jul 2009 15:39:23 +0000 (17:39 +0200)]
Merge branch 'master' of git://git.samba.org/samba
Jelmer Vernooij [Sun, 19 Jul 2009 15:18:04 +0000 (17:18 +0200)]
Include ntsvc NDR in libndr-standard.
Jelmer Vernooij [Sun, 19 Jul 2009 15:17:23 +0000 (17:17 +0200)]
Remove unused variable.
Slava Semushin [Sat, 18 Jul 2009 16:30:33 +0000 (23:30 +0700)]
source4/lib/registry/patchfile.c(reg_diff_load): fixed possible resource leak.
File descriptor leaks when write(2) fails and we are returning from
function.
Found by cppcheck:
[./source4/lib/registry/patchfile.c:319]: (error) Resource leak: fd
Slava Semushin [Sat, 18 Jul 2009 09:28:53 +0000 (16:28 +0700)]
lib/util/util_file.c(file_save): fixed file descriptor leak when read(2) fails.
Found by cppcheck:
[./lib/util/util_file.c:383]: (error) Resource leak: fd
Matthieu Patou [Sat, 11 Jul 2009 13:57:35 +0000 (15:57 +0200)]
Fix broken password quality check
This fixes broken password tests when the passwords contain non ASCII characters
(e.g. accentuated chars like ('e, `e, ...)
Matthias Dieter Wallnöfer [Wed, 15 Jul 2009 11:25:04 +0000 (13:25 +0200)]
Fix typo
Matthias Dieter Wallnöfer [Fri, 17 Jul 2009 16:13:28 +0000 (18:13 +0200)]
[SAMBA 4] Some cosmetic changes for the LDB modules
Some corrections which make the code a bit more readable (no functional changes here)
Matt Kraai [Thu, 9 Jul 2009 16:45:28 +0000 (09:45 -0700)]
include unix.h if it's available
Matthias Dieter Wallnöfer [Thu, 9 Jul 2009 15:54:42 +0000 (17:54 +0200)]
Cosmetic correction
Changes the order of two commands. First set up the "priv" structure, then
assign it to the "ntvfs" structure.
Jelmer Vernooij [Sun, 19 Jul 2009 13:39:52 +0000 (15:39 +0200)]
Merge more ndr interfaces into libndr-standard.
Jelmer Vernooij [Sun, 19 Jul 2009 11:41:04 +0000 (13:41 +0200)]
librpc: Integrate some subsystems now part of libndr-standard and integrate ndr_dfs in libndr-standard.
Jelmer Vernooij [Sun, 19 Jul 2009 11:39:38 +0000 (13:39 +0200)]
Add missing includes.
Jelmer Vernooij [Sun, 19 Jul 2009 11:19:54 +0000 (13:19 +0200)]
provision: Remove unused imports.
Jelmer Vernooij [Sun, 19 Jul 2009 10:41:09 +0000 (12:41 +0200)]
Create libndr-standard, which includes the NDR marshalling code for
the "standard" set of DCE/RPC interfaces found on Windows.
Jelmer Vernooij [Sun, 19 Jul 2009 10:15:59 +0000 (12:15 +0200)]
Remove unnecessary include, update README.
Jelmer Vernooij [Sun, 19 Jul 2009 10:10:47 +0000 (12:10 +0200)]
Remove outdated status file about samba3 -> samba4 upgrade project.
Volker Lendecke [Sun, 19 Jul 2009 00:32:44 +0000 (02:32 +0200)]
Fix a few type errors in VFS modules
Jelmer Vernooij [Sat, 18 Jul 2009 18:04:11 +0000 (20:04 +0200)]
VFS examples: Update copy of config.{guess,sub}.
Jelmer Vernooij [Sat, 18 Jul 2009 16:39:20 +0000 (18:39 +0200)]
python: Set right ldb modules directory when using system ldb.
Jelmer Vernooij [Sat, 18 Jul 2009 16:28:57 +0000 (18:28 +0200)]
Actually fill in ldb modules directory.
Jelmer Vernooij [Sat, 18 Jul 2009 14:11:21 +0000 (16:11 +0200)]
Remove pyldb_util and simply duplicate the 5-line function it contains,
rather than creating a separate shared library for it.
Jelmer Vernooij [Sat, 18 Jul 2009 08:37:59 +0000 (10:37 +0200)]
ldb: Display SHLD_FLAGS when building.
Jeremy Allison [Sat, 18 Jul 2009 04:50:33 +0000 (21:50 -0700)]
Fix Coverity CIDs 887, 888. Don't pass NULL's to functions
that deref them.
Jeremy.
Jeremy Allison [Sat, 18 Jul 2009 04:40:23 +0000 (21:40 -0700)]
Fix Coverity CID 928. Removed check as this can never be null.
Jeremy.
Jeremy Allison [Sat, 18 Jul 2009 04:36:55 +0000 (21:36 -0700)]
Fix Coverity CID 929. Potential NULL deref after code refactoring.
Jeremy.
Jeremy Allison [Sat, 18 Jul 2009 04:29:28 +0000 (21:29 -0700)]
Fix coverity CID 930. Pointer check can never be null here.
Jeremy
Jeremy Allison [Sat, 18 Jul 2009 04:26:16 +0000 (21:26 -0700)]
Fix coverity CID 931. This check is redundent as smb_fname can
never be null in this function.
Jeremy.
Jeremy Allison [Sat, 18 Jul 2009 01:05:10 +0000 (18:05 -0700)]
Fix a typo reading uninitialized memory. Caught by valgrind.
Jeremy.
Jeremy Allison [Sat, 18 Jul 2009 00:57:48 +0000 (17:57 -0700)]
Move the initialization of smbd_server_conn from smbd/process,
after the accept and fork, to smbd_init_globals(), so it's
done immediately on server startup. This is needed as some
messages are sent to all active smbd processes (including
the master listening daemon). If it gets a message that
forces it to scan it's current connections (ie. conn_find())
then it discovers that sconn->smb1.tcons.Connections dereferences
null (as sconn == NULL in the parent) and crashes. Yes,
I could fix all cases where sconn is used and explicitly
check for NULL but this fix is easier. It means that
the smbd_event_context() is initialized in the master
daemon and then re-initialized after fork, but that
should be being done correctly in every fork call anyway.
Without this change the previous fix
6a9e0039100b57f9626e87defec6720c476b9789
still panics in the reproducible test case for bug
6564, as this is one case where such a message
(MSG_SMB_CONF_UPDATED) is sent to the parent. Metze
please check. This change passes valgrind.
Jeremy.
Jeremy Allison [Sat, 18 Jul 2009 00:36:26 +0000 (17:36 -0700)]
Fix bug #6564 - SetPrinter fails (panics) as non root.
Missing become_root()/unbecome_root() around reload_services.
Jeremy.
Volker Lendecke [Fri, 17 Jul 2009 20:40:24 +0000 (22:40 +0200)]
3.4 is released...
Günther Deschner [Fri, 17 Jul 2009 15:16:44 +0000 (17:16 +0200)]
s4-spoolss: fix the build after OsVersion changes.
Guenther
Günther Deschner [Fri, 17 Jul 2009 14:47:48 +0000 (16:47 +0200)]
spoolss: fill in some unknowns in spoolss_OSVersion and spoolss_OSVersionEx.
Guenther
Bo Yang [Sat, 18 Jul 2009 06:07:33 +0000 (14:07 +0800)]
s3: add failure check.
Signed-off-by: Bo Yang <boyang@samba.org>
Günther Deschner [Fri, 17 Jul 2009 13:39:40 +0000 (15:39 +0200)]
s3-rpcclient: add createprinteric command.
Guenther
Günther Deschner [Fri, 17 Jul 2009 13:38:40 +0000 (15:38 +0200)]
spoolss: fill in spoolss_Create/DeletePrinterIC + rerun make samba3-idl.
Guenther
Günther Deschner [Wed, 15 Jul 2009 23:05:25 +0000 (01:05 +0200)]
s3-lsa: let _lsa_Delete return NT_STATUS_NOT_SUPPORTED as w2k3 does.
Guenther
Günther Deschner [Thu, 16 Jul 2009 16:45:29 +0000 (18:45 +0200)]
s3-lsa: Fix access_mask calculation for new handle in _lsa_CreateAccount().
Guenther
Günther Deschner [Thu, 16 Jul 2009 14:32:04 +0000 (16:32 +0200)]
s3-lsa: add (not yet activate) level specific access checks for _lsa_QueryInfoPolicy.
Guenther
Günther Deschner [Thu, 16 Jul 2009 14:28:11 +0000 (16:28 +0200)]
s3-lsa: also implement level 13 in lsa_QueryInfoPolicy.
Guenther
Günther Deschner [Fri, 17 Jul 2009 11:44:55 +0000 (13:44 +0200)]
s3-lsa: Fix policy handle memleak and handle type check in _lsa_DeleteObject().
Guenther
Günther Deschner [Fri, 17 Jul 2009 11:37:08 +0000 (13:37 +0200)]
s3-rpcclient: add LSA storeprivatedata command.
Guenther
Günther Deschner [Fri, 17 Jul 2009 11:30:37 +0000 (13:30 +0200)]
s3-rpcclient: add LSA retrieveprivatedata command.
Guenther
Günther Deschner [Fri, 17 Jul 2009 10:56:30 +0000 (12:56 +0200)]
s3-rpcclient: add LSA setsecret command.
Guenther
Günther Deschner [Fri, 17 Jul 2009 10:03:58 +0000 (12:03 +0200)]
s3-rpcclient: add LSA querysecret command.
Guenther
Günther Deschner [Fri, 17 Jul 2009 09:58:10 +0000 (11:58 +0200)]
s3-rpcclient: add LSA deletesecret command.
Guenther
Günther Deschner [Fri, 17 Jul 2009 09:54:49 +0000 (11:54 +0200)]
s3-rpcclient: add LSA createsecret command.
Guenther
Günther Deschner [Fri, 17 Jul 2009 11:09:26 +0000 (13:09 +0200)]
lsa: fill in lsa_StorePrivateData and lsa_RetrievePrivateData and rerun make samba3-idl.
Guenther
Bo Yang [Sat, 18 Jul 2009 02:46:11 +0000 (10:46 +0800)]
s3: compile warning and upn handling
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Sat, 18 Jul 2009 00:03:57 +0000 (08:03 +0800)]
s3: don't do this, upper callbacks will check it
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Sat, 18 Jul 2009 00:01:56 +0000 (08:01 +0800)]
s3: Fix crsh in net usershare list
Signed-off-by: Bo Yang <boyang@samba.org>
Jeremy Allison [Fri, 17 Jul 2009 01:28:58 +0000 (18:28 -0700)]
More conversions of NULL -> talloc_autofree_context()
so we at least know when we're using a long-lived context.
Jeremy.
Jeremy Allison [Fri, 17 Jul 2009 01:14:56 +0000 (18:14 -0700)]
Replace more long-lived contexts with talloc_autofree_context().
Jeremy.
Jeremy Allison [Fri, 17 Jul 2009 01:13:46 +0000 (18:13 -0700)]
Replace short-lived NULL talloc contexts with talloc_tos().
Jeremy.
Jeremy Allison [Fri, 17 Jul 2009 01:12:17 +0000 (18:12 -0700)]
Remove an unused talloc context.
Jeremy.
Andrew Bartlett [Thu, 16 Jul 2009 22:39:51 +0000 (08:39 +1000)]
Revert "s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler version"
This is now handled correctly in the newly imported Heimdal
This reverts commit
4a754d029b0eb229b23980aa4a80dae2b485a302.
Andrew Bartlett [Thu, 16 Jul 2009 22:29:03 +0000 (08:29 +1000)]
s4:heimdal: import lorikeet-heimdal-
200907162216 (commit
d09910d6803aad96b52ee626327ee55b14ea0de8)
This includes in particular changes to the KDC to resolve bug 6272,
originally by Matthieu Patou <mat+Informatique.Samba@matws.net>. We
need to sort the AuthorizationData elements to put the PAC first, or
else WinXP breaks when browsed from Win2k8.
Andrew Bartlett
Andrew Bartlett [Thu, 16 Jul 2009 07:37:36 +0000 (17:37 +1000)]
s4:kdc Rework KDC to pull in less attributes for krbtgt lookups
Each attribute we request from LDB comes with a small cost, so don't
lookup any more than we must for the (very) frequent krbtgt lookup
case. Similarly, we don't need to build a PAC for a server (as a
target), so don't ask for the PAC attributes here either.
Andrew Bartlett
Andrew Bartlett [Thu, 16 Jul 2009 02:47:57 +0000 (12:47 +1000)]
s4:kdc rename functions from LDB_ to hdb_samba4
The LDB_ prefix is misleading, and stomps on the LDB namespace. This
is a Samba4 hdb module, and not something generic.
Andrew Bartlett
Günther Deschner [Thu, 16 Jul 2009 16:39:06 +0000 (18:39 +0200)]
Revert "fix LSA-PRIVILEGES"
This reverts commit
0d9fdbceedddb08dbea8ed84e06a218d3ec562f4.
Günther Deschner [Thu, 16 Jul 2009 16:38:55 +0000 (18:38 +0200)]
Revert "fix LSA-TRUSTED-DOMAINS"
This reverts commit
3c9b26276083002124674678ac757e859fb6b20e.
Günther Deschner [Thu, 16 Jul 2009 16:38:25 +0000 (18:38 +0200)]
s4-smbtorture: use secinfo flags instead of numbers in lsa test.
Guenther
Günther Deschner [Thu, 16 Jul 2009 16:37:19 +0000 (18:37 +0200)]
s3-lsa: Fix pointless check for sec_info flags in _lsa_QuerySecurity().
Guenther
Günther Deschner [Thu, 16 Jul 2009 16:32:53 +0000 (18:32 +0200)]
s3-lsa: implement _lsa_LookupPrivName().
Guenther
Günther Deschner [Thu, 16 Jul 2009 00:25:43 +0000 (02:25 +0200)]
s3-lsa: implement _lsa_EnumAccountsWithUserRight().
Guenther
Jeremy Allison [Thu, 16 Jul 2009 16:54:14 +0000 (09:54 -0700)]
Tidyup prompted by #6554 - Wrong deallocation in sam_account_ok.
Jeremy.
Stefan Metzmacher [Thu, 16 Jul 2009 10:21:29 +0000 (12:21 +0200)]
s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler version
Otherwise heimdal/lib/gssapi/gssapi/gssapi.h will just define it to
__attribute__ ((deprecated)) which is not supported by all compilers
we care about.
This should fix the build on Tru64
metze
Stefan Metzmacher [Thu, 16 Jul 2009 10:08:56 +0000 (12:08 +0200)]
s4:heimdal_build: try to fix the build on systems without ifaddrs.h
metze
Stefan Metzmacher [Thu, 16 Jul 2009 07:06:42 +0000 (09:06 +0200)]
tevent: try to fix the build on QNX qnx18 6.4.1 it doesn't have SA_RESTART defined
metze
Stefan Metzmacher [Thu, 16 Jul 2009 08:51:34 +0000 (10:51 +0200)]
s4:heimdal_build: tell heimdal we have inet_aton()
This should fix problems on Solaris.
metze
Günther Deschner [Thu, 16 Jul 2009 09:13:26 +0000 (11:13 +0200)]
s4-smbtorture: use torture_comment in RPC-LSA tests.
Guenther
Günther Deschner [Thu, 16 Jul 2009 09:07:14 +0000 (11:07 +0200)]
fix LSA-PRIVILEGES
Günther Deschner [Thu, 16 Jul 2009 09:07:06 +0000 (11:07 +0200)]
fix LSA-TRUSTED-DOMAINS
Günther Deschner [Thu, 16 Jul 2009 00:10:23 +0000 (02:10 +0200)]
s4-smbtorture: move all privilege tests to RPC-LSA-PRIVILEGES.
Guenther
Günther Deschner [Wed, 15 Jul 2009 22:56:17 +0000 (00:56 +0200)]
s4-smbtorture: move all trusted domain tests to RPC-LSA-TRUSTED-DOMAINS.
Guenther
Stefan Metzmacher [Thu, 16 Jul 2009 06:51:51 +0000 (08:51 +0200)]
s4:heimdal_build: try to fix the build on Solaris
The problem seems to be #define flock rk_flock
heimdal/../heimdal_build/replace.c: In function `rk_flock':
heimdal/../heimdal_build/replace.c:64: error: storage size of 'lock' isn't known
heimdal/../heimdal_build/replace.c:64: warning: unused variable `lock'
metze
Stefan Metzmacher [Thu, 16 Jul 2009 06:20:17 +0000 (08:20 +0200)]
tsocket: rename sa_len => sa_socklen, because sa_len is a macro on some platforms
metze
Andrew Bartlett [Tue, 7 Jul 2009 02:34:55 +0000 (12:34 +1000)]
s4:kdc Initialise new hdb function pointers.
Soon we will add implementations for these.
Andrew Bartlett [Wed, 15 Jul 2009 23:53:14 +0000 (09:53 +1000)]
Günther Deschner [Thu, 16 Jul 2009 00:48:34 +0000 (02:48 +0200)]
lsa: fix typo in lsa_TrustDomInfoEnum enum in IDL.
Guenther