Michael Adam [Mon, 12 Jan 2009 12:04:40 +0000 (13:04 +0100)]
nss_wrapper.pl: fix "Use of uninitialized value $i in array element" messages
I just saw this in "make test" after "SMBD OUTPUT:"...
Michael
Steven Danneman [Thu, 8 Jan 2009 19:18:13 +0000 (11:18 -0800)]
Make STATEDIR and CACHEDIR configurable through ./configure and loadparm.c
If they are not explicitely set in either place both will default to LOCKDIR.
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 10 Jan 2009 16:59:43 +0000 (17:59 +0100)]
Even for srclen == 0 we have to return something
This fixes a regression reported by Corinna Vinschen <corinna@vinschen.de>
Thanks,
Volker
Stefan Metzmacher [Mon, 12 Jan 2009 08:20:57 +0000 (09:20 +0100)]
tevent: use for() loops instead of while() loops
metze
Tim Prouty [Mon, 12 Jan 2009 07:16:37 +0000 (23:16 -0800)]
s3: Fix uninitialized variable in OneFS streams
Tim Prouty [Sat, 3 Jan 2009 01:35:04 +0000 (17:35 -0800)]
s3: Differentiate between posix files with colons and actual streams
It is possible for a posix file created locally or over nfs to have a
":" in the name. Since ":" is a reserved character in windows,
filenames containing a colon must be mangled in a directory listing.
Right now files containing colons will not even be displayed in
directory listings if streams modules are in use. During the
directory listing the file will be detected as a stream because of the
colon, but the streams module will fail to find the stream since it
doesn't exist. This fix adds a step to is_ntfs_stream_name that stats
the filename to differentiate between actual streams and files
containing colons.
While this is an improvement, it isn't perfect. Consider the case
where there is a file on disk called "a.txt:s1" and also a file called
"a.txt" that has a stream called "s1". This patch will always
preference "a.txt:s1" over a.txt's s1 stream.
The real issue is that at the vfs level, the vfs modules have no way
to tell between a demangled name with a colon and an actual stream. A
more invasive, but better, long-term fix would be to add all paths
that come over the wire into a struct containing metadata about the
path. This metadata could include a flag to indicate whether the path
came over the wire with a colon ":" (guaranteeing that the client is
requesting a stream). Passing this struct down to the lower levels,
including all path-based vfs calls, would allow the above case to be
handled correctly in all cases.
Tim Prouty [Fri, 12 Dec 2008 22:32:48 +0000 (14:32 -0800)]
s3: Add OneFS alternate data streams implementation
Tim Prouty [Wed, 31 Dec 2008 01:17:24 +0000 (17:17 -0800)]
s3: General cleanup of the open path in the OneFS vfs module
Volker Lendecke [Sun, 11 Jan 2009 10:17:26 +0000 (11:17 +0100)]
Move cli_api_pipe() to its only user cli_pipe.c
Tim Prouty [Sun, 11 Jan 2009 19:00:50 +0000 (11:00 -0800)]
tevent: Fix build break
Bo Yang [Sat, 10 Jan 2009 05:46:50 +0000 (13:46 +0800)]
Fix tevent_common_context_destructor to remove all events instead of just the first one
Signed-off-by: Bo Yang <boyang@novell.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Bo Yang [Sat, 10 Jan 2009 22:12:08 +0000 (14:12 -0800)]
Don't set child->requests to NULL in parent after fork
Volker Lendecke [Sat, 10 Jan 2009 12:04:33 +0000 (13:04 +0100)]
Fix a type-punned error
Volker Lendecke [Sat, 10 Jan 2009 12:02:43 +0000 (13:02 +0100)]
Fix a C++ warning
Jeremy Allison [Sat, 10 Jan 2009 03:40:09 +0000 (19:40 -0800)]
Minor tidyup of unix account missing code.
Jeremy.
Volker Lendecke [Tue, 6 Jan 2009 22:46:05 +0000 (23:46 +0100)]
Remove the rpc_srv_register wrapper around rpc_pipe_register_commands
Volker Lendecke [Tue, 6 Jan 2009 22:39:09 +0000 (23:39 +0100)]
Call rpc_srv_register instead of rpc_pipe_register_commands in eventlog and svcctl
Volker Lendecke [Tue, 6 Jan 2009 22:37:09 +0000 (23:37 +0100)]
Fake up ndr_table_spoolss
Volker Lendecke [Tue, 6 Jan 2009 22:29:25 +0000 (23:29 +0100)]
Pass the full ndr_interface_table into the s3 rpcserver when registering
Volker Lendecke [Fri, 9 Jan 2009 17:32:20 +0000 (18:32 +0100)]
Add derpc_transport_string_by_transport(), apply some const
Volker Lendecke [Tue, 6 Jan 2009 18:09:57 +0000 (19:09 +0100)]
start rpcclient epmapper
Volker Lendecke [Tue, 6 Jan 2009 20:28:44 +0000 (21:28 +0100)]
Fix some nonempty blank lines
Volker Lendecke [Tue, 6 Jan 2009 10:32:46 +0000 (11:32 +0100)]
Simplify find_pipe_fns_by_context slightly
Volker Lendecke [Tue, 6 Jan 2009 10:32:07 +0000 (11:32 +0100)]
Fix some nonempty blank lines
Tim Prouty [Fri, 9 Jan 2009 19:50:28 +0000 (11:50 -0800)]
s3: Remove rendundant op_tuple entry in xattr streams
Tim Prouty [Fri, 9 Jan 2009 19:07:45 +0000 (11:07 -0800)]
s3: Fix open path to delete streams depending on the create disposition
The new create disposition test in smbtorture RAW-STREAMS verifies
this fix.
Tim Prouty [Sun, 21 Dec 2008 23:49:46 +0000 (15:49 -0800)]
s3: Add delete_all_streams to proto.h
Tim Prouty [Fri, 9 Jan 2009 19:38:58 +0000 (11:38 -0800)]
s4 torture: Add new create disposition test to RAW-STREAMS
Günther Deschner [Fri, 9 Jan 2009 15:25:47 +0000 (16:25 +0100)]
s3-svcctl: remove last traces of hand-marshalled svcctl code.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:22:03 +0000 (16:22 +0100)]
s3-svcctl: remove old marshalling of svcctl_EnumServicesStatusW.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:20:09 +0000 (16:20 +0100)]
s3-svcctl: build svcctl marshalling helper.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:19:37 +0000 (16:19 +0100)]
s3-svcctl: use pidl for _svcctl_EnumServicesStatusW.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:18:51 +0000 (16:18 +0100)]
s3-net: use rpccli_svcctl_EnumServicesStatusW.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:16:11 +0000 (16:16 +0100)]
s4-smbtorture: print hand-decoded service status array in svcctl torture test.
Guenther
Karolin Seeger [Fri, 9 Jan 2009 15:52:12 +0000 (16:52 +0100)]
s3/net: Display error message if user does not exist.
net rpc rights grant: Verify if the username can be resolved to a SID and
display a proper error message if it does not. Otherwise users might think
setting privileges worked fine, but in fact it does not.
Karolin
Günther Deschner [Fri, 9 Jan 2009 15:17:35 +0000 (16:17 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 9 Jan 2009 15:17:03 +0000 (16:17 +0100)]
svcctl: include hand marshalling helper in idl.
Guenther
Günther Deschner [Fri, 9 Jan 2009 13:36:13 +0000 (14:36 +0100)]
svcctl: add ndr_push/pull_ENUM_SERVICE_STATUSW_array helper.
Thanks metze for helping here.
Guenther
Günther Deschner [Fri, 9 Jan 2009 13:32:39 +0000 (14:32 +0100)]
s3-svcctl: use pidl defined constants in services implementation.
Guenther
Günther Deschner [Fri, 9 Jan 2009 13:30:56 +0000 (14:30 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 9 Jan 2009 13:29:40 +0000 (14:29 +0100)]
svcctl: add SERVICE_TYPE_INTERACTIVE_PROCESS define.
Guenther
Karolin Seeger [Fri, 9 Jan 2009 14:54:16 +0000 (15:54 +0100)]
s3/smbpasswd: Check if Unix account exists before asking for the password.
Admins shouldn't have to type in the password twice when the passdb account
cannot be created because the Unix account is missing.
Karolin
Stefan Metzmacher [Fri, 9 Jan 2009 12:10:07 +0000 (13:10 +0100)]
s4:debug: make setup_logging() a bit more compatible with samba3
In samba3 the 2nd argument is bool interactive.
E.g ndrdump uses true there which used to map to DEBUG_FILE
in samba4, it maps to DEBUG_STDOUT now, which is better.
In the end end samba3 should also use the samba4 version of
setup_logging()
metze
Stefan Metzmacher [Fri, 9 Jan 2009 11:23:11 +0000 (12:23 +0100)]
Revert "quote ' inside '...' and make sure shell isn't eating \ by using perl here."
This reverts commit
2a52b059ce44403ff6ced066e0bb23fa6cc66a73.
It breaks the build on ubuntu.
metze
Björn Jacke [Fri, 9 Jan 2009 11:05:55 +0000 (12:05 +0100)]
quote ' inside '...' and make sure shell isn't eating \ by using perl here.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Karolin Seeger [Fri, 9 Jan 2009 10:22:00 +0000 (11:22 +0100)]
docs: Improve man mount.cifs.
Add hint about specifying the workgroup in the credentials file.
Whitespace cleanup.
This fixes bug #4541.
Patch based on proposed patch from Christian Perrier <bubulle@debian.org>.
Thanks for reporting and providing a patch!
Karolin
Björn Jacke [Thu, 8 Jan 2009 18:14:48 +0000 (19:14 +0100)]
fix syntax error in case statement
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 8 Jan 2009 14:38:47 +0000 (15:38 +0100)]
s3:smbd: handle incoming smb requests via event handlers
We use a fd event and receive incoming smb requests
when the fd becomes readable. It's not completely
nonblocking yet, but it should behave like the old code.
We use timed events to trigger retries for deferred open calls.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 18:45:13 +0000 (19:45 +0100)]
s3:events: debug sys_select() errors
metze
Stefan Metzmacher [Thu, 8 Jan 2009 14:16:51 +0000 (15:16 +0100)]
s3:events: install a tevent debug handler that calls DEBUG()
metze
Andrew Bartlett [Fri, 9 Jan 2009 01:06:18 +0000 (12:06 +1100)]
Only do special DN tracking for normal DNs in OpenLDAP backend.
This means trying (again, harder), not to do this for DN+Binary and
DN+String attributes.
Andrew Bartlett
Jeremy Allison [Thu, 8 Jan 2009 23:41:49 +0000 (15:41 -0800)]
Fix bug #6021 - smbclient du command does not recuse properly
Jeremy.
Volker Lendecke [Wed, 7 Jan 2009 17:44:52 +0000 (18:44 +0100)]
Now that all policy_handle free_fn's are just TALLOC_FREE, dump free_fn
Volker Lendecke [Wed, 7 Jan 2009 17:11:24 +0000 (18:11 +0100)]
Use TALLOC for struct lsa_info
Volker Lendecke [Wed, 7 Jan 2009 17:06:21 +0000 (18:06 +0100)]
Make use of a talloc_destructor for free_printer_entry
Volker Lendecke [Wed, 7 Jan 2009 16:56:08 +0000 (17:56 +0100)]
Make use of a talloc_destructor for free_eventlog_info()
Volker Lendecke [Wed, 7 Jan 2009 16:48:10 +0000 (17:48 +0100)]
Make samr_info a talloc context of its own
Volker Lendecke [Wed, 7 Jan 2009 16:36:54 +0000 (17:36 +0100)]
Simplify init_pipe_handle_list a bit
Günther Deschner [Thu, 8 Jan 2009 18:13:22 +0000 (19:13 +0100)]
s3-rpcclient: add eventlog test client.
Guenther
Günther Deschner [Thu, 8 Jan 2009 18:12:59 +0000 (19:12 +0100)]
s3-eventlog: minor cosmetics.
Guenther
Günther Deschner [Thu, 8 Jan 2009 17:39:12 +0000 (18:39 +0100)]
s3-eventlog: trying to make eventlog_io_q_read_eventlog readable.
Guenther
Günther Deschner [Thu, 8 Jan 2009 17:02:51 +0000 (18:02 +0100)]
s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server.
Jerry, please check.
Guenther
Jeremy Allison [Thu, 8 Jan 2009 18:36:10 +0000 (10:36 -0800)]
Fix race condition in alarm lock processing noticed by Richard Sharpe <realrichardsharpe@gmail.com>.
"It seems to me that if the lock is already held by another process when we
enter this code, there is a race between the timeout and the granting. If
the lock is subsequently granted, the process releasing the lock will signal
the wait variable (or whatever) and our process will be scheduled. However,
if the timeout occurs before we are scheduled, the timeout will be delivered
first.
We will have the lock but will forget we have the lock, and never release
it."
Jeremy.
Günther Deschner [Thu, 8 Jan 2009 18:15:41 +0000 (19:15 +0100)]
s3-net: fix type in rpc_service_list_internal(). Sorry...
Guenther
Günther Deschner [Thu, 8 Jan 2009 16:28:20 +0000 (17:28 +0100)]
s4-smbtorture: extend test_QueryServiceConfig2W a bit.
Guenther
Günther Deschner [Thu, 8 Jan 2009 15:54:08 +0000 (16:54 +0100)]
s4-smbtorture: fix build of svcctl torture test.
Guenther
Günther Deschner [Thu, 8 Jan 2009 14:45:09 +0000 (15:45 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 8 Jan 2009 15:49:47 +0000 (16:49 +0100)]
svcctl: use svcctl_ServiceState in some other places.
Guenther
Günther Deschner [Thu, 8 Jan 2009 15:49:18 +0000 (16:49 +0100)]
svcctl: use hex range format in IDL.
Guenther
Günther Deschner [Thu, 8 Jan 2009 15:44:54 +0000 (16:44 +0100)]
svcctl: add ENUM_SERVICE_STATUSW and ENUM_SERVICE_STATUSA.
Guenther
Günther Deschner [Thu, 8 Jan 2009 14:43:49 +0000 (15:43 +0100)]
svcctl: remove redundant SERVICE_STATE_* defines.
Guenther
Stefan Metzmacher [Thu, 8 Jan 2009 15:23:59 +0000 (16:23 +0100)]
s3:smbd: fix the build with dmapi support
struct smbd_dmapi_context *dmapi_ctx;
is in globals.c
metze
Stefan Metzmacher [Thu, 8 Jan 2009 14:57:59 +0000 (15:57 +0100)]
s4:blackbox: don't remove newlines in the subunit failure output
metze
Stefan Metzmacher [Thu, 8 Jan 2009 14:15:46 +0000 (15:15 +0100)]
s4:events: don't trigger \n in debug messages two times
metze
Jelmer Vernooij [Thu, 8 Jan 2009 14:47:34 +0000 (15:47 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Volker Lendecke [Thu, 8 Jan 2009 14:25:50 +0000 (15:25 +0100)]
Attempt to fix the build
Jelmer Vernooij [Thu, 8 Jan 2009 14:23:35 +0000 (15:23 +0100)]
Make sure smbtorture4 can find all gensec modules. (Fixes RPC-BINDSAMBA3)
Günther Deschner [Thu, 8 Jan 2009 12:23:59 +0000 (13:23 +0100)]
s3-svcctl: use pidl based struct SERVICE_STATUS.
Guenther
Günther Deschner [Thu, 8 Jan 2009 12:08:18 +0000 (13:08 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 8 Jan 2009 12:06:38 +0000 (13:06 +0100)]
s3-svcctl: add copyright to svcctl rpc_server.
Guenther
Günther Deschner [Thu, 8 Jan 2009 12:05:29 +0000 (13:05 +0100)]
s3-svcctl: remove some more redundant headers.
Guenther
Günther Deschner [Thu, 8 Jan 2009 11:46:54 +0000 (12:46 +0100)]
s3-svcctl: move SVC_HANDLE_IS* defines to implementation specific header file.
Guenther
Günther Deschner [Thu, 8 Jan 2009 11:40:25 +0000 (12:40 +0100)]
s3-svcctl: remove (now duplicate) defines.
Guenther
Günther Deschner [Thu, 8 Jan 2009 11:39:50 +0000 (12:39 +0100)]
svcctl: add svcctl_ServiceStatus and svcctl_ControlsAccepted.
Guenther
Günther Deschner [Thu, 8 Jan 2009 11:28:35 +0000 (12:28 +0100)]
s3-svcctl: remove (now duplicate) SVCCTL_STAT* defines.
Guenther
Jelmer Vernooij [Thu, 8 Jan 2009 12:15:10 +0000 (13:15 +0100)]
Don't attempt to use GNUTLS >= 2.6, as it is known broken with the socket-tls backend.
Jelmer Vernooij [Thu, 8 Jan 2009 11:51:19 +0000 (12:51 +0100)]
Fix ldap.py test on systems that *can* find the record (the search fails here locally).
Jelmer Vernooij [Thu, 8 Jan 2009 11:45:57 +0000 (12:45 +0100)]
Print the failed value in the time tests.
Jelmer Vernooij [Thu, 8 Jan 2009 11:27:52 +0000 (12:27 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Stefan Metzmacher [Thu, 8 Jan 2009 11:03:45 +0000 (12:03 +0100)]
s3:smbd: move all globals and static variables in globals.[ch]
The goal is to move all this variables into a big context structure.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 11:00:15 +0000 (12:00 +0100)]
s3:smbd: variables in a main() don't need to be static
metze
Stefan Metzmacher [Thu, 8 Jan 2009 10:52:52 +0000 (11:52 +0100)]
s3:smbd: open_sockets_smbd() don't need a static variable arrount atexit()
open_sockets_smbd() is only called once.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 10:37:06 +0000 (11:37 +0100)]
s3:smbd: keep dmapi globals in one context struct
metze
Stefan Metzmacher [Thu, 8 Jan 2009 09:43:10 +0000 (10:43 +0100)]
s3:smbd: remove stupid static variables for the nfs quota code
metze
Stefan Metzmacher [Thu, 8 Jan 2009 08:04:30 +0000 (09:04 +0100)]
s3:smbd: remove pointless static variable in uid.c
We always free the value at the end of the function,
so we don't need a static variable to hold just NULL
for the time the function isn't executed.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 08:02:21 +0000 (09:02 +0100)]
s3:smbd: make static const in mangle_hash2.c really static const
const char *foo, means a non-const pointer to
a const char.
const char * const foo, means a const pointer to
a const char.
char * const foo, would mean a const pointer to
a non-const char.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:57:52 +0000 (08:57 +0100)]
s3:smbd: make const globals in mangle_hash2.c really static const
const char *foo, means a non-const pointer to
a const char.
const char * const foo, means a const pointer to
a const char.
char * const foo, would mean a const pointer to
a non-const char.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:51:41 +0000 (08:51 +0100)]
s3:smbd: make globals in utmp.c static const
const char *foo, means a non-const pointer to
a const char.
const char * const foo, means a const pointer to
a const char.
char * const foo, would mean a const pointer to
a non-const char.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:50:36 +0000 (08:50 +0100)]
s3:smbd: it's pointless to have a global magic_char
We call magic_char = lp_magicchar(p) each time it's used.
metze
Stefan Metzmacher [Thu, 8 Jan 2009 07:47:57 +0000 (08:47 +0100)]
s3:smbd: remove pointless static variables in chgpasswd.c
metze