Karolin Seeger [Tue, 18 Nov 2008 15:17:17 +0000 (16:17 +0100)]
WHATSNEW: Update WHATSNEW for 3.2.5.
Karolin
Volker Lendecke [Sat, 8 Nov 2008 16:14:06 +0000 (17:14 +0100)]
Fix the offset checks in the trans routines
This fixes a potential crash bug, a client can make us read memory we
should not read. Luckily I got the disp checks right...
Volker
Karolin Seeger [Mon, 17 Nov 2008 13:02:56 +0000 (14:02 +0100)]
Revert "build-docs: Add 'make clean'."
This reverts commit
4f9f592ab792e36e870bbeba96a1fb8f0ee9efda.
Karolin Seeger [Mon, 17 Nov 2008 13:02:56 +0000 (14:02 +0100)]
Revert "build: don't install the cifs.upcall binary twice."
This reverts commit
cfc8dc236dda869dbe4141bef80f6965ce76188d.
Karolin Seeger [Mon, 17 Nov 2008 13:02:56 +0000 (14:02 +0100)]
Revert "Fix bug #5783 FindFirst fails where search pattern == mangled filename."
This reverts commit
fc9247572e0ace4956845e279c63c9d00fa667bd.
Karolin Seeger [Mon, 17 Nov 2008 13:02:56 +0000 (14:02 +0100)]
Revert "Fix winbindd crash in an unusual failure mode. Bug #5737. Based on original patch from shargagan@novell.com"
This reverts commit
9a38a8454cfbd0011d804b3ab88c16e5d4f1c4bd.
Karolin Seeger [Mon, 17 Nov 2008 13:02:55 +0000 (14:02 +0100)]
Revert "Fix bug #5790 samba returns STATUS_OBJECT_NAME_NOT_FOUND on set file disposition."
This reverts commit
24348e2e028f8f63c7acad33f2f9a362a3d3fdc0.
Karolin Seeger [Mon, 17 Nov 2008 13:02:55 +0000 (14:02 +0100)]
Revert "SMB traffic analyzer vfs module from Holger Hetterich <hhetter@novell.com>"
This reverts commit
aeabc475d8abf9a820b4846a30cf92cc253bc939.
Karolin Seeger [Mon, 17 Nov 2008 13:02:55 +0000 (14:02 +0100)]
Revert "Fix the new vfs_smb_traffic_analyzer build for static links"
This reverts commit
f64bcae4ff2bb1a9db603c1f38e1e4fa2e5148bc.
Karolin Seeger [Mon, 17 Nov 2008 13:02:55 +0000 (14:02 +0100)]
Revert "Use IPv4/v6 independent calls. Change safe_strcpy/cat to strlcpy/cat (this"
This reverts commit
caa0f1131872f82c1a346f701830544b372e4317.
Karolin Seeger [Mon, 17 Nov 2008 13:02:55 +0000 (14:02 +0100)]
Revert "s3-srvsvc: fix _srvsvc_NetShareAdd segfault."
This reverts commit
aa9a74f33f1a1862836569565d64861706de5429.
Karolin Seeger [Mon, 17 Nov 2008 13:02:55 +0000 (14:02 +0100)]
Revert "Fix bug #5797 - Moving readonly files fails. Reported by infomail@lordb.de."
This reverts commit
7292c322ca70e9df82e020f45f1510e9ca02efbc.
Karolin Seeger [Mon, 17 Nov 2008 13:02:54 +0000 (14:02 +0100)]
Revert "Second part of the fix for bug #5790 - samba returns STATUS_OBJECT_NAME_NOT_FOUND on set file disposition call."
This reverts commit
e73c090b5ff624f71ce827c494cd71ca73144ba9.
Karolin Seeger [Mon, 17 Nov 2008 13:02:54 +0000 (14:02 +0100)]
Revert "Add an initial version of a manpage for the vfs_smb_traffic_analyzer module."
This reverts commit
1394827cfda4eeff5b4239b6ed5c93fcaaed0e2e.
Karolin Seeger [Mon, 17 Nov 2008 13:02:54 +0000 (14:02 +0100)]
Revert "Avoid freeing fsp twice when opening new_file fails. (Debian #431696)"
This reverts commit
7c9a7cb8682156ffb39382a44e3abf40408bff63.
Karolin Seeger [Mon, 17 Nov 2008 13:02:54 +0000 (14:02 +0100)]
Revert "Ensure we null out fsp after a close in all paths."
This reverts commit
a48d591ef5d839159f600a8c7e2966211450c00b.
Karolin Seeger [Mon, 17 Nov 2008 13:02:54 +0000 (14:02 +0100)]
Revert "fixed segv on startup with trusted domains"
This reverts commit
8b41be0c7080edaf9fb33e583c66f2ef50a91643.
Karolin Seeger [Mon, 17 Nov 2008 13:02:54 +0000 (14:02 +0100)]
Revert "re-added "winbind:ignore domains" patch"
This reverts commit
37d4e792bfd72e4b12811e0fbdb75cec2eda8f2a.
Karolin Seeger [Mon, 17 Nov 2008 13:02:53 +0000 (14:02 +0100)]
Revert "Fix the make test problem Karolin reported. Now rename_open_files actually works correctly we must emit the change notify before we change the name, not before."
This reverts commit
ac2046979cacf96f8d4df7c5ece06e55d51758c8.
Karolin Seeger [Mon, 17 Nov 2008 13:02:53 +0000 (14:02 +0100)]
Revert "Restructure the module so it connects to the remote data sink"
This reverts commit
1bf75ac9781c60be5a7b5899bc42aa1d198091d9.
Karolin Seeger [Mon, 17 Nov 2008 13:02:53 +0000 (14:02 +0100)]
Revert "Convert to allocated strings. Use write_data(), not send as this doesn't correctly"
This reverts commit
747f7a5647851290f6a3968477a8749e1134777c.
Karolin Seeger [Mon, 17 Nov 2008 13:02:53 +0000 (14:02 +0100)]
Revert "Turn the socket connections into a refcounted list - in the common case there'll now only be one socket per smbd."
This reverts commit
63603373628901fcb6a816d9ac9b5340dd8d8662.
Karolin Seeger [Mon, 17 Nov 2008 13:02:53 +0000 (14:02 +0100)]
Revert "Fix use of DLIST_REMOVE as spotted by Constantine Vetoshev <gepardcv@gmail.com>."
This reverts commit
8443b4859f64aa5459976ce37ca96a90daae889a.
Karolin Seeger [Mon, 17 Nov 2008 13:02:53 +0000 (14:02 +0100)]
Revert "Whitespace cleanup."
This reverts commit
a2f298883f21c3e9afe686ee393410f2bcb28370.
Karolin Seeger [Mon, 17 Nov 2008 13:02:53 +0000 (14:02 +0100)]
Revert "Fix bug 5805: don't close stdout"
This reverts commit
a937de4a626a8084e852bf7d345441bab15963cd.
Karolin Seeger [Mon, 17 Nov 2008 13:02:52 +0000 (14:02 +0100)]
Revert "Fix bug #5080. Access to cups-printers via samba broken with cups 1.3.4, Unsupported character set."
This reverts commit
47161923108222c41db4572b5f44cdb2b6d84a51.
Karolin Seeger [Mon, 17 Nov 2008 13:02:52 +0000 (14:02 +0100)]
Revert "libaddns: Use the same prerequisite for DDNS update as Windows XP."
This reverts commit
35130846b4595cc3a937e10a113d2805a5b2c096.
Karolin Seeger [Mon, 17 Nov 2008 13:02:52 +0000 (14:02 +0100)]
Revert "net_dns: Make "lwinet ads dns register" honor the "interfaces" parameter."
This reverts commit
d2242f9776cfed2dfff44db180dbf34fbbba2e5e.
Karolin Seeger [Mon, 17 Nov 2008 13:02:52 +0000 (14:02 +0100)]
Revert "Correctly fix smbclient to terminate on eof from server."
This reverts commit
28fa519a80bfcd30737a51ad157d134322c1fed9.
Karolin Seeger [Mon, 17 Nov 2008 13:02:52 +0000 (14:02 +0100)]
Revert "Fix a potential NULL deref in line 258 found by the IBM checker"
This reverts commit
589fe1c879ef23ee9e45f5f877f2696142d57e70.
Karolin Seeger [Mon, 17 Nov 2008 13:02:52 +0000 (14:02 +0100)]
Revert "Fix an uninitialized variable found by the IBM Checker"
This reverts commit
2ed66bc2b6e22aeb0dcc1aba68bac3791ee0647f.
Karolin Seeger [Mon, 17 Nov 2008 13:02:52 +0000 (14:02 +0100)]
Revert "Fix an unlikely memleak found by the IBM checker"
This reverts commit
a0ee34c3c55a64ac2b73fdbaa32233d01ee131c6.
Karolin Seeger [Mon, 17 Nov 2008 13:02:51 +0000 (14:02 +0100)]
Revert "Fix an uninitialized variable warning"
This reverts commit
2e65d8bce755ddfa35bae5ad4c5107db7e18515a.
Karolin Seeger [Mon, 17 Nov 2008 13:02:51 +0000 (14:02 +0100)]
Revert "OS/X does not have rl_done in readline.h"
This reverts commit
829e29c95ad6c1b5744dcffb4586ff7c875e3831.
Karolin Seeger [Mon, 17 Nov 2008 13:02:51 +0000 (14:02 +0100)]
Revert "Fix some missing error handlings"
This reverts commit
4ac937db865d9fc56cb49838a361dd697d06efc7.
Karolin Seeger [Mon, 17 Nov 2008 13:02:51 +0000 (14:02 +0100)]
Revert "Remove an unused variable"
This reverts commit
7cb9d82244a8e93261d12a3800334d8152a2431e.
Karolin Seeger [Mon, 17 Nov 2008 13:02:51 +0000 (14:02 +0100)]
Revert "Attempt to fix bug 5778"
This reverts commit
ecc67001315111493738e893917c4550be7828a1.
Karolin Seeger [Mon, 17 Nov 2008 13:02:51 +0000 (14:02 +0100)]
Revert "Log in the parent winbind log where a request is going"
This reverts commit
b1bcaf45ce14108b7e2b429b96908e30bf6eb90d.
Karolin Seeger [Mon, 17 Nov 2008 13:02:50 +0000 (14:02 +0100)]
Revert "If name_to_fqdn fails, retry with the dns domain the DC gave us"
This reverts commit
82a086fb6f70dd6b725e4976293bc377a6a90f3a.
Karolin Seeger [Mon, 17 Nov 2008 13:02:50 +0000 (14:02 +0100)]
Revert "Fixed "declaration shadows global declaration" warnings."
This reverts commit
fa3096b975de2c7fd747ca9f344e36c911e27a9c.
Karolin Seeger [Mon, 17 Nov 2008 13:02:50 +0000 (14:02 +0100)]
Revert "Fixed build warning "passing arg from incompatible pointer type""
This reverts commit
ed955214133c264865d2f6ca532349f0c1ea8d4b.
Karolin Seeger [Mon, 17 Nov 2008 13:02:50 +0000 (14:02 +0100)]
Revert "Fix bug #5814 - Winbindd dumping core in a strange manner while doing "rescan_trusted_domain"."
This reverts commit
15b2f1d8744d157b131a0441e8738d8519de37c7.
Karolin Seeger [Mon, 17 Nov 2008 13:02:50 +0000 (14:02 +0100)]
Revert "mount.cifs: have uppercase_string return success on NULL pointer"
This reverts commit
3f4cdabc965f824b70891f6a6bcb29e5f9b579e5.
Karolin Seeger [Mon, 17 Nov 2008 13:02:49 +0000 (14:02 +0100)]
Revert "mount.cifs: make return codes match the return codes for /bin/mount (try #3)"
This reverts commit
98bcd52a568c274707cc6ccb9071d07a8bfca1ca.
Karolin Seeger [Mon, 17 Nov 2008 13:02:49 +0000 (14:02 +0100)]
Revert "Make use of ZERO_STRUCT (the first memset was actually wrong)"
This reverts commit
69de2806465742ea6f1ea96d75d2cb3be6b84284.
Karolin Seeger [Mon, 17 Nov 2008 13:02:49 +0000 (14:02 +0100)]
Revert "Now it's working, back port the aync fix for parsing large cups printer lists."
This reverts commit
f5f7ed4041ef986a5ce208d59bbf39d34373ce71.
Karolin Seeger [Mon, 17 Nov 2008 13:02:49 +0000 (14:02 +0100)]
Revert "Fix the build"
This reverts commit
916bb3a8dc1ab23e416508cc2ed7a5791540e622.
Karolin Seeger [Mon, 17 Nov 2008 13:02:48 +0000 (14:02 +0100)]
Revert "Fix bug 5691: SIGBUS on Solaris"
This reverts commit
41b2199fd87598076a1f45106b512c94042f7968.
Karolin Seeger [Mon, 17 Nov 2008 13:02:48 +0000 (14:02 +0100)]
Revert "Enable optional anonymization of user names,"
This reverts commit
e9359e6e8f692c693aad95f9a241c41cc23aa02a.
Karolin Seeger [Mon, 17 Nov 2008 13:02:48 +0000 (14:02 +0100)]
Revert "Update the manpage for vfs_smb_traffic_analyzer to include the anonymize_prefix option"
This reverts commit
9222fde6505deb31324b507d73c96bcb6edb161d.
Karolin Seeger [Mon, 17 Nov 2008 13:02:48 +0000 (14:02 +0100)]
Revert "Fix the "Premature end of data in tag" error when buiding the manpage, fix a typo in the text, add an example for anonymization usage."
This reverts commit
abfdb52b60e84980d22e6c6c3479e67e20311b12.
Karolin Seeger [Mon, 17 Nov 2008 13:02:48 +0000 (14:02 +0100)]
Revert "Note url explaining this code."
This reverts commit
9953885d0be6a2477f5fd29940f3f1d6a7136cf4.
Karolin Seeger [Mon, 17 Nov 2008 13:02:48 +0000 (14:02 +0100)]
Revert "Attempt to fix bug #5818 - "smbcacls: sorts ACEs improperly and loses inheritance", based on"
This reverts commit
5d2d94b46bd2ab03e2f83036b4d7fa3e401c3458.
Karolin Seeger [Mon, 17 Nov 2008 13:02:47 +0000 (14:02 +0100)]
Revert "WHATSNEW: Update changes since 3.2.4."
This reverts commit
fac5f4c8421b371b22d337853f1f8241c3bdbc5b.
Karolin Seeger [Mon, 17 Nov 2008 13:02:47 +0000 (14:02 +0100)]
Revert "WHATSNEW: Update changes since 3.2.4."
This reverts commit
ec9f180390852a9356df11412bc7478f48f52b43.
Karolin Seeger [Mon, 17 Nov 2008 13:02:47 +0000 (14:02 +0100)]
Revert "Don't use debug level 1 to log a trivial message."
This reverts commit
520dcfffe78bb079bbdad6de5a4cdc392527f4b8.
Karolin Seeger [Mon, 17 Nov 2008 13:02:47 +0000 (14:02 +0100)]
Revert "Fix bug 5826 - Directory/Filenames get truncated when 3.2.0 client acesses old server."
This reverts commit
f3b0e219f1a7660ff275db701935eecbe053fa25.
Karolin Seeger [Mon, 17 Nov 2008 13:02:47 +0000 (14:02 +0100)]
Revert "Unify the logic in pull_ascii_base_talloc() and pull_ucs2_base_talloc()."
This reverts commit
01fd94981e322da59ac2c00055220c89de135ebe.
Karolin Seeger [Mon, 17 Nov 2008 13:02:47 +0000 (14:02 +0100)]
Revert "Cope with bad trans2mkdir requests from System i QNTC IBM SMB client."
This reverts commit
feb057d4503118e519b5dbd9d2c3ca2c1ee55380.
Karolin Seeger [Mon, 17 Nov 2008 13:02:46 +0000 (14:02 +0100)]
Revert "Unify access checks for lsa server functions."
This reverts commit
afed4929f9c707fb72b0e8dd12b1a1e8dcab9a84.
Karolin Seeger [Mon, 17 Nov 2008 13:02:46 +0000 (14:02 +0100)]
Revert "s3-samr-server: be consistent when reporting we do password complexity."
This reverts commit
f8d4596ec2b8f35dd3cc05aa7ee356abb9c0920b.
Karolin Seeger [Mon, 17 Nov 2008 13:02:46 +0000 (14:02 +0100)]
Revert "WHATSNEW: Update changes."
This reverts commit
1d86b5e003effb4bb56ef9b0444da63a909fbc3c.
Karolin Seeger [Mon, 17 Nov 2008 13:02:46 +0000 (14:02 +0100)]
Revert "Delete the krb5 ccname variable from the PAM environment if set."
This reverts commit
ddba89d7713923bfbf1c8492c5dc6c6d5b220f1e.
Karolin Seeger [Mon, 17 Nov 2008 13:02:46 +0000 (14:02 +0100)]
Revert "Cope with MAXIMUM_ALLOWED_ACCESS requests when opening handles."
This reverts commit
042e50f8709cfbe45d5b184cb3c4fe1b16bdc3b0.
Karolin Seeger [Mon, 17 Nov 2008 13:02:45 +0000 (14:02 +0100)]
Revert "Fix bug 5840: Segfault in "rpcclient lsaaddacctrights""
This reverts commit
369fecaeb2470a1f7e68417ccdddb61334e37d92.
Karolin Seeger [Mon, 17 Nov 2008 13:02:45 +0000 (14:02 +0100)]
Revert "Fix net rpc vampire, based on an *amazing* piece of debugging work by "Cooper S. Blake" <the_analogkid@yahoo.com>."
This reverts commit
61046225de8a4cd77e94d8c5c4a8f510bc11b79e.
Karolin Seeger [Mon, 17 Nov 2008 13:02:45 +0000 (14:02 +0100)]
Revert "s3-samr-server: _samr_DeleteUser needs to wipe out the user_handle on success."
This reverts commit
ae01a98d49be39c258e479d610fa2e58ea2b6c62.
Karolin Seeger [Mon, 17 Nov 2008 13:02:45 +0000 (14:02 +0100)]
Revert "Remove the requirement for ldap call made as root. Add in security"
This reverts commit
b339f17132b18edad52b4c2f6b348e4b8d789bcb.
Karolin Seeger [Mon, 17 Nov 2008 13:02:45 +0000 (14:02 +0100)]
Revert "s3-samr-server: fix access check in _samr_QuerySecurity()."
This reverts commit
96b35c32ae99d74608ad95d063629554fee77979.
Karolin Seeger [Mon, 17 Nov 2008 13:02:44 +0000 (14:02 +0100)]
Revert "WHATSNEW: Update changes since 3.2.4."
This reverts commit
fd93db7084fdb5899fb823046b9d6ed1d05221c7.
Karolin Seeger [Thu, 23 Oct 2008 10:04:02 +0000 (12:04 +0200)]
WHATSNEW: Update changes since 3.2.4.
Karolin
(cherry picked from commit
71de4d58bb2aea6a98e94055387ef6671aa64410)
Günther Deschner [Wed, 22 Oct 2008 21:16:19 +0000 (23:16 +0200)]
s3-samr-server: fix access check in _samr_QuerySecurity().
Guenther
(cherry picked from commit
25cb282f7042e8192c0bc6d720df0646b74e9a47)
Jeremy Allison [Mon, 20 Oct 2008 23:53:05 +0000 (16:53 -0700)]
Remove the requirement for ldap call made as root. Add in security
checks for all SAMR calls.
Jeremy.
(cherry picked from commit
b848f96d747fb41c074dd073f24f186539257d71)
Günther Deschner [Wed, 22 Oct 2008 23:42:27 +0000 (01:42 +0200)]
s3-samr-server: _samr_DeleteUser needs to wipe out the user_handle on success.
Guenther
(cherry picked from commit
8a0054c6d273049bea235803db25912f6cf03610)
(cherry picked from commit
40a904ee021e4c9390235f1d476bc37b87ac9b70)
Jeremy Allison [Wed, 22 Oct 2008 20:18:58 +0000 (13:18 -0700)]
Fix net rpc vampire, based on an *amazing* piece of debugging work by "Cooper S. Blake" <the_analogkid@yahoo.com>.
"I believe I have found two bugs in the 3.2 code and one bug that
carried on to the 3.3 branch. In the 3.2 code, everything is
located in the utils/net_rpc_samsync.c file. What I believe is the
first problem is that fetch_database() is calling
samsync_fix_delta_array() with rid_crypt set to true, which means
the password hashes are unencrypted from the RID encryption.
However, I believe this call is redundant, and the corresponding
call for samdump has rid_crypt set to false. So I think the
rid_crypt param should be false in fetch_database().
If you follow the code, it makes its way to sam_account_from_delta()
where the password hashes are decrypted a second time by calling
sam_pwd_hash(). I believe this is what is scrambling my passwords.
These methods were refactored somewhere in the 3.3 branch. Now the
net_rpc_samsync.c class calls rpc_vampire_internals, which calls
libnet/libnet_samsync.c, which calls samsync_fix_delta_array() with
rid_crypt always set to false. I think that's correct. But the
second bug has carried through in the sam_account_from_delta()
function:
208 if (memcmp(r->ntpassword.hash, zero_buf, 16) != 0) {
209 sam_pwd_hash(r->rid, r->ntpassword.hash, lm_passwd, 0);
210 pdb_set_lanman_passwd(account, lm_passwd, PDB_CHANGED);
211 }
212
213 if (memcmp(r->lmpassword.hash, zero_buf, 16) != 0) {
214 sam_pwd_hash(r->rid, r->lmpassword.hash, nt_passwd, 0);
215 pdb_set_nt_passwd(account, nt_passwd, PDB_CHANGED);
If you look closely you'll see that the nt hash is going into the
lm_passwd variable and the decrypted value is being set in the lanman
hash, and the lanman hash is being decrypted and put into the nt hash
field. So the LanMan and NT hashes look like they're being put in
the opposite fields."
Fix this by removing the rid_crypt parameter.
Jeremy.
(cherry picked from commit
e38436f731ff09333588cc0751c79029a569f390)
Volker Lendecke [Wed, 22 Oct 2008 12:26:05 +0000 (14:26 +0200)]
Fix bug 5840: Segfault in "rpcclient lsaaddacctrights"
(cherry picked from commit
79222e476edbccf81e70cf1c0d1f40db0b88e20b)
Jeremy Allison [Wed, 22 Oct 2008 00:06:53 +0000 (17:06 -0700)]
Cope with MAXIMUM_ALLOWED_ACCESS requests when opening handles.
Jeremy.
(cherry picked from commit
82ec832f7edffe2fcfd1bb067e092c159bed2973)
Andreas Schneider [Mon, 20 Oct 2008 15:35:42 +0000 (17:35 +0200)]
Delete the krb5 ccname variable from the PAM environment if set.
If winbind sets the KRB5CCNAME variable it should unset it when
the cache gets destroyed.
(cherry picked from commit
e7b0d1c984a37600a234c1f4c95b06e9b5898f30)
Karolin Seeger [Tue, 21 Oct 2008 13:12:57 +0000 (15:12 +0200)]
WHATSNEW: Update changes.
Karolin
(cherry picked from commit
c5609611ef2af5dee47a380003c6ce94f3781f0b)
Günther Deschner [Mon, 20 Oct 2008 18:16:03 +0000 (20:16 +0200)]
s3-samr-server: be consistent when reporting we do password complexity.
Guenther
(cherry picked from commit
7c2831c5872ad26e1e0cd7df59d6c0b88d566760)
Jeremy Allison [Fri, 17 Oct 2008 22:25:58 +0000 (15:25 -0700)]
Unify access checks for lsa server functions.
Jeremy.
(cherry picked from commit
ef15ff6abec34377ab7fa75201e2799c0bb72aeb)
Jeremy Allison [Fri, 17 Oct 2008 04:04:18 +0000 (21:04 -0700)]
Cope with bad trans2mkdir requests from System i QNTC IBM SMB client.
If total_data == 4 Windows doesn't care what values
are placed in that field, it just ignores them.
The System i QNTC IBM SMB client puts bad values here,
so ignore them.
Jeremy.
(cherry picked from commit
5b1d8588d01d11251541829c5a3dff211fe925fd)
Jeremy Allison [Thu, 16 Oct 2008 22:06:13 +0000 (15:06 -0700)]
Unify the logic in pull_ascii_base_talloc() and pull_ucs2_base_talloc().
Jeremy.
(cherry picked from commit
5109bd33719a4bb1534cb0e012c92ec778fb26df)
Jeremy Allison [Thu, 16 Oct 2008 18:57:51 +0000 (11:57 -0700)]
Fix bug 5826 - Directory/Filenames get truncated when 3.2.0 client acesses old server.
Karolin this is a show-stopper for 3.2.5.
There was some code in pull_ucs2_base_talloc() to cope with this case which
hadn't been added to pull_ascii_base_talloc(). The older Samba returns non
unicode names which is why you are seeing this codepath being executed.
Jeremy.
(cherry picked from commit
09fa53d927436310ae3c17096d42e2fa4de1dd2e)
Jeremy Allison [Thu, 16 Oct 2008 01:08:07 +0000 (18:08 -0700)]
Don't use debug level 1 to log a trivial message.
Jeremy.
(cherry picked from commit
7c53cde257515e7bfffc8f3c0b54b7c99554d240)
Karolin Seeger [Wed, 15 Oct 2008 18:33:59 +0000 (20:33 +0200)]
WHATSNEW: Update changes since 3.2.4.
Karolin
(cherry picked from commit
84d9c849dd71d5b07de3239740d3874998ecbd8c)
Karolin Seeger [Wed, 15 Oct 2008 18:23:24 +0000 (20:23 +0200)]
WHATSNEW: Update changes since 3.2.4.
Karolin
(cherry picked from commit
4cc0d89d2cc562e88e67ceeb035c440f38eeaae3)
Jeremy Allison [Tue, 14 Oct 2008 23:05:00 +0000 (16:05 -0700)]
Attempt to fix bug #5818 - "smbcacls: sorts ACEs improperly and loses inheritance", based on
a patch from Paul Fertser <fercerpav@gmail.com>. I also added the ability to get/set hex
and symbolic inheritance flag names on ACE flags. I'm still investigating the effects
of setting the "SEC_DESC_DACL_AUTO_INHERIT_REQ" flag as I don't yet see what effects
this is having on the ACE sent.
Jeremy.
(cherry picked from commit
e59a21e945e6336f3d7622bf77cf5c2304936b70)
Jeremy Allison [Tue, 14 Oct 2008 22:40:44 +0000 (15:40 -0700)]
Note url explaining this code.
Jeremy.
(cherry picked from commit
4f1cdfe0901f4c78dff56ae5c26d2801b97d50d5)
Holger Hetterich [Tue, 14 Oct 2008 18:37:41 +0000 (11:37 -0700)]
Fix the "Premature end of data in tag" error when buiding the manpage, fix a typo in the text, add an example for anonymization usage.
(cherry picked from commit
1d202a8a7bccc65e47fc78b17d89b7e74a358487)
Holger Hetterich [Mon, 13 Oct 2008 21:18:54 +0000 (14:18 -0700)]
Update the manpage for vfs_smb_traffic_analyzer to include the anonymize_prefix option
(cherry picked from commit
c67cf648331bf4b8268813cb005b7283dd65eb73)
Holger Hetterich [Mon, 13 Oct 2008 21:14:25 +0000 (14:14 -0700)]
Enable optional anonymization of user names,
if the configuration parameter anonymization_prefix is defined in
smb.conf, and use the prefix given there.
(cherry picked from commit
86a621a1a3e08bad8a0b276d8444f1f69a500385)
Volker Lendecke [Tue, 7 Oct 2008 19:24:25 +0000 (21:24 +0200)]
Fix bug 5691: SIGBUS on Solaris
(cherry picked from commit
0f3f34033a80e44fa18cae452a164e445392138a)
Volker Lendecke [Sun, 12 Oct 2008 08:41:29 +0000 (10:41 +0200)]
Fix the build
(cherry picked from commit
1ab2a5b958a900a078cadf98b83fba7fadbaedf9)
Jeremy Allison [Sat, 11 Oct 2008 00:25:44 +0000 (17:25 -0700)]
Now it's working, back port the aync fix for parsing large cups printer lists.
Jeremy.
(cherry picked from commit
48ee5a66d18b805d03f93c85e98a41374d82cfb9)
Volker Lendecke [Thu, 9 Oct 2008 15:22:59 +0000 (17:22 +0200)]
Make use of ZERO_STRUCT (the first memset was actually wrong)
(cherry picked from commit
e42477caece1a2e861aa0698d2e06847819f0b0d)
Jeff Layton [Thu, 9 Oct 2008 14:44:37 +0000 (10:44 -0400)]
mount.cifs: make return codes match the return codes for /bin/mount (try #3)
The manpage for /bin/mount specifies that the return code should be a
positive integer (actually, it's a bitfield). Clean up the return
codes from mount.cifs to make them match the expected return values
from /bin/mount. This necessary for proper integration with autofs.
This is the third attempt at this patch. The changes here are minor,
just changing some return's from main() into exit() calls for
consistency's sake.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit
2374799c8114ae3ed422d1cbe4ca12c4fd075274)
Jeff Layton [Thu, 9 Oct 2008 14:42:28 +0000 (10:42 -0400)]
mount.cifs: have uppercase_string return success on NULL pointer
We currently don't attempt to uppercase the device portion of the mount
string if there isn't a prefixpath. Fix that by making uppercase_string
return success without doing anything on a NULL pointer.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
(cherry picked from commit
34b5cfe8a0cb8674da0c5ac7d81b6e64160ccaa2)
Jeremy Allison [Wed, 8 Oct 2008 18:40:16 +0000 (11:40 -0700)]
Fix bug #5814 - Winbindd dumping core in a strange manner while doing "rescan_trusted_domain".
From analysis by hargagan <shargagan@novell.com> :
"The winbindd_child_died() is also getting called from process_loop() in case of
SIGCHLD signal. In this case it doesn't make the timeout_handler to NULL for
the first request. It then initiate a new request using
schedule_async_request() which installs a new timeout handler for the same
request. In such a case, for a badly unresponsive system both the timeout
handler can be called. For the first call the "private_data" will be cleared
and for another call the timeout handler will be detecting the double free. So,
for such a case as well, the winbindd_child_died() should make the
timeout_handler to NULL."
Jeremy.
(cherry picked from commit
ce8de496ec139b7a56db20c5ffbcbdc2f4db0a51)
Tim Prouty [Tue, 7 Oct 2008 17:30:22 +0000 (10:30 -0700)]
Fixed build warning "passing arg from incompatible pointer type"
The fix explicitly makes the conversion from timeval to time_t using the
existing time utility functions.
Compiling modules/vfs_smb_traffic_analyzer.c
modules/vfs_smb_traffic_analyzer.c: In function `smb_traffic_analyzer_send_data':
modules/vfs_smb_traffic_analyzer.c:173: warning: passing arg 1 of `localtime' from incompatible pointer type
(cherry picked from commit
22852666ddf3e77404373042ceecb19747ae25cd)