Tim Prouty [Tue, 29 Apr 2008 21:36:24 +0000 (14:36 -0700)]
Cleanup size_t return values in callers of convert_string_allocate
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
Volker Lendecke [Tue, 20 May 2008 19:54:36 +0000 (21:54 +0200)]
Fix nesting tdb_traverse in a transaction
Calling tdb_traverse inside a transaction led to the transaction lock being
held indefinitely. This was caused by the tdb_transaction_lock/unlock inside
tdb_traverse: The transaction code holds the global lock at offset
TRANSACTION_LOCK. The call to tdb_transaction_lock does nothing because the
transaction_lock is already being held. tdb_transaction_unlock inside tdb_wrap
resets tdb->have_transaction_lock but does not release the kernel-level fcntl
lock. transaction_commit later on does not release that fcntl lock either,
because tdb->have_transaction_lock was already reset by tdb_transaction().
This patch does fix that problem for me. An alternative would be to make
tdb->have_transaction_lock a counter that can cope with proper nesting, maybe
in other places as well.
Volker
Jeremy Allison [Tue, 20 May 2008 19:09:48 +0000 (12:09 -0700)]
Fix bug #5477 - recvfile code was broken.
Jeremy.
Volker Lendecke [Tue, 20 May 2008 16:35:23 +0000 (18:35 +0200)]
Fix memcache_flush()
I have no idea what I've been smoking when I checked this in :-(
Karolin, this fixes the join bug 3.0.28->3.2.0rc1
Thanks,
Volker
Günther Deschner [Tue, 20 May 2008 15:48:39 +0000 (17:48 +0200)]
Fix typo.
Guenther
(cherry picked from commit
d3dd7ea5a77414c0d802668ab5bfbe3487b66926)
Volker Lendecke [Tue, 20 May 2008 15:29:40 +0000 (17:29 +0200)]
Fix a valgrind error in _samr_LookupNames
(cherry picked from commit
fb0a25d59ddd28ea1d5af33ec7d9f817fac3fb9d)
Kai Blin [Thu, 15 May 2008 08:14:41 +0000 (10:14 +0200)]
net: The top level help function for net cmd is always net_cmd_usage
Kai Blin [Wed, 14 May 2008 13:09:29 +0000 (15:09 +0200)]
net: Move help for "net status" to net_status.c
Kai Blin [Wed, 14 May 2008 12:29:52 +0000 (14:29 +0200)]
net: Move printer help to net_rpc where it's used.
Kai Blin [Wed, 14 May 2008 12:24:21 +0000 (14:24 +0200)]
net: Split out "net share"
Kai Blin [Wed, 14 May 2008 07:01:53 +0000 (09:01 +0200)]
net: Split out "net afs"
Kai Blin [Tue, 13 May 2008 19:18:09 +0000 (21:18 +0200)]
net: Move more utility functions into net_util.c
Kai Blin [Tue, 13 May 2008 11:52:58 +0000 (13:52 +0200)]
net: Split out "net file"
Kai Blin [Tue, 13 May 2008 11:44:28 +0000 (13:44 +0200)]
net: Split out "net group"
Kai Blin [Tue, 13 May 2008 10:51:09 +0000 (12:51 +0200)]
net: Split out "net user"
Kai Blin [Tue, 13 May 2008 09:11:35 +0000 (11:11 +0200)]
net: Move "net join" handling into a separate file.
Kai Blin [Mon, 12 May 2008 12:38:21 +0000 (14:38 +0200)]
net: Split out common help functions.
Kai Blin [Mon, 12 May 2008 09:56:18 +0000 (11:56 +0200)]
net: more whitespace cleanup
Kai Blin [Mon, 12 May 2008 09:53:23 +0000 (11:53 +0200)]
net: Use true/false instead of True/False.
Karolin Seeger [Fri, 16 May 2008 07:27:20 +0000 (09:27 +0200)]
man pages: Remove man page for 'mangled map'.
'mangled map' has been removed with
dee8beba7a92b8a3f68bbcc59fd0a827f68c7736.
Karolin
(cherry picked from commit
d9b4e500675a378daba50d12cd638a245aa78b72)
Karolin Seeger [Tue, 20 May 2008 09:09:06 +0000 (11:09 +0200)]
sesssetup.c: Add debug message.
Log when we kill other smbd sessions like when we hit the VC == 0 case.
This one fixes BUG #5476.
Initial patch from Björn Jacke <bj@sernet.de>.
Karolin
Karolin Seeger [Tue, 20 May 2008 09:03:33 +0000 (11:03 +0200)]
man pages: Add documentation for new cluster parameters.
Karolin
Jeremy Allison [Tue, 20 May 2008 00:19:18 +0000 (17:19 -0700)]
Remove conn_find_byname now it's no longer used in
the msdfs.c code.
Jeremy
Jeremy Allison [Mon, 19 May 2008 20:11:00 +0000 (13:11 -0700)]
Restructuring of code to fix #5460. Remove search
by name code from conn, we were already doing the
same check in the dfs_redirect() function, so move
it into parse_dfs_path() instead.
Jeremy.
Volker Lendecke [Sun, 18 May 2008 12:30:33 +0000 (14:30 +0200)]
Convert messages_local.c to use "struct tdb_wrap"
This works around a problem with smbcontrol opening messaging.tdb twice. Very
likely this is not the right fix. Michael, please check.
Volker
Volker Lendecke [Mon, 19 May 2008 02:24:21 +0000 (04:24 +0200)]
Don't block smbcontrol online/offline if !"winbind offline logons"
There's no point to block these, winbind will ignore them anyway.
Jerry, Jeremy, we definitely need a chance to trigger a reconnection attempt
after a DC has been rebooted. Right now winbind's reaction to a single rebooted
DC is to declare it offline. It will not try before a "winbind cache timeout"
timeout. If the admin sets this to an hour or longer for performance reasons,
we're screwed. Reboot your DC, no logon for an hour.
Volker
Volker Lendecke [Mon, 19 May 2008 02:20:56 +0000 (04:20 +0200)]
If no node number is given, default to the current node in smbcontrol
root [Mon, 19 May 2008 00:48:09 +0000 (02:48 +0200)]
Fix some comments to match get_kdc_ip_string()'s behaviour
Michael Adam [Sun, 18 May 2008 23:22:14 +0000 (01:22 +0200)]
build: remove the proto_exists target - it is not needed anymore.
Michael
Michael Adam [Sun, 18 May 2008 22:54:45 +0000 (00:54 +0200)]
build: remove the "delheaders" target.
Michael
Michael Adam [Sun, 18 May 2008 22:51:45 +0000 (00:51 +0200)]
build: remove "headers" and "proto" make targets.
Replace "proto" target by a message.
Michael
Michael Adam [Sun, 18 May 2008 21:39:15 +0000 (23:39 +0200)]
build: remove mkproto.sh and mkproto.awk
Michael
Michael Adam [Sun, 18 May 2008 21:37:10 +0000 (23:37 +0200)]
build: remove reference to mkproto.sh from Makefile
No generated prototypes anymore...
Michael
Michael Adam [Sun, 18 May 2008 21:35:42 +0000 (23:35 +0200)]
libnet: freeze libnet_proto.h from "make proto"
Michael
Michael Adam [Sun, 18 May 2008 21:33:20 +0000 (23:33 +0200)]
build: freeze passwd_proto.h from "make proto"
Michael
Michael Adam [Sun, 18 May 2008 21:31:42 +0000 (23:31 +0200)]
net: freeze net_proto.h from "make proto"
Michael
Michael Adam [Sun, 18 May 2008 21:29:01 +0000 (23:29 +0200)]
ntlm_auth: freeze ntlm_auth_proto.h from "make proto"
Michael
Michael Adam [Sun, 18 May 2008 21:26:51 +0000 (23:26 +0200)]
smbclient: freeze client_proto.h from "make proto"
Michael
Michael Adam [Sun, 18 May 2008 21:16:38 +0000 (23:16 +0200)]
swat: freeze swat_proto.h from "make proto"
Michael
Michael Adam [Sun, 18 May 2008 21:09:34 +0000 (23:09 +0200)]
winbindd: freeze winbindd_proto.h
Michael
Michael Adam [Sun, 18 May 2008 20:58:07 +0000 (22:58 +0200)]
build: freeze proto.h
Michael
Kai Blin [Sun, 18 May 2008 00:26:32 +0000 (02:26 +0200)]
configure: Fix comment to match the current iconv check.
Volker Lendecke [Sat, 17 May 2008 20:44:35 +0000 (22:44 +0200)]
Factor out generation of an info3 struct from a serversupplied_info
Stefan Metzmacher [Fri, 16 May 2008 10:50:16 +0000 (12:50 +0200)]
configure: make use of LIBREPLACE_NETWORK_LIBS instead of redoing the tests
metze
Stefan Metzmacher [Fri, 16 May 2008 10:48:57 +0000 (12:48 +0200)]
configure: remove some header checks which are already done by AC_LIBREPLACE_NETWORK_CHECKS
metze
Stefan Metzmacher [Fri, 16 May 2008 10:46:10 +0000 (12:46 +0200)]
lib/replace: move sys/sockio.h and sys/un.h checks into AC_LIBREPLACE_NETWORK_CHECKS
metze
(cherry picked from commit
7f26a5425e706a97cc07c5139b3fea4fde9e4020)
Stefan Metzmacher [Fri, 16 May 2008 10:33:11 +0000 (12:33 +0200)]
configure: remove unused configure checks for HAVE_SOCK_SIN_LEN and HAVE_UNIXSOCKET and rely on libreplace
metze
Stefan Metzmacher [Fri, 16 May 2008 10:29:21 +0000 (12:29 +0200)]
lib/replace: add checks for HAVE_SOCK_SIN_LEN and HAVE_UNIXSOCKET
Moved from the samba specific locations
metze
(cherry picked from commit
e674128ee2f11596f358ed46104c9d25eb2f754f)
Stefan Metzmacher [Fri, 16 May 2008 10:16:05 +0000 (12:16 +0200)]
configure: remove unused configure check for HAVE_WORKING_AF_LOCAL
metze
Volker Lendecke [Sat, 29 Mar 2008 17:19:31 +0000 (18:19 +0100)]
Simplify fake_file logic
Günther Deschner [Fri, 16 May 2008 11:24:15 +0000 (13:24 +0200)]
Fix Bug #5461 and implement a very basic _samr_GetDisplayEnumerationIndex().
Citrix PM cannot use a Samba DC when having more then 900 groups as citrix
insists on calling _samr_GetDisplayEnumerationIndex() after receiving the first
900 groups via _samr_QueryDisplayInfo() to get the continuation index.
Guenther
Günther Deschner [Fri, 16 May 2008 10:16:04 +0000 (12:16 +0200)]
libnetjoin: for informational reasons, report forest_name.
Guenther
Günther Deschner [Fri, 16 May 2008 10:11:43 +0000 (12:11 +0200)]
netdomjoin-gui: before prompting for creds (for receiving joinable ous), find a dc.
Guenther
Günther Deschner [Fri, 16 May 2008 09:52:48 +0000 (11:52 +0200)]
net: use the netapi_ctx from the net_context struct.
Guenther
Günther Deschner [Thu, 15 May 2008 15:47:07 +0000 (17:47 +0200)]
dsgetdcname: store client sitename for mailslot and cldap replies.
Guenther
Stefan Metzmacher [Thu, 8 May 2008 09:01:09 +0000 (11:01 +0200)]
libreplace: try to fix the build on HP-UX which has if_nametoindex() in -lipv6
metze
(cherry picked from commit
da2179ee5d5b6094ab63a9d9d6a8d59893937087)
Stefan Metzmacher [Thu, 8 May 2008 08:39:41 +0000 (10:39 +0200)]
libreplace: make sure system/network.h is only used when AC_LIBREPLACE_NETWORK_CHECKS was used
metze
(cherry picked from commit
3fddd36e119f73a5021370450f9687ef9d252bab)
Stefan Metzmacher [Thu, 8 May 2008 08:32:19 +0000 (10:32 +0200)]
libreplace: export LIBREPLACE_NETWORK_OBJS and LIBREPLACE_NETWORK_LIBS vars
metze
(cherry picked from commit
aa7ef1af746319a3d771decd0ec03dabe8b8ad28)
Stefan Metzmacher [Thu, 8 May 2008 08:27:23 +0000 (10:27 +0200)]
libreplace: include inet_ntoa.o when the system one is broken
metze
(cherry picked from commit
67845d3471711d24069636d0d4032f9d53748334)
Stefan Metzmacher [Thu, 8 May 2008 08:08:42 +0000 (10:08 +0200)]
libreplace: merge getifaddrs.m4 into libreplace_network.m4
metze
(cherry picked from commit
0234d397fefee8e1d0dcd3402f748c2251021c90)
Stefan Metzmacher [Thu, 8 May 2008 08:06:39 +0000 (10:06 +0200)]
libreplace: merge getaddrinfo.m4 into libreplace_network.m4
metze
(cherry picked from commit
64591d064dc3da6074f0f7539911a6e433d9cc43)
Stefan Metzmacher [Thu, 8 May 2008 08:04:51 +0000 (10:04 +0200)]
libreplace: merge socketpair.m4 into libreplace_network.m4
metze
(cherry picked from commit
f9f8f93adcc7161ebb18f5a0bf28c73d951a15ad)
Stefan Metzmacher [Thu, 8 May 2008 08:02:21 +0000 (10:02 +0200)]
libreplace: merge inet_pton.m4 into libreplace_network.m4
metze
(cherry picked from commit
3a70274c908e31453942b442351eab8423c1a53d)
Stefan Metzmacher [Thu, 8 May 2008 08:00:58 +0000 (10:00 +0200)]
libreplace: merge inet_ntop.m4 into libreplace_network.m4
metze
(cherry picked from commit
223ef6c08efb52251d0a772bb0c481b2803cf0ce)
Stefan Metzmacher [Thu, 8 May 2008 07:59:16 +0000 (09:59 +0200)]
libreplace: merge inet_aton.m4 into libreplace_network.m4
metze
(cherry picked from commit
fba00736c870f449c0eee32fe0d7b0d539dca51f)
Stefan Metzmacher [Thu, 8 May 2008 07:58:07 +0000 (09:58 +0200)]
libreplace: merge inet_ntoa.m4 into libreplace_network.m4
metze
(cherry picked from commit
82e826253b6d18832931dbb5c1dda009889bf9e0)
Stefan Metzmacher [Thu, 8 May 2008 07:56:10 +0000 (09:56 +0200)]
libreplace: merge socket.m4 into libreplace_network.m4
metze
(cherry picked from commit
c70eba87dbbac6c2c1e68c343cdd410577c1686f)
Jelmer Vernooij [Thu, 8 May 2008 11:43:45 +0000 (13:43 +0200)]
William Jojo [Thu, 8 May 2008 10:41:57 +0000 (12:41 +0200)]
Add undefined symbol flag for AIX.
(cherry picked from commit
dabdf24e86f038e3afc67532fa5bf60a37992161)
Stefan Metzmacher [Wed, 7 May 2008 15:38:41 +0000 (17:38 +0200)]
libreplace: also use AC_LIBREPLACE_NETWORK_CHECKS for the standalone build
metze
(cherry picked from commit
04f4523ed032946b8f0e74ac6f7458010159e3bb)
Stefan Metzmacher [Wed, 7 May 2008 15:20:38 +0000 (17:20 +0200)]
libreplace: use AC_LIBREPLACE_NETWORK_CHECKS only for samba
metze
Stefan Metzmacher [Wed, 7 May 2008 15:15:36 +0000 (17:15 +0200)]
libreplace: use AC_LIBREPLACE_NETWORK_CHECKS only for samba
metze
(cherry picked from commit
3451b54bf7f5e37a589ec261d28c2a8b6f9788ed)
Stefan Metzmacher [Wed, 7 May 2008 14:50:19 +0000 (16:50 +0200)]
libreplace: split out network checks into a AC_LIBREPLACE_NETWORK_CHECKS macro
Note: moving it out of AC_LIBREPLACE_BROKEN_CHECKS will be the next step
metze
(cherry picked from commit
55a904b1d7aeca849d450e371b18afca5b0c6218)
Stefan Metzmacher [Wed, 7 May 2008 11:10:31 +0000 (13:10 +0200)]
libreplace: always provide utime() and utimes()
I'd like to also provide futimes(), but it seems
that some systems doesn't support a it at kernel level.
If someone knows how to write a portable replacement
for futimes() please tell me...
metze
(cherry picked from commit
a9604fe4a323dccb537cf02ea7594437b4995803)
Michael Adam [Thu, 15 May 2008 23:39:12 +0000 (01:39 +0200)]
packaging: re-introduce Release numbering ".ctdb.<number>"
This got accidentially (?) replaced by .ctdb.test.<date>".
Michael
(cherry picked from commit
be62d594bc2b680dfefb4a5050d033b77c08154b)
Michael Adam [Thu, 15 May 2008 23:26:47 +0000 (01:26 +0200)]
packaging: enable calling RHEL-CTDB/makerpms.sh from other directories
Michael
(cherry picked from commit
05168aaa8dba85ecc1b74afacdd4d5ddc5825cfa)
Michael Adam [Thu, 15 May 2008 23:02:56 +0000 (01:02 +0200)]
packaging: fix RHEL-CTDB build by removing duplicate winbind-32bit paragraphs
Michael
(cherry picked from commit
29d5a68d95f656d5ca61edc4a10ec8b028597bb5)
Michael Adam [Thu, 15 May 2008 22:52:46 +0000 (00:52 +0200)]
packaging: use git-archive in RHEL-CTDB/makerpms.sh
(instead of using tar and make distclean and ...)
Michael
(cherry picked from commit
3ad0f2212720eb5fb33794c033a60f5ea4428c2c)
Michael Adam [Thu, 15 May 2008 22:37:12 +0000 (00:37 +0200)]
packaging: use docs tarball instead of docs dir in makerpms / samba.spec
Michael
(cherry picked from commit
f28a24d5eac2dcf99e1d00c2daf913dd9912eb4a)
Michael Adam [Thu, 15 May 2008 22:19:59 +0000 (00:19 +0200)]
packaging: add a comment explaining EXTRA_OPTIONS to the makerpms script
Michael
(cherry picked from commit
0defc2c60f2ca469d7538c60b7638150c67feb33)
Michael Adam [Thu, 15 May 2008 22:15:31 +0000 (00:15 +0200)]
packaging: fix a comment typo in makerpms script.
Michael
(cherry picked from commit
6044373d69ae8cb0353e7a03e923462a093da5f0)
Andrew Tridgell [Fri, 9 May 2008 11:35:08 +0000 (21:35 +1000)]
merge build changes from Mathias
(cherry picked from commit
2c08939f3db19eaaf31cb117e3d541d17a36da5e)
Michael Adam [Thu, 15 May 2008 16:06:23 +0000 (18:06 +0200)]
net rpc registry: fix getvalueraw to really print raw...
Michael
Michael Adam [Thu, 15 May 2008 14:49:25 +0000 (16:49 +0200)]
net rpc registry: add a getvalueraw subcommand.
Michael
Michael Adam [Thu, 15 May 2008 14:07:06 +0000 (16:07 +0200)]
net rpc registry: abstract add boolean "raw" to rpc_registry_getvalue_internal()
and wrap it into new rpc_registry_getvalue_full() for the getvalue subcommand.
Michael
Michael Adam [Thu, 15 May 2008 12:38:01 +0000 (14:38 +0200)]
net rpc registry: fix usage message of getvalue.
Michael
Michael Adam [Thu, 15 May 2008 12:35:45 +0000 (14:35 +0200)]
net registry: add a getvalueraw command to print the value in raw format.
Michael
Michael Adam [Thu, 15 May 2008 12:34:21 +0000 (14:34 +0200)]
net registry: refactor core of net_registry_getvalue() out
into net_registry_getvalue_internal(), which takes a bool parameter "raw"
controlling the output format.
Michael
Michael Adam [Thu, 15 May 2008 10:55:54 +0000 (12:55 +0200)]
net_registry: add raw output of value to print_registry_value().
Michael
Günther Deschner [Thu, 15 May 2008 15:00:31 +0000 (17:00 +0200)]
net: Fix net lookup dsgetdcname, no need to pull site ourselves.
Guenther
Günther Deschner [Thu, 15 May 2008 14:59:46 +0000 (16:59 +0200)]
dsgetdcname: add site support.
Guenther
Günther Deschner [Thu, 15 May 2008 14:41:18 +0000 (16:41 +0200)]
dsgetdcname: check for invalid sitename/flag combinations.
Guenther
Günther Deschner [Thu, 15 May 2008 14:38:32 +0000 (16:38 +0200)]
libads/cldap: store client sitename also keyed by dns domain name.
Guenther
Günther Deschner [Thu, 15 May 2008 07:42:37 +0000 (09:42 +0200)]
Fix build warning.
Guenther
Michael Adam [Thu, 15 May 2008 00:41:05 +0000 (02:41 +0200)]
testparm: list registry shares with testparm.
I.e., use lp_load_with_registry_shares() instead of lp_load().
Michael
Michael Adam [Thu, 15 May 2008 00:39:45 +0000 (02:39 +0200)]
loadparm: add funcion lp_load_with_registry_shares().
This is like lp_load(), except that it will load the
registry shares into the services aarray when registry
shares are activated.
Michael
Michael Adam [Thu, 15 May 2008 00:39:02 +0000 (02:39 +0200)]
loadparm: add call to do_section() to process_registry_service().
Michael
Michael Adam [Thu, 15 May 2008 00:25:34 +0000 (02:25 +0200)]
loadparm: add parameter allow_registry_shares to lp_load_ex().
This allows for registry shares to be activated, i.e. loaded into
the services array at lp_load() time.
Michael
Michael Adam [Thu, 15 May 2008 00:15:20 +0000 (02:15 +0200)]
loadparm: add a function process_registry_shares()
This loads the shares defined in registry into the services array.
Michael
Michael Adam [Thu, 15 May 2008 00:08:14 +0000 (02:08 +0200)]
loadparm: refactor processing of service out of process_registry_globals()
into new function process_registry_service().
Michael