Michael Adam [Thu, 27 Jan 2011 20:46:12 +0000 (21:46 +0100)]
libwbclient: remove two unused defines
Michael Adam [Wed, 26 Jan 2011 21:00:22 +0000 (22:00 +0100)]
wbinfo: remove --remove-gid-mapping - winbindd does not implement that any more.
Michael Adam [Wed, 26 Jan 2011 21:00:22 +0000 (22:00 +0100)]
wbinfo: remove --remove-uid-mapping - winbindd does not implement that any more.
Michael Adam [Wed, 26 Jan 2011 21:00:22 +0000 (22:00 +0100)]
wbinfo: remove --set-gid-mapping - winbindd does not implement that any more.
Michael Adam [Wed, 26 Jan 2011 21:00:22 +0000 (22:00 +0100)]
wbinfo: remove --set-uid-mapping - winbindd does not implement that any more.
Michael Adam [Mon, 24 Jan 2011 16:37:33 +0000 (17:37 +0100)]
s3:registry: fix comments in regdb_store_regdb_version()
Andreas Schneider [Wed, 26 Jan 2011 13:18:15 +0000 (14:18 +0100)]
s4-torture: Reorder the epmapper tests.
It works like a stack!
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan 27 15:28:05 CET 2011 on sn-devel-104
Andreas Schneider [Tue, 25 Jan 2011 17:49:32 +0000 (18:49 +0100)]
s4-torture: Added a full epm_Map test.
Andreas Schneider [Tue, 25 Jan 2011 21:51:26 +0000 (22:51 +0100)]
s4-torture: Added a test_Insert for epmapper.
Andreas Schneider [Tue, 25 Jan 2011 21:50:42 +0000 (22:50 +0100)]
s4-torture: Use binding handle in epm_Delete test.
Andreas Schneider [Tue, 18 Jan 2011 15:42:34 +0000 (16:42 +0100)]
s4-torture: Comment out the test_InqObject.
Andreas Schneider [Wed, 12 Jan 2011 16:41:05 +0000 (17:41 +0100)]
s4-torture: Added a clean test_Map_simple.
Andreas Schneider [Fri, 24 Dec 2010 09:35:47 +0000 (10:35 +0100)]
s4-torture: Added a clean test_Lookup_terminate_search.
Andreas Schneider [Thu, 23 Dec 2010 19:57:28 +0000 (20:57 +0100)]
s4-torture: Added a clean test_Lookup_simple.
Andreas Schneider [Thu, 23 Dec 2010 12:07:39 +0000 (13:07 +0100)]
s4-torture: Added test_LookupHandleFree.
Andreas Schneider [Tue, 5 Oct 2010 09:17:31 +0000 (11:17 +0200)]
s4-torture: Start with a clean epm_Insert_noreplace test.
Andreas Schneider [Wed, 26 Jan 2011 09:01:26 +0000 (10:01 +0100)]
s4-selftest: Mark epmapper as knownfail.
Andreas Schneider [Tue, 5 Oct 2010 13:32:54 +0000 (15:32 +0200)]
idl: Added missing endpoint mapper defines.
[MS-RPCE] 2.2.1.2.4 ept_lookup Method
Andreas Schneider [Tue, 4 Jan 2011 09:11:09 +0000 (10:11 +0100)]
librpc: Added support to accept netbios names.
If we have a NCACN_NP pipe, the binding host is the netbios name an not
an IP address.
Günther Deschner [Tue, 25 Jan 2011 11:10:25 +0000 (12:10 +0100)]
s3-build: remove another leftover of -I../source4.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan 27 13:30:30 CET 2011 on sn-devel-104
David Disseldorp [Wed, 26 Jan 2011 22:32:01 +0000 (14:32 -0800)]
Looking into printer driver issues, I ran across some peculiarities in
copy_file():
- Firstly, if the source file is zero bytes, NT_STATUS_DISK_FULL is
returned.
- Secondly, the conditional lseek is confusing. It fires when
OPENX_FILE_EXISTS_OPEN is set and I can't see why the lseek is
necessary in this case.
- Finally, the lseek error path also results in NT_STATUS_DISK_FULL.
Proposed fix for first and third point below.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:59:56 CET 2011 on sn-devel-104
Andreas Schneider [Wed, 19 Jan 2011 22:15:21 +0000 (23:15 +0100)]
s3-utils: Fixed a resource leak in net_afs.
s3-utils: Fixed a resource leak in net_afs.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:12:47 CET 2011 on sn-devel-104
Andreas Schneider [Wed, 19 Jan 2011 22:13:47 +0000 (23:13 +0100)]
s3-utils: Fixed a resource leak in smbta-util.
s3-utils: Fixed a resource leak in smbta-util.
Andreas Schneider [Wed, 19 Jan 2011 22:07:33 +0000 (23:07 +0100)]
s3-utils: Fixed possible resource leak in net_usershare.
s3-utils: Fixed possible resource leak in net_usershare.
Andreas Schneider [Wed, 19 Jan 2011 14:18:10 +0000 (15:18 +0100)]
s3-utils: Fixed possible resource leak in smbget.
s3-utils: Fixed possible resource leak in smbget.
Andreas Schneider [Wed, 19 Jan 2011 14:20:34 +0000 (15:20 +0100)]
s3-utils: Fixed possible resource leak in smbfilter.
s3-utils: Fixed possible resource leak in smbfilter.
Andreas Schneider [Wed, 19 Jan 2011 22:11:32 +0000 (23:11 +0100)]
s3-modules: Fixed the for-loop code block.
s3-modules: Fixed the for-loop code block.
Andreas Schneider [Wed, 19 Jan 2011 22:04:13 +0000 (23:04 +0100)]
s3-lib: Fixed a missing return value in tldap.
s3-lib: Fixed a missing return value in tldap.
Kai Blin [Wed, 26 Jan 2011 21:17:43 +0000 (22:17 +0100)]
errormap: Add unix_to_werror() function
While this function technically is closest to the
map_nt_status_from_unix() function, I think it is better to keep the new
function in line with our usual fooerror_to_barerror() naming scheme.
Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Jan 26 23:07:24 CET 2011 on sn-devel-104
Jeremy Allison [Wed, 26 Jan 2011 18:50:44 +0000 (10:50 -0800)]
Allow "security = share" with SMB2. We already handle this in smb2/smb2_server.c
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 20:37:29 CET 2011 on sn-devel-104
Jeremy Allison [Wed, 26 Jan 2011 16:43:43 +0000 (08:43 -0800)]
From Metze - make sure we're using the same string length for the hash.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 18:32:15 CET 2011 on sn-devel-104
Günther Deschner [Mon, 24 Jan 2011 19:52:24 +0000 (20:52 +0100)]
s3-winbind: share a common winbind_samlogon_retry_loop().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 26 12:41:14 CET 2011 on sn-devel-104
Günther Deschner [Mon, 24 Jan 2011 19:45:35 +0000 (20:45 +0100)]
Revert "s3: These assignments are overwritten immediately"
This reverts commit
18962ea3852d0d0fc7371e99813bebd54fae0a19.
Günther Deschner [Mon, 24 Jan 2011 19:43:56 +0000 (20:43 +0100)]
Revert "s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains."
This reverts commit
cea36aeacf8778493463f31e6afc3f58384639e2.
Stefan Metzmacher [Wed, 26 Jan 2011 07:48:34 +0000 (08:48 +0100)]
pidl:Typelist: fix perl warnings about recursiv function calls
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 26 10:59:04 CET 2011 on sn-devel-104
Stefan Metzmacher [Tue, 25 Jan 2011 18:46:18 +0000 (19:46 +0100)]
pidl:Samba3/ServerNDR: correctly initialise ndr_push struct
We need to copy the ptr_count from the ndr_pull struct to the ndr_push struct,
otherwise we'll reuse full pointer ids, which will cause the client to
fail in the ndr unmarshalling.
metze
Jeremy Allison [Tue, 25 Jan 2011 22:59:44 +0000 (14:59 -0800)]
Missed one debug printf of name_hash. Ensure always use %x.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 00:46:28 CET 2011 on sn-devel-104
Jeremy Allison [Tue, 25 Jan 2011 22:23:19 +0000 (14:23 -0800)]
Fix bug #7863 - Unlink may unlink wrong file when hardlinks are involved.
Do this by keeping a linked list of delete on close tokens, one for
each filename that identifies a path to the dev/inode. Use the
jenkins hash of the pathname to identify the correct token.
Jeremy Allison [Tue, 25 Jan 2011 21:57:38 +0000 (13:57 -0800)]
Add uint32_t name_hash argument (currently unused) to get_file_infos().
Will be used when we store more than one delete on close token.
Jeremy Allison [Tue, 25 Jan 2011 22:01:52 +0000 (14:01 -0800)]
Add name_hash into the share mode entry struct (as yet only use for renames to identify a specific path).
Jeremy Allison [Tue, 25 Jan 2011 21:49:01 +0000 (13:49 -0800)]
Add name_hash to files_struct. Set within fsp_set_smb_fname().
Kamen Mazdrashki [Sat, 22 Jan 2011 01:22:48 +0000 (03:22 +0200)]
s4-test/delete_object: Remove global ldb connections
Make it more xUnit compliant
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Jan 25 21:30:19 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Mon, 17 Jan 2011 12:52:00 +0000 (13:52 +0100)]
s4:ldap.py - check the write protection on LSA objects
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Jan 25 13:09:41 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Tue, 21 Dec 2010 11:24:30 +0000 (12:24 +0100)]
s4:dsdb/samdb/ldb_modules/objectclass.c - move LSA specific object checks into "objectclass_attrs" LDB module
LSA object classes are protected on both LDAP add and LDAP modify
operations, so I've refactored the previous check in the objectclass LDB
module only for LDAP adds in a new one in the objectclass_attrs LDB
module for both adds and modifies.
This is the result of the investigations done by Hongwei Sun and I in
the last months.
Interestingly these protection mechansim doesn't apply on LDAP deletes!
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Günther Deschner [Tue, 25 Jan 2011 01:42:59 +0000 (02:42 +0100)]
idl: add file_id idl.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan 25 12:27:00 CET 2011 on sn-devel-104
Günther Deschner [Tue, 25 Jan 2011 01:52:18 +0000 (02:52 +0100)]
s3-libndr: remove cmdline_lp_ctx.
Guenther
Günther Deschner [Tue, 25 Jan 2011 01:01:56 +0000 (02:01 +0100)]
waf: share libndr.so between samba3 and samba4.
Guenther
Günther Deschner [Mon, 24 Jan 2011 23:52:10 +0000 (00:52 +0100)]
libndr: move ndr_print_bool to ndr_basic.c
Guenther
Günther Deschner [Mon, 24 Jan 2011 23:47:05 +0000 (00:47 +0100)]
s3-waf: add PKGCONFIGDIR.
Guenther
Björn Baumbach [Thu, 20 Jan 2011 13:38:30 +0000 (14:38 +0100)]
s3-smbclient: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 25 11:41:53 CET 2011 on sn-devel-104
Björn Baumbach [Thu, 20 Jan 2011 13:08:42 +0000 (14:08 +0100)]
s3-masktest: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Björn Baumbach [Mon, 17 Jan 2011 11:02:39 +0000 (12:02 +0100)]
s3-smbclient: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Björn Baumbach [Mon, 17 Jan 2011 12:03:05 +0000 (13:03 +0100)]
s3-torture: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Björn Baumbach [Mon, 17 Jan 2011 08:51:45 +0000 (09:51 +0100)]
s3-docs: fix deldriver option
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Björn Baumbach [Fri, 14 Jan 2011 11:35:55 +0000 (12:35 +0100)]
s3-docs: add some long opts to smbclient(1) man
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Jelmer Vernooij [Tue, 25 Jan 2011 02:09:27 +0000 (18:09 -0800)]
s4-waf: Skip header-not-found cache if a library is specified, as it may provide
additional C flags.
Tridge, please check.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Jan 25 03:59:32 CET 2011 on sn-devel-104
Jelmer Vernooij [Tue, 25 Jan 2011 01:15:49 +0000 (17:15 -0800)]
s4-waf: Only show minversion when there was a minimum version specified.
Jelmer Vernooij [Tue, 25 Jan 2011 01:14:50 +0000 (17:14 -0800)]
Show text output messages when interfacing with bzr.
Jelmer Vernooij [Mon, 3 Jan 2011 05:54:07 +0000 (06:54 +0100)]
remove unnecessary use of pass.
Günther Deschner [Mon, 24 Jan 2011 15:55:05 +0000 (16:55 +0100)]
s3-build: remove source4 include path for autoconf build as well.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 17:40:56 CET 2011 on sn-devel-104
Günther Deschner [Fri, 21 Jan 2011 15:58:32 +0000 (16:58 +0100)]
s3-rpcclient: allow to define validation level for samlogon.
Guenther
Günther Deschner [Mon, 24 Jan 2011 14:27:52 +0000 (15:27 +0100)]
s3-waf: fix lib/addns include path.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 16:15:58 CET 2011 on sn-devel-104
Günther Deschner [Mon, 24 Jan 2011 14:26:11 +0000 (15:26 +0100)]
s3-waf: no need anymore to include "source4" globally.
Guenther
Stefan Metzmacher [Mon, 24 Jan 2011 12:29:14 +0000 (13:29 +0100)]
libcli/ldap: use lib/ldb_compat.h for the s3 build
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 24 14:55:50 CET 2011 on sn-devel-104
Günther Deschner [Mon, 24 Jan 2011 10:48:36 +0000 (11:48 +0100)]
s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains.
After failing the netr_LogonSamLogonEx, we failed to retry with
netr_LogonSamLogon.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 12:35:42 CET 2011 on sn-devel-104
Volker Lendecke [Mon, 24 Jan 2011 08:25:01 +0000 (09:25 +0100)]
Revert "s3: Fix an infinite loop"
This reverts commit
61f7d7cdeccb1f733590e8bdb8229b32363a815e.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 24 10:10:43 CET 2011 on sn-devel-104
Volker Lendecke [Sun, 23 Jan 2011 08:12:43 +0000 (09:12 +0100)]
s3: Fix an infinite loop
If select returns EBADF (which should NEVER happen), then we loop infinitely
because the select masks seem all active.
I've been given an strace where smbd floods syslog with inotify-related
error messages. The strace shows that select returns EBADF, and we're calling
the inotify event callback. It then complains there's no data on the inotify
fd.
Metze, please check!
We might need to fix this in 3.4 and 3.5 as well. And we need to find the
deeper reason where we close a file descriptor and don't tell the events
system about it.
Volker
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 23 10:05:39 CET 2011 on sn-devel-104
Volker Lendecke [Sat, 22 Jan 2011 15:22:42 +0000 (16:22 +0100)]
s3: Fix connecting to port-139 only servers
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state->req_139 was not set yet.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 22 17:42:41 CET 2011 on sn-devel-104
Kamen Mazdrashki [Fri, 21 Jan 2011 20:51:05 +0000 (22:51 +0200)]
s4-repl_meta_data: replmd_update_is_newer() should not return true if metadata stamps are equal
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Sat Jan 22 12:22:30 CET 2011 on sn-devel-104
Kamen Mazdrashki [Fri, 21 Jan 2011 00:39:23 +0000 (02:39 +0200)]
s4-repl_meta_data: Print out what is wrong when we fail to modify object
Kamen Mazdrashki [Fri, 21 Jan 2011 00:38:25 +0000 (02:38 +0200)]
s4-repl_meta_data: We should not use USNs in metadata comparisons
If object is changed by same DC, then version should be incremented
Günther Deschner [Fri, 21 Jan 2011 14:35:11 +0000 (15:35 +0100)]
s3-torture: fix uninitialized status code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:52:34 CET 2011 on sn-devel-104
Günther Deschner [Fri, 21 Jan 2011 15:02:18 +0000 (16:02 +0100)]
s3-rpc_client: fix dcerpc_try_samr_connects().
Only return when both results are ok.
Guenther
Günther Deschner [Fri, 21 Jan 2011 15:00:31 +0000 (16:00 +0100)]
s3-rpc_client: no need to include gen_ndr/cli_samr.h anymore.
Guenther
Günther Deschner [Fri, 21 Jan 2011 14:51:05 +0000 (15:51 +0100)]
s3-rpc_client: fix uninitialized variable found by -O3.
Guenther
Günther Deschner [Tue, 18 Jan 2011 22:16:42 +0000 (23:16 +0100)]
s3-waf: remove RPCCLI_SPOOLSS subsystem.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:06:40 CET 2011 on sn-devel-104
Günther Deschner [Tue, 18 Jan 2011 22:16:24 +0000 (23:16 +0100)]
s3-build: remove RPCCLI_SPOOLSS subsystem.
Guenther
Günther Deschner [Tue, 18 Jan 2011 21:10:30 +0000 (22:10 +0100)]
s3-rpcclient: prefer dcerpc_spoolss_X functions.
Guenther
Günther Deschner [Tue, 18 Jan 2011 17:37:52 +0000 (18:37 +0100)]
s3-rpc_client: prefer dcerpc_spoolss_X functions.
Guenther
Günther Deschner [Tue, 18 Jan 2011 23:43:33 +0000 (00:43 +0100)]
s3-lanman: remove trailing whitespace.
Guenther
Andreas Schneider [Wed, 12 Jan 2011 14:51:49 +0000 (15:51 +0100)]
s3-rpc_client: Added dcerpc_try_samr_connects.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 15:19:01 CET 2011 on sn-devel-104
Andreas Schneider [Wed, 12 Jan 2011 14:36:19 +0000 (15:36 +0100)]
s3-rpc_client: Rename get_query_dispinfo_params.
Andreas Schneider [Wed, 12 Jan 2011 14:14:35 +0000 (15:14 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user3.
Andreas Schneider [Wed, 12 Jan 2011 08:04:19 +0000 (09:04 +0100)]
s3-rpc_client: Added dcerpc_samr_chng_pswd_auth_crap.
Andreas Schneider [Wed, 12 Jan 2011 07:46:28 +0000 (08:46 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user2.
Andreas Schneider [Tue, 11 Jan 2011 12:07:02 +0000 (13:07 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user.
Andreas Schneider [Tue, 11 Jan 2011 11:56:44 +0000 (12:56 +0100)]
s3-rpc_client: Added header information to cli_samr.h.
Andreas Schneider [Tue, 11 Jan 2011 11:56:08 +0000 (12:56 +0100)]
s3-rpc_client: Added header information to cli_lsarpc.h.
Michael Adam [Fri, 21 Jan 2011 12:49:06 +0000 (13:49 +0100)]
s3:docs: document "winbind max domain connections"
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 21 14:33:57 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 7 Apr 2010 15:45:12 +0000 (17:45 +0200)]
s3:winbind: Fork multiple children per domain
This makes us scale better with many simultaneous winbind requests,
some of which might be slow.
This implementation breaks offline logons, as the cached credentials are
maintained in a child (this needs fixing). So, if the offline logons are
active, only allow one DC connection.
Probably the offline logon and the scalable file server cases are
separate enough so that this patch is useful even with the restriction.
Stefan Metzmacher [Sat, 15 Jan 2011 11:06:09 +0000 (12:06 +0100)]
s3:printing: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 13:14:49 CET 2011 on sn-devel-104
Stefan Metzmacher [Sat, 15 Jan 2011 10:55:39 +0000 (11:55 +0100)]
s3:srv_spoolss: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Stefan Metzmacher [Sat, 15 Jan 2011 10:53:11 +0000 (11:53 +0100)]
s3:smbd: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Stefan Metzmacher [Sat, 15 Jan 2011 10:50:59 +0000 (11:50 +0100)]
s3:net: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Stefan Metzmacher [Sat, 15 Jan 2011 10:44:23 +0000 (11:44 +0100)]
s3:libads: use dcerpc_spoolss_X() functions
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Fri, 21 Jan 2011 09:30:13 +0000 (10:30 +0100)]
s3: Fix a deadlock between smbd and ctdbd
Do the notification after we released the share mode lock. Inside notify_fname
we take out another tdb lock. With ctdb also accessing our databases, this can
lead to deadlocks. Putting this notify after the TALLOC_FREE(lck) above we
avoid locking two records simultaneously. Notifies are async and informational
only, so calling the notify_fname without holding the share mode lock should
not do any harm.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 21 12:29:21 CET 2011 on sn-devel-104
Günther Deschner [Fri, 21 Jan 2011 09:38:23 +0000 (10:38 +0100)]
s3-spoolss: make it more obvious what winreg_create_printer() does.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 11:43:29 CET 2011 on sn-devel-104
Günther Deschner [Fri, 21 Jan 2011 09:34:38 +0000 (10:34 +0100)]
s3-rpcclient: rename duplicate enumkey command to winreg_enumkey.
Guenther
Günther Deschner [Wed, 19 Jan 2011 13:39:50 +0000 (14:39 +0100)]
s3-spoolss: as smbtorture testing proves: devmode size is the size of the devicemode minus the driverdata extra size.
Jeremy, please check.
Guenther
Günther Deschner [Wed, 19 Jan 2011 13:39:36 +0000 (14:39 +0100)]
s4-smbtorture: make sure there is always driverextra data in spoolss devmode size tests.
Guenther
git.samba.org / sharpe / samba-autobuild / .git / log