Andrew Tridgell [Mon, 19 Apr 2010 03:49:00 +0000 (13:49 +1000)]
s4-dev: expanded selftest-vars.sh to match current testenv
Andrew Tridgell [Mon, 19 Apr 2010 03:43:53 +0000 (13:43 +1000)]
s4-python: PyErr_SetString() will crash on NULL strings
use nt_errstr() when no error available
Andrew Tridgell [Mon, 19 Apr 2010 03:43:12 +0000 (13:43 +1000)]
build: fixed a python-3 indent error
Andrew Tridgell [Mon, 19 Apr 2010 03:42:53 +0000 (13:42 +1000)]
build: expanded testwaf to include cross-compiling and python versions
Jeremy Allison [Mon, 19 Apr 2010 03:23:54 +0000 (20:23 -0700)]
Final fix for #7331 - Compound async SMB 2 requests don't work right.
Don't free the cancelled SMB2 req early, let the cancelation
function take care of it. Return a NT_STATUS_CANCELLED when
we find and cancel a request. Fix our SMB2 error returns to
correctly set the structuresize to 9, and add the expected
zero byte (see section 2.2.2 in the SMB2 spec.).
This causes Samba to pass the test program in this bug report
that W2K8R2 fails (heh heh :-). This is because we always cause
compound requests to get to a cancelation point before dealing
with a cancel request.
Jeremy.
Volker Lendecke [Sat, 17 Apr 2010 19:39:09 +0000 (21:39 +0200)]
s3: Fix indentation in remove_ccache
Volker Lendecke [Sat, 17 Apr 2010 18:09:45 +0000 (20:09 +0200)]
s3: Fix a memleak in discover_dc_netbios
Volker Lendecke [Sat, 17 Apr 2010 17:24:34 +0000 (19:24 +0200)]
s3: Fix a typo in winbindd_ccache_save
Volker Lendecke [Sun, 18 Apr 2010 12:09:22 +0000 (14:09 +0200)]
nsswitch: Fix a memleak in wbinfo
Ira Cooper [Sun, 18 Apr 2010 13:02:23 +0000 (15:02 +0200)]
s3: Improved support for GAMIN.
Support the FAMNoExists API for gamin to reduce cpu use and problems when
using GAMIN as FAM for vfs_notify_fam.
Andrew Tridgell [Sun, 18 Apr 2010 12:57:59 +0000 (22:57 +1000)]
build: more dependencies on /usr/bin/perl -> ${PERL}
Andrew Tridgell [Sun, 18 Apr 2010 12:55:16 +0000 (22:55 +1000)]
build: cope with perl not being in /usr/bin/perl
This should fixed the pidl build on SerNet-NetBSD5
Andrew Tridgell [Sun, 18 Apr 2010 11:47:00 +0000 (21:47 +1000)]
s4-waf: removed the unused installdir= option to SAMBA_BINARY()
This was left over from the automatic conversion of the config.mk
files
Andrew Tridgell [Sun, 18 Apr 2010 11:08:11 +0000 (21:08 +1000)]
build: fixed install of binary targets that are in subdirs
this should fix the smbd/smbd install problem with Kai's s3 waf build
Andrew Tridgell [Sun, 18 Apr 2010 09:41:47 +0000 (19:41 +1000)]
build: support make V=1 for verbose build
this also adds support for other options, such as "make TESTS=testpattern"
Andrew Tridgell [Sun, 18 Apr 2010 08:21:04 +0000 (18:21 +1000)]
build: more adjustments for the ABI type name maps
- use 'va_list' instead of 'struct __va_list_tag *'
Using the C name for va_list is preferable
- add support for negative ABI name matches in abi_match=. That is
used to exlude ldb_*module_ops from the ldb ABI
- don't include the ldb module ops or backend ops in the ABI
Andrew Tridgell [Sun, 18 Apr 2010 07:35:53 +0000 (17:35 +1000)]
build: added abi_type_maps for FC12 struct va_list
fedora12 x86 uses "struct va_list"
Andrew Tridgell [Sun, 18 Apr 2010 07:31:24 +0000 (17:31 +1000)]
build: don't depend on the word size of nm output
the first column varies in length for different architectures
Jeremy Allison [Sun, 18 Apr 2010 05:42:23 +0000 (22:42 -0700)]
Second part of fix for bug #7331 - Compound async SMB 2 requests don't work right.
Cause us to match W2K8R2 by sending an interim compound reply
followed by a async reply.
Jeremy.
Andrew Tridgell [Sun, 18 Apr 2010 05:39:59 +0000 (15:39 +1000)]
s4-waf: rebuild signature files with the api type maps
This is not strictly necessary, as the old types would compare equal,
but it is neater to use the generic type names
Andrew Tridgell [Sun, 18 Apr 2010 05:39:14 +0000 (15:39 +1000)]
build: added abi type maps for _Bool and __va_list_tag
This allows us to make the signature files platform independent
Andrew Tridgell [Sun, 18 Apr 2010 02:48:09 +0000 (12:48 +1000)]
ldb-waf: enable ABI checking in ldb
we use separate signature files for ldb and ldb-samba4, as the samba4
varient of the library has many more public symbols
Andrew Tridgell [Sun, 18 Apr 2010 02:47:33 +0000 (12:47 +1000)]
ldb: mark the tdb backend in ldb as _PRIVATE_
Andrew Tridgell [Sun, 18 Apr 2010 02:47:13 +0000 (12:47 +1000)]
tevent-waf: enabled ABI checking in tevent
Andrew Tridgell [Sun, 18 Apr 2010 02:47:00 +0000 (12:47 +1000)]
tevent: mark backend init fns as _PRIVATE_
these are not supposed to be exposed in the library
Andrew Tridgell [Sun, 18 Apr 2010 02:46:33 +0000 (12:46 +1000)]
tdb-waf: added ABI checking for tdb
Andrew Tridgell [Sun, 18 Apr 2010 02:46:21 +0000 (12:46 +1000)]
talloc: mark public functions as _PUBLIC_
Andrew Tridgell [Sun, 18 Apr 2010 02:46:04 +0000 (12:46 +1000)]
talloc-waf: added ABI checking for talloc
Andrew Tridgell [Sun, 18 Apr 2010 02:45:30 +0000 (12:45 +1000)]
replace-waf: hide symbols in libreplace if a builtin library
Andrew Tridgell [Sun, 18 Apr 2010 02:44:58 +0000 (12:44 +1000)]
libreplace: added _PUBLIC_ and _PRIVATE_ to replace.h
these are needed for all libs that use ABI checking, so libreplace
is the logical place for now
Andrew Tridgell [Sun, 18 Apr 2010 02:44:07 +0000 (12:44 +1000)]
s4-waf: put the --xxx-wrapper options in 'developer options' group
Andrew Tridgell [Sun, 18 Apr 2010 02:43:15 +0000 (12:43 +1000)]
build: added ABI checking to the WAF build
See http://wiki.samba.org/index.php/Waf#ABI_Checking for details
Andrew Tridgell [Sun, 18 Apr 2010 02:41:56 +0000 (12:41 +1000)]
build: added a script for generating ABI signatures from shared libraries
Jeremy Allison [Sun, 18 Apr 2010 04:20:17 +0000 (21:20 -0700)]
First part of fix for bug #7331 - Compound async SMB 2 requests don't work right.
Gets us handling SMB2 compound async requests similar to W2K8R2
(and triggers the same client bug in the Win7 redirector). Great
thanks to Ira Cooper <samba@ira.wakeful.net> for helping with
this and to Metze for the wonderful async framework. The one
thing I need to fix to make us identical to W2K8R2 is that
when a compound request goes async at the end W2K8R2 splits
the replies up into a compound non-async reply followed by
a separate async reply. Currently we're doing the whole thing
in a compound reply.
Jeremy.
Matthias Dieter Wallnöfer [Sat, 17 Apr 2010 18:42:37 +0000 (20:42 +0200)]
s4:dsdb/dns/dns_update.c - fix a typo
Matthias Dieter Wallnöfer [Sat, 17 Apr 2010 18:08:15 +0000 (20:08 +0200)]
s4:kdc/db-glue.c - use "TALLOC_FREE" insteal of "talloc_free" for the "priv" context
Also after a free "priv" could be != NULL and may be freed again.
This should fix bug #7365.
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 21:22:01 +0000 (23:22 +0200)]
s4:kdc/wdc-samba4.c - fix integer counter types
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 21:17:15 +0000 (23:17 +0200)]
s4:kdc/db-glue.c - fix integer counter types
Nadezhda Ivanova [Sat, 17 Apr 2010 15:16:25 +0000 (18:16 +0300)]
s4:Added a test for correct CO expansion in SD creation.
Volker Lendecke [Fri, 16 Apr 2010 13:06:17 +0000 (15:06 +0200)]
s3: Slightly simpify samr_ValidatePassword_Reset
Volker Lendecke [Fri, 16 Apr 2010 13:06:03 +0000 (15:06 +0200)]
s3: Slightly simpify samr_ValidatePassword_Change
Volker Lendecke [Fri, 16 Apr 2010 13:00:54 +0000 (15:00 +0200)]
s3: Slightly simplify the logic of check_password_complexity()
The whole routine was just one if-branch. Do an early return instead.
Volker Lendecke [Fri, 16 Apr 2010 12:16:40 +0000 (14:16 +0200)]
s3: Fix some nonempty blank lines
Andreas Schneider [Fri, 16 Apr 2010 09:04:27 +0000 (11:04 +0200)]
s3-winreg_nt: Fixed QueryValue with data=NULL to get the length.
Nadezhda Ivanova [Fri, 16 Apr 2010 11:28:09 +0000 (14:28 +0300)]
s4:Replaced dsdb_get_dom_sid_from_ldb_message() with samdb_result_dom_sid()
Karolin Seeger [Fri, 16 Apr 2010 07:23:30 +0000 (09:23 +0200)]
s3-docs: Improve "winbind nss info" section in man smb.conf.
Karolin
Andrew Tridgell [Fri, 16 Apr 2010 05:33:07 +0000 (15:33 +1000)]
s4-rpc: fixed the build with the old build system
../librpc/gen_ndr/ndr_drsblobs.o was being linked in twice into
drsblobs.so
Andrew Tridgell [Thu, 15 Apr 2010 07:15:25 +0000 (17:15 +1000)]
s4-net: allow a username to be displayed in setpassword errors
the filter is a bit too cryptic
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 15 Apr 2010 07:14:46 +0000 (17:14 +1000)]
s4-net: nicer error message (and no exception)
in net newuser and net setpasswd we shouldn't be throwing python
exceptions on normal user errors like unknown user
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 15 Apr 2010 07:13:37 +0000 (17:13 +1000)]
s4-test: added KRB5_CONFIG to selftest-vars.sh
Andrew Tridgell [Thu, 15 Apr 2010 06:25:50 +0000 (16:25 +1000)]
s4-test: check that a weak password is rejected by kpasswd
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Stefan Metzmacher [Thu, 15 Apr 2010 17:01:17 +0000 (19:01 +0200)]
s4:rootdse: only return "tokenGroups", when the client asked for them
metze
Jelmer Vernooij [Thu, 15 Apr 2010 16:41:56 +0000 (18:41 +0200)]
pydsdb: Fix memory leak on invalid parameters, formatting, trivial
typos.
Matthieu Patou [Tue, 13 Apr 2010 20:46:51 +0000 (00:46 +0400)]
s4 python: add a unit test for function dsdb_get_oid_from_attid
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Sat, 10 Apr 2010 22:02:50 +0000 (02:02 +0400)]
s4 python: make the function dsdb_get_oid_from_attid reachable from a samDB object
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 12 Apr 2010 20:51:00 +0000 (00:51 +0400)]
s4 python: Add a function to get the oid of an attribute when the attid is known
This function is mainly to help decoding replPropertyMetaData in python
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 12 Apr 2010 21:00:08 +0000 (01:00 +0400)]
s4: Add python binding to waf so that the drsblobs.so is also built in waf
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 12 Apr 2010 20:58:50 +0000 (00:58 +0400)]
s4: Fix python binding for drsblobs
This binding needs symbols in drsblobs_c.c otherwise we have unresolved symbols
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Wed, 7 Apr 2010 21:44:22 +0000 (01:44 +0400)]
s4 provision: Remove hard coded ACL for GPO objects
It is no longer needed to hard code ACL for GPO object as we have now code
that calculate ACL from defaultSecurityDescriptor and inheritance correctly.
In fact the resulting ACL returned by this hard coded value is a bit wrong as
some ACE are duplicated.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Stefan Metzmacher [Thu, 15 Apr 2010 14:30:02 +0000 (16:30 +0200)]
s4:setup/wscript_build: install dns_update_list into ${SETUPDIR}
metze
Stefan Metzmacher [Thu, 15 Apr 2010 14:26:59 +0000 (16:26 +0200)]
Revert "Revert "s4:script/installmisc.sh - install "dns_update_list" to target setup folder""
This reverts commit
a34eafc693d8750c0883823068e5c6f7355efa04.
This commit was correct.
metze
Stefan Metzmacher [Thu, 15 Apr 2010 14:25:37 +0000 (16:25 +0200)]
Revert "s4:"dns_update_list" file: install it properly into the private directory"
This reverts commit
fde707aa0c563d239c2f8c442cddfee0b6ff057f.
This is wrong, we need to install it into the setup directory,
so that provision will find it and copy it to private dir.
metze
Stefan Metzmacher [Thu, 15 Apr 2010 16:26:38 +0000 (18:26 +0200)]
s4:dynconfig/wscript: ${LOCALSTATEDIR} already has var/ included
metze
Stefan Metzmacher [Thu, 15 Apr 2010 15:22:41 +0000 (17:22 +0200)]
s4:torture/rpc/countcalls: check for NT_STATUS_IS_RPC() instead of NT_STATUS_NET_WRITE_FAULT
metze
Stefan Metzmacher [Thu, 15 Apr 2010 15:21:13 +0000 (17:21 +0200)]
s4:libnet_passwd: check for NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE for SetPassword
metze
Stefan Metzmacher [Thu, 15 Apr 2010 15:20:21 +0000 (17:20 +0200)]
s4:libnet_passwd: check for NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE in the ChangePassword calls
metze
Stefan Metzmacher [Thu, 15 Apr 2010 15:19:19 +0000 (17:19 +0200)]
s4:libnet_rpc: check for NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE instead of NT_STATUS_NET_WRITE_FAULT
metze
Nadezhda Ivanova [Thu, 15 Apr 2010 15:21:55 +0000 (18:21 +0300)]
s4:Added a test to make sure we ignore ACEs with ID flag set.
Nadezhda Ivanova [Thu, 15 Apr 2010 10:54:23 +0000 (13:54 +0300)]
A bit of refactoring in the SD creation code.
Stefan Metzmacher [Mon, 12 Apr 2010 12:11:50 +0000 (14:11 +0200)]
s4:torture/rpc/autoidl.c: check for NT_STATUS_RPC_* instead of p->last_fault_code
metze
Stefan Metzmacher [Tue, 13 Apr 2010 19:48:36 +0000 (21:48 +0200)]
s4:torture/rpc/dsgetinfo.c: check for NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE instead of DCERPC_FAULT_INVALID_TAG
metze
Stefan Metzmacher [Mon, 12 Apr 2010 12:14:29 +0000 (14:14 +0200)]
s4:torture/rpc/spoolss.c: check for NT_STATUS_RPC_* instead of p->last_fault_code
metze
Stefan Metzmacher [Mon, 12 Apr 2010 12:13:55 +0000 (14:13 +0200)]
s4:torture/rpc/scanner.c: check for NT_STATUS_RPC_* instead of p->last_fault_code
metze
Stefan Metzmacher [Mon, 12 Apr 2010 12:13:27 +0000 (14:13 +0200)]
s4:torture/rpc/samr.c: check for NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE instead of DCERPC_FAULT_OP_RNG_ERROR
metze
Stefan Metzmacher [Mon, 12 Apr 2010 12:12:30 +0000 (14:12 +0200)]
s4:torture/rpc/drsuapi.c: check for NT_STATUS_RPC_ENUM_VALUE_OUT_OF_RANGE instead of DCERPC_FAULT_INVALID_TAG
metze
Stefan Metzmacher [Mon, 12 Apr 2010 12:12:10 +0000 (14:12 +0200)]
s4:torture/rpc/countcalls.c: check for NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE instead of DCERPC_FAULT_OP_RNG_ERROR
metze
Stefan Metzmacher [Sat, 10 Apr 2010 09:04:04 +0000 (11:04 +0200)]
s4:torture/rpc/alter_context: check for NT_STATUS_RPC_PROTOCOL_ERROR instead of DCERPC_NCA_S_PROTO_ERROR
metze
Stefan Metzmacher [Mon, 29 Mar 2010 20:58:53 +0000 (22:58 +0200)]
s4:torture/rpc/dssync.c: check for NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE instead of DCERPC_FAULT_OP_RNG_ERROR
metze
Stefan Metzmacher [Mon, 29 Mar 2010 20:45:05 +0000 (22:45 +0200)]
s4:torture/rpc/alter_context.c: check for NT_STATUS_RPC_BAD_STUB_DATA instead of NT_STATUS_NET_WRITE_FAULT
metze
Stefan Metzmacher [Mon, 29 Mar 2010 20:36:22 +0000 (22:36 +0200)]
s4:torture/rpc/handles.c: check for NT_STATUS_RPC_SS_CONTEXT_MISMATCH instead of DCERPC_FAULT_CONTEXT_MISMATCH
metze
Stefan Metzmacher [Mon, 29 Mar 2010 20:36:07 +0000 (22:36 +0200)]
s4:torture/rpc/lsa.c: test for NT_STATUS_RPC_SS_CONTEXT_MISMATCH instead of NT_STATUS_NET_WRITE_FAULT
metze
Stefan Metzmacher [Mon, 12 Apr 2010 12:10:24 +0000 (14:10 +0200)]
s4:librpc/rpc/pyrpc.c: map NT_STATUS_NET_WRITE_FAULT to the matching NT_STATUS_RPC_* code
metze
Stefan Metzmacher [Mon, 29 Mar 2010 20:35:37 +0000 (22:35 +0200)]
pidl:Samba4/NDR/Client: map NT_STATUS_NET_WRITE_FAULT to the matching NT_STATUS_RPC_* code
metze
Stefan Metzmacher [Sat, 20 Mar 2010 10:31:55 +0000 (11:31 +0100)]
librpc/rpc: add dcerpc_fault_to_nt_status()
For now this only handles fault codes with we've seen yet
and for which we have explicit torture checks.
metze
Stefan Metzmacher [Tue, 13 Apr 2010 07:38:03 +0000 (09:38 +0200)]
s4:torture/rpc: don't look at p->last_fault_code for debugging anymore
metze
Stefan Metzmacher [Tue, 13 Apr 2010 07:14:14 +0000 (09:14 +0200)]
s4:util/net/drs: don't look at p->last_fault_code for debugging anymore
metze
Stefan Metzmacher [Tue, 13 Apr 2010 07:12:52 +0000 (09:12 +0200)]
s4:libnet/libnet_join: don't look at p->last_fault_code for debugging anymore
metze
Stefan Metzmacher [Thu, 15 Apr 2010 07:29:33 +0000 (09:29 +0200)]
s4:winbind: use WINBINDD_SOCKET_NAME instead of WINBINDD_SAMBA3_SOCKET
metze
Stefan Metzmacher [Thu, 15 Apr 2010 07:24:56 +0000 (09:24 +0200)]
s4:winbind: wbsrv_samba3_priv_pipe_dir() needs to return the directory not the pipe path
metze
Stefan Metzmacher [Thu, 15 Apr 2010 06:28:20 +0000 (08:28 +0200)]
s4:selftest/wscript: --enable-selftest and --with-selftest-prefix are configure options
metze
Andrew Tridgell [Thu, 15 Apr 2010 04:43:43 +0000 (14:43 +1000)]
build: throw a fatal error for duplicate target declarations
We don't want someone to declare two subsystems of the same name but
with different source files
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 15 Apr 2010 04:42:13 +0000 (14:42 +1000)]
s4-waf: removed a duplicate declaration of python_netbios
Andrew Tridgell [Thu, 15 Apr 2010 03:59:51 +0000 (13:59 +1000)]
build: ensure we don't recreate library loops in expansions
after removing library loops from the dependeny graph, we re-add
parent dependencies. We need to ensure that we don't re-add a
dependency which re-creates the loop we so carefully removed.
This also adds a final check for library dependency loops, and shows
an appropriate error if one is found.
Andrew Tridgell [Wed, 14 Apr 2010 23:14:10 +0000 (09:14 +1000)]
build: make the 'wrong version of waf' message even clearer
suggest ./autogen-waf.sh
Andrew Tridgell [Wed, 14 Apr 2010 22:55:26 +0000 (08:55 +1000)]
build: check that the user is not using an old /usr/bin/waf
some systems have /usr/bin/waf installed, and its quite old
Volker Lendecke [Wed, 14 Apr 2010 19:48:38 +0000 (21:48 +0200)]
s3: Fix a typo
Stefan Metzmacher [Tue, 13 Apr 2010 20:06:51 +0000 (22:06 +0200)]
s4:torture/rpc: rename rpc.h => torture_rpc.h
The reason for this is that some systems include
<rpc/rpc.h> from within system headers. HP-UX 11.00
does so somewhere deep inside of <shadow.h>.
For torture/winbind/struct_based.c <rpc/rpc.h> resolves
to torture/rpc/rpc.h and breaks the build.
metze
Andrew Tridgell [Wed, 14 Apr 2010 13:38:05 +0000 (23:38 +1000)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Wed, 14 Apr 2010 13:37:47 +0000 (23:37 +1000)]
build: try to honor MAKEFLAGS from make
This means "make -j" and "make -k" now do roughly what is expected
make -j will use the number of CPUs on the system, regardless of the
number after the -j (as MAKEFLAGS doesn't contain that value).
make -k will will continue on errors
Stefan Metzmacher [Tue, 13 Apr 2010 15:36:51 +0000 (17:36 +0200)]
s4:torture/rpc/winreg: fix compiler warnings
metze