Amitay Isaacs [Thu, 8 Sep 2011 04:44:44 +0000 (14:44 +1000)]
s4-provision: Add Seperate instructions for BIND 9.7.x and 9.8.x.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 06:20:00 +0000 (16:20 +1000)]
s4-provision: Enable SPNs for DNS
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Sun, 11 Sep 2011 15:31:38 +0000 (17:31 +0200)]
s4:samba-tool/domain.py - rename arguments "domain" -> "domain-level", "forest" -> "forest-level"
This should clarify the scope of them.
Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Sep 11 20:12:52 CEST 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Fri, 9 Sep 2011 13:27:25 +0000 (15:27 +0200)]
s4:samba-tool/domain.py - restore domain raise functionality
The samba-tool command has accidentally been damaged by commit
2d4988c3d79e501003875cd26b7f9aaa72402b31.
Reviewed-by: Jelmer
Matthias Dieter Wallnöfer [Wed, 22 Jun 2011 12:48:33 +0000 (14:48 +0200)]
ldb:ldb_controls.c - remove duplicate definition of "LDB_CONTROL_CMP"
And fix the comment
Reviewed-by: Jelmer
Matthias Dieter Wallnöfer [Tue, 21 Jun 2011 09:11:04 +0000 (11:11 +0200)]
ldb:pyldb.c - point out that "PyLdbResult_AsResult" does not convert everything
Reviewed-by: Jelmer
Andrew Bartlett [Sat, 10 Sep 2011 05:51:45 +0000 (15:51 +1000)]
lib/util/charset: the comparsion must be against our charset modules
There is little point testing this against the system iconv.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Sep 10 15:45:42 CEST 2011 on sn-devel-104
Andrew Bartlett [Sat, 10 Sep 2011 05:41:14 +0000 (15:41 +1000)]
lib/util/charset Use name of ISO-8859-1 that matches our internal implementation
Andrew Bartlett [Sat, 10 Sep 2011 03:23:22 +0000 (13:23 +1000)]
lib/util/charset: Improve toture assertions in iconv test
Andrew Bartlett [Fri, 9 Sep 2011 23:53:29 +0000 (09:53 +1000)]
lib/util/charset Run charset sets with and without the system iconv
We need to know that we can load the samba-provided modules, and that
they are correct. However, we must mark a number of tests as
knownfail due to errors in our internal iconv modules.
Andrew Bartlett
Andrew Bartlett [Fri, 9 Sep 2011 13:51:06 +0000 (23:51 +1000)]
lib/util/charset: add back loading of charset modules
For autoconf builds these remain as modules, for waf builds they are
built into the charset library.
This is required to provide the CP850 charset when iconv is not available.
The charset modules static for the waf builds because with proper
shared libs, there isn't the same need for these to be in seperate .so
files. The modules are also not produced if a system iconv is found,
except for developers, to allow testing of both code paths.
Andrew Bartlett
Stefan Metzmacher [Fri, 9 Sep 2011 20:43:28 +0000 (22:43 +0200)]
libcli/smb: s/FLAGS2_UNKNOWN_BIT4/FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Sep 10 00:34:50 CEST 2011 on sn-devel-104
Andrew Bartlett [Fri, 9 Sep 2011 02:44:56 +0000 (12:44 +1000)]
s4-s3-upgrade Do not use python 2.6 style exceptions
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Sep 9 08:54:16 CEST 2011 on sn-devel-104
Andrew Bartlett [Fri, 9 Sep 2011 02:08:54 +0000 (12:08 +1000)]
build: a more robust zlib test
Just in-case, and done this way due to the #define maze that applies
to this function. No actual host has been found that needs this yet.
Andrew Bartlett
Amitay Isaacs [Fri, 9 Sep 2011 03:27:13 +0000 (13:27 +1000)]
samba-tool: epilog option to OptionParser available in python >= 2.6
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Fri, 9 Sep 2011 03:26:04 +0000 (13:26 +1000)]
samba-tool: Provide feedback if synopsis is not defined for a command
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Fri, 9 Sep 2011 03:24:10 +0000 (13:24 +1000)]
samba-tool: max() with key option is available in python >= 2.6
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Fri, 9 Sep 2011 03:22:27 +0000 (13:22 +1000)]
samba-tool: Correctly handle sys.exit() called from subcommand
Catch SystemExit exception if any subcommand calls sys.exit()
and return with failure (-1).
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Fri, 2 Sep 2011 15:23:26 +0000 (11:23 -0400)]
samba-tool: Fixed "ldapcmp" command synopsis
Fixed "ldapcmp" command syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 30 Aug 2011 22:08:44 +0000 (18:08 -0400)]
samba-tool: Fixed "dbcheck" subcommand syntax
Fixed syntax for "dbcheck" subcommand
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Wed, 7 Sep 2011 15:11:38 +0000 (11:11 -0400)]
samba-tool: Moved _get_user_realm_domain fcn to common
_get_user_realm_domain is used by both delegation and spn commands
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 6 Sep 2011 17:41:41 +0000 (13:41 -0400)]
samba-tool: Fixed "testparm" syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 6 Sep 2011 17:35:00 +0000 (13:35 -0400)]
samba-tool: Fixed "user" command syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 6 Sep 2011 17:25:30 +0000 (13:25 -0400)]
samba-tool: Fixed "rodc" syntax
Remove options from syntax to be consistent w/ the rest of commands
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 6 Sep 2011 17:15:25 +0000 (13:15 -0400)]
samba-tool: Fixed "ntacl" subcommands syntax
Removed options from syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 6 Sep 2011 17:12:36 +0000 (13:12 -0400)]
samba-tool: Fixed "group" subcommands syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 6 Sep 2011 17:05:19 +0000 (13:05 -0400)]
samba-tool: Fixed "dsacl" command syntax
Removed option from syntax to be consistent w/ the rest of commands
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Fri, 2 Sep 2011 17:56:51 +0000 (13:56 -0400)]
samba-tool: Fixed "drs" subcommands syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Fri, 2 Sep 2011 17:21:49 +0000 (13:21 -0400)]
samba-tool: Fixed "domain" subcommands syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Fri, 2 Sep 2011 16:52:54 +0000 (12:52 -0400)]
samba-tool: Fixed "spn" command syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Fri, 2 Sep 2011 17:10:05 +0000 (13:10 -0400)]
samba-tool: Fixed "delegation" command syntax
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 30 Aug 2011 21:52:59 +0000 (17:52 -0400)]
samba-tool: Fixed "time" command synopsis
"server_name" is an optional parameter
added "options" parameter
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 30 Aug 2011 21:22:06 +0000 (17:22 -0400)]
samba-tool: Removed "acl" command
Removed "acl" command as it has been changed to:
"dsacl" and "ntacl"
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 30 Aug 2011 21:19:59 +0000 (17:19 -0400)]
samba-tool: Added "ntacl" command
Added "ntacl" command to substitute "acl nt" command
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 30 Aug 2011 21:09:53 +0000 (17:09 -0400)]
samba-tool: Added "dsacl" command
Added "dsacl" command to substitute "acl ds"
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 2 Aug 2011 22:05:54 +0000 (18:05 -0400)]
samba-tool: Changed fsmo implementation
Changed fsmo code to fit the object <action> model
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Tue, 2 Aug 2011 17:50:15 +0000 (13:50 -0400)]
samba-tool: Expanded acronym descriptions
Expanded command acronym descriptions
Added footnote for "server connection needed"
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Mon, 1 Aug 2011 21:47:31 +0000 (17:47 -0400)]
samba-tool: Formatted subcommand list output
Formatted output of subcommand list to be a function of the
max number of chars in the longest string
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Mon, 1 Aug 2011 18:45:18 +0000 (14:45 -0400)]
samba-tool: Moved command definition to sambatool command
Moved subcommand definition from __init__.py to cmd_sambatool class
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Fri, 29 Jul 2011 21:04:45 +0000 (17:04 -0400)]
samba-tool: Add long_description and epilog to Command class
long_description and epilog should now be defined for each command.
Their string value will be printed whenever the user invokes the
command w/ the -h or --help
long_desciption will be printed after the usage statement.
epilog will be printed after the options are defined
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Fri, 29 Jul 2011 01:44:06 +0000 (21:44 -0400)]
samba-tool: Redefined samba-tool as a SuperCommand
Removed MainCommand class as samba-tool is a SuperCommand
Redefined samba-tool as a SuperCommand
Fixed error handling in SuperCommand _run
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Fri, 29 Jul 2011 01:42:03 +0000 (21:42 -0400)]
samba-tool: Removed SuperCommand usage method
Removed usage method as it is not being used anywhere
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Giampaolo Lauria [Thu, 28 Jul 2011 18:21:40 +0000 (14:21 -0400)]
samba-tool: Removed attribute name from Command class
Removed name as it is not used anywhere
Moved all the attributes on top of the class declaration
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Fri, 9 Sep 2011 05:21:59 +0000 (15:21 +1000)]
s4-test: name attribute remove from Command class, so test not required
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Tue, 6 Sep 2011 12:09:47 +0000 (14:09 +0200)]
s3-spoolss: Fix bug #8351 forms migration.
Don't fail if the form already exists (or is builtin now).
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep 9 03:21:42 CEST 2011 on sn-devel-104
Andrew Bartlett [Thu, 8 Sep 2011 21:31:42 +0000 (07:31 +1000)]
s4-s3-upgrade do not convert min password length as a time
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Sep 9 01:53:55 CEST 2011 on sn-devel-104
Jeremy Allison [Thu, 8 Sep 2011 20:48:27 +0000 (13:48 -0700)]
Second part of fix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
Be smarter about setting default permissions when a ACL_USER_OBJ isn't given. Use the principle of least surprises for the user.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Sep 9 00:26:08 CEST 2011 on sn-devel-104
Jeremy Allison [Thu, 8 Sep 2011 19:51:18 +0000 (12:51 -0700)]
First part of fix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
create_default_mode() is not needed - it's taken care of by code
inside ensure_canon_entry_valid().
Jeremy Allison [Fri, 3 Jun 2011 21:28:33 +0000 (14:28 -0700)]
Fix bug #8203 - winbindd needs to reset the DC connection if an RPC times out.
Based on Volker's original code.
(cherry picked from commit
5b5ef7f20d34f4c6c1d3d02530ac7b13e051c960)
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 8 21:29:53 CEST 2011 on sn-devel-104
Stefan Metzmacher [Thu, 8 Sep 2011 07:56:16 +0000 (09:56 +0200)]
s3:torture: make use of CLI_FULL_CONNECTION_DONT_SPNEGO
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 8 19:23:32 CEST 2011 on sn-devel-104
Stefan Metzmacher [Thu, 8 Sep 2011 07:24:11 +0000 (09:24 +0200)]
s3:torture: make use of CLI_FULL_CONNECTION_FORCE_DOS_ERRORS
metze
Stefan Metzmacher [Thu, 8 Sep 2011 07:49:26 +0000 (09:49 +0200)]
s3:libsmb: add CLI_FULL_CONNECTION_FORCE_ASCII
metze
Stefan Metzmacher [Thu, 8 Sep 2011 07:18:45 +0000 (09:18 +0200)]
s3:libsmb: add CLI_FULL_CONNECTION_FORCE_DOS_ERRORS
metze
Stefan Metzmacher [Thu, 8 Sep 2011 15:26:30 +0000 (17:26 +0200)]
s3:libsmb: don't handle CLI_FULL_CONNECTION_* flags in cli_full_connection()
This is already done by cli_state_create().
metze
Stefan Metzmacher [Thu, 8 Sep 2011 15:26:30 +0000 (17:26 +0200)]
s3:libsmb: don't handle CLI_FULL_CONNECTION_* flags in cli_start_connection()
This is already done by cli_state_create().
metze
Andrew Bartlett [Thu, 8 Sep 2011 11:41:12 +0000 (21:41 +1000)]
s4-param void function cannot return value
This is even if the returned function is void, on Solaris.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Sep 8 16:38:30 CEST 2011 on sn-devel-104
Andrew Tridgell [Tue, 26 Jul 2011 02:21:00 +0000 (12:21 +1000)]
s3-loadparm: fixed re-application of cmdline parametric options
this ensures that cmdline parametric options are re-applied when we
reload smb.conf
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 02:19:58 +0000 (12:19 +1000)]
s3-loadparm: fixed a memory leak in parametric options
before we memset the Globals structure we need to free any global
parametrics
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 01:01:36 +0000 (11:01 +1000)]
nsswitch: make the wbcSidsToUnixIds() parser more robust
this allows it to handle new types of responses
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 00:52:59 +0000 (10:52 +1000)]
s4-winbindd: implement WINBINDD_SIDS_TO_XIDS
this fixes wbinfo --sids-to-unix-ids
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 00:51:31 +0000 (10:51 +1000)]
s4-winbindd: fixed handling of extra_data in s3 requests
extra_data in s3 winbind requests is appended to the end of the
request, but does not change the length header of the packet. Instead
you need to get it from the extra_len element of the request
structure.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 26 Jul 2011 00:50:22 +0000 (10:50 +1000)]
s4-winbind: added count argument to wb_sids2xids_recv()
this allows callers to know how many SIDs were mapped
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Volker Lendecke [Thu, 8 Sep 2011 11:15:21 +0000 (13:15 +0200)]
s3: Fix a debug message
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Sep 8 15:08:43 CEST 2011 on sn-devel-104
Volker Lendecke [Thu, 8 Sep 2011 10:01:42 +0000 (12:01 +0200)]
s3: Fix a typo
Andrew Bartlett [Thu, 8 Sep 2011 09:07:47 +0000 (19:07 +1000)]
build: Add duplicate symbol checking as part of make test
This ensures we do not get duplicate symbols again, when run as
./configure.developer on non-build farm machines.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Sep 8 13:37:40 CEST 2011 on sn-devel-104
Andrew Bartlett [Thu, 8 Sep 2011 07:14:44 +0000 (17:14 +1000)]
build: netapi does not depend on TOKEN_UTIL
This means we avoid dupliate symbols between libgpo and netapi.
Andrew Bartlett
Andrew Bartlett [Thu, 8 Sep 2011 07:10:27 +0000 (17:10 +1000)]
build: make LIBWBCLIENT_OLD and auth_unix_token libraries
This assists with avoiding duplicate symbols.
Andrew Bartlett
Andrew Bartlett [Thu, 8 Sep 2011 07:09:47 +0000 (17:09 +1000)]
librpc: put NDR_NTPRINTING into ndr-samba grouping library
This assists with avoiding duplicate symobls now that ntprinting_migrate is a library.
Andrew Bartlett
Andrew Bartlett [Thu, 8 Sep 2011 07:08:52 +0000 (17:08 +1000)]
libgpo: call security_token_has_sid() directly
Stefan Metzmacher [Wed, 7 Sep 2011 18:35:51 +0000 (20:35 +0200)]
s3:libsmb: pass CLI_FULL_CONNECTION_* flags via cli_connect_nb()
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Sep 8 10:21:50 CEST 2011 on sn-devel-104
Stefan Metzmacher [Wed, 7 Sep 2011 19:10:24 +0000 (21:10 +0200)]
s3:libsmb: pass CLI_FULL_CONNECTION_* flags to cli_state_create()
metze
Stefan Metzmacher [Thu, 8 Sep 2011 06:01:30 +0000 (08:01 +0200)]
lib/replace: include <sys/uio.h> in "system/filesys.h" in order to have struct iovec
This is needed on some platforms, e.g. NetBSD5.
metze
Jeremy Allison [Thu, 8 Sep 2011 05:18:18 +0000 (22:18 -0700)]
Revert "Part 4 of bugfix for bug #7509 - smb_acl_to_posix: ACL is invalid for set (Invalid argument)"
This belongs as part of the bugfix for bug #8443 - Default user entry is set to minimal permissions on incoming ACL change with no user specified.
Not as part of #7509.
This reverts commit
2a1453e2318af77a79180f3137f8a8d3f1240233.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 8 08:50:12 CEST 2011 on sn-devel-104
Andrew Tridgell [Wed, 7 Sep 2011 07:18:24 +0000 (17:18 +1000)]
s4-cracknames: use consistent search for crossRef objects
This matches the search in other places
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Sep 8 05:02:54 CEST 2011 on sn-devel-104
Andrew Tridgell [Wed, 7 Sep 2011 07:12:37 +0000 (17:12 +1000)]
pidl: adjust expected output for new flag checking
Andrew Tridgell [Wed, 7 Sep 2011 06:25:48 +0000 (16:25 +1000)]
s4-dsdb: prevent crash on bad DN in construct_parent_guid()
this was found by a flakey test in autobuild
Andrew Tridgell [Wed, 7 Sep 2011 05:37:22 +0000 (15:37 +1000)]
torture-drs: fixed NDR tests for DRS blobs
this also adds new tests for trustAuthInOutBlob blobs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:36:57 +0000 (15:36 +1000)]
torture-ndr: fixed NDR tests for NTLMSSP blobs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:36:38 +0000 (15:36 +1000)]
torture-ndr: fixed NDR tests for NBT blobs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:36:22 +0000 (15:36 +1000)]
torture-ndr: fixed NDR tests for DFS blobs
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:35:55 +0000 (15:35 +1000)]
torture-ndr: added support for testing push functions
this allows us to check the symmetry of pull/push functions in NDR
tests
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:34:43 +0000 (15:34 +1000)]
pidl: added checking of NDR flags in generated code
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:34:20 +0000 (15:34 +1000)]
libndr: add checking to all pull/push functions of base types
this checks that the passed in ndr_flags are valid
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:29:32 +0000 (15:29 +1000)]
libndr: moved the NDR_* flags to have less overlap
We have 3 different types of flags values in our NDR layer. We've
recently found bugs where these types of flags have been mixed up,
especially by people adding hand written ndr code for tricky
structures. We previously got away with this because (for example)
NDR_SCALARS and NDR_IN had the same value, so mixing up the two
concepts sometimes worked. Unfortunately it also led to bugs where we
didn't do what was expected, such as in our smbtorture ndr test suite,
where passing a ndr_flags value of zero led to only checking that two
empty structures were equal.
This changes the values of the NDR_IN|NDR_OUT and
NDR_SCALARS|NDR_BUFFERS values to be in different bit ranges, and adds
macros for checking the validity of passed in flags. A followup patch
modifies the ndr calls to use these macros, and pidl to generate
them. This should catch misuse of the APIs.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 7 Sep 2011 05:28:42 +0000 (15:28 +1000)]
lib: added base64_decode_data_blob_talloc()
its nice to be able to allocate on other than NULL
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 5 Sep 2011 07:07:22 +0000 (17:07 +1000)]
s4-dsdb: fixed compiler warning
sid can be const
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Jeremy Allison [Wed, 7 Sep 2011 21:57:11 +0000 (14:57 -0700)]
Tidy up previous patch for bug #8442 - NFSv4 DENY ACLs always include SYNCHRONIZE flag - blocking renames.
aceType is an enum field, not a bitmask.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 8 03:34:39 CEST 2011 on sn-devel-104
Amitay Isaacs [Tue, 6 Sep 2011 06:22:45 +0000 (16:22 +1000)]
s4-provision: Fill msDS-NC-Replica-Locations attribute in DNS provisioning
This attribute is required by the hosting requirement.
[MS_ADTS].pdf 7.1.2.3.1 DC and Application NC Replica
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Sep 8 02:04:51 CEST 2011 on sn-devel-104
Amitay Isaacs [Mon, 5 Sep 2011 06:19:37 +0000 (16:19 +1000)]
s4-provision: Make DNS entries consistent with dns_update script
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 06:19:02 +0000 (16:19 +1000)]
s4-provision: Reworked DNS provisioning to support AD DNS schema
This changes configure DNS partitions used by AD DNS and populate
with relevant entries. This has an advantage that Windows can
replicate these partitions and set up dns server using them.
In addition, these partitions are used by bind9_dlz module to query
zone information directly and do not need to create text database
for dynamic zones.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 06:11:57 +0000 (16:11 +1000)]
s4-provision: LDIF files to set up AD DNS schema
This files set up DomainDnsZones and ForestDnsZones partitions and
other configuration parameters for replication.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 06:09:59 +0000 (16:09 +1000)]
s4-provision: Add DNS backend option to provision
This option is introduced temporarily to test bind9 backend with
and without dlz_dlopen module.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 05:52:53 +0000 (15:52 +1000)]
s4-provision: exit is not imported directed, use sys.exit
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Amitay Isaacs [Mon, 5 Sep 2011 05:48:27 +0000 (15:48 +1000)]
s4-provision: Extract dns account creation as separate ldif
MicrosoftDNS container and LDAP entries for root servers will be
added by sambadns.py directly.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Jelmer Vernooij [Wed, 7 Sep 2011 18:31:05 +0000 (20:31 +0200)]
samba-tool: Avoid use of "except .. as" construction introduced in python2.6.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Sep 8 00:34:22 CEST 2011 on sn-devel-104
Ira Cooper [Wed, 7 Sep 2011 19:24:22 +0000 (12:24 -0700)]
Fix bug #8442 - NFSv4 DENY ACLs always include SYNCHRONIZE flag - blocking renames.
Thanks to Youzhong Yang for discovering this issue.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Sep 7 22:56:06 CEST 2011 on sn-devel-104
Michael Adam [Wed, 7 Sep 2011 15:38:42 +0000 (17:38 +0200)]
s3:winbind: put winbindd_cache into the state dir, not the cache dir
Despite the name, in winbind offline logon mode, this is a database
that contains valuable information and should not be cleared.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Sep 7 21:17:37 CEST 2011 on sn-devel-104
Gregor Beck [Mon, 5 Sep 2011 15:07:37 +0000 (17:07 +0200)]
s3:dbwrap_ctdb: improve error message in transaction destructor
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Wed, 31 Aug 2011 08:19:18 +0000 (10:19 +0200)]
s3: let g_lock_unlock() return more specific status codes on failure
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Wed, 7 Sep 2011 16:08:50 +0000 (18:08 +0200)]
s3: Fix Coverity ID 2611, UNINIT
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Sep 7 19:47:49 CEST 2011 on sn-devel-104