John Terpstra [Thu, 16 Jan 2003 05:35:11 +0000 (05:35 +0000)]
Added NT4 Profile Modification Docs, updated Win2K version.
NOTE: These documents are place holders for a REAL document.
Andrew Bartlett [Thu, 16 Jan 2003 04:40:07 +0000 (04:40 +0000)]
(missed in last commit)
Change the 'cookie' to be the ntlmssp_context, and use the 'auth_context' on
that to store the cookie. Ensures that simple callbacks can 'just work'.
Also make it clear that we are doing a pull_string into a pstring, not just
any sized buffer.
Andrew Bartlett
Andrew Tridgell [Thu, 16 Jan 2003 04:14:59 +0000 (04:14 +0000)]
allow a couple of LSA functions to take a username instead of a SID,
They still accept a SID, it just can be tedious to have to type SIDs
instead of names all the time.
Andrew Bartlett [Thu, 16 Jan 2003 03:32:55 +0000 (03:32 +0000)]
Add LIBSMB_OBJ for the new ntlm_auth functionality.
Andrew Bartlett
Andrew Bartlett [Thu, 16 Jan 2003 03:29:54 +0000 (03:29 +0000)]
Updates to the NTLMSSP code again - moving the base64 decode fuctionality out
of the SWAT code, and adding a base64 encoder.
The main purpose of this patch is to add NTLMSSP support to 'ntlm_auth', for
use with Squid. Unfortunetly the squid side doesn't quite support what we need
yet.
Changes to winbind to get us the info we need, and a couple of consequential
changes/cleanups in the rest of the code.
Andrew Bartlett
Jeremy Allison [Thu, 16 Jan 2003 02:58:25 +0000 (02:58 +0000)]
More Heimdal changes. Still not compiling with Heimdal yet...
Jeremy.
Jeremy Allison [Thu, 16 Jan 2003 02:39:58 +0000 (02:39 +0000)]
Fist part of fixes to make us compile with Heimdal. Don't explicitly
detect for now, I still have vague hopes of hiding the differences
between MIT and Heimdal with a compatibility layer....
Jeremy.
Gerald Carter [Thu, 16 Jan 2003 02:20:27 +0000 (02:20 +0000)]
* merge fixes for SGML syntax errors (does no one ever regenerate the docs?)
* regenerate the docs
* add some files from SAMBA_3_0
Andrew Bartlett [Thu, 16 Jan 2003 02:02:23 +0000 (02:02 +0000)]
Fix a signed/unsigned warning.
Jeremy Allison [Thu, 16 Jan 2003 00:27:30 +0000 (00:27 +0000)]
Add mutex protection around auth calls.
Jeremy.
Gerald Carter [Wed, 15 Jan 2003 23:11:45 +0000 (23:11 +0000)]
s/WIFSIGNALLED/WIFSIGNALED/g
Gerald Carter [Wed, 15 Jan 2003 22:37:16 +0000 (22:37 +0000)]
do not use RCS variables in file
Gerald Carter [Wed, 15 Jan 2003 22:19:03 +0000 (22:19 +0000)]
add ntlogon directory and files from 3.0
Tim Potter [Wed, 15 Jan 2003 22:15:07 +0000 (22:15 +0000)]
Removed level 0 DEBUG leftover from testing.
Andrew Bartlett [Wed, 15 Jan 2003 20:39:33 +0000 (20:39 +0000)]
Missed auth_ntlmssp.c in last night's checkin. Also keep track of the current
challenge in the NTLMSSP context.
Andrew Bartlett
Gerald Carter [Wed, 15 Jan 2003 19:00:44 +0000 (19:00 +0000)]
remove torture tools on make clean
Gerald Carter [Wed, 15 Jan 2003 18:31:46 +0000 (18:31 +0000)]
small merges from SAMBA_3_0; mostly typos, renames, etc...
Herb Lewis [Wed, 15 Jan 2003 16:44:35 +0000 (16:44 +0000)]
initialize acct_ctrl before using it
remove ldap_msgfree(result); as result is unitialized at this point
Gerald Carter [Wed, 15 Jan 2003 16:07:14 +0000 (16:07 +0000)]
* removed unused variable from rpcclient code
* added container option to net command (patch from SuSE)
* Makefile patch for examples/VFS from SuSE
Andrew Bartlett [Wed, 15 Jan 2003 12:52:38 +0000 (12:52 +0000)]
Refactor the NTLMSSP code again - this time we use function pointers to
eliminate the dependency on the auth subsystem. The next step is to add
the required code to 'ntlm_auth', for export to Squid etc.
Andrew Bartlett
Andrew Bartlett [Wed, 15 Jan 2003 12:48:06 +0000 (12:48 +0000)]
Doing a malloc(strlen(s)) then a pstrpcp(y, s) is just silly, make it a strdup
instead.
Andrew Bartlett
Andrew Tridgell [Wed, 15 Jan 2003 07:40:40 +0000 (07:40 +0000)]
added cli_lsa_enum_account_rights() call. Note that this is in
principal similar to the existing cli_lsa_enum_privsaccount() call,
except that cli_lsa_enum_account_rights() doesn't require a call to
open_account first. There is also the minor matter that
cli_lsa_enum_account_rights() works whereas
cli_lsa_enum_privsaccount() doesn't!
this call can be used to find what privileges an account or group
has. This is a first step towards proper privileges support in Samba.
Andrew Bartlett [Wed, 15 Jan 2003 05:56:12 +0000 (05:56 +0000)]
Fix warnings by getting the function into a shape the autoprototyper will
read, and add a static.
Andrew Bartlett
Andrew Bartlett [Wed, 15 Jan 2003 05:55:22 +0000 (05:55 +0000)]
Crash fixes:
- fix a crash when a second NTLMSSP session tried to free the first
- fix a crash due to some NULL pointers in the Add Printer Wizard (or read
printer code too it appears). As far as I can tell it's just that the
GUID just might not exist.
Andrew Bartlett
Martin Pool [Wed, 15 Jan 2003 05:27:33 +0000 (05:27 +0000)]
One more from waitpid() audit: Correctly interpret waitstatus when a
child fails. Possibly this was causing smbmount to exit(0) when it
really should have indicated a failure.
Martin Pool [Wed, 15 Jan 2003 05:23:40 +0000 (05:23 +0000)]
Run autoheader
Martin Pool [Wed, 15 Jan 2003 05:00:04 +0000 (05:00 +0000)]
Fix bug where the existence of config.cache would cause functions like
yp_get_default_domain to be misdetected.
According to the autoconf manual we need to check for libraries before
looking for functions in them.
Herb Lewis [Wed, 15 Jan 2003 01:05:35 +0000 (01:05 +0000)]
IRIX uses libns_winbind.so instead of libnss_winbind.so
Gerald Carter [Tue, 14 Jan 2003 23:55:14 +0000 (23:55 +0000)]
[merge] removing unused variable and unused file
Andrew Bartlett [Tue, 14 Jan 2003 23:45:14 +0000 (23:45 +0000)]
Fix some debug lines, and add a bit more info to help track down ldap
connectivity problems.
Andrew Bartlett
Gerald Carter [Tue, 14 Jan 2003 16:03:27 +0000 (16:03 +0000)]
merge: disable [u|g]idPool objects
Gerald Carter [Tue, 14 Jan 2003 15:52:45 +0000 (15:52 +0000)]
make -i flag work lik eit did in 2.2
Andrew Bartlett [Tue, 14 Jan 2003 06:53:35 +0000 (06:53 +0000)]
Commit my (disabled) fstring/pstring mixup detection code.
We need to fix some 'overmalloc' cases before it can be enabled by default.
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jan 2003 06:46:14 +0000 (06:46 +0000)]
The last of the fstring/pstring mixups, and an extra 'static'.
Andrew Bartlett [Tue, 14 Jan 2003 06:36:40 +0000 (06:36 +0000)]
A couple more pstcpy/fstrcpy mixups - doing an fstrcpy into a pstring is
harmless, but breaks my automated check.
Tim Potter [Tue, 14 Jan 2003 05:25:08 +0000 (05:25 +0000)]
Added comment about a SMB_ASSERT()
Tim Potter [Tue, 14 Jan 2003 05:08:42 +0000 (05:08 +0000)]
Remove wrapper function _get_trust_account_password() as it doesn't
seem to do anything useful anymore other than call
secrets_fetch_trust_account_password().
Tim Potter [Tue, 14 Jan 2003 04:04:13 +0000 (04:04 +0000)]
Added a comment in case anyone is thinking of doing a SMB_ASSERT in winbindd.
Andrew Tridgell [Tue, 14 Jan 2003 02:51:37 +0000 (02:51 +0000)]
query_alt_name takes a forced unicode string in win2000. It is not
null terminated.
Thanks to Metze for finding this.
Andrew Tridgell [Tue, 14 Jan 2003 00:39:18 +0000 (00:39 +0000)]
clearer debug message when the user is already in the ldap db
Andrew Tridgell [Tue, 14 Jan 2003 00:35:38 +0000 (00:35 +0000)]
add help text for 'net ads lookup'
Jeremy Allison [Mon, 13 Jan 2003 23:07:28 +0000 (23:07 +0000)]
Missing indirect in final free.
Jeremy.
Andrew Bartlett [Mon, 13 Jan 2003 21:49:49 +0000 (21:49 +0000)]
Always initialise this variable - and don't set the 'must change now' if it was
last changed at '0'.
We need to actually change this password sometime...
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 21:48:52 +0000 (21:48 +0000)]
Fix typo, and the build.
Richard Sharpe [Mon, 13 Jan 2003 20:30:28 +0000 (20:30 +0000)]
Make sure that those cleanups actually went in.
Andrew Bartlett [Mon, 13 Jan 2003 13:11:36 +0000 (13:11 +0000)]
Patch from metze to add what he feels is the correct semantics for a Domain
Controller. As we have had a number of attempts at this over the last little
while, I need to get my test rig going, and give this whole area a poke...
Meanwhile, if you want to use this, just adjust your 'auth methods' line to use
samstrict_dc...
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 13:03:25 +0000 (13:03 +0000)]
Patch from metze to to make testparm show values for 'workgroup', 'netbios
name' and 'netbios scope'. Probably has a similar effect on SWAT.
Also adds '-V' to testparm.
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 12:54:59 +0000 (12:54 +0000)]
Patch from ab, to make findsmb omit -r most of the time.
(original mail follows)
--
From: Alexander Bokovoy <a.bokovoy@sam-solutions.net>
Greetings!
I propose to make an optional argument '-r' for findsmb utility to pass
'-r' option to nmblookup optionally and default to omit it. The reason is
to have findsmb working more user-friendly in contemporary office
environments where Windows 95/98 boxes are rare and also to allow usage of
the utility under non-priviledged accounts when Windows95/98 boxes are in
minority or even absent in network neighbourhood.
An attached patch provides this change for HEAD together with
documentation changes.
--
/ Alexander Bokovoy
Andrew Bartlett [Mon, 13 Jan 2003 12:48:37 +0000 (12:48 +0000)]
Updates to our NTLMSSP code:
This tries to extract our server-side code out of sessetup.c, and into a more
general lib. I hope this is only a temporay resting place - I indend to
refactor it again into an auth-subsystem independent lib, using callbacks.
Move some of our our NTLMSSP #defines into a new file, and add two that I found
in the COMsource docs - we seem to have a double-up, but I've verified from
traces that the NTLMSSP_TARGET_TYPE_{DOMAIN,SERVER} is real.
This code also copes with ASCII clients - not that we will ever see any here,
but I hope to use this for HTTP, were we can get them. Win2k authenticates
fine under forced ASCII, btw.
Tested with Win2k, NTLMv2 and Samba's smbclient.
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 12:42:20 +0000 (12:42 +0000)]
Accessing data after it's been free()ed really is a no-no...
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 12:21:07 +0000 (12:21 +0000)]
Fix to debian bug #171071 - we had the wrong dereference on the pointer to be
Realloc()ed, causing it to fail.
Big thanks to Sandor Sonfeld <sonf@linuxmail.org> for the debug, stack and
valgrind traces!
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 08:53:54 +0000 (08:53 +0000)]
Don't force the DOS password into a 14 char space, as this would imply null
termination - the password will not be null terminated before hashing if
len >= 14.
related to debian bug #157432
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 08:09:32 +0000 (08:09 +0000)]
Ensure we do not pass uninitialised data to the kernel. (Picked up by
valgrind).
Andrew Bartlett
Martin Pool [Mon, 13 Jan 2003 04:57:21 +0000 (04:57 +0000)]
Fix typo in comment.
Tim Potter [Mon, 13 Jan 2003 03:45:31 +0000 (03:45 +0000)]
Merge ... remove "winbindd holding pattern" from appliance. It's a bit
simpler as the rescanning of trusted domains helps us out a bit.
Andrew Bartlett [Sun, 12 Jan 2003 12:23:37 +0000 (12:23 +0000)]
Keep all the const warnings in one place, by adding a utility function to
make the TDB_DATA.
Andrew Bartlett
Andrew Bartlett [Sun, 12 Jan 2003 11:31:03 +0000 (11:31 +0000)]
Oops, this is the change to use an fstring for the incoming service buffer -
the commit to reply.c just matches a pstrcpy for the pstring. (harmless, fixes
it for the automated test).
Andrew Bartlett
Andrew Bartlett [Sun, 12 Jan 2003 11:29:02 +0000 (11:29 +0000)]
Make the 'service' in make_connection() use an fstrcpy(), and an fstring,
becouse that is what it's input (reply_tcon_and_x) uses, and becouse we really
don't want supprises for service names.
Also remove a legacy #define, in favor of the lp_ equiv.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:33:00 +0000 (12:33 +0000)]
While the usage is most bisarre, this fixes up another fstring/pstring mixup.
(In this case, an fstrcpy() into a pstring, ie harmless).
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:24:19 +0000 (12:24 +0000)]
Use size_t for the counter vars, to match the type they are assigned from
(signed/unsigned mixup).
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:18:57 +0000 (12:18 +0000)]
A couple more fstring/pstring issues - and move from sizeof(fstring) to
sizeof(var) in slprintf statements, so as to ensure we don't get mixups there.
Also remove fstrcpy() into a variable that is about to be printed into anyway.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:13:03 +0000 (12:13 +0000)]
Remove an unused paramter for our old LM-only password change code, and fix a
(harmless) fstring/pstring mixup.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:04:14 +0000 (12:04 +0000)]
Fix a number of client-side fstring/pstring mixups.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 03:29:31 +0000 (03:29 +0000)]
Patch from Nik Conwell <nik@bu.edu>. Don't reference free()ed data when trying
to figure out if we have got our ticket yet.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 03:25:31 +0000 (03:25 +0000)]
Return the 'freindly' NT error message if at all possible.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 03:23:16 +0000 (03:23 +0000)]
No point having this for both parts of the 'if' statement.
Andrew Bartlett
Gerald Carter [Sat, 11 Jan 2003 02:36:13 +0000 (02:36 +0000)]
typo from merge
Gerald Carter [Sat, 11 Jan 2003 02:30:34 +0000 (02:30 +0000)]
fix tdb_append() prototype
Gerald Carter [Sat, 11 Jan 2003 02:29:23 +0000 (02:29 +0000)]
[merge] make sure to updatre print queue cache during timeout_processing() to send notify events; CR 1491
Jeremy Allison [Sat, 11 Jan 2003 00:17:37 +0000 (00:17 +0000)]
Added new message_send_pid() code that uses tdb append to reduce locking
contention on the messaging tdb.
Jeremy.
Jeremy Allison [Sat, 11 Jan 2003 00:07:40 +0000 (00:07 +0000)]
Added tdb_append() call. Efficiently adds to an entry. Used by new messaging
code. Also added torture tests for it.
Jeremy.
Jeremy Allison [Fri, 10 Jan 2003 20:17:06 +0000 (20:17 +0000)]
First part of efficiency fixes for message sending to pid's (cutting down
the amount of time we hold tdb locks). Gulp down all messages at once rather
than reading/re-writing one at a time. NOTE: All dispatch routines *must*
be able to cope with incoming message on *odd* byte boundaries (all current
handlers do).
Jeremy.
Jeremy Allison [Fri, 10 Jan 2003 19:59:18 +0000 (19:59 +0000)]
Fix lpq_cache time check (missed from yesterday).
Jeremy.
Gerald Carter [Thu, 9 Jan 2003 19:51:28 +0000 (19:51 +0000)]
a 0 length printer data value is not a memory allocation error; fix CR601
Martin Pool [Thu, 9 Jan 2003 07:23:23 +0000 (07:23 +0000)]
tdb_chainlock_with_timeout: Add TODO: If we time out waiting for a
lock, it might be nice to use F_GETLK to get the pid of the process
currently holding the lock and print that as part of the debugging
message.
I'd like to have this in appliance_head, but the code is too different
so I won't worry for now.
Tim Potter [Thu, 9 Jan 2003 06:58:07 +0000 (06:58 +0000)]
Remove read_with_timeout() and replaced its only caller (the passwd chat
stuff) with a call to read_socket_with_timeout() which does the same thing.
Passwd chat still works but I couldn't figure out the right arguments to
passwd chat to get it to work right but data was definitely getting
through.
Tim Potter [Thu, 9 Jan 2003 05:50:15 +0000 (05:50 +0000)]
Remove dead function.
Tim Potter [Thu, 9 Jan 2003 05:49:51 +0000 (05:49 +0000)]
Moved smbd process counting functions from smbd/server.c to smbd/process.c
so that bin/vfstest can link.
Martin Pool [Thu, 9 Jan 2003 01:16:12 +0000 (01:16 +0000)]
Correct misleading comment: winbindd_lookupname gets the SID for a
name, not vice versa.
Jeremy Allison [Wed, 8 Jan 2003 23:49:37 +0000 (23:49 +0000)]
Ensure we return disk full by default on short writes.
Jeremy.
Jeremy Allison [Wed, 8 Jan 2003 21:42:43 +0000 (21:42 +0000)]
Ensure we don't get an invalid number for total smbd's if the tdb update
fails.
Jeremy.
Herb Lewis [Wed, 8 Jan 2003 18:33:16 +0000 (18:33 +0000)]
reran autoconf
Richard Sharpe [Wed, 8 Jan 2003 17:59:52 +0000 (17:59 +0000)]
Some fixes to editreg. Clientgen should not be touched, and an update to configure that Herb needs.
Jeremy Allison [Wed, 8 Jan 2003 07:02:18 +0000 (07:02 +0000)]
Fix erroneous free of SAM_ACCOUNT (make clearer when allocated
memory is being returned).
Jeremy
Tim Potter [Wed, 8 Jan 2003 04:14:12 +0000 (04:14 +0000)]
Removed pointless null statement in signal handler.
Tim Potter [Wed, 8 Jan 2003 02:54:42 +0000 (02:54 +0000)]
Display an error message when the server cannot be resolved when running at
debug level 0.
Jeremy Allison [Wed, 8 Jan 2003 02:09:14 +0000 (02:09 +0000)]
Fix open problem with changing attributes on an existing file - based
on work by <steve@griffin.sio2.nl>.
Jeremy.
Volker Lendecke [Tue, 7 Jan 2003 20:54:31 +0000 (20:54 +0000)]
Fix memory leak. Thanks, Herb!
Volker
Herb Lewis [Tue, 7 Jan 2003 17:55:14 +0000 (17:55 +0000)]
this makes it compile, but I'm not sure if it is correct. Are we really
testing a pointer value to be equal to 0x19 ???
Herb Lewis [Tue, 7 Jan 2003 17:43:37 +0000 (17:43 +0000)]
cannot make assignments to const values.
Herb Lewis [Tue, 7 Jan 2003 17:33:30 +0000 (17:33 +0000)]
add and escape before $( in regex string so it is not interpreted as the
perl variable for "real gid of this process"
Volker Lendecke [Tue, 7 Jan 2003 10:38:33 +0000 (10:38 +0000)]
Create a machine account correctly if the unix account exists.
With this, my test for W2kSP3 join after pdbedit -a -m works fine.
Volker
Christopher R. Hertel [Tue, 7 Jan 2003 04:33:43 +0000 (04:33 +0000)]
Added code to the handling of the -M option to ensure that we default to
port 139 for that option. The NetBIOS Messenger Service doesn't run on
a non-NBT port.
Tim Potter [Tue, 7 Jan 2003 03:39:22 +0000 (03:39 +0000)]
Rename a local variable to avoid a warning.
Tim Potter [Tue, 7 Jan 2003 03:36:39 +0000 (03:36 +0000)]
'index' is the name of a libc function. Rename to 'ndx' to avoid compiler
warnings.
Tim Potter [Tue, 7 Jan 2003 03:31:52 +0000 (03:31 +0000)]
Remove unused variable.
Jeremy Allison [Mon, 6 Jan 2003 21:48:43 +0000 (21:48 +0000)]
Fix memory leaks in pdb_ code.
Jeremy.
Gerald Carter [Mon, 6 Jan 2003 18:00:18 +0000 (18:00 +0000)]
add $(LDFLAGS) to libsmbclient
Jeremy Allison [Mon, 6 Jan 2003 07:29:34 +0000 (07:29 +0000)]
Fix from "Ken Cross" <kcross@nssolutions.com> for enumerating
groups.
Jeremy.
Andrew Bartlett [Mon, 6 Jan 2003 06:15:34 +0000 (06:15 +0000)]
Fix a segfault when we don't correctly load a VFS module (don't keep it in
the loaded list on error). Also change some of the error returns, becouse
NT_STATUS_UNSUCCESSFUL gives a most useless error message on the client.
As for which error, my logic is that a share without a valid VFS module is
not a valid share, and therefore should return the same error as a non-existant
share.
Andrew Bartlett