Volker Lendecke [Wed, 16 Mar 2011 20:48:50 +0000 (21:48 +0100)]
s3: Fix Coverity ID 2233, REVERSE_INULL
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
Volker Lendecke [Wed, 16 Mar 2011 20:47:10 +0000 (21:47 +0100)]
s3: Fix Coverity ID 2234: REVERSE_INULL
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
Volker Lendecke [Wed, 16 Mar 2011 20:34:44 +0000 (21:34 +0100)]
s3: Fix Coverity ID 2140, DEADCODE
This routine was never executed after
f0dcc90f because "netname" was always
NULL.
Jeremy, please check!
Volker Lendecke [Wed, 16 Mar 2011 20:29:02 +0000 (21:29 +0100)]
s3: Fix Coverity ID 2144, DEADCODE
We could never have assigned the real value in line 481.
Andreas, please check!
Volker Lendecke [Wed, 16 Mar 2011 20:24:58 +0000 (21:24 +0100)]
s3: Fix Coverity ID 2147, FORWARD_NULL
How could this ever have worked???
Volker Lendecke [Wed, 16 Mar 2011 20:21:17 +0000 (21:21 +0100)]
s3: Fix Coverity ID 2148, FORWARD_NULL
Further down we unconditionally reference *info
Volker Lendecke [Wed, 16 Mar 2011 19:34:30 +0000 (20:34 +0100)]
s3: Fix Coverity ID 1402: PASS_BY_VALUE
There's no point in passing GROUP_MAP on the stack
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 16 Mar 2011 17:59:28 +0000 (18:59 +0100)]
s3: Fix Coverity ID 2213, PASS_BY_VALUE
There's little point to pass a copy of this structure on the stack.
Günther, please check!
Volker Lendecke [Wed, 16 Mar 2011 17:50:02 +0000 (18:50 +0100)]
s3: Fix Coverity ID 1012, CHECKED_RETURN
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
Volker Lendecke [Wed, 16 Mar 2011 17:50:02 +0000 (18:50 +0100)]
s3: Fix Coverity ID 1013, CHECKED_RETURN
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
Volker Lendecke [Wed, 16 Mar 2011 17:47:36 +0000 (18:47 +0100)]
s3: Fix Coverity ID 1017, CHECKED_RETURN
Günther, please check!
Volker Lendecke [Wed, 16 Mar 2011 17:45:50 +0000 (18:45 +0100)]
s3: Fix Coverity ID 1018, CHECKED_RETURN
Volker Lendecke [Wed, 16 Mar 2011 17:42:48 +0000 (18:42 +0100)]
s3: Fix Coverity ID 1034, CHECKED_RETURN
In all other places we check the result of secrets_init.
Volker Lendecke [Wed, 16 Mar 2011 16:55:37 +0000 (17:55 +0100)]
s3: Fix Coverity ID 2100, BAD_SIZEOF
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104
Volker Lendecke [Wed, 16 Mar 2011 16:19:13 +0000 (17:19 +0100)]
s3: Fix Coverity ID 2317: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Wed, 16 Mar 2011 16:19:13 +0000 (17:19 +0100)]
s3: Fix Coverity ID 2318: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Wed, 16 Mar 2011 16:17:47 +0000 (17:17 +0100)]
s3: Fix Coverity ID 2319: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Günther Deschner [Wed, 16 Mar 2011 15:54:31 +0000 (16:54 +0100)]
s4-smbtorture: use torture_assert in torture_samba3_rpc_sharesec().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 17:47:11 CET 2011 on sn-devel-104
Günther Deschner [Wed, 16 Mar 2011 15:41:28 +0000 (16:41 +0100)]
s4-smbtorture: use torture_fail and _assert in torture_samba3_rpc_getusername().
Guenther
Günther Deschner [Wed, 16 Mar 2011 15:32:09 +0000 (16:32 +0100)]
s4-smbtorture: remove explicit mem_ctx from torture_samba3_rpc_getusername().
Guenther
Günther Deschner [Thu, 24 Feb 2011 23:11:14 +0000 (00:11 +0100)]
s3-packet: only include packet.h where needed.
Guenther
Günther Deschner [Thu, 24 Feb 2011 22:51:28 +0000 (23:51 +0100)]
s3-interfaces: only include interfaces.h where needed.
Guenther
Günther Deschner [Thu, 24 Feb 2011 21:58:08 +0000 (22:58 +0100)]
s3-msdfs: avoid global inclusion of msdfs.h.
Guenther
Günther Deschner [Wed, 16 Mar 2011 15:20:58 +0000 (16:20 +0100)]
s4-smbtorture: use torture_assert in samr large-dc test.
Guenther
David Disseldorp [Wed, 9 Mar 2011 14:18:22 +0000 (15:18 +0100)]
s3-printing: fix memory leak in print_cups.c
As found by valgrind, tmp_pcap_cache is not freed following printer list
tdb update.
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Mar 16 16:37:58 CET 2011 on sn-devel-104
David Disseldorp [Wed, 9 Mar 2011 13:05:39 +0000 (14:05 +0100)]
s3-printing: remove duplicate cups response processing code
There is currently a lot of duplicate code included for processing
responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This
change splits this code into a separate function.
Signed-off-by: Andreas Schneider <asn@samba.org>
David Disseldorp [Tue, 8 Mar 2011 15:36:03 +0000 (16:36 +0100)]
s3-printing: use printcap IDL for IPC
Use printcap IDL for marshalling and unmarshalling messages between cups
child and parent smbd processes. This simplifies the IPC and ensures
the parent is notified of cups errors encountered by the child.
https://bugzilla.samba.org/show_bug.cgi?id=7994
Signed-off-by: Andreas Schneider <asn@samba.org>
David Disseldorp [Mon, 7 Mar 2011 14:32:02 +0000 (15:32 +0100)]
idl: define printcap IPC message format
Signed-off-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 16 Mar 2011 14:00:57 +0000 (15:00 +0100)]
s4-smbtorture: use torture_fail and _assert macros in torture_netlogon_samba3().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 15:51:12 CET 2011 on sn-devel-104
Günther Deschner [Wed, 16 Mar 2011 13:56:16 +0000 (14:56 +0100)]
s4-smbtorture: remove explicit mem_ctx from torture_netlogon_samba3().
Guenther
Günther Deschner [Wed, 16 Mar 2011 13:52:51 +0000 (14:52 +0100)]
s4-smbtorture: use torture_fail and _skip in raw.write test.
Guenther
Günther Deschner [Wed, 16 Mar 2011 13:51:30 +0000 (14:51 +0100)]
s4-smbtorture: remove duplicate if branch in raw.write test.
Guenther
Günther Deschner [Wed, 16 Mar 2011 12:27:38 +0000 (13:27 +0100)]
s4-smbtorture: use torture_fail/-assert api in torture_samba3_hide().
Guenther
Günther Deschner [Thu, 24 Feb 2011 10:56:08 +0000 (11:56 +0100)]
s3-build: stop including ldap and lber headers everywhere in the code.
Instead use new header smb_ldap.h where all LDAP API related things are handled,
while smbldap.h only deals with our smbldap_X() API.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104
Günther Deschner [Wed, 2 Mar 2011 13:03:30 +0000 (14:03 +0100)]
s3-includes: avoid global include of gssapi headers.
Guenther
Günther Deschner [Wed, 2 Mar 2011 13:00:23 +0000 (14:00 +0100)]
s3-libsmb: move smb encryption structs into own header.
Guenther
Günther Deschner [Thu, 24 Feb 2011 09:47:16 +0000 (10:47 +0100)]
libcli/security: move display_sec headers to own header file and add to
security.h grouping header.
Guenther
Stefan Metzmacher [Mon, 14 Mar 2011 07:37:31 +0000 (08:37 +0100)]
s4:ldb: don't install .pc files when building a private library
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Mar 16 09:58:22 CET 2011 on sn-devel-104
Andrew Tridgell [Wed, 16 Mar 2011 06:42:24 +0000 (17:42 +1100)]
headers: cope with non-system popt in test_headers
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Mar 16 09:09:40 CET 2011 on sn-devel-104
Andrew Tridgell [Wed, 16 Mar 2011 06:42:02 +0000 (17:42 +1100)]
headers: include Python.h first to avoid warnings
Volker Lendecke [Wed, 16 Mar 2011 06:31:48 +0000 (07:31 +0100)]
s3: Fix a cut&paste error in pdb_ads_connect
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 08:22:28 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 15 Mar 2011 08:30:22 +0000 (09:30 +0100)]
s3: Use jenkins hash for str_checksum, fix bug 8010
From the bugreport:
I have a folder with ~90 photos: IMG_XXXX.JPG where XXXX is a four digit
number, almost consecutive (photos from camera for one day).
Current implementation gives about 30 different checksums for this set of
files.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 16 01:15:41 CET 2011 on sn-devel-104
Andrew Tridgell [Tue, 15 Mar 2011 21:47:11 +0000 (08:47 +1100)]
libcli: openchange doesn't need these headers any more
thanks to Simo for pointing this out
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Mar 16 00:25:10 CET 2011 on sn-devel-104
Günther Deschner [Tue, 15 Mar 2011 21:51:58 +0000 (22:51 +0100)]
s3-build: try to silence annoying "Ignoring invalid value 'vlp' for parameter 'printing'"
warning on the buildfarm.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 23:38:43 CET 2011 on sn-devel-104
Günther Deschner [Tue, 15 Mar 2011 16:40:39 +0000 (17:40 +0100)]
s4-rap: remove last iconv_convenience traces from rap client and test code.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 22:01:51 CET 2011 on sn-devel-104
Günther Deschner [Tue, 15 Mar 2011 16:28:51 +0000 (17:28 +0100)]
s4-rap: decouple rap client code from torture binary, add new LIBCLI_RAP subsystem.
Guenther
Günther Deschner [Tue, 15 Mar 2011 15:35:58 +0000 (16:35 +0100)]
s4-smbtorture: check for username and computername presence in rap_netsessionenum test.
Guenther
Günther Deschner [Thu, 24 Feb 2011 09:46:55 +0000 (10:46 +0100)]
s3-libsmb: only include rap client when needed.
Guenther
Günther Deschner [Tue, 15 Mar 2011 10:32:03 +0000 (11:32 +0100)]
s3-build: share smbtorture4 build rules with s3-waf build.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 16:10:17 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 15 Mar 2011 10:19:57 +0000 (11:19 +0100)]
libwbclient: CID 2199 -- NULL pointer return
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 15 12:08:48 CET 2011 on sn-devel-104
Volker Lendecke [Tue, 15 Mar 2011 10:09:26 +0000 (11:09 +0100)]
s3: Fix Coverity ID 2278: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 10:08:12 +0000 (11:08 +0100)]
s3: Fix Coverity ID 2279: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 10:06:49 +0000 (11:06 +0100)]
s3: Fix Coverity ID 2280: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 10:05:48 +0000 (11:05 +0100)]
s3: Fix Coverity ID 2281: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 10:04:23 +0000 (11:04 +0100)]
s3: Fix Coverity ID 2282: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 10:02:57 +0000 (11:02 +0100)]
s3: Fix Coverity ID 2283: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
Volker Lendecke [Tue, 15 Mar 2011 10:00:13 +0000 (11:00 +0100)]
s3: Fix Coverity ID 2284: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
Volker Lendecke [Tue, 15 Mar 2011 09:58:55 +0000 (10:58 +0100)]
s3: Fix Coverity ID 2285: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
Volker Lendecke [Tue, 15 Mar 2011 09:56:37 +0000 (10:56 +0100)]
s3: Fix Coverity ID 2286: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 09:54:59 +0000 (10:54 +0100)]
s3: Fix Coverity ID 2287: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_CreateKey.
Volker Lendecke [Tue, 15 Mar 2011 09:52:49 +0000 (10:52 +0100)]
s3: Fix Coverity ID 2288: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
Volker Lendecke [Tue, 15 Mar 2011 09:49:00 +0000 (10:49 +0100)]
s3: Fix Coverity ID 2289: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
Volker Lendecke [Tue, 15 Mar 2011 09:47:02 +0000 (10:47 +0100)]
s3: Fix Coverity ID 2290: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteKey.
Volker Lendecke [Mon, 14 Mar 2011 20:47:18 +0000 (21:47 +0100)]
s3: Read uidNumber/gidNumber in pdb_ads_sid_to_id
Question: How shall we allocate those? Something like the rid allocator?
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 15 09:59:55 CET 2011 on sn-devel-104
Volker Lendecke [Mon, 14 Mar 2011 07:10:13 +0000 (08:10 +0100)]
s3: Remove some unused code
Volker Lendecke [Mon, 14 Mar 2011 07:09:21 +0000 (08:09 +0100)]
s3: "hex_encode" does the same as "binary_string"
Andrew Tridgell [Tue, 15 Mar 2011 03:43:24 +0000 (14:43 +1100)]
s4-rpc: added dcesrv_call_account_name()
this will be used by openchange
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 15 06:14:00 CET 2011 on sn-devel-104
Andrew Tridgell [Tue, 15 Mar 2011 03:05:42 +0000 (14:05 +1100)]
libcli: protect access_check.h against double inclusion
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 15 05:07:01 CET 2011 on sn-devel-104
Andrew Tridgell [Tue, 15 Mar 2011 02:56:46 +0000 (13:56 +1100)]
waf: ensure that MAKEFLAGS is set before parsing it
Andrew Tridgell [Tue, 15 Mar 2011 02:09:30 +0000 (13:09 +1100)]
build: added simple header handling for our libraries
we don't need header munging for tdb/talloc etc
Andrew Tridgell [Tue, 8 Mar 2011 05:44:17 +0000 (16:44 +1100)]
s3-waf: enable public_headers_allow_broken
Andrew Tridgell [Tue, 8 Mar 2011 05:43:49 +0000 (16:43 +1100)]
build: removed mkdir of public headers directory
not needed now that we have public_headers_allow_broken
Andrew Tridgell [Tue, 8 Mar 2011 05:42:42 +0000 (16:42 +1100)]
build: added public_headers_allow_broken option
the s3 waf build will use this to say that we should allow public
headers that contain references to non-public headers. In the s4 build
that is not allowed, but the s3 build does not yet have clean public
headers
Andrew Tridgell [Tue, 8 Mar 2011 02:01:21 +0000 (13:01 +1100)]
s3-waf: enable public header building in s3
Andrew Tridgell [Fri, 4 Mar 2011 06:11:33 +0000 (17:11 +1100)]
waf: auto-create include paths if needed
Andrew Tridgell [Fri, 4 Mar 2011 06:11:20 +0000 (17:11 +1100)]
waf: make mkdir_p() a bit more robust
Andrew Tridgell [Thu, 3 Mar 2011 07:06:00 +0000 (18:06 +1100)]
build: fixed cflags for test_header
when using system libraries, we need the right cflags
Andrew Tridgell [Thu, 3 Mar 2011 06:41:45 +0000 (17:41 +1100)]
waf: build headers in separate 'headers' build group
Andrew Tridgell [Thu, 3 Mar 2011 06:22:38 +0000 (17:22 +1100)]
build: force _SAMBA_BUILD_==4 to be true in public headers
for s4 public headers, this is always true
Andrew Tridgell [Thu, 3 Mar 2011 06:21:45 +0000 (17:21 +1100)]
ldb: only install headers if we are not building as a private lib
Andrew Tridgell [Thu, 3 Mar 2011 06:19:33 +0000 (17:19 +1100)]
lib: don't install public headers if a private library
for talloc/tevent/tdb, only install headers if we are doing a
standalone build
Andrew Tridgell [Thu, 3 Mar 2011 06:18:58 +0000 (17:18 +1100)]
waf: always generate public headers in the build tree
this allows us to properly test our public headers before install
Andrew Tridgell [Thu, 3 Mar 2011 05:34:57 +0000 (16:34 +1100)]
build: mark some private includes as OK in public headers
these are includes which are protected by #ifdefs which means they
don't get exposed to public users
Andrew Tridgell [Thu, 3 Mar 2011 05:34:13 +0000 (16:34 +1100)]
rpc: make ndr/ndr_svcctl.h public
this is used by public header gen_ndr/ndr_svcctl.h
Andrew Tridgell [Thu, 3 Mar 2011 05:33:12 +0000 (16:33 +1100)]
s4-rpc: make common/proto.h public
this is needed by public header common.h
Andrew Tridgell [Thu, 3 Mar 2011 05:32:39 +0000 (16:32 +1100)]
s4-policy: don't make s4 policy.h public
if we are going to make GPO headers public, it should be from libgpo/
Andrew Tridgell [Thu, 3 Mar 2011 05:31:00 +0000 (16:31 +1100)]
ldb: use include <> form for public headers
Andrew Tridgell [Thu, 3 Mar 2011 05:30:33 +0000 (16:30 +1100)]
waf: build substituted public headers in build tree
the bin/default/include/public directory will contain headers that are
ready to install
Andrew Tridgell [Thu, 3 Mar 2011 05:29:15 +0000 (16:29 +1100)]
lib: fixed header paths
this is a public header, and needs to use sane paths for the public
header creation
Andrew Tridgell [Thu, 3 Mar 2011 05:28:14 +0000 (16:28 +1100)]
talloc: use <talloc.h> not "talloc.h"
this ensures we use the right header
Andrew Tridgell [Thu, 3 Mar 2011 05:27:44 +0000 (16:27 +1100)]
tdb: use public_headers to install header files
Andrew Tridgell [Thu, 3 Mar 2011 05:27:26 +0000 (16:27 +1100)]
tdb: use system include style for system headers
Andrew Tridgell [Thu, 3 Mar 2011 02:23:13 +0000 (13:23 +1100)]
waf: moved header file handling into its own module
It is getting quite complex now, and shouldn't just be mixed in with
everything else
Andrew Tridgell [Mon, 28 Feb 2011 07:57:25 +0000 (18:57 +1100)]
build: added automated testing of our public headers
we generate test_headers.h, which includes all of our public headers,
and check it compiles
Andrew Tridgell [Mon, 28 Feb 2011 07:56:33 +0000 (18:56 +1100)]
build: added include/public to the list of include paths
this allows us to use the public name of any header in the source tree
Andrew Tridgell [Mon, 28 Feb 2011 07:56:05 +0000 (18:56 +1100)]
tevent: use public_headers for tevent.h
Andrew Tridgell [Mon, 28 Feb 2011 07:55:52 +0000 (18:55 +1100)]
talloc: use public_headers to install talloc.h and pytalloc.h
this allows them to be included in the test_headers.h generated header
Andrew Tridgell [Mon, 28 Feb 2011 07:55:12 +0000 (18:55 +1100)]
wafsamba: keep a list of public headers
this will be used to construct test_headers.h, for testing our public
headers
Andrew Tridgell [Mon, 28 Feb 2011 07:53:36 +0000 (18:53 +1100)]
wafsamba: don't follow symlinks outside the build tree
when computing stale files, don't follow symlinks that are not within
the build tree
Andrew Tridgell [Mon, 28 Feb 2011 07:52:36 +0000 (18:52 +1100)]
wafsamba: added global_include option
this allows you to disable the global include additions. We will use
this for testing our public headers without including any of the
source tree directories