Richard Sharpe [Sat, 31 Mar 2012 05:04:28 +0000 (22:04 -0700)]
Add an open and close method to samba.smb.SMB so we can open and close files.
Also, fix up some documentation.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Sun Apr 1 16:29:52 CEST 2012 on sn-devel-104
Volker Lendecke [Sat, 31 Mar 2012 11:37:20 +0000 (13:37 +0200)]
s3-aio-fork: Fix a segfault in vfs_aio_fork
aio_suspend does not signal the main process with a signal, it just waits. The
aio_fork module does not use the signal at all, it directly calls back into the
main smbd by calling smbd_aio_complete_aio_ex. This is an abstraction
violation, but the alternative would have been to use signals where they are
not needed. However, in wait_for_aio_completion this bites us: With aio_fork we
call handle_aio_completed twice on the same aio_ex struct: Once from the call
to handle_aio_completion within the aio_fork module and once from the code in
wait_for_aio_completion.
This patch fixes it in a pretty bad way by introducing flag variables and more
state. But the mid-term plan is to replace the posix aio calls from the vfs and
do pread_send/recv and pwrite_send/recv at the vfs layer, so this will
significantly change anyway.
Thanks to Kirill Malkin <kirill.malkin@starboardstorage.com> for reporting this
crash!
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Mar 31 15:25:55 CEST 2012 on sn-devel-104
Volker Lendecke [Sat, 31 Mar 2012 11:34:42 +0000 (13:34 +0200)]
s3-aio-fork: Fix aio_suspend event hierarchy
We end up here multiple times. There's no real point putting the events into
the child struct, at the end of this routine we need to free them anyway.
Volker Lendecke [Sat, 31 Mar 2012 08:37:15 +0000 (10:37 +0200)]
s3-aio-fork: Fix an alignment warning on OS/X
Richard Sharpe [Sat, 31 Mar 2012 05:02:25 +0000 (22:02 -0700)]
Make sure we claim that a DACL or SACL is present if the SD says so
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Sat Mar 31 09:34:36 CEST 2012 on sn-devel-104
Jeremy Allison [Sat, 31 Mar 2012 04:21:57 +0000 (21:21 -0700)]
Fix an IPv6 breakage I introduced by adding an strlcpy truncation check. Found by Matthieu Patou <mat@samba.org>.
The truncate of the strlcpy() here was a *desired* side effect.
strlcpy()/strlcat() should never be used like that. Be more
explicit about the truncation and don't use strlcpy here.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Mar 31 07:59:16 CEST 2012 on sn-devel-104
Jeremy Allison [Fri, 30 Mar 2012 19:23:07 +0000 (12:23 -0700)]
Fix bug #8831 - Inconsistent (with manpage) command-line switch for "help" in smbtree
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 30 22:59:53 CEST 2012 on sn-devel-104
Jeremy Allison [Fri, 30 Mar 2012 17:57:51 +0000 (10:57 -0700)]
Who would have guessed - checking returns from strlcat found a memory overwrite bug :-).
Jeremy Allison [Fri, 30 Mar 2012 00:13:07 +0000 (17:13 -0700)]
More strlcat/strlcpy truncate checks.
Kai Blin [Fri, 30 Mar 2012 15:19:48 +0000 (17:19 +0200)]
s4 dns: Allow updating PTR records.
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Fri Mar 30 19:26:52 CEST 2012 on sn-devel-104
Volker Lendecke [Fri, 30 Mar 2012 13:15:29 +0000 (15:15 +0200)]
s3: Avoid a crash with debug level 10
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Mar 30 16:52:16 CEST 2012 on sn-devel-104
Matthieu Patou [Fri, 30 Mar 2012 08:24:07 +0000 (01:24 -0700)]
ldb: Permit desactivation of autocomit for every ldb_xxx_ctrl function
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Fri Mar 30 11:59:09 CEST 2012 on sn-devel-104
Jeremy Allison [Wed, 28 Mar 2012 23:49:30 +0000 (16:49 -0700)]
Start to add truncate checks on all uses of strlcpy(). Reading lwn
has it's uses :-).
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 29 20:48:15 CEST 2012 on sn-devel-104
Jeremy Allison [Wed, 28 Mar 2012 22:09:47 +0000 (15:09 -0700)]
Based on code from Richard Sharpe <realrichardsharpe@gmail.com>,
ensure we don't crash on a NULL DACL.
Volker Lendecke [Thu, 29 Mar 2012 12:16:04 +0000 (14:16 +0200)]
s3: Fix a valgrind error
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Mar 29 15:50:13 CEST 2012 on sn-devel-104
Amitay Isaacs [Mon, 26 Mar 2012 22:44:59 +0000 (09:44 +1100)]
lib/tdb: Update ABI
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Thu Mar 29 13:12:46 CEST 2012 on sn-devel-104
Amitay Isaacs [Mon, 26 Mar 2012 22:44:33 +0000 (09:44 +1100)]
lib/tdb: Add/expose lock functions to support CTDB
This patch adds two lock functions used by CTDB to perform asynchronous
locking. These functions do not actually perform any fcntl operations,
but only increment internal counters.
- tdb_transaction_write_lock_mark()
- tdb_transaction_write_lock_unmark()
It also exposes two internal functions
- tdb_lock_nonblock()
- tdb_unlock()
These functions are NOT exposed in include/tdb.h to prevent any further
uses of these functions. If you ever need to use these functions, consider
using tdb2.
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Rusty Russell [Thu, 29 Mar 2012 04:28:33 +0000 (14:58 +1030)]
cast: make sure suncc sees a constant.
cast_const() et. al. are supposed to be a constant expression, so you can do things like:
static char *p = cast_const(char *, (const char *)"hello");
Unfortunately, a cast to intptr_t and arithmetic makes suncc reject it as
a constant expression. We need the cast, because (1) the expression could be
a void *, so we can't just add to it, and (2) gcc complains with -Wcast-qual
without it.
So instead of adding BUILD_BUG_OR_ZERO, we use a ? :, which keeps everyone happy.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
(Imported from CCAN commit
74859ab18b10aaf990848e49d7789ff5c6cf96c6)
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Thu Mar 29 08:18:57 CEST 2012 on sn-devel-104
Rusty Russell [Tue, 27 Mar 2012 05:10:45 +0000 (15:40 +1030)]
cast: test/compile_fail-cast_static.c should fail without COMPOUND_LITERALS.
It still gave a warning on gcc, because casting a char to a char* gives a warning. Not so on sun CC.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
(Imported from CCAN commit
6569a707d169a629e25e10710c760c8dc84525c7)
Rusty Russell [Mon, 26 Mar 2012 04:03:17 +0000 (14:33 +1030)]
tdb2: fix prototype in tdb1 code.
We were handing an int-returning function where we should hand an enum TDB_ERROR
returning function. Worse, it was returning 0/-1 instead of 0/TDB_ERR_*.
Fortunately, it's only compared against success, but the Solaris compiler
warns about it, and it's not correct anyway.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Amitay Isaacs [Wed, 28 Mar 2012 06:49:09 +0000 (17:49 +1100)]
s4-upgradedns: Make sure the attribute exists before accessing it
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Mar 28 10:27:40 CEST 2012 on sn-devel-104
Richard Sharpe [Wed, 28 Mar 2012 03:32:11 +0000 (20:32 -0700)]
Add DEBUG statements to show when access has been denied and why.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Wed Mar 28 07:07:26 CEST 2012 on sn-devel-104
Kai Blin [Tue, 27 Mar 2012 13:00:01 +0000 (15:00 +0200)]
s4 dns: Only do recursive queries when allowed/desired
If recursive queries are switched off in smb.conf or the client doesn't ask for
recursion, don't recurse.
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Tue Mar 27 17:39:26 CEST 2012 on sn-devel-104
Kai Blin [Tue, 27 Mar 2012 12:42:15 +0000 (14:42 +0200)]
s4 dns: Check smb.conf if we should allow recursion
Kai Blin [Tue, 27 Mar 2012 11:59:03 +0000 (13:59 +0200)]
s4 dns: Allow changing the dns operation flags in handlers
Kai Blin [Tue, 27 Mar 2012 11:36:16 +0000 (13:36 +0200)]
s4 dns: Only forward for zones we don't own
Kai Blin [Tue, 27 Mar 2012 06:42:22 +0000 (08:42 +0200)]
s4 dns: Forward questions we can't answer to another server
This makes use of libdns and currently hardcodes the forward server, but
it works. :)
Kai Blin [Mon, 26 Mar 2012 18:47:42 +0000 (20:47 +0200)]
s4 dns: Add a simple dns lookup helper
Kai Blin [Sun, 11 Mar 2012 09:13:51 +0000 (10:13 +0100)]
s4 dns: Add a simple async client library
Jelmer Vernooij [Sun, 25 Mar 2012 20:38:59 +0000 (21:38 +0100)]
selftest.py: Add get_interface.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Mar 27 00:32:48 CEST 2012 on sn-devel-104
Jelmer Vernooij [Mon, 26 Mar 2012 16:25:37 +0000 (18:25 +0200)]
ndr: Update ABI.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Mar 26 19:58:25 CEST 2012 on sn-devel-104
Jelmer Vernooij [Tue, 20 Mar 2012 01:31:02 +0000 (02:31 +0100)]
wafsamba: Cope with slight differences in gdb output regarding incomplete sequences.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=8820
Jelmer Vernooij [Sat, 24 Mar 2012 14:42:22 +0000 (15:42 +0100)]
Add ABI file for libndr.
Volker Lendecke [Mon, 26 Mar 2012 10:46:11 +0000 (12:46 +0200)]
s3: Pass filters explicitly through vfs notify watch
This removes a dependency on "struct notify_entry" and makes the nature of the
API more explicit. We depend upon the VFS module to mask out elements from
e->filter and e->subdir_filter that it took over to handle.
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Mar 26 17:45:44 CEST 2012 on sn-devel-104
Volker Lendecke [Mon, 26 Mar 2012 11:11:02 +0000 (13:11 +0200)]
s3: Fix a typo
Volker Lendecke [Mon, 26 Mar 2012 11:09:33 +0000 (13:09 +0200)]
s3: Rename a variable in inotify_watch for clarity
Volker Lendecke [Mon, 26 Mar 2012 11:00:53 +0000 (13:00 +0200)]
s3: Pass "filter" instead of "notify_entry" to inotify_map
This makes the potential modification a bit more obvious
SATOH Fumiyasu [Mon, 26 Mar 2012 10:13:12 +0000 (19:13 +0900)]
s3-docs: Prepend '/' to filename argument (Bug #8826)
Andrew Bartlett [Mon, 26 Mar 2012 01:06:39 +0000 (12:06 +1100)]
s4-dsdb: use constant-time search for descriptor -> get_last_structural_class()
The objectClass list is sorted at this point, as we are called below
the objectclass module here, or are working from a search result.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Mar 26 05:38:13 CEST 2012 on sn-devel-104
Richard Sharpe [Mon, 26 Mar 2012 00:27:11 +0000 (17:27 -0700)]
Fix the PyDoc comments in samba.smb.SMB and add a security_info argument to both get_acl and set_acl to allow the caller to specify what info is wanted. Defaults to 0 which means all info.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Mon Mar 26 04:05:25 CEST 2012 on sn-devel-104
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 10:44:02 +0000 (12:44 +0200)]
s4:ldap.py - re-introduce the "(dn=CN=ldaptestUSER3,CN=Users,DC=wallnoefer2,DC=local)" test
This syntax is not supported by Windows AD and should also be denied by
s4/LDB.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Mar 26 02:30:53 CEST 2012 on sn-devel-104
Matthias Dieter Wallnöfer [Wed, 26 Oct 2011 07:47:35 +0000 (09:47 +0200)]
LDB/s4 - deny the "(dn=...)" syntax on search filters when in AD mode
Achieve this by introducing a "disallowDNFilter" flag.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Tue, 25 Oct 2011 18:10:30 +0000 (20:10 +0200)]
LDB/s4 - do not use the "(dn=...)" syntax on filters anymore
Make it AD-compatible using "(distinguishedName=...)".
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Sun, 25 Mar 2012 21:35:23 +0000 (23:35 +0200)]
s4:ldap.py - test the already mentioned structural object class sorting behaviour
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Sun, 25 Mar 2012 21:25:01 +0000 (23:25 +0200)]
s4:dsdb - enhance "get_last_structural_class()" for optimisations
If the objectclass entry has been sorted before we are able to determine
the (last) structural or 88 object class in constant time.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Sun, 25 Mar 2012 20:51:51 +0000 (22:51 +0200)]
s4:objectclass LDB module - fix up the sorting in respect to structural or 88 objectclasses
Please have a look at MS-ADTS 3.1.1.1.4.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Sun, 25 Mar 2012 19:33:52 +0000 (21:33 +0200)]
s4:objectclass LDB module - clean up "objectclass_sort()"
Make it easier to comprehend
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Jelmer Vernooij [Sun, 25 Mar 2012 21:18:52 +0000 (23:18 +0200)]
s3-make: Fix build with new smb2_session file.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Mar 26 00:56:13 CEST 2012 on sn-devel-104
Jelmer Vernooij [Sun, 25 Mar 2012 15:15:42 +0000 (17:15 +0200)]
LIBCLI_SMB2: Depend on cli_smb_common rather than libsmb.
The latter pulls in a fair number of other libraries, including popt and the Samba registry library.
Jelmer Vernooij [Sun, 25 Mar 2012 15:14:56 +0000 (17:14 +0200)]
smb2: Move smb2cli session setup code to cli_smb_common.
Jelmer Vernooij [Sun, 25 Mar 2012 15:14:14 +0000 (17:14 +0200)]
libcli/smb: Stop generating unused proto file.
Jelmer Vernooij [Sat, 24 Mar 2012 20:18:55 +0000 (21:18 +0100)]
replace: Avoid DEBUG(), which is not available in libreplace.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Mar 25 00:13:59 CET 2012 on sn-devel-104
Jelmer Vernooij [Sat, 24 Mar 2012 20:17:56 +0000 (21:17 +0100)]
libreplace: Add usleep implementation.
Jelmer Vernooij [Sat, 24 Mar 2012 19:43:07 +0000 (20:43 +0100)]
use usleep rather than sys_usleep in various places, in anticipation of usleep moving to libreplace.
Jelmer Vernooij [Sat, 24 Mar 2012 19:17:08 +0000 (20:17 +0100)]
lib/util: Remove obsolete sys_getpid() and sys_fork().
The performance of these is minimal (these days) and they can return
invalid results when used as part of applications that do not use
sys_fork().
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 24 21:55:41 CET 2012 on sn-devel-104
Jelmer Vernooij [Sat, 24 Mar 2012 16:16:26 +0000 (17:16 +0100)]
lib/util: Allow calloc use in util.c, too.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 24 18:50:32 CET 2012 on sn-devel-104
Jelmer Vernooij [Sat, 24 Mar 2012 16:11:11 +0000 (17:11 +0100)]
adt_tree: Fix return types.
Jelmer Vernooij [Sat, 24 Mar 2012 16:05:29 +0000 (17:05 +0100)]
replace: Work around socket wrapper.
It's fine to ignore socket wrapper here, as it doesn't deal with unix domain sockets.
Jelmer Vernooij [Sat, 24 Mar 2012 15:50:37 +0000 (16:50 +0100)]
replace: Add system/network.h for ucred struct.
Jelmer Vernooij [Sat, 24 Mar 2012 15:42:47 +0000 (16:42 +0100)]
s3-waf: Use samba3-util library instead of lots of tiny libs.
The smaller libraries are currently all trivial in size and don't have
any dependencies other than samba-util.
Having lots of small private libraries is a pain for packaging,
and there isn't much advantage in this.
Jelmer Vernooij [Sat, 24 Mar 2012 15:41:35 +0000 (16:41 +0100)]
adt_tree: Avoid WERROR.
Jelmer Vernooij [Sat, 24 Mar 2012 15:00:36 +0000 (16:00 +0100)]
libreplace: Add getpeereid implementation.
Jelmer Vernooij [Sat, 24 Mar 2012 14:44:33 +0000 (15:44 +0100)]
util_malloc: Remove unused constant.
Jelmer Vernooij [Sat, 24 Mar 2012 14:26:36 +0000 (15:26 +0100)]
lib/util: Remove dummy wrapper for getgrgid().
Jelmer Vernooij [Sat, 24 Mar 2012 14:25:48 +0000 (15:25 +0100)]
lib/util: Remove dummy wrapper for getgrnam().
Jelmer Vernooij [Sat, 24 Mar 2012 14:25:05 +0000 (15:25 +0100)]
lib/util: Remove dummy wrapper for getpwuid().
Jelmer Vernooij [Sat, 24 Mar 2012 14:24:15 +0000 (15:24 +0100)]
lib/util: Remove dummy wrapper for getpwnam().
Jelmer Vernooij [Sat, 24 Mar 2012 14:23:02 +0000 (15:23 +0100)]
lib/util: Remove dummy wrappers for setpwent/getpwent/endpwent.
Jelmer Vernooij [Sat, 24 Mar 2012 14:19:09 +0000 (15:19 +0100)]
lib/util: Move calloc_array and memalign_array to top-level libutil.
Jelmer Vernooij [Sat, 24 Mar 2012 14:00:22 +0000 (15:00 +0100)]
lib/util: Remove prototype for removed sys_memalign.
Jelmer Vernooij [Sat, 24 Mar 2012 13:58:09 +0000 (14:58 +0100)]
lib/util: Remove trivial wrapper sys_connect() around connect().
Jelmer Vernooij [Sat, 24 Mar 2012 13:57:47 +0000 (14:57 +0100)]
cli_pipe: Avoid sys_connect.
Jelmer Vernooij [Sat, 24 Mar 2012 13:57:33 +0000 (14:57 +0100)]
sock_exec: Avoid sys_connect.
Jelmer Vernooij [Sat, 24 Mar 2012 13:51:23 +0000 (14:51 +0100)]
util_sock: Avoid sys_connect.
Jelmer Vernooij [Sat, 24 Mar 2012 13:48:56 +0000 (14:48 +0100)]
ctdb_conn: Avoid sys_connect.
Jelmer Vernooij [Sat, 24 Mar 2012 13:43:21 +0000 (14:43 +0100)]
replace: Move memalign() from lib/util/system.c to libreplace.
Richard Sharpe [Sat, 24 Mar 2012 04:27:41 +0000 (21:27 -0700)]
Improve the Makefile. Use a standard make macro, not a shell command.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Sat Mar 24 07:09:44 CET 2012 on sn-devel-104
Jelmer Vernooij [Fri, 23 Mar 2012 23:40:49 +0000 (00:40 +0100)]
selftest.py: Add cleanup_pid.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Mar 24 04:52:59 CET 2012 on sn-devel-104
Jelmer Vernooij [Fri, 23 Mar 2012 22:46:34 +0000 (23:46 +0100)]
selftest.py: Add write_krb5_conf.
Jelmer Vernooij [Fri, 23 Mar 2012 22:46:19 +0000 (23:46 +0100)]
selftest.py: Add mk_realms_stanza function.
Jelmer Vernooij [Fri, 23 Mar 2012 22:46:02 +0000 (23:46 +0100)]
selftest.py: Add selftest.target.samba with bindir_path function.
Richard Sharpe [Fri, 23 Mar 2012 14:39:45 +0000 (07:39 -0700)]
Make it possible for developers of out-of-tree modules to use the same names as in-tree modules.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Sat Mar 24 03:18:38 CET 2012 on sn-devel-104
Volker Lendecke [Fri, 23 Mar 2012 14:56:43 +0000 (15:56 +0100)]
lib/async_req: Retry read_packet with read(2)
This way it will also work with pipes
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Mar 23 17:31:24 CET 2012 on sn-devel-104
Volker Lendecke [Thu, 22 Mar 2012 13:58:24 +0000 (14:58 +0100)]
s3: Remove the sys_notify dependency from notify_internal
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Mar 23 12:12:51 CET 2012 on sn-devel-104
Andrew Bartlett [Thu, 22 Mar 2012 23:32:47 +0000 (10:32 +1100)]
s3-build: gss_krb5_export_lucid_sec_context is no longer used in the s3 build
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Mar 23 04:37:36 CET 2012 on sn-devel-104
Andrew Bartlett [Thu, 22 Mar 2012 22:40:39 +0000 (09:40 +1100)]
wintest: test demote of DC
Rusty Russell [Fri, 23 Mar 2012 00:15:18 +0000 (10:45 +1030)]
lib/tdb: fix transaction issue for HAVE_INCOHERENT_MMAP.
We unmap the tdb on expand, the remap. But when we have INCOHERENT_MMAP
(ie. OpenBSD) and we're inside a transaction, doing the expand can mean
we need to read from the database to partially fill a transaction block.
This fails, because if mmap is incoherent we never allow accessing the
database via read/write.
The solution is not to unmap and remap until we've actually written the
padding at the end of the file.
Reported-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Fri Mar 23 02:53:15 CET 2012 on sn-devel-104
Rusty Russell [Fri, 23 Mar 2012 00:13:48 +0000 (10:43 +1030)]
lib/tdb: fix test/run-die-during-transaction when HAVE_INCOHERENT_MMAP.
Since we force mmap on, we don't intercept writes to the db, so we never
see it in an inconsistent state. #ifdef over the check that we should have
recovered it at least once.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Rusty Russell [Fri, 23 Mar 2012 00:11:55 +0000 (10:41 +1030)]
lib/tdb: fix missing return 0 code.
fde694274e1e5a11d1473695e7ec7a97f95d39e4 made tdb_mmap return an int,
but didn't put the return 0 on the "internal db" case.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Christian Ambach [Thu, 22 Mar 2012 17:12:07 +0000 (18:12 +0100)]
s3:vfs_gpfs: fix some compiler warnings
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Mar 22 20:14:34 CET 2012 on sn-devel-104
Christian Ambach [Thu, 22 Mar 2012 17:11:47 +0000 (18:11 +0100)]
s3:vfs_gpfs: remove fallback to linux_setlease
if setting the lease in GPFS failed, there is not much sense in trying
to set a lease just locally that would not inform us of openers
on other cluster nodes
Christian Ambach [Thu, 22 Mar 2012 17:00:17 +0000 (18:00 +0100)]
s3:vfs_gpfs: correct use of profiling macros
under certain conditions START_PROFILE could have been called, but no END_PROFILE
Christof Schmitt [Thu, 8 Mar 2012 21:57:12 +0000 (13:57 -0800)]
s3:vfs_gpfs: Implement fallocate callback for GPFS
GPFS provides the gpfs_prealloc call. Implement the fallocate
callback with mode VFS_FALLOCATE_EXTEND_SIZE using this call.
There is no support for VFS_FALLOCATE_KEEP_SIZE, so report
this mode as not available.
Christof Schmitt [Fri, 2 Mar 2012 21:26:24 +0000 (14:26 -0700)]
s3:vfs_gpfs: Report disk space and usage on GPFS share according to quotas
When a client requests the information about free space and space used,
adjust the reported values according to quotas in the GPFS file system:
- Retrieve quotas for the current user, current group and fileset for
the top level of the share.
- If the soft block quota grace time has expired, report disk as full.
- If a hard block quota has been exceeded, report disk as full.
- If none of the hard block quotas been exceeded, report
share size and free space according to the lowest limits found in
the quotas.
- If no applicable hard block quota has been set, report the
information from the statfs call.
This feature is disabled by default and has to be enabled by setting the
option gpfs:dfreequota.
Christof Schmitt [Fri, 2 Mar 2012 21:26:19 +0000 (14:26 -0700)]
s3:vfs_gpfs: add GPFS api calls for quota and free space reporting
Add the GPFS api calls for reporting the quotas and free space:
- get_gpfs_quota for querying a quota
- get_gpfs_fset_id for mapping a path to a fileset id
Christof Schmitt [Fri, 2 Mar 2012 21:26:10 +0000 (14:26 -0700)]
s3:vfs_gpfs: Export disk_norm function
vfs modules implementing the disk_free callback need access
to the function disk_norm for normalizing the data if the parameter
small query is true.
Christian Ambach [Thu, 22 Mar 2012 15:49:30 +0000 (16:49 +0100)]
s3:client correct a wording
Volker Lendecke [Thu, 22 Mar 2012 13:23:11 +0000 (14:23 +0100)]
s3: Fix smbd -i
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Mar 22 18:40:02 CET 2012 on sn-devel-104
Volker Lendecke [Thu, 22 Mar 2012 13:18:13 +0000 (14:18 +0100)]
s3: Remove an unused structure field
Volker Lendecke [Thu, 22 Mar 2012 11:17:26 +0000 (12:17 +0100)]
s3: Add "notify" cmd to smbclient
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Mar 22 13:51:50 CET 2012 on sn-devel-104