Andrew Tridgell [Mon, 8 Nov 2010 06:13:12 +0000 (17:13 +1100)]
fix
Andrew Tridgell [Mon, 8 Nov 2010 05:02:21 +0000 (16:02 +1100)]
s4-debug: lowered the debug level of some unimportant messages
Andrew Tridgell [Mon, 8 Nov 2010 04:46:09 +0000 (15:46 +1100)]
s4-ldb: don't give an error if a module is already registered
this can happen when both the build and install paths are used to load
ldb modules
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov 8 05:28:14 UTC 2010 on sn-devel-104
Andrew Tridgell [Mon, 8 Nov 2010 04:45:18 +0000 (15:45 +1100)]
waf: go back to the previous method of handling .inst. rules
the change broke the library linkages for some library, as spotted by
Brad
Andrew Tridgell [Mon, 8 Nov 2010 01:47:09 +0000 (12:47 +1100)]
waf: fixed the names of the installed libraries after the last change
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov 8 02:31:18 UTC 2010 on sn-devel-104
Andrew Tridgell [Mon, 8 Nov 2010 00:55:02 +0000 (11:55 +1100)]
s4-dns: ensure we get the right case on the grant rule for administrator
it may be 'Administrator' in the database, and bind match rules are
case sensitive
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov 8 01:41:43 UTC 2010 on sn-devel-104
Andrew Tridgell [Mon, 8 Nov 2010 00:11:32 +0000 (11:11 +1100)]
waf: fixed tabs/spaces for python3.0
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov 8 00:55:13 UTC 2010 on sn-devel-104
Andrew Tridgell [Mon, 8 Nov 2010 00:01:13 +0000 (11:01 +1100)]
waf: prevent us from modifying non-install libs during make install
we need to ensure that 'make install' does not change any of our build
libraries, and only changes the .inst.so libraries, otherwise doing a
make test in the build directory directly after a make install could
use the installed libraries, which would mean using the wrong
LDB_MODULES_PATH
this could cause the "unknown error" loading ldb modules when running
some commands directly after a make install
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Sun, 7 Nov 2010 23:58:28 +0000 (10:58 +1100)]
s4-ldb: better error message when we try to register a module twice
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Sun, 7 Nov 2010 23:14:50 +0000 (10:14 +1100)]
s4-pydrs: validate the DsGetNCChanges response
check that object_count matches up with first_object
Andrew Tridgell [Sun, 7 Nov 2010 02:55:20 +0000 (13:55 +1100)]
s4-join: modify join behaviour according to domain level
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Sun Nov 7 23:32:16 UTC 2010 on sn-devel-104
Andrew Tridgell [Sun, 7 Nov 2010 02:53:13 +0000 (13:53 +1100)]
s4-drs: allow override of the replica_flags
Andrew Tridgell [Sun, 7 Nov 2010 00:25:00 +0000 (11:25 +1100)]
s4-dsdb: give the DN on a shema attribute failure
Matthias Dieter Wallnöfer [Sun, 7 Nov 2010 19:10:48 +0000 (20:10 +0100)]
s4:ldap.py - add more "objectGUID" related tests
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Nov 7 21:12:03 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sun, 7 Nov 2010 19:10:29 +0000 (20:10 +0100)]
s4:objectguid LDB module - fix typo in output message
Matthias Dieter Wallnöfer [Sun, 7 Nov 2010 19:09:51 +0000 (20:09 +0100)]
s4:objectguid LDB module - objectGUIDs cannot be specified on add operations
Matthias Dieter Wallnöfer [Sun, 7 Nov 2010 17:51:43 +0000 (18:51 +0100)]
s4:upgradeprovision - remove some "recalculate_sd" uses
We need "recalculate_sd" only when no external "nTSecurityDescriptor" change
is performed. Otherwise the recalculation is performed automatically.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Nov 7 18:52:42 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Mon, 1 Nov 2010 16:51:36 +0000 (17:51 +0100)]
s4:descriptor LDB module - make the "nTSecurityDescriptor" attribute fully behave as in AD
- fix crash when provided "nTSecurityDescriptor" attribute is empty
- print out the correct error codes if it's provided multi-valued
- simplify the "recalculate_sd" control handling
Matthias Dieter Wallnöfer [Sun, 7 Nov 2010 10:27:26 +0000 (11:27 +0100)]
s4:ldb_modules/util.c - "dsdb_get_single_valued_attr" - support the attribute fetch also on LDB add operations
We've to completely ignore the flags in that case.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Nov 7 11:10:23 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sun, 7 Nov 2010 09:04:22 +0000 (10:04 +0100)]
ldb:ldb_pack.c - the "dn" attribute isn't allowed in the message part, only the "distinguishedName" one
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Nov 7 10:11:02 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sun, 7 Nov 2010 08:55:19 +0000 (09:55 +0100)]
s4:torture/dssync.c - remove unused variable
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 22:04:55 +0000 (23:04 +0100)]
s4:descriptor LDB module - save a pointer to the request message on the temporary "ac" context
This prevents two calls of "ldb_msg_copy_shallow".
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 21:49:08 +0000 (22:49 +0100)]
s4:descriptor LDB module - by "dsdb_next_callback" we don't need anymore the default operation callback implementations
Only customised ones still need to remain.
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 21:39:40 +0000 (22:39 +0100)]
s4:descriptor LDB module - remove a bit pointless memory context
For only one operation we do not need an additional "mem_ctx". "ac" should be
enough (see for example the samldb LDB module).
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 21:38:15 +0000 (22:38 +0100)]
s4:descriptor LDB module - remove a "ldb_msg_sanity_check" call
This check (the structural objectclass) is performed in the objectclass LDB
module.
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 21:27:13 +0000 (22:27 +0100)]
s4:descriptor LDB module - don't ignore referrals if we are executing an ordinary external search operation
Referrals are valid results.
Jelmer Vernooij [Sun, 7 Nov 2010 01:05:51 +0000 (02:05 +0100)]
credentials: Lowercase library name,
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Nov 7 01:48:44 UTC 2010 on sn-devel-104
Jelmer Vernooij [Sun, 7 Nov 2010 00:57:34 +0000 (01:57 +0100)]
ldbsamba: Lowercase library name.
Jelmer Vernooij [Sun, 7 Nov 2010 00:52:13 +0000 (01:52 +0100)]
samdb: Lowercase library name.
Jelmer Vernooij [Sun, 7 Nov 2010 00:44:26 +0000 (01:44 +0100)]
samdb: Make private (at least for the moment).
Jelmer Vernooij [Fri, 5 Nov 2010 12:48:34 +0000 (13:48 +0100)]
pytalloc: Make some arguments optional.
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 20:22:53 +0000 (21:22 +0100)]
ldb:ldb_parse.c - "ldb_parse_hex2char" - always initialise "c"
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Nov 6 21:04:58 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 19:47:51 +0000 (20:47 +0100)]
s4:ldap.py - enhance the "distinguishedName" tests
The "dn" shortcut isn't supported by AD.
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 19:23:35 +0000 (20:23 +0100)]
s4:update_keytab LDB module - we don't need to search for the "distinguishedName" attribute
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Nov 6 20:08:28 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 19:18:40 +0000 (20:18 +0100)]
s4:operational LDB module - "canonicalName" doesn't make use of the "distinguishedName" attribute
It uses the DN from the returned message
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 18:46:42 +0000 (19:46 +0100)]
ldb:ldb_tdb.c - ltdb_check_special_dn - fix indentation
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 18:38:47 +0000 (19:38 +0100)]
ldb:ldb_tdb.c - make "ltdb_add" more similar to "ltdb_modify"
And remove in "ltdb_add_internal" a cache loading call which has been present
twice.
Matthias Dieter Wallnöfer [Sat, 6 Nov 2010 17:18:44 +0000 (18:18 +0100)]
s4:samr RPC server - "dcesrv_samr_RemoveMemberFromForeignDomain"
- Remove TODO comment: MS-SAMR 3.1.5.8.7 explicitly states:
"The SamrRemoveMemberFromForeignDomain method removes a member from all
aliases."
- Remove the search attributes since they aren't strictly needed.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Nov 6 18:07:57 UTC 2010 on sn-devel-104
Stefan Metzmacher [Sat, 6 Nov 2010 12:41:34 +0000 (13:41 +0100)]
s4:DRS-RPC-DSSYNC: don't try to decrypt secret attributes twice
dsdb_extended_replicated_objects_convert() already decrypts the
attributes in place.
This fixes the usage of --option="dssync:print_pwd_blobs=yes".
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Nov 6 13:30:16 UTC 2010 on sn-devel-104
Andrew Tridgell [Sat, 6 Nov 2010 03:44:33 +0000 (14:44 +1100)]
s4-cldap: fixed debug message to match content
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Sat Nov 6 04:26:45 UTC 2010 on sn-devel-104
Andrew Tridgell [Sat, 6 Nov 2010 03:35:30 +0000 (14:35 +1100)]
s4-join: fixed SPNs, invocationId and dnshostname and python join
- we need the GN/ SPN for replication.
- fixed the string form of the invocationId
- lowercase the dnshostname
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Fri, 5 Nov 2010 07:57:36 +0000 (18:57 +1100)]
s4-join: switch over to the new DC join in make test
Andrew Tridgell [Fri, 5 Nov 2010 03:16:49 +0000 (14:16 +1100)]
samba-tool: deprecate samba-tool vampire command
Volker Lendecke [Fri, 5 Nov 2010 14:48:44 +0000 (15:48 +0100)]
s3: Make proper use of sid_check_is_in_xx routines
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Nov 5 15:35:59 UTC 2010 on sn-devel-104
Volker Lendecke [Fri, 5 Nov 2010 14:44:55 +0000 (15:44 +0100)]
s3: Fix a typo
Volker Lendecke [Fri, 5 Nov 2010 14:38:28 +0000 (15:38 +0100)]
s3: Remove some duplicate prototypes
Stefan Metzmacher [Fri, 5 Nov 2010 08:43:05 +0000 (09:43 +0100)]
socket_wrapper: fill in sa.sa_len if the system supports it
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov 5 14:40:00 UTC 2010 on sn-devel-104
Andrew Tridgell [Fri, 5 Nov 2010 08:09:45 +0000 (19:09 +1100)]
s4-join: fixed secure_channel_type
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Nov 5 13:24:32 UTC 2010 on sn-devel-104
Andrew Tridgell [Fri, 5 Nov 2010 07:57:17 +0000 (18:57 +1100)]
s4-join: don't print all the NDR packets by default
Andrew Tridgell [Fri, 5 Nov 2010 07:56:46 +0000 (18:56 +1100)]
s4-cldap: print all the DNS servers found
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Fri, 5 Nov 2010 07:50:29 +0000 (18:50 +1100)]
s4-ldb: much more memory efficient msg filtering
this ensures we don't leave unnecessary attributes in returned ldb
objects
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Fri, 5 Nov 2010 07:28:04 +0000 (18:28 +1100)]
s4-drs: reduce the memory usage of the getncchanges server
we now keep just a list of GUIDs around between getncchanges calls,
instead of an entire db search. This makes the overhead of having a
pending getncchanges call much smaller.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Fri, 5 Nov 2010 06:08:52 +0000 (17:08 +1100)]
s4-kerberos Mention the remote address we fail to contact the KDC on
Andrew Tridgell [Fri, 5 Nov 2010 03:10:30 +0000 (14:10 +1100)]
s4-ldb: show the reason for module initialization failure
Andrew Tridgell [Fri, 5 Nov 2010 03:10:11 +0000 (14:10 +1100)]
s4: net -> samba-tool
Andrew Tridgell [Fri, 5 Nov 2010 03:09:49 +0000 (14:09 +1100)]
s4-join: added DC join to the python join code
this will replace the old vampire code
Andrew Tridgell [Fri, 5 Nov 2010 03:08:49 +0000 (14:08 +1100)]
s4-pydrs: added rodc option to python drs replication
Andrew Tridgell [Fri, 5 Nov 2010 03:06:10 +0000 (14:06 +1100)]
s4-pydsdb: added DsReplicaAttribute()
this allows us to form a DsReplicaAttribute structure from python
Andrew Tridgell [Fri, 5 Nov 2010 00:52:20 +0000 (11:52 +1100)]
pidl: use a union assignment instead of memmove
this means we don't lose type checking
Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>
Matthias Dieter Wallnöfer [Fri, 5 Nov 2010 11:49:42 +0000 (12:49 +0100)]
s4:password_hash LDB module - fix indentation
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Nov 5 12:31:28 UTC 2010 on sn-devel-104
Volker Lendecke [Fri, 5 Nov 2010 10:41:09 +0000 (11:41 +0100)]
s3: Allow disabling of mdns registrations
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Nov 5 11:24:41 UTC 2010 on sn-devel-104
Matthieu Patou [Mon, 1 Nov 2010 13:55:25 +0000 (00:55 +1100)]
fix in_screen so that it works on os that don't chdir to $PWD
That's the case on freebsd 7.2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov 5 09:27:19 UTC 2010 on sn-devel-104
Stefan Metzmacher [Thu, 21 Oct 2010 05:00:34 +0000 (07:00 +0200)]
tsocket: fill in sa.sa_len if the system supports it
metze
Matthias Dieter Wallnöfer [Thu, 4 Nov 2010 20:58:16 +0000 (21:58 +0100)]
ldb:ldb.h - reorder extended operations list
We always define the controls and operations with a comment block. The data
structure definitions lie a bit below.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Nov 5 08:44:14 UTC 2010 on sn-devel-104
Stefan Metzmacher [Thu, 4 Nov 2010 17:07:18 +0000 (18:07 +0100)]
s4:dsdb/drepl_notify: reuse dreplsrv_notify_operation structures
Otherwise we'll requeue the same notify events on and on.
(gdb) p *((struct dreplsrv_service *) 0x1b52190)->ops.notifies
$8 = {prev = 0xe4cb30, next = 0x1a25440, service = 0x1b52190, uSN = 123905,
source_dsa = 0x164c100, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *) 0x1b52190)->ops.notifies->next
$9 = {prev = 0x80e000, next = 0x1b7bf70, service = 0x1b52190, uSN = 123589,
source_dsa = 0x1a2d930, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *) 0x1b52190)->ops.notifies->next->next
$10 = {prev = 0x1a25440, next = 0x1d0c310, service = 0x1b52190, uSN = 1587,
source_dsa = 0x13d3210, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *) 0x1b52190)->ops.notifies->next->next->next
$11 = {prev = 0x1b7bf70, next = 0x1ba1420, service = 0x1b52190, uSN = 123905,
source_dsa = 0x164c100, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *)
0x1b52190)->ops.notifies->next->next->next->next
$12 = {prev = 0x1d0c310, next = 0x1c43510, service = 0x1b52190, uSN = 123589,
source_dsa = 0x1a2d930, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *)
0x1b52190)->ops.notifies->next->next->next->next->next
$13 = {prev = 0x1ba1420, next = 0xed97b0, service = 0x1b52190, uSN = 1587,
source_dsa = 0x13d3210, is_urgent = false, replica_flags = 29}
(gdb) p *((struct dreplsrv_service *)
0x1b52190)->ops.notifies->next->next->next->next->next->next
$14 = {prev = 0x1c43510, next = 0xe4ce80, service = 0x1b52190, uSN = 123905,
source_dsa = 0x164c100, is_urgent = false, replica_flags = 29}
We can reuse this operations, while they're not yet started.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov 5 07:15:04 UTC 2010 on sn-devel-104
Anatoliy Atanasov [Thu, 4 Nov 2010 22:00:13 +0000 (00:00 +0200)]
s4/auth: Add logon_parameters to authenticate_username_pw
We need to be able to set the logon parameters in the same way as in the
ntlm server so we can handle openldap simple authentication call correctly.
Autobuild-User: Anatoliy Atanasov <anatoliy@samba.org>
Autobuild-Date: Fri Nov 5 06:32:43 UTC 2010 on sn-devel-104
Anatoliy Atanasov [Thu, 4 Nov 2010 21:57:48 +0000 (23:57 +0200)]
s4/test: Added test for simple bind with machine account
Samba4 returns error on simple bind, when we do it using openldap
simple_bind_s api.
Jelmer Vernooij [Fri, 5 Nov 2010 02:00:45 +0000 (03:00 +0100)]
talloc: Add python talloc module, move convenience functions to it.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Nov 5 02:48:21 UTC 2010 on sn-devel-104
Jelmer Vernooij [Fri, 5 Nov 2010 01:35:55 +0000 (02:35 +0100)]
talloc: rename pytalloc.c to pytalloc_util.c
Jelmer Vernooij [Fri, 5 Nov 2010 01:30:01 +0000 (02:30 +0100)]
waf: Put private libraries in a separate directory when building.
Thanks to Tridge for pointing out what exactly I had to change. :-)
Jelmer Vernooij [Fri, 5 Nov 2010 01:08:44 +0000 (02:08 +0100)]
wafsamba: Use project name variable rather than hardcoding 'samba4'.
Suggested-By: Andrew Tridgell <tridge@samba.org>
Jelmer Vernooij [Thu, 4 Nov 2010 23:33:51 +0000 (00:33 +0100)]
wafsamba: Drop private library prefix when installing private libraries
to a custom path.
Jelmer Vernooij [Thu, 4 Nov 2010 23:20:16 +0000 (00:20 +0100)]
wafsamba: Support expanding variables in LIBDIR/PRIVATELIBDIR variables.
Jelmer Vernooij [Thu, 4 Nov 2010 23:03:20 +0000 (00:03 +0100)]
Add --disable-rpath-private-install flag.
Jelmer Vernooij [Thu, 4 Nov 2010 22:23:39 +0000 (23:23 +0100)]
Add --with-privatelibdir build option.
Jelmer Vernooij [Thu, 4 Nov 2010 22:02:50 +0000 (23:02 +0100)]
samba_utils: Use LIBDIR rather than assuming it is set to $prefix/lib.
Jelmer Vernooij [Thu, 4 Nov 2010 01:07:57 +0000 (02:07 +0100)]
selftest: Allow some tests to output empty subunit data.
Andrew Bartlett [Thu, 4 Nov 2010 23:28:04 +0000 (10:28 +1100)]
s4-ldap_server Don't DEBUG() at level 2 every time a caller disconnects
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Nov 5 00:12:37 UTC 2010 on sn-devel-104
Andrew Tridgell [Thu, 4 Nov 2010 22:01:47 +0000 (09:01 +1100)]
s4: don't run etags over .inst files
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 4 22:51:06 UTC 2010 on sn-devel-104
Andrew Tridgell [Thu, 4 Nov 2010 22:01:28 +0000 (09:01 +1100)]
compression: added a simple lzxpress test
Andrew Tridgell [Thu, 4 Nov 2010 22:00:57 +0000 (09:00 +1100)]
compression: fixed an uninitialised data but in lzxpress
Volker Lendecke [Thu, 4 Nov 2010 18:23:06 +0000 (19:23 +0100)]
s3: Remove the use of cli_send_trans from cli_get_fs_full_size_info
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 4 22:08:53 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Mon, 1 Nov 2010 16:23:34 +0000 (17:23 +0100)]
s4:ldap.py/passwords.py - just use objectclass "user" for users
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 4 21:09:00 UTC 2010 on sn-devel-104
Volker Lendecke [Thu, 4 Nov 2010 17:49:55 +0000 (18:49 +0100)]
s3: Remove an unused prototype
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 4 17:44:09 UTC 2010 on sn-devel-104
Stefan Metzmacher [Thu, 4 Nov 2010 11:37:29 +0000 (12:37 +0100)]
s4:dsdb/objectclass_attrs: not all objects have delete protected attributes as must contain
Before we got the following error, while starting samba after a
'samba-tool vampire':
Failed to store repsFrom - objectclass_attrs: delete protected attribute
'objectSid' on entry 'DC=ForestDnsZones,DC=alpha,DC=sz,DC=salzgitter-ag,DC=lab'
missing!
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 4 17:01:59 UTC 2010 on sn-devel-104
Stefan Metzmacher [Wed, 3 Nov 2010 11:33:54 +0000 (12:33 +0100)]
s4:dsdb/samdb: optimize samldb_prim_group_change()
We should only do searches when we have to.
metze
Stefan Metzmacher [Thu, 4 Nov 2010 13:29:12 +0000 (14:29 +0100)]
s4:dsdb/common: fix memory leak in samdb_ntds_settings_dn()
fetch and set should use the same name!
metze
Stefan Metzmacher [Thu, 4 Nov 2010 12:32:06 +0000 (13:32 +0100)]
s4:dsdb/kcc: fix memory leak in kcctpl_copy_output_edges()
metze
Günther Deschner [Wed, 3 Nov 2010 16:16:06 +0000 (17:16 +0100)]
s3-waf: add check for httpConnect and httpConnectEncrypt.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Nov 4 14:10:40 UTC 2010 on sn-devel-104
Kamen Mazdrashki [Thu, 4 Nov 2010 01:27:10 +0000 (03:27 +0200)]
s4-ldb_module.h: use LDB error code for ldb_error() macro rather than LDB_DEBUG_FATAL
We end up calling ldb_error_at() which expects an LDB error,
but LDB_DEBUG_FATAL is not such code. It is actually equal to LDB_SUCCESS.
Thus the effect is that we report a *fatal* error, but return
LDB_SUCCESS in many places.
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Thu Nov 4 12:57:33 UTC 2010 on sn-devel-104
Kamen Mazdrashki [Wed, 3 Nov 2010 21:43:21 +0000 (23:43 +0200)]
s4-devel: Verify prefixMap is saved correctly in LDB on disk
Jelmer Vernooij [Thu, 4 Nov 2010 11:29:42 +0000 (12:29 +0100)]
urgent_replication: forbid empty subunit output.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Nov 4 12:13:47 UTC 2010 on sn-devel-104
Jelmer Vernooij [Thu, 4 Nov 2010 01:07:57 +0000 (02:07 +0100)]
selftest: Allow some tests to output empty subunit data.
Andrew Bartlett [Thu, 4 Nov 2010 02:16:11 +0000 (13:16 +1100)]
s4-dsdb Fix urgent_replication test not to set an invalid userAccountControl
A userAccountControl value of 0 or 1 is invalid, you must include one of
the account types.
Andrew Bartlett
Jelmer Vernooij [Thu, 4 Nov 2010 00:36:57 +0000 (01:36 +0100)]
urgent_replication: Fix syntax error.
Andrew Tridgell [Thu, 4 Nov 2010 09:34:37 +0000 (20:34 +1100)]
s4-dsdb: use LDB_FLAG_MOD_REPLACE for isDeleted
isDeleted could have been set to FALSE previously
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 4 10:18:10 UTC 2010 on sn-devel-104
Andrew Tridgell [Thu, 4 Nov 2010 09:33:31 +0000 (20:33 +1100)]
s4-dsdb: use LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK in dsdb
when we are creating linked attributes with multiple values (some
deleted), use LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK to disable
that checking.
Andrew Tridgell [Thu, 4 Nov 2010 09:27:43 +0000 (20:27 +1100)]
s4-ldb: implement LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK
this disables the single value checking for one attribute. It is much
more specific than a general RELAX control, and also more efficient. I
think we should try to have more precise overrides like this, rather
than using RELAX as a general purpose override
Andrew Tridgell [Thu, 4 Nov 2010 09:13:17 +0000 (20:13 +1100)]
s4-ldb: don't load modules from the same directory twice
this prevents samba dying if you do a 'make install' while it is
running. Otherwise the make install changes the inode numbers of the
modules in the modules directory, causing them to reload, which causes
multiple modules of the same name to try and load
Andrew Tridgell [Thu, 4 Nov 2010 09:05:59 +0000 (20:05 +1100)]
s4-ldb: honor controls on search in ldbedit