Matthias Dieter Wallnöfer [Thu, 27 Oct 2011 07:54:06 +0000 (09:54 +0200)]
s4:lib/registry - enhance registry tests in respect to default values
Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 3 21:41:17 CET 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Fri, 28 Oct 2011 17:52:49 +0000 (19:52 +0200)]
s4:lib/registry/ldb.c - quit the deletion of a not-existing default value with WERR_BADFILE
Reviewed-by: Jelmer
Matthias Dieter Wallnöfer [Tue, 25 Oct 2011 18:08:31 +0000 (20:08 +0200)]
s4:lib/registry/ldb.c - don't use search filters for base searches
They are not necessary in this case.
Reviewed-by: Jelmer
Matthias Dieter Wallnöfer [Fri, 28 Oct 2011 16:20:47 +0000 (18:20 +0200)]
s4:lib/registry/regf.c - always generate debug messages on error cases
We need to know what is going on.
Reviewed-by: Jelmer
Günther Deschner [Thu, 3 Nov 2011 08:34:04 +0000 (09:34 +0100)]
s4-smbtorture: add some ndr validation tests for netlogon_samlogon_response structs.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Nov 3 20:08:20 CET 2011 on sn-devel-104
Günther Deschner [Thu, 3 Nov 2011 10:33:16 +0000 (11:33 +0100)]
torture: add torture_assert_guid_equal() macro.
Guenther
Günther Deschner [Wed, 2 Nov 2011 17:05:59 +0000 (18:05 +0100)]
waf: convert NDR_NBT into shared library.
Guenther
Günther Deschner [Wed, 12 Oct 2011 12:58:46 +0000 (14:58 +0200)]
nbt: create standard ndr_pull/push interface for common netlogon samlogon replies.
Guenther
Günther Deschner [Thu, 3 Nov 2011 09:30:37 +0000 (10:30 +0100)]
nbt: move netlogon_samlogon_response into librpc/ndr/ndr_nbt.h.
Guenther
Günther Deschner [Thu, 3 Nov 2011 13:40:46 +0000 (14:40 +0100)]
nbt: trim down header dependencies of nbt.idl.
Guenther
Günther Deschner [Thu, 3 Nov 2011 13:07:09 +0000 (14:07 +0100)]
s4: add some missing header dependencies.
Guenther
Günther Deschner [Thu, 3 Nov 2011 13:39:50 +0000 (14:39 +0100)]
nbt: move nbt_string ndr functions to ndr/ndr_nbt.c helper.
Guenther
Günther Deschner [Wed, 2 Nov 2011 17:31:40 +0000 (18:31 +0100)]
nbt: merge in LIBCLI_NDR_NETLOGON helper into NDR_NBT.
Guenther
Günther Deschner [Wed, 2 Nov 2011 19:08:25 +0000 (20:08 +0100)]
librpc: remove nbt dependency to svcctl.
Guenther
Günther Deschner [Wed, 2 Nov 2011 19:07:42 +0000 (20:07 +0100)]
librpc: remove nbt dependency to samr.
Guenther
Günther Deschner [Wed, 2 Nov 2011 17:14:07 +0000 (18:14 +0100)]
librpc: only let NDR_NBT depend on NDR_NBT_BUF.
Guenther
Stefan Metzmacher [Wed, 2 Nov 2011 18:08:54 +0000 (19:08 +0100)]
s3:param: change default of "* signing" to "default"
This should not change the bahavior.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 3 18:33:34 CET 2011 on sn-devel-104
Stefan Metzmacher [Wed, 2 Nov 2011 18:07:45 +0000 (19:07 +0100)]
s3:smbd: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:55:55 +0000 (18:55 +0100)]
s3:libsmb: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 18:00:57 +0000 (19:00 +0100)]
s3:lib: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:55:55 +0000 (18:55 +0100)]
s3:libsmb: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:libsmb: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:torture: s/Undefined/SMB_SIGNING_DEFAULT/ s/Required/SMB_SIGNING_REQUIRED/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:lib: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:lib/netapi: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:libnet: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:winbindd: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:web: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:utils: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:nmbd: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:auth: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:41:50 +0000 (18:41 +0100)]
s3:client: s/Undefined/SMB_SIGNING_DEFAULT/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:34:27 +0000 (18:34 +0100)]
s3:param: make use of SMB_SIGNING_* constants
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:21:49 +0000 (18:21 +0100)]
libcli/smb: use the same values for SMB_SIGNING_* as the source3 code uses
The source3 code currently uses:
#define Undefined (-1)
#define False false
#define True true
#define Required (3)
In order to make the rewrite easier we should match the values.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:19:18 +0000 (18:19 +0100)]
libcli/smb: remove unused SMB_SIGNING_SUPPORTED
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:16:01 +0000 (18:16 +0100)]
s4:smb_server: s/SMB_SIGNING_SUPPORTED/SMB_SIGNING_IF_REQUIRED/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:16:01 +0000 (18:16 +0100)]
s4:libcli/smb2: s/SMB_SIGNING_SUPPORTED/SMB_SIGNING_IF_REQUIRED/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:16:01 +0000 (18:16 +0100)]
s4:libcli/raw: s/SMB_SIGNING_SUPPORTED/SMB_SIGNING_IF_REQUIRED/
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:13:45 +0000 (18:13 +0100)]
lib/param: use SMB_SIGNING_IF_REQUIRED instead of SMB_SIGNING_SUPPORTED
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:11:51 +0000 (18:11 +0100)]
libcli/smb: add SMB_SIGNING_IF_REQUIRED as replacement for SMB_SIGNING_SUPPORTED
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:10:17 +0000 (18:10 +0100)]
libcli/smb: SMB_SIGNING_AUTO is no longer used
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:09:23 +0000 (18:09 +0100)]
s4:libcli/smb2: remove unused SMB_SIGNING_AUTO handling
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:09:23 +0000 (18:09 +0100)]
s4:libcli/raw: remove unused SMB_SIGNING_AUTO handling
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:06:12 +0000 (18:06 +0100)]
lib/param: map "* signing = auto" to SMB_SIGNING_SUPPORTED
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:03:24 +0000 (18:03 +0100)]
s4:smb_server: change the default for "server signing" to "default"
metze
Stefan Metzmacher [Wed, 2 Nov 2011 17:03:24 +0000 (18:03 +0100)]
lib/param: change the default for "client signing" to "default"
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:59:54 +0000 (17:59 +0100)]
s4:libcli/smb2: SMB_SIGNING_DEFAULT matches SMB_SIGNING_SUPPORTED on the client for now
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:59:54 +0000 (17:59 +0100)]
s4:libcli/raw: SMB_SIGNING_DEFAULT matches SMB_SIGNING_SUPPORTED on the client for now
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:25:45 +0000 (17:25 +0100)]
libcli/smb: add SMB_SIGNING_DEFAULT
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:50:23 +0000 (17:50 +0100)]
s4:smb_server/smb2: add the same SMB_SIGNING_AUTO logic as for smb1
metze
Stefan Metzmacher [Thu, 3 Nov 2011 06:34:30 +0000 (07:34 +0100)]
selftest/Samba4: use "server signing = on" for now
Otherwise the smb2.compound test fails as it doesn't work
with signing yet.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:48:45 +0000 (17:48 +0100)]
s4:smb_server/smb: make the SMB_SIGNING_AUTO behavior a bit easier to follow
The prepares a future change to SMB_SIGNING_DEFAULT.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:30:34 +0000 (17:30 +0100)]
s3:param: the behavior of "client/server signing = auto" is the same as "true"
So remove the special case for 'Auto'.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:21:03 +0000 (17:21 +0100)]
s4:libcli/smb2: let SMB_SIGNING_AUTO behave like SMB_SIGNING_SUPPORTED
This matches the smb1 behavior.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 16:02:03 +0000 (17:02 +0100)]
s4:libcli/raw: only use smb signing if required
This matches the source3 code, I want to have the behavior
in common before I put the config options in common.
Later we may change this consitently in all code.
metze
Stefan Metzmacher [Wed, 2 Nov 2011 14:43:54 +0000 (15:43 +0100)]
s3:libsmb: restore the 3.6.x behavior signing config parameters
metze
Giampaolo Lauria [Tue, 1 Nov 2011 19:21:32 +0000 (15:21 -0400)]
samba-tool: Fix short description and error msgs in domain level
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Nov 3 16:53:16 CET 2011 on sn-devel-104
Giampaolo Lauria [Tue, 1 Nov 2011 19:16:53 +0000 (15:16 -0400)]
samba-tool: Fix --quiet option in domain samba3upgrade
--quiet option does not require an argument
Giampaolo Lauria [Fri, 21 Oct 2011 16:05:07 +0000 (12:05 -0400)]
samba-tool: Improve "delegation" command error handling
Change samdb toggle_userAccountFlags fcn to display more
meaningful error messages
Add flags string param to toggle_userAccountFlags
Change call to toggle_userAccountFlags in delegation command
to pass the flag name to be displayed in case of errors
Giampaolo Lauria [Fri, 21 Oct 2011 15:57:34 +0000 (11:57 -0400)]
samba-tool: Improve "delegation" command error message
Write a more specific error msg when the on|off arg is invalid
Giampaolo Lauria [Fri, 21 Oct 2011 15:49:29 +0000 (11:49 -0400)]
samba-tool: Improve "delegation" command error handling
Display a more meaningful error msg when user account not found
Assert when returned number of entries is not 0 or 1
Giampaolo Lauria [Fri, 21 Oct 2011 15:35:36 +0000 (11:35 -0400)]
samba-tool: Fix "delegation show" command synopsis
Removed "show" from synopsis as it is no longer necessary
David Disseldorp [Thu, 3 Nov 2011 11:54:00 +0000 (12:54 +0100)]
pkg: add comments to the systemd sysconfig file
Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Thu Nov 3 15:11:27 CET 2011 on sn-devel-104
Björn Baumbach [Wed, 2 Nov 2011 14:27:30 +0000 (15:27 +0100)]
s3-build: add bin/dbwrap_tool to the BIN_PROGS2 dependencies
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Nov 3 11:52:53 CET 2011 on sn-devel-104
Björn Baumbach [Wed, 2 Nov 2011 12:40:36 +0000 (13:40 +0100)]
s3-registry: fix upgrade code
Assume REGDB_VERSION_V1 if no version key found in registry.tdb
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Baumbach [Wed, 2 Nov 2011 12:38:18 +0000 (13:38 +0100)]
s3-utils: net - Fix one error/usage message
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Baumbach [Fri, 28 Oct 2011 12:29:56 +0000 (14:29 +0200)]
s3-printing: fix typo
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 2 Nov 2011 13:38:08 +0000 (14:38 +0100)]
s3:torture: let SMB2-BASICS work against w2k8r2 and win8pre0
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 3 09:44:59 CET 2011 on sn-devel-104
Matthieu Patou [Wed, 2 Nov 2011 19:24:20 +0000 (20:24 +0100)]
s4-sites: Document, fix under optimal coding, use exceptions
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Wed Nov 2 22:35:00 CET 2011 on sn-devel-104
Jelmer Vernooij [Wed, 2 Nov 2011 15:39:47 +0000 (16:39 +0100)]
samba.netcmd: Pass in outf/errf.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Nov 2 20:09:40 CET 2011 on sn-devel-104
Jelmer Vernooij [Wed, 2 Nov 2011 15:33:56 +0000 (16:33 +0100)]
pyldb: Remove duplicate definition of SYNTAX_DN.
Jelmer Vernooij [Wed, 2 Nov 2011 15:23:06 +0000 (16:23 +0100)]
s4-python: samba.provision: Require schema to be passed in - code path which handles schema not being specified is broken anyway.
Jelmer Vernooij [Wed, 2 Nov 2011 15:22:16 +0000 (16:22 +0100)]
samba.common: Fix formatting of docstring (trips up pydoctor).
Günther Deschner [Wed, 2 Nov 2011 15:58:53 +0000 (16:58 +0100)]
s3-waf: convert libcli_netlogon3 into a private library.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov 2 18:34:55 CET 2011 on sn-devel-104
Sumit Bose [Wed, 2 Nov 2011 11:06:07 +0000 (12:06 +0100)]
s3-lsa: Let passdb backend handle the DOMAIN$ user
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Wed, 2 Nov 2011 12:06:45 +0000 (13:06 +0100)]
s3-waf: move trusts_util.c code into a private library.
Guenther
Günther Deschner [Wed, 2 Nov 2011 11:50:34 +0000 (12:50 +0100)]
s3-trustdomcache: make enumerate_domain_trusts() static.
Guenther
Günther Deschner [Wed, 2 Nov 2011 11:04:46 +0000 (12:04 +0100)]
s3-waf: convert libnet_keytab into a private library.
Guenther
Günther Deschner [Wed, 2 Nov 2011 11:03:53 +0000 (12:03 +0100)]
s3-libnet: add ads forward declaration in libnet keytab code.
Guenther
Günther Deschner [Wed, 2 Nov 2011 09:45:33 +0000 (10:45 +0100)]
s3-waf: fix libgpo.so library name.
Guenther
David Disseldorp [Wed, 2 Nov 2011 13:53:20 +0000 (14:53 +0100)]
ldb: fix compiler warning
Mixed declarations and code.
Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Wed Nov 2 16:51:24 CET 2011 on sn-devel-104
David Disseldorp [Wed, 2 Nov 2011 13:51:51 +0000 (14:51 +0100)]
s3:smb2_server: remove unused outhdr variables
Matthieu Patou [Wed, 2 Nov 2011 12:32:33 +0000 (13:32 +0100)]
samba-tool: add subcommand for sites manipulation
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Wed Nov 2 15:14:32 CET 2011 on sn-devel-104
Matthieu Patou [Wed, 2 Nov 2011 12:31:40 +0000 (13:31 +0100)]
s4-selftest: add unit tests for sites's function in python
Matthieu Patou [Wed, 2 Nov 2011 12:30:59 +0000 (13:30 +0100)]
s4-python: add function to manipulate sites in python
Matthieu Patou [Wed, 2 Nov 2011 08:39:23 +0000 (09:39 +0100)]
s4-resolver: make it work back with ipv4 only DNS records
It turns out that if there is no AAAA record the dns server (bind and MS
windows at least) do not return the A record when just asked for AAAA.
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Wed Nov 2 11:15:34 CET 2011 on sn-devel-104
Rusty Russell [Tue, 1 Nov 2011 23:38:32 +0000 (10:08 +1030)]
tdb2: don't be fascist when TDB_VERSION1 is specified.
We currently insist that a tdb file be a version1 file if tdb_open() is
passed the TDB_VERSION1 flag; we fail if it's actually a tdb2.
But that makes generic wrappers harder, and is unlikely to be what the
user wants: if they do, they can check tdb_get_flags() & TDB_VERSION1
after opening.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
(Imported from CCAN commit
9691464a16ef22d6acadfef209666381dfe22b2f)
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Wed Nov 2 08:38:38 CET 2011 on sn-devel-104
Amitay Isaacs [Wed, 2 Nov 2011 03:34:41 +0000 (14:34 +1100)]
dsdb: Handle the case when extended rights string is NULL
Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Nov 2 07:03:40 CET 2011 on sn-devel-104
Amitay Isaacs [Tue, 25 Oct 2011 04:06:07 +0000 (15:06 +1100)]
s4-drepl: Search for application partitions in addition to main ones
To replicate application partitions (e.g. DNS partitions) consult
msDs-hasMasterNCs attribute as well. Also, make sure we don't add
same partition twice in the list. hasMasterNCs and msDs-hasMasterNCs
have domain, configuration and schema partitions common.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Amitay Isaacs [Mon, 24 Oct 2011 06:37:24 +0000 (17:37 +1100)]
s4-dnsserver: Check the raised exception with assertRaises
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Amitay Isaacs [Mon, 24 Oct 2011 06:22:21 +0000 (17:22 +1100)]
s4-dnsserver: Handle the case when the dns name is NULL
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Amitay Isaacs [Mon, 24 Oct 2011 06:20:46 +0000 (17:20 +1100)]
s4-dnsserver: Build a dns name tree for correct enumeration
The result of EnumRecords/EnumRecords2 RPC calls, is a list of
dns records that are one level below in the name hierarchy starting
from the search name. This patch builds a tree of names to get
the list of records one level below the search names and correctly
count the number of child records for each of those.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Amitay Isaacs [Mon, 24 Oct 2011 06:15:27 +0000 (17:15 +1100)]
s4-dnsserver: List dns zones matching the search filter
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Amitay Isaacs [Mon, 24 Oct 2011 06:07:45 +0000 (17:07 +1100)]
s4-dnsserver: Compare two dns names using last uncommon name components
When search_name is not NULL, use the second last component of name
instead of the last name.
e.g. To compare following two names,
_ldap._tcp.gc, and
_ldap._tcp.Default-First-Site-Name._sites.gc
with search_name=NULL, it is gc and gc
with search_name=gc, it is _tcp and _sites
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Amitay Isaacs [Mon, 24 Oct 2011 05:54:16 +0000 (16:54 +1100)]
s4-dnsserver: Set DNS_DP_AUTOCREATED flag for the zone information
This make the zone information similar to windows (W2K8r2).
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Amitay Isaacs [Fri, 21 Oct 2011 00:27:28 +0000 (11:27 +1100)]
samba-tool: Improve the description of dns subcommands.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Amitay Isaacs [Tue, 20 Sep 2011 07:31:24 +0000 (17:31 +1000)]
samba-tool: Enable comparison of DNS naming contexts in ldapcmp
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Jeremy Allison [Mon, 31 Oct 2011 19:38:36 +0000 (12:38 -0700)]
Remove opendir() VFS code from ACL modules.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Nov 2 02:13:51 CET 2011 on sn-devel-104
Jeremy Allison [Mon, 31 Oct 2011 19:38:20 +0000 (12:38 -0700)]
Call check_parent_access() on readdir.
Jeremy Allison [Mon, 31 Oct 2011 19:37:39 +0000 (12:37 -0700)]
Change function signature of check_parent_access() to take char * instead of struct smb_filename.
Expose it so it can be called from directory code.