From: Ira Cooper <ira@wakeful.net>
Date: Wed, 30 May 2012 18:50:06 +0000 (-0700)
Subject: Fix bad bugfix for bug #8910 - resolve_ads() code can return zero addresses and miss... 
X-Git-Tag: samba-4.0.0beta1~113
X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;h=fc7e1113c34819de6fc8053fb81ee2e0e970bec2;p=vlendec%2Fsamba-autobuild%2F.git

Fix bad bugfix for bug #8910 - resolve_ads() code can return zero addresses and miss valid DC IP addresses

Original code incorrectly used a while() instead of a for() loop.
We need to iterate over the entire array here.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 30 23:29:03 CEST 2012 on sn-devel-104
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 3eae3470683..4c05e4f4189 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -2491,7 +2491,7 @@ static NTSTATUS resolve_ads(const char *name,
 
 	*return_count = 0;
 
-	while ( i < numdcs && (*return_count<numaddrs) ) {
+	for (i = 0; i < numdcs && (*return_count<numaddrs); i++ ) {
 		/* If we don't have an IP list for a name, lookup it up */
 		if (!dcs[i].ss_s) {
 			/* We need to get all IP addresses here. */