From: Michael Adam <obnox@samba.org>
Date: Wed, 8 Jul 2009 22:21:46 +0000 (+0200)
Subject: s3:registry: don't leak to talloc_stack in regdb_store_keys_internal2()
X-Git-Tag: tevent-0.9.8~710^2~143
X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;h=f93c9e0d415b5c2e2fd73bb370db7b7e17ede9aa;p=gd%2Fsamba-autobuild%2F.git

s3:registry: don't leak to talloc_stack in regdb_store_keys_internal2()

and catch one potential talloc failure.

Michael
---

diff --git a/source3/registry/reg_backend_db.c b/source3/registry/reg_backend_db.c
index 542f6dc7d0d..6bf98d4c756 100644
--- a/source3/registry/reg_backend_db.c
+++ b/source3/registry/reg_backend_db.c
@@ -623,14 +623,21 @@ static WERROR regdb_store_keys_internal2(struct db_context *db,
 	WERROR werr;
 
 	if (!key) {
-		return WERR_INVALID_PARAM;
+		werr = WERR_INVALID_PARAM;
+		goto done;
 	}
 
 	keyname = talloc_strdup(ctx, key);
 	if (!keyname) {
-		return WERR_NOMEM;
+		werr = WERR_NOMEM;
+		goto done;
 	}
+
 	keyname = normalize_reg_path(ctx, keyname);
+	if (!keyname) {
+		werr = WERR_NOMEM;
+		goto done;
+	}
 
 	/* allocate some initial memory */