From: Andrew Tridgell <tridge@samba.org>
Date: Thu, 13 Dec 2001 11:30:13 +0000 (+0000)
Subject: better error handling
X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;h=d58b1b5981652e5ef37eb8d07ae3ff7797b112c5;p=gd%2Fsamba%2F.git

better error handling
(This used to be commit ed6279481bfcb21212e9c22009969c19ea4f1646)
---

diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
index 5d7b08a348f..8378442885e 100644
--- a/source3/libads/kerberos.c
+++ b/source3/libads/kerberos.c
@@ -35,7 +35,12 @@ int kerberos_kinit_password(const char *principal, const char *password,
 	krb5_ccache cc;
 	krb5_principal me;
 	krb5_creds my_creds;
-	
+
+	if (! *password) {
+		/* kerberos dies on an empty password! */
+		return KRB5_PARSE_MALFORMED;
+	}
+
 	if ((code = krb5_init_context(&ctx)))
 		return code;
 	
@@ -103,7 +108,7 @@ int ads_kinit_password(ADS_STRUCT *ads)
 	ret = kerberos_kinit_password(s, ads->password, 0);
 
 	if (ret) {
-		DEBUG(1,("kerberos_kinit_password %s failed: %s\n", 
+		DEBUG(0,("kerberos_kinit_password %s failed: %s\n", 
 			 s, error_message(ret)));
 	}
 	free(s);