From: Jeremy Allison Date: Thu, 22 Mar 2007 22:15:35 +0000 (+0000) Subject: r21942: Hoist by our own petard :-). Older smbclient binaries X-Git-Tag: samba-4.0.0alpha6~801^2~6296 X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;h=bf26a7632e438199ab10c9557f7d018e19705604;p=ira%2Fwip.git r21942: Hoist by our own petard :-). Older smbclient binaries were not able to connect to the rewritten dfs code as they set the dfs flag bit but then send local paths. Now that our dfs code is a *lot* more robust in detecting this sort of braindamage we can just call into it directly on getting a DFS flag and let the parser sort it out without having to check it's actually connecting to a dfs enabled share (I'm proud of this code :-). Jeremy. (This used to be commit 8c4d929c76ba56d59f651c57d1feb37d2916a436) --- diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c index 1641679a358..13c44e94200 100644 --- a/source3/smbd/msdfs.c +++ b/source3/smbd/msdfs.c @@ -1253,7 +1253,7 @@ NTSTATUS resolve_dfspath(connection_struct *conn, BOOL dfs_pathnames, pstring na { NTSTATUS status = NT_STATUS_OK; BOOL dummy; - if (dfs_pathnames && lp_host_msdfs() && lp_msdfs_root(SNUM(conn))) { + if (dfs_pathnames) { status = dfs_redirect(conn, name, False, &dummy); } return status; @@ -1269,7 +1269,7 @@ NTSTATUS resolve_dfspath(connection_struct *conn, BOOL dfs_pathnames, pstring na NTSTATUS resolve_dfspath_wcard(connection_struct *conn, BOOL dfs_pathnames, pstring name, BOOL *ppath_contains_wcard) { NTSTATUS status = NT_STATUS_OK; - if (dfs_pathnames && lp_host_msdfs() && lp_msdfs_root(SNUM(conn))) { + if (dfs_pathnames) { status = dfs_redirect(conn, name, True, ppath_contains_wcard); } return status;