From: Matthias Dieter Wallnöfer <mdw@samba.org>
Date: Mon, 4 Apr 2011 12:04:18 +0000 (+0200)
Subject: s4:objectclass LDB module - "ldb_msg_sanity_check" call not really needed
X-Git-Tag: ldb-1.1.0~208
X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;h=b7de06e8e756eb338e40d319095311f8f7d70cba;p=ira%2Fwip.git

s4:objectclass LDB module - "ldb_msg_sanity_check" call not really needed

This call should only be performed at the beginning of a request.
"ldb_msg_sanity_check" checks for DN validity (which should already have been
done at the beginning of the request) and empty attributes (which should
be done by the "objectclass_attrs" LDB module).

Hence it is superflous here.

Reviewed-by: abartlet
---

diff --git a/source4/dsdb/samdb/ldb_modules/objectclass.c b/source4/dsdb/samdb/ldb_modules/objectclass.c
index 4107c9cd7cc..fd39937bc95 100644
--- a/source4/dsdb/samdb/ldb_modules/objectclass.c
+++ b/source4/dsdb/samdb/ldb_modules/objectclass.c
@@ -762,11 +762,6 @@ static int objectclass_do_add(struct oc_context *ac)
 		}
 	}
 
-	ret = ldb_msg_sanity_check(ldb, msg);
-	if (ret != LDB_SUCCESS) {
-		return ret;
-	}
-
 	ret = ldb_build_add_req(&add_req, ldb, ac,
 				msg,
 				ac->req->controls,