From: Aaron Bentley <aaron.bentley@utoronto.ca>
Date: Sat, 17 Mar 2007 21:25:43 +0000 (-0400)
Subject: Avoid old subversion warning, except when opening checkouts.  Error instead.
X-Git-Tag: bzr-svn-0.4.0~190^2
X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;h=684cc0251c1f7e92dd04ef8c15cc693099223c31;p=jelmer%2Fsubvertpy.git

Avoid old subversion warning, except when opening checkouts.  Error instead.
---

diff --git a/__init__.py b/__init__.py
index 52cdd158..101976e2 100644
--- a/__init__.py
+++ b/__init__.py
@@ -116,11 +116,7 @@ BzrDirFormat.register_control_format(format.SvnFormat)
 import svn.core
 subr_version = svn.core.svn_subr_version()
 
-if subr_version.major == 1 and subr_version.minor < 4:
-    from bzrlib.trace import warning
-    warning('Subversion version too old for working tree support.')
-else:
-    BzrDirFormat.register_control_format(checkout.SvnWorkingTreeDirFormat)
+BzrDirFormat.register_control_format(checkout.SvnWorkingTreeDirFormat)
 
 InterRepository.register_optimiser(InterSvnRepository)
 
diff --git a/checkout.py b/checkout.py
index 681af296..2f423fda 100644
--- a/checkout.py
+++ b/checkout.py
@@ -46,6 +46,8 @@ import urllib
 import svn.core, svn.wc
 from svn.core import SubversionException, Pool
 
+from bzrlib.plugins.svn.errors import NoCheckoutSupport
+
 class WorkingTreeInconsistent(BzrError):
     _fmt = """Working copy is in inconsistent state (%(min_revnum)d:%(max_revnum)d)"""
 
@@ -665,6 +667,9 @@ class SvnWorkingTreeDirFormat(BzrDirFormat):
 
         if isinstance(transport, LocalTransport) and \
             transport.has(svn.wc.get_adm_dir()):
+            subr_version = svn.core.svn_subr_version()
+            if subr_version.major == 1 and subr_version.minor < 4:
+                raise NoCheckoutSupport()
             return format
 
         raise NotBranchError(path=transport.base)
diff --git a/errors.py b/errors.py
index dba0e11d..27acdc3f 100644
--- a/errors.py
+++ b/errors.py
@@ -49,3 +49,8 @@ def convert_svn_error(unbound):
     convert.__doc__ = unbound.__doc__
     convert.__name__ = unbound.__name__
     return convert
+
+
+class NoCheckoutSupport(BzrError):
+
+    _fmt = 'Subversion version too old for working tree support.'