From: David Sterba Date: Fri, 16 Feb 2024 14:49:27 +0000 (+0100) Subject: btrfs: open code btrfs_backref_iter_free() X-Git-Tag: 6.9-rc-smb3-client-fixes-part2~51^2~31 X-Git-Url: http://git.samba.org/samba.git/?a=commitdiff_plain;h=56430c14a627a70319b670aea53b117fd33e989f;p=sfrench%2Fcifs-2.6.git btrfs: open code btrfs_backref_iter_free() The helper is trivial and used only once, open code it. It's safe to remove the 'if', the pointer is validated in build_backref_tree(). Signed-off-by: David Sterba --- diff --git a/fs/btrfs/backref.h b/fs/btrfs/backref.h index 523e594ac753..493ea47db426 100644 --- a/fs/btrfs/backref.h +++ b/fs/btrfs/backref.h @@ -283,14 +283,6 @@ struct btrfs_backref_iter { struct btrfs_backref_iter *btrfs_backref_iter_alloc(struct btrfs_fs_info *fs_info); -static inline void btrfs_backref_iter_free(struct btrfs_backref_iter *iter) -{ - if (!iter) - return; - btrfs_free_path(iter->path); - kfree(iter); -} - static inline struct extent_buffer *btrfs_backref_get_eb( struct btrfs_backref_iter *iter) { diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 2fca67f2b39b..f96f267fb4aa 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -523,7 +523,8 @@ static noinline_for_stack struct btrfs_backref_node *build_backref_tree( if (handle_useless_nodes(rc, node)) node = NULL; out: - btrfs_backref_iter_free(iter); + btrfs_free_path(iter->path); + kfree(iter); btrfs_free_path(path); if (err) { btrfs_backref_error_cleanup(cache, node);